;
+ sclk_dly = 42;
[...]
How did you calculate the actual phase values from the original parameters?
greatings
--
David Lanzendörfer
OpenSourceSupport GmbH
System engineer and supporter
http://www.o2s.ch/
signature.asc
Description: This is a digitally signed message part.
:
Acked-by: David Lanzendörfer david.lanzendoer...@o2s.ch
chears and all the best
david
[...]
How did you calculate the actual phase values from the original
parameters?
Like shown in the clock driver. 0 is always a 180 deg phase shift, and
any other value is the number of the parent
Hi
Yep, except that if I see a value -1 as a phase, I would assume that
it's 359, but maybe it's just me :)
-1 looks suspiciously like an error return value from somewhere...
--
David Lanzendörfer
OpenSourceSupport GmbH
System engineer and supporter
http://www.o2s.ch/
signature.asc
their muxing.
br
--
David Lanzendörfer
OpenSourceSupport GmbH
System engineer and supporter
http://www.o2s.ch/
signature.asc
Description: This is a digitally signed message part.
Hi
Oh, good catch, thanks! Fixed in the sunxi-devel branch
in my *personal* git repo. I'll also push this to the official linux-sunxi
sunxi-devel branch later today.
Fixed it for the next patch set as well.
-david
signature.asc
Description: This is a digitally signed message part.
Hi
Please use the real compatibles here. It's much easier to search
for. Plus, your driver doesn't support all the SoCs you're mentionning here.
[...]
Please provide the real property name to use. No need for an example
here, you have a full-fledged one in a few lines.
Fixed that.
Ditto.
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
on cd pins
-fixup: Don't set MMC_CAP_NEEDS_POLL / MMC_CAP_4_BIT_DATA
Changes since v6:
-fixing copyright info in sunxi-mmc.*
-s/__SUNXI_MCI_H__/__SUNXI_MMC_H__/g
-s/SDXC_RESPONSE_/SDXC_RESP_/g
-s/define/definitions - Comment from Priit Laes
---
David Lanzendörfer (5):
ARM: sunxi: Add
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
---
.../devicetree/bindings/mmc/sunxi-mmc.txt | 32
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
diff --git a/Documentation/devicetree/bindings
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
on cd pins
-fixup: Don't set MMC_CAP_NEEDS_POLL / MMC_CAP_4_BIT_DATA
---
David Lanzendörfer (5):
ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs
ARM: dts: sun7i: Add support for mmc
ARM: dts: sun4i: Add support for mmc
ARM: dts: sun5i: Add support
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
---
.../devicetree/bindings/mmc/sunxi-mmc.txt | 32
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
diff --git a/Documentation/devicetree/bindings
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
---
.../devicetree/bindings/mmc/sunxi-mmc.txt | 32
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
diff --git a/Documentation/devicetree/bindings
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
---
.../devicetree/bindings/mmc/sunxi-mmc.txt | 32
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
diff --git a/Documentation/devicetree/bindings
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
-mmc.h
-moving defines out of the struct definition
since this is bad coding style
-adding documentation for the device tree binding
---
David Lanzendörfer (5):
ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs
ARM: dts: sun7i: Add support for mmc
ARM: dts: sun4i
Hi
+(cmd-opcode == 5 || cmd-opcode == 52))
Aren't these the ones defined in linux/mmc/sdio.h:
5 - SD_IO_SEND_OP_COND
52 - SD_IO_RW_DIRECT
Yes. They are...
Changed that.
Also I removed the camel cases and the defines within the struct definition.
+struct sunxi_mmc_clk_dly {
+
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
new lines
-Adding missing patch for automatic reparenting of clocks
Changes since v3:
-Move clk_enable / disable into host_init / exit (Hans)
-Fix hang on boot caused by irq storm (Hans)
regards
David
---
David Lanzendörfer (4):
ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
Hi Maxime
I have four comments here:
- Read Documentation/SubmittingPatches, especially Section 5 and 12
(hints, you forgot the clock maintainers for your clock patches
and you didn't put any signed-off-by tags)
Oops. I added signed-offs now
- You ignored pretty much all the
Hi
I'm not that fond of these default y patterns. It forces the driver
down to every user of the multiplatform kernels. I'd suggest removing
the default and adding the driver to the defconfigs we have.
Ok. Removed it.
+static void sunxi_mmc_init_host(struct mmc_host *mmc)
+{
[...]
+
From: Emilio López emi...@elopez.com.ar
This commit implements .determine_rate, so that our factor clocks can be
reparented when needed.
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-factors.c | 36
1 file changed, 36
corrections into the previous commits.
It also includes the patch of Emilios, I forgot to include last time.
best regards
David
---
David Lanzendörfer (4):
ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs
ARM: dts: sun7i: Add support for mmc
ARM: dts: sun4i: Add
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
This is based on the driver Allwinner ships in their Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23
As Maxime has pointed out, I've forgotten to add a changelog
in my coverletter.
Here is, what has changed in this revision:
Changes since v1:
-Using mmc_of_parse instead of diy dt parsing
-Adding nodes for all mmc controller to the dtsi files, including sofar unused
controllers
-Using generic
---
arch/arm/boot/dts/sun4i-a10-a1000.dts |8
arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8
arch/arm/boot/dts/sun4i-a10.dtsi | 54
3 files changed, 70 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++
arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++
arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23 +
arch/arm/boot/dts/sun7i-a20.dtsi| 61 +++
4 files changed, 100
---
arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++
arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++
arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 15
arch/arm/boot/dts/sun5i-a13-olinuxino.dts| 15
From: Emilio López emi...@elopez.com.ar
Signed-off-by: Emilio López emi...@elopez.com.ar
---
drivers/clk/sunxi/clk-sunxi.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/clk/sunxi.h | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 include/linux/clk/sunxi.h
diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h
This is based on the driver Allwinner ships in the Android kernel sources.
Initial porting to upstream kernels done by David Lanzendörfer, additional
fixes and cleanups by Hans de Goede.
It uses dma in bus-master mode using a built-in designware idmac controller,
which is identical to the one
offset configuration has
been proposed and implemented by Emilio.
This patchset is the second attempt to send this driver upstream.
I'm looking forward to the acceptance of this patchset into mainline.
best regards
David
---
David Lanzendörfer (4):
ARM: sunxi: Add driver for SD/MMC hosts found
Hi
I forgot to mention that the autoparenting patch of Emilios is a crucial
depency...
http://git.o2s.ch/?p=linux-next.git;a=commit;h=f8e936772672a3a6ec934558d2a7aef030c663c4
Without it, the clock will return the wrong value and the card will refuse to
initialize
regards
david
signature.asc
I think that we're miss-communicating a bit here. What I'm trying to say
is that trying to extend the dw_mmc driver to support sunxi is a bad
idea because the sunxi hardware is quite different. And that the
sunxi hardware having autostop allows the existing sunxi-mci driver to
be much simpler
Hi
Note as said before I expect David to take things from here.
I will start working on it this evening.
I just took what David was using. I agree picking one and staying with
it would be better.
There is a reason why my working branch was called plsdsif
(short for Please don't shout at me in
Hi
that takes the MMC clock (and only the MMC clock) and does the setup
(it's basically configuring two values, sample and output, into the
clock register). I really don't know what does this do/why is it
required/when is it used; I'm cc'ing Hans and David who can hopefully
explain that part.
Hi
David, since you'll be doing v2 I guess you'll be filling in v2. FYI
I've tested this on sun4i-a10, sun5i-a10s sun5i-a13 and sun7i-a20.
Yeah. I'll take care of it.
I'll work out a V2 which incorporates all the comments made on the first patch
set you've handed in.
It uses dma in bus-master
Hi
[...]
+mmc-f_max = 5000;
[...]
[...]
in case of sdc3 they are putting 2 in f_max (as that is often
used for sdio cards) but then later in set_ios they clamp the passed
in clock to 4700 Mhz, so I seriously doubt that 200Mhz has actually
[...]
Do you have something like this in mind? -
drivers/mmc/host/dw_mmc-exynos.c
No, as explained in my previous mail the idmac being shared seemed to be the
only 2 things the dw-mmc controller and the sunxi-mmc controller have in
common.
Ok.
Looking at dw_mmc-exynos.c it still pretty
74 matches
Mail list logo
