Re: [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

2015-12-31 Thread Eduardo Valentin
Hello, On Sat, Dec 26, 2015 at 12:32:25AM +0100, Pali Rohár wrote: > Driver for omap3 with documentation is there since v4.4-rc1. > > Signed-off-by: Pali Rohár > --- > arch/arm/boot/dts/omap34xx.dtsi |5 + > arch/arm/boot/dts/omap36xx.dtsi |5 + > 2 files changed, 10 insertion

Re: [PATCH 0/8 v5] enable to use thermal-zone on r8a7790/1

2015-12-17 Thread Eduardo Valentin
On Tue, Dec 15, 2015 at 01:16:20AM +, Kuninori Morimoto wrote: > > Hi > > These are v5 of thermal-zone support for r8a7790/r8a7791. > > Kuninori Morimoto (8): > 1) thermal: rcar: move rcar_thermal_dt_ids to upside > 2) thermal: rcar: check every rcar_thermal_update_temp() return

Re: [PATCH 5/8 v5] thermal: rcar: enable to use thermal-zone on DT

2015-12-17 Thread Eduardo Valentin
On Tue, Dec 15, 2015 at 01:18:39AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch enables to use thermal-zone on DT if it was call as > "renesas,rcar-thermal-gen2". > Previous style is still supported by "renesas,rcar-thermal". Could you please include also an explan

Re: [PATCH v3 0/5] Fix a trivial typo and support rk3228/rk3399 SoCs for thermal driver.

2015-12-17 Thread Eduardo Valentin
Hello, On Thu, Dec 03, 2015 at 04:48:38PM +0800, Caesar Wang wrote: > This series pacthes to support the next soc for this thermal driver. > I don't add the dts thermal data since these SoCs have *_not_* land > in this mainline. I believe these SoCs dts will land in this mainline > lately, > then

Re: [PATCH 4/8 v4] thermal: rcar: retern error rcar_thermal_get_temp() if no ctemp update

2015-12-14 Thread Eduardo Valentin
On Tue, Dec 08, 2015 at 05:28:13AM +, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current rcar_thermal_get_temp() returns latest temperature, but it might > not be updated if some HW issue happened. This means user might get > wrong temperature. This patch solved this issue. > > S

Re: [PATCH 8/8 v4] thermal: of-thermal: of_thermal_set_trip_temp() call thermal_zone_device_update()

2015-12-14 Thread Eduardo Valentin
Hey! On Tue, Dec 08, 2015 at 05:30:00AM +, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > of_thermal_set_trip_temp() updates trip temperature. It should call > thermal_zone_device_update() immediately. > > Signed-off-by: Kuninori Morimoto > --- > v3 -> v4 > > - no change > > d

Re: [PATCH] thermal: rcar: add .set_trip_temp support

2015-11-30 Thread Eduardo Valentin
On Wed, Nov 25, 2015 at 05:42:27AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > You can set trip temp if your kernel has CONFIG_THERMAL_WRITABLE_TRIPS > > echo $temp > /sys/class/thermal/thermal_zone0/trip_point_0_temp > > -45000 < $temp < 125000 is supported > Default is 90

Re: [PATCH] thermal: rcar: enable to set tripN-temp via DT

2015-11-24 Thread Eduardo Valentin
Morimoto-san, On Wed, Nov 25, 2015 at 01:45:14AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Current rcar thermal driver is using 90 degrees as trip temp, but it > should be based on each SoC / platform. > This patch enables to set trip temp via DT. (It uses db8500-thermal

Re: [PATCH] cpufreq: qoriq: Register cooling device based on device tree

2015-11-24 Thread Eduardo Valentin
On Tue, Nov 24, 2015 at 08:18:17AM -0600, Scott Wood wrote: > On Tue, 2015-11-24 at 14:55 +0800, Jia Hongtao wrote: > > Register the qoriq cpufreq driver as a cooling device, based on the > > thermal device tree framework. When temperature crosses the passive trip > > point cpufreq is used to throt

Re: [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs

2015-11-12 Thread Eduardo Valentin
On Thu, Nov 12, 2015 at 10:29:52AM -0800, Eduardo Valentin wrote: > On Mon, Nov 09, 2015 at 12:48:52PM +0800, Caesar Wang wrote: > > Thank you all for providing inputs and comments on previous versions of > > this patchset. > > Especially thanks to the (Eduardo, Dmitry, Heiko

Re: [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs

2015-11-12 Thread Eduardo Valentin
Do you have any results on existing support? Is the driver still in one piece for rk3288? I am planing to send your series in next rc cycles. It won't appear in linux-next until merge window finishes. BR, Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe dev

Re: [PATCH v3 1/2] thermal: mediatek: Add cpu power cooling model.

2015-11-10 Thread Eduardo Valentin
ld take into account the > temperature and the idle state. Still, why would we have one binding to describe static power per platform? I would prefer we go towards a generalized binding description. If temperature is not needed on all platforms, make it an optional property. BR, Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2015-11-10 Thread Eduardo Valentin
On Tue, Nov 10, 2015 at 12:05:54PM +, Javi Merino wrote: > On Mon, Nov 09, 2015 at 11:13:32AM +0100, Sascha Hauer wrote: > > + > > +/* > > + * The MT8173 thermal controller has four banks. Each bank can read up to > > + * four temperature sensors simultaneously. The MT8173 has a total of 5 >

Re: [PATCH v2 0/9] Better compatible for the rockchip thermal and support RK3368 SoCs

2015-11-06 Thread Eduardo Valentin
Hi, On Fri, Nov 06, 2015 at 08:03:24PM +0100, Heiko Stuebner wrote: > Hi Eduardo, Caesar, > > Am Freitag, 6. November 2015, 10:47:40 schrieb Eduardo Valentin: > > On Thu, Nov 05, 2015 at 01:17:56PM +0800, Caesar Wang wrote: > > > This series patchs are working for RK3

Re: [PATCH v2 9/9] arm64: dts: Enable the Thermal on R88 board

2015-11-06 Thread Eduardo Valentin
On Thu, Nov 05, 2015 at 01:18:05PM +0800, Caesar Wang wrote: > This patch enable the TS-ADC. > > When a thermal temperature is invoked use the CRU to reset the chip > on R88 board. TSHUT is low active on this board. > Acked-by: Eduardo Valentin > Signed-o

Re: [PATCH v2 8/9] arm64: dts: Add main Thermal info to rk3368.dtsi

2015-11-06 Thread Eduardo Valentin
On Thu, Nov 05, 2015 at 01:18:04PM +0800, Caesar Wang wrote: > This patch add the thermal needed info on RK3368. > Meanwhile, support the trips to throttle for thermal. > Acked-by: Eduardo Valentin > Signed-off-by: Caesar Wang > > --- -- To unsubscribe from this l

Re: [PATCH v2 7/9] arm64: dts: Add the thermal data found on RK3368

2015-11-06 Thread Eduardo Valentin
ttle cluster). > > This patch adds the second order for thermal throttle, and the critical > temperature for thermal over-tempeature protection on Software. > > Signed-off-by: Caesar Wang Acked-by: Eduardo Valentin > --- > > Changes in v2: None > Changes in v1: None &g

Re: [PATCH v2 0/9] Better compatible for the rockchip thermal and support RK3368 SoCs

2015-11-06 Thread Eduardo Valentin
oc-thermal.git Yeah, apologize the delay on giving you a feedback on your code. As I mentioned before, I had a couple of other things in past weeks that consumed my time. Anyways, this specific patch series looks way better now that you have split it further. I will have a better look on it again

Re: [PATCH v3 2/2] arm64: dts: mt8173: Add thermal zone node for mt8173.

2015-11-04 Thread Eduardo Valentin
On Thu, Oct 22, 2015 at 08:02:39PM +0800, Dawei Chien wrote: > Add thermal zone node to mt8173.dtsi. > > Signed-off-by: Dawei Chien > --- > This patch is base on > https://patchwork.kernel.org/patch/7249821/ > https://patchwork.kernel.org/patch/7249861/ > https://patchwork.kernel.org/patch/724989

Re: [PATCH v3 1/2] thermal: mediatek: Add cpu power cooling model.

2015-11-04 Thread Eduardo Valentin
On Thu, Oct 22, 2015 at 08:02:38PM +0800, Dawei Chien wrote: > This power model is base on Intelligent Power Allocation (IPA) > technical, requires that the operating-points of the CPUs are > registered using the kernel's opp library and the > `cpufreq_frequency_table` is assigned to the `struct de

Re: [PATCH v3 0/2] thermal: mediatek: Add cpu power cooling model

2015-11-04 Thread Eduardo Valentin
On Mon, Nov 02, 2015 at 03:53:33PM +, Punit Agrawal wrote: > Viresh Kumar writes: > > > On 22-10-15, 20:02, Dawei Chien wrote: > >> Use Intelligent Power Allocation (IPA) technical to add static/dynamic > >> power model for binding CPU thermal zone. > >> The power allocator governor allocate

Re: [PATCH] thermal: of: Introduce governor selection in dts

2015-11-02 Thread Eduardo Valentin
On Tue, Aug 11, 2015 at 10:07:31AM +0100, Sudeep Holla wrote: > > > On 10/08/15 18:47, Javi Merino wrote: > >On Mon, Aug 10, 2015 at 09:00:49AM +0100, Chung-Yih Wang (王崇懿) wrote: > >>This patch was originally introduced when we made power_allocator the > >>default governor where we had issues in

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2015-09-29 Thread Eduardo Valentin
On Wed, Sep 23, 2015 at 03:37:42PM +0200, Sascha Hauer wrote: > This adds support for the Mediatek thermal controller found on MT8173 > and likely other SoCs. > The controller is a bit special. It does not have its own ADC, instead > it controls the on-SoC AUXADC via AHB bus accesses. For this reas

Re: [PATCH v6 3/3] dts: hi6220: enable thermal sensor for hisilicon SoC

2015-06-03 Thread Eduardo Valentin
uld be bound to. > it also need specify the polling interval for every thermal zone. > > Signed-off-by: Leo Yan > Signed-off-by: kongxinwei Acked-by: Eduardo Valentin I have taken the patches containing the driver changes and the Documentation entry. But this patch needs to go via

Re: [PATCH v6 2/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-06-03 Thread Eduardo Valentin
On Wed, May 20, 2015 at 07:16:37PM +0800, Xinwei Kong wrote: > From: kongxinwei > > This patch adds the support for hisilicon thermal sensor, within > hisilicon SoC. there will register sensors for thermal framework > and use device tree to bind cooling device. > > Signed-off-by: Leo Yan > Sign

Re: [PATCH v5 3/3] dts: hi6220: enable thermal sensor for hisilicon SoC

2015-05-19 Thread Eduardo Valentin
On Mon, May 18, 2015 at 03:11:49PM +0800, Xinwei Kong wrote: > From: kongxinwei > > Dts includes two part: the first part is related with thermal sensor; > the second part is related with thermal zones, in this part it will > define the thermal zones and which sensor device should be bound to. >

Re: [PATCHv2] ti-soc-thermal: implement omap3 support

2015-04-07 Thread Eduardo Valentin
Hi Pavel, On Thu, Apr 02, 2015 at 04:49:07PM +0200, Pavel Machek wrote: > > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Signed-off-by: Pavel Machek > > --- > > Patch is against thermal linus tree, ple

Re: [PATCHv2] ti-soc-thermal: implement omap3 support

2015-04-07 Thread Eduardo Valentin
On Thu, Apr 02, 2015 at 04:49:07PM +0200, Pavel Machek wrote: > > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Signed-off-by: Pavel Machek > > --- > > Patch is against thermal linus tree, please apply s

Re: [PATCH v2 1/2] dt-bindings: Document the hi6220 thermal sensor bindings

2015-04-06 Thread Eduardo Valentin
On Tue, Apr 07, 2015 at 11:46:22AM +0800, Xinwei Kong wrote: > > > On 2015/4/6 22:03, Matt Porter wrote: > > On Tue, Mar 31, 2015 at 02:59:21PM +0800, Xinwei Kong wrote: > >> From: kongxinwei > >> > >> This adds documentation of device tree bindings for the > >> thermal sensor controller of hi62

Re: [PATCH V2 2/2] ARM: dts: am57xx-beagle-x15: Add thermal map to include fan and tmp102

2015-03-24 Thread Eduardo Valentin
> Signed-off-by: Nishanth Menon Acked-by: Eduardo Valentin > --- > Changes since V1: > - slight change in omap4-cpu-thermal for usage in am57xx-dtsi > - Not carrying forward ack due to change > > V1: http://marc.info/?t=14268810274&

Re: [PATCH 1/3] ARM: dts: OMAP5+: separate the cpu thermal zone definition from omap4

2015-03-20 Thread Eduardo Valentin
On Fri, Mar 20, 2015 at 02:47:39PM -0500, Nishanth Menon wrote: > From: Tero Kristo > > OMAP4 has a finer counter granularity, which allows for a delay of 1000ms > in the thermal zone polling intervals. OMAP5/DRA7 have different counter > mechanism, which allows at maximum a 500ms timer. Adjust t

Re: [PATCH 2/3] ARM: dts: DRA7: Add bandgap and related thermal nodes

2015-03-20 Thread Eduardo Valentin
by: Keerthy > Signed-off-by: Nishanth Menon Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/dra7.dtsi | 12 > arch/arm/boot/dts/dra72x.dtsi |9 + > arch/arm/boot/dts/dra74x.dtsi |9 + > 3 files changed, 30 insertions(+) > &g

Re: [PATCH 3/3] ARM: dts: am57xx-beagle-x15: Add thermal map

2015-03-20 Thread Eduardo Valentin
> Signed-off-by: Nishanth Menon Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/am57xx-beagle-x15.dts | 49 > +++ > 1 file changed, 49 insertions(+) > > diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts > b/arch/arm/boot/dts

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: > Explanation of several properties, which allow PWM fan working as a cooling > device, have been embraced in this commit. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename cooling-pwm-values to cooling-levels >

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 03:11:24PM -0400, Eduardo Valentin wrote: > On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: > > Explanation of several properties, which allow PWM fan working as a cooling > > device, have been embraced in this commit. > > >

Re: [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:19PM +0100, Lukasz Majewski wrote: > With those bindings it is possible to use pwm-fan device available in > Odroid U3 as a cooling device. > > Signed-off-by: Lukasz Majewski Acked-by: Eduardo Valentin > --- > Changes for v2: > - Rena

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 05:10:14PM +0100, Gregory CLEMENT wrote: > Hi Tyler, Eduardo, > > On 24/02/2015 20:56, Tyler Hall wrote: > > Eduardo, > > > > On Tue, Feb 24, 2015 at 1:36 PM, Eduardo Valentin > > wrote: > >> The fix seams reasonable.

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 02:28:15PM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: > > > With those bindings it is possible to use pwm-fan device available > > > in Odroid U3 as a cooling device. > > > > > > Signed-off-by: Lukasz

Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Eduardo Valentin
believe the series should go via your tree, yes. I had only minor comments in the code added for the cooling device code, as it lacks the unregistration call in the .remove callback. Also, the DTS changes may generate conflicts with platform code. Lukasz may probably ask Kukjin Kim to add them via the samsung tree. BR, Eduardo Valentin > > Thanks, > Guenter signature.asc Description: Digital signature

Re: [PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
(IS_ENABLED(CONFIG_THERMAL)) { > + cdev = thermal_of_cooling_device_register(pdev->dev.of_node, > + "pwm-fan", ctx, > + &pwm_fan_c

Re: [PATCH V2] (gpio-fan): Add thermal control hooks

2015-02-24 Thread Eduardo Valentin
On Tue, Feb 24, 2015 at 11:55:23AM -0800, Guenter Roeck wrote: > On Tue, Feb 24, 2015 at 03:29:35PM -0400, Eduardo Valentin wrote: > > Guenter, > > > > On Thu, Jan 08, 2015 at 08:48:40PM -0800, Guenter Roeck wrote: > > > On 01/08/2015 10:05 AM, Nishanth Menon wrote

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: > With those bindings it is possible to use pwm-fan device available in > Odroid U3 as a cooling device. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename cooling-pwm-values property to cooling-levels > Changes f

Re: [PATCH V2] (gpio-fan): Add thermal control hooks

2015-02-24 Thread Eduardo Valentin
ake the shutdown and remove logic the same > > as well. > > > > Signed-off-by: Nishanth Menon > > --- > > Applied to -next. What is the target kernel version for this change? It didn't make 4.0-rc1 BR, Eduardo Valentin > > Thanks, > Guenter > signature.asc Description: Digital signature

Re: [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:31AM +0100, Lukasz Majewski wrote: > Explanation of several properties, which allow PWM fan working as a cooling > device, have been embraced in this commit. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename cooling-pwm-values to cooling-levels >

Re: [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:29AM +0100, Lukasz Majewski wrote: > Odroid U3 fan can work without being registered as OF cooling device > (with CONFIG_THERMAL_OF disabled). > In this situation it can be controlled via PWM entry at > /sys/class/hwmon/hwmon0/pwm1. > > Therefore, the thermal_of_cooli

Re: [PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:30AM +0100, Lukasz Majewski wrote: > Odroid U3 fan can work without being registered as OF cooling device > (with CONFIG_THERMAL{_OF|} disabled). > In this situation it can be controlled via PWM entry at > /sys/class/hwmon/hwmon0/pwm1. > > Therefore, the thermal_cdev_

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-24 Thread Eduardo Valentin
pdates in the DTS files? I would appreciate if you get a Review-by, from Ezequiel for instance, before we apply this. Ezequiel, any objections before I move forward with this one? BR, Eduardo Valentin > > My conclusions about these registers are based on experimental data. The > docum

Re: [PATCH v5] thermal: Add QPNP PMIC temperature alarm driver

2015-02-23 Thread Eduardo Valentin
On Thu, Feb 05, 2015 at 07:12:56PM +0200, Ivan T. Ivanov wrote: > Add support for the temperature alarm peripheral found inside > Qualcomm plug-and-play (QPNP) PMIC chips. The temperature alarm > peripheral outputs a pulse on an interrupt line whenever the > thermal over temperature stage value cha

Re: [PATCH v4] thermal: Add QPNP PMIC temperature alarm driver

2015-02-03 Thread Eduardo Valentin
On Tue, Feb 03, 2015 at 11:24:45AM +0200, Ivan T. Ivanov wrote: > > Hi Eduardo, > > On Mon, 2015-02-02 at 14:14 -0400, Eduardo Valentin wrote: > > Ivan, > > > > On Mon, Feb 02, 2015 at 05:19:30PM +0200, Ivan T. Ivanov wrote: > > > Add support for the te

Re: [PATCH v4] thermal: Add QPNP PMIC temperature alarm driver

2015-02-02 Thread Eduardo Valentin
Ivan, On Mon, Feb 02, 2015 at 05:19:30PM +0200, Ivan T. Ivanov wrote: > Add support for the temperature alarm peripheral found inside > Qualcomm plug-and-play (QPNP) PMIC chips. The temperature alarm > peripheral outputs a pulse on an interrupt line whenever the > thermal over temperature stage va

Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings

2015-01-31 Thread Eduardo Valentin
e", "nvidia,tegra20-pcie"' where > is tegra30, tegra132, ..." [...] "You should attempt to >document known values of if you use it" > > > Signed-off-by: Paul Walmsley > Cc: Alexandre Courbot > Cc: Dylan Reid > Cc: Eduardo Valent

Re: [PATCH v2] thermal: Fix examples in DT documentation

2015-01-28 Thread Eduardo Valentin
such errors in the documentation. > > Signed-off-by: Srinivas Kandagatla > --- > Changes Since v1: > - Fixed few more typo's as suggested by Eduardo Valentin Looks like there are still occurencies of adc-dummy after your patch. But I am amending myself, no need to res

Re: [PATCH] thermal: Fix examples in DT documentation

2015-01-27 Thread Eduardo Valentin
Hello Srinivas, On Tue, Jan 27, 2015 at 10:50:47AM +, Srinivas Kandagatla wrote: > There are various issues with the examples in this documentation, some > of the DT labels are invalid and one of the macro THERMAL_NO_LIMITS > referenced is not available as well. > > As Its highly likely that

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 04:01:06PM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: > > > On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: > > > > Odroid U3 fan can work witho

Re: [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-01-14 Thread Eduardo Valentin
ERMAL subsystem (and such configuration is perfectly > valid). OK. Now I understand. Then, please resend this one using CONFIG_THERMAL. Thanks, Eduardo Valentin > > > > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > > Changes for v2: &

Re: [PATCH V2] (gpio-fan): Add thermal control hooks

2015-01-09 Thread Eduardo Valentin
Nishanth Menon For the thermal part: Acked-by: Eduardo Valentin > --- > > Changes since v1: > - review comments incorporated (hopefully correct) > - checkpatch verified > - retested :). > > V1: https://patchwork.kernel.org/patch/5587061/ &g

Re: [PATCH 2/4] ARM: tegra: Move out nyan-generic parts out from the nyan-big DT

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 11:37:27AM +0100, Tomeu Vizoso wrote: > In preparation for adding the DT for the nyan-blaze board. > > Signed-off-by: Tomeu Vizoso For the (small part of the) thermal sensor: Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/tegra124-nyan

Re: [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Remove unused function

2015-01-05 Thread Eduardo Valentin
On Wed, Dec 24, 2014 at 08:57:14AM -0600, Nishanth Menon wrote: > On 12/21/2014 11:43 AM, Rickard Strandqvist wrote: > > Remove the function ti_bandgap_write_thot() that is not used anywhere. > > > > This was partially found by using a static code analysis program called > > cppcheck. > > > > Si

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: > On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: > > Odroid U3 fan can work without being registered as OF cooling device > > (with CONFIG_THERMAL_OF disabled). > > In this situation it can

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
gt; Therefore, the thermal_of_cooling_device_register() function needs a stub > to allow clean compilation. > > Signed-off-by: Lukasz Majewski Acked-by: Eduardo Valentin > --- > Changes for v2: > - None > --- > include/linux/thermal.h | 14 +++--- > 1 file changed, 11 in

Re: [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-01-02 Thread Eduardo Valentin
Patch subject should use a prefix like: 'arm: dts:' On Mon, Dec 22, 2014 at 05:27:45PM +0100, Lukasz Majewski wrote: > With those bindings it is possible to use pwm-fan device available in > Odroid U3 as a cooling device. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename

Re: [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:43PM +0100, Lukasz Majewski wrote: > Several new properties to allow PWM fan working as a cooling device have been > combined into this single commit. > Patch prefix should look something like 'dt-bindings: ...', or better 'Documentation: devicetree: ...', or 'Docume

Re: [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:42PM +0100, Lukasz Majewski wrote: > Odroid U3 fan can work without being registered as OF cooling device > (with CONFIG_THERMAL_OF disabled). > In this situation it can be controlled via PWM entry at > /sys/class/hwmon/hwmon0/pwm1. > > Therefore, the thermal_cdev_upd

[PATCH 1/2] thermal: db8500: Do not print error message in the EPROBE_DEFER case

2014-12-12 Thread Eduardo Valentin
Avoid printing the error message in the EPROBE_DEFER case where registering cpu cooling at db8500 thermal driver. Cc: Zhang Rui Cc: Grant Likely Cc: Rob Herring Cc: linux...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Eduardo Valentin

Re: [PATCH] thermal: Fix cdev registration with THERMAL_NO_LIMIT on 64bit

2014-12-10 Thread Eduardo Valentin
On Wed, Dec 10, 2014 at 09:57:37AM +0800, Zhang Rui wrote: > On Tue, 2014-12-09 at 12:22 +, Punit Agrawal wrote: > > The size of unsigned long varies between 32 and 64 bit systems while > > the size of phandle arguments is always 32 bits per parameter. > > > > On 64-bit systems, cooling device

Re: [PATCH V2 01/26] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-12-04 Thread Eduardo Valentin
On Thu, Dec 04, 2014 at 09:41:43AM +0530, Viresh Kumar wrote: > From: Eduardo Valentin > > In this patch, the cpu_cooling code checks for the usability of cpufreq > layer before proceeding with the CPU cooling device registration. The > main reason is: CPU cooling device i

Re: [PATCHv3 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
Russel, On Fri, Nov 28, 2014 at 05:10:24PM +, Russell King - ARM Linux wrote: > On Fri, Nov 28, 2014 at 10:53:30AM -0400, Eduardo Valentin wrote: > > diff --git a/drivers/thermal/samsung/exynos_thermal_common.c > > b/drivers/thermal/samsung/exynos_thermal_common.c > > i

[PATCHv3 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
: Naveen Krishna Chatradhi Cc: Rob Herring Cc: Zhang Rui Acked-by: Viresh Kumar Signed-off-by: Eduardo Valentin --- drivers/thermal/cpu_cooling.c | 3 +++ drivers/thermal/db8500_cpufreq_cooling.c | 5 - drivers/thermal/imx_thermal.c | 5

Re: [PATCHv2 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
Hello Folks, On Fri, Nov 28, 2014 at 11:18:24AM +0100, Lukasz Majewski wrote: > On Fri, 28 Nov 2014 13:35:49 +0530 > Viresh Kumar wrote: > > > On 27 November 2014 at 19:42, Eduardo Valentin > > wrote: > > > (I'm sorry VireshK, I am still using my normal

[PATCHv2 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-27 Thread Eduardo Valentin
: Naveen Krishna Chatradhi Cc: Rob Herring Cc: Zhang Rui Acked-by: Viresh Kumar Signed-off-by: Eduardo Valentin --- drivers/thermal/cpu_cooling.c | 5 + drivers/thermal/db8500_cpufreq_cooling.c | 5 - drivers/thermal/imx_thermal.c | 5

Re: [PATCH 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-27 Thread Eduardo Valentin
Hello Viresh, On Thu, Nov 27, 2014 at 09:38:39AM +0530, Viresh Kumar wrote: > Few nits.. > > On 26 November 2014 at 23:20, Eduardo Valentin wrote: > > > Signed-off-by: Eduardo Valentin > > --- > > The normal practice is to write the non-commitable part here ...

[PATCH 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-26 Thread Eduardo Valentin
: Naveen Krishna Chatradhi Cc: Rob Herring Cc: Zhang Rui Signed-off-by: Eduardo Valentin --- drivers/thermal/cpu_cooling.c | 5 + drivers/thermal/db8500_cpufreq_cooling.c | 5 - drivers/thermal/imx_thermal.c | 5 - drivers/thermal

Re: [PATCH v19 0/5] Rockchip soc thermal driver

2014-11-24 Thread Eduardo Valentin
ithub.com/mmind/linux-rockchip.git For 3 - 5 you can add my: Acked-by: Eduardo Valentin Cheers, Eduardo Valentin > [branch "3.19-armsoc/dts"] > remote = origin > merge = refs/heads/wip/v3.19-armsoc/dts > > Changes in v19: > - update driver to

Re: [PATCHv5 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-20 Thread Eduardo Valentin
Hi Guenter, On Thu, Nov 20, 2014 at 10:12:13AM -0400, Eduardo Valentin wrote: > Different drivers request API extensions in of-thermal. For this reason, > additional callbacks are required to fit the new drivers needs. > > The current API implementation expects the registering sensor

[PATCHv5 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-20 Thread Eduardo Valentin
Perttunen Reviewed-by: Mikko Perttunen Reviewed-by: Alexandre Courbot Reviewed-by: Lukasz Majewski Signed-off-by: Eduardo Valentin --- drivers/hwmon/lm75.c | 9 +++-- drivers/hwmon/ntc_thermistor.c | 6 +++- drivers/hwmon/tmp102.c

Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-20 Thread Eduardo Valentin
Alexander, On Wed, Nov 19, 2014 at 05:06:24PM +0900, Alexandre Courbot wrote: > On Tue, Nov 18, 2014 at 11:39 PM, Eduardo Valentin > wrote: > > Different drivers request API extensions in of-thermal. For this reason, > > additional callbacks are required to fit the

Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-20 Thread Eduardo Valentin
Mikko, On Wed, Nov 19, 2014 at 05:43:20PM +0200, Mikko Perttunen wrote: > On 11/19/2014 05:41 PM, Mikko Perttunen wrote: > > On 11/18/2014 04:39 PM, Eduardo Valentin wrote: > >> Different drivers request API extensions in of-thermal. For this reason, > >> additional ca

Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-19 Thread Eduardo Valentin
Hey Lukasz, On Wed, Nov 19, 2014 at 09:21:39AM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > } > > On which branch should I apply this patch? > This is based in my -linus branch. That means I will send this for the next major window, not rc. The branch -fixes of thermal-soc include p

Re: [PATCH v18 2/5] thermal: rockchip: add driver for thermal

2014-11-18 Thread Eduardo Valentin
Hello Caesar, On Tue, Nov 18, 2014 at 03:41:28PM +0800, Caesar Wang wrote: > Hello edubezval, > > I saw your latest patch[0]. > I need send the new patch to fit the of-thermal Sensors API. > Right? > > [0]: https://patchwork.kernel.org/patch/5324371/ > Right. I've just posted a new version of

[PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-18 Thread Eduardo Valentin
Majewski Signed-off-by: Eduardo Valentin --- drivers/hwmon/lm75.c | 9 +++-- drivers/hwmon/ntc_thermistor.c | 6 +++- drivers/hwmon/tmp102.c | 6 +++- drivers/thermal/of-thermal.c | 40

Re: [PATCH 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-18 Thread Eduardo Valentin
, here we should only check: > if (!ops) > return ERR_PTR(-EINVAL); > > And check if specific callbacks are available in other > functions (like [1]) > OK. For the sake of this change only, I agree. However, I might be sending patches on top of this one to keep the checks of required fields in the registration itself. Cheers, > > } > > Despite this minor comments, feel free to add :-) > > Reviewed-by: Lukasz Majewski OK. Thanks. > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group Eduardo Valentin signature.asc Description: Digital signature

[PATCH 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-17 Thread Eduardo Valentin
: Eduardo Valentin --- Difference from V2: - Fix wrong assignment in tegra driver. Difference from V1: - Fix error handling when .get_trend is not provided. --- drivers/hwmon/lm75.c | 9 +++-- drivers/hwmon/ntc_thermistor.c | 6 +++- drivers/hwmon

Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-17 Thread Eduardo Valentin
Mikko, On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote: > > diff --git a/drivers/thermal/tegra_soctherm.c > > b/drivers/thermal/tegra_soctherm.c > > index 70f7e9e..893c39c 100644 > > --- a/drivers/thermal/tegra_soctherm.c > > +++ b/drivers/thermal/tegra_soctherm.c > > @@ -317,6

[PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-17 Thread Eduardo Valentin
: Eduardo Valentin --- Difference from V1: - Fix error handling when .get_trend is not provided. --- drivers/hwmon/lm75.c | 9 +++-- drivers/hwmon/ntc_thermistor.c | 6 +++- drivers/hwmon/tmp102.c | 6 +++- drivers/thermal

[PATCH 1/1] thermal: of: improve of-thermal sensor registration API

2014-11-17 Thread Eduardo Valentin
: Eduardo Valentin --- drivers/hwmon/lm75.c | 9 +++-- drivers/hwmon/ntc_thermistor.c | 6 +++- drivers/hwmon/tmp102.c | 6 +++- drivers/thermal/of-thermal.c | 42 +- drivers/thermal

Re: [PATCH v17 1/5] thermal: rockchip: add driver for thermal

2014-11-07 Thread Eduardo Valentin
Hello Dmitry, On Thu, Nov 06, 2014 at 05:57:28PM -0800, Dmitry Torokhov wrote: > Hi Eduardo, > > On Thu, Nov 06, 2014 at 09:30:20PM -0400, Eduardo Valentin wrote: > > Hello Caesar, > > > > On Sat, Nov 01, 2014 at 10:44:29AM +0800, Caesar Wang wrote: > > >

Re: [PATCH v17 1/5] thermal: rockchip: add driver for thermal

2014-11-06 Thread Eduardo Valentin
Hello Caesar, On Sat, Nov 01, 2014 at 10:44:29AM +0800, Caesar Wang wrote: > Thermal is TS-ADC Controller module supports > user-defined mode and automatic mode. > > User-defined mode refers,TSADC all the control signals entirely by > software writing to register for direct control. > > Automaic

Re: [PATCH v3] thermal: Add QPNP PMIC temperature alarm driver

2014-11-06 Thread Eduardo Valentin
On Thu, Oct 30, 2014 at 03:55:45PM +0200, Ivan T. Ivanov wrote: > > On Wed, 2014-10-29 at 17:32 +0200, Ivan T. Ivanov wrote: > > > + > > > > + chip->tz_dev = thermal_zone_device_register(node->name, > > > > TRIP_NUM, 0, > > > > + chip, &qpnp_tz_ops, NULL, > > > > > > Have you consid

Re: [PATCH v3] thermal: Add QPNP PMIC temperature alarm driver

2014-10-27 Thread Eduardo Valentin
Hello Ivan On Wed, Oct 01, 2014 at 06:53:37PM +0300, Ivan T. Ivanov wrote: > Add support for the temperature alarm peripheral found inside > Qualcomm plug-and-play (QPNP) PMIC chips. The temperature alarm > peripheral outputs a pulse on an interrupt line whenever the > thermal over temperature st

Re: [PATCH] thermal: fix multiple disbalanced device node counters

2014-10-08 Thread Eduardo Valentin
e > > nodes allocated by for_each_child_of_node(), of_parse_phandle() > > and of_find_node_by_name(), fix all problems at once. > > > can you please take this patch? Yes, Applied. Thanks. > > thanks, > rui > > Signed-off-by: Vladimir Zapolskiy > > Cc

Re: [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver

2014-09-24 Thread Eduardo Valentin
Hello Ivan, On Wed, Sep 24, 2014 at 05:56:10PM +0300, Ivan T. Ivanov wrote: > On Mon, 2014-09-15 at 11:30 -0400, Eduardo Valentin wrote: > > Hey Ivan, > > > > Please give us at least a two weeks time frame before resending your > > patches. > > Hi Eduardo, >

Re: [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver

2014-09-15 Thread Eduardo Valentin
Hey Ivan, Please give us at least a two weeks time frame before resending your patches. On Mon, Sep 15, 2014 at 06:03:03PM +0300, Ivan T. Ivanov wrote: > Add support for the temperature alarm peripheral found inside > Qualcomm plug-and-play (QPNP) PMIC chips. The temperature alarm > peripheral o

Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal

2014-09-11 Thread Eduardo Valentin
Arnd, On Thu, Sep 11, 2014 at 02:32:08PM +0200, Arnd Bergmann wrote: > On Thursday 11 September 2014 08:18:43 Eduardo Valentin wrote: > > > As what we want is to make thermal driver have a chance to configure the > > > hardware shutdown registers, I'm thinking

Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal

2014-09-11 Thread Eduardo Valentin
PM, Zhang Rui wrote: > > > > On Tue, 2014-09-09 at 11:09 -0400, Eduardo Valentin wrote: > > > >> Hello > > > >> > > > >> On Tue, Sep 09, 2014 at 01:35:31PM +0200, Heiko Stübner wrote: > > > >> > Am Dienstag, 9. September 2014,

Re: [PATCH v4 1/4] thermal: rockchip: add driver for thermal

2014-09-10 Thread Eduardo Valentin
Hello Caesar, On Wed, Sep 10, 2014 at 12:39:07PM +0800, Caesar Wang wrote: > Dear Eduardo, > > I'm sorry for it. > I just received this message.Maybe my mailbox has a problem. No problems. You can take your time. > > Thank you for your comments. > > 在 2014年08月3

Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal

2014-09-09 Thread Eduardo Valentin
Hello On Tue, Sep 09, 2014 at 01:35:31PM +0200, Heiko Stübner wrote: > Am Dienstag, 9. September 2014, 10:27:17 schrieb Zhang Rui: > > On Thu, 2014-09-04 at 09:02 +0800, Caesar Wang wrote: > > > 在 2014年09月03日 16:07, Heiko Stübner 写道: > > > > Am Mittwoch, 3. September 2014, 10:10:37 schrieb Caesar

Re: [PATCH v2] thermal: rcar: Add binding docs for new R-Car Gen2 SoCs

2014-09-09 Thread Eduardo Valentin
On Thu, Aug 28, 2014 at 10:12:32AM +0200, Geert Uytterhoeven wrote: > - r8a7792 (R-Car V2H) > - r8a7793 (R-Car M2-N) > - r8a7794 (R-Car E2) > > r8a7791 is now called "R-Car M2-W". > > Signed-off-by: Geert Uytterhoeven Pulled into my next branch. Thanks. > --- > v2: Drop RFC > --- > Docu

Re: [PATCH] thermal: add generic IIO channel thermal sensor driver

2014-09-08 Thread Eduardo Valentin
Hello, Sorry for the waaay too long answer. In any case, I believe it is worth giving answers to why this patch was not merged. On Wed, Feb 05, 2014 at 05:43:27PM -0800, Courtney Cavin wrote: > This driver is a generic method for using IIO ADC channels as thermal > sensors. In fact, this seams

Re: [PATCH v2] thermal: rcar: Add binding docs for new R-Car Gen2 SoCs

2014-09-08 Thread Eduardo Valentin
Hi Geert, On Sat, Sep 06, 2014 at 08:10:13PM +0200, Geert Uytterhoeven wrote: > Hi Eduardo, > > On Sat, Sep 6, 2014 at 6:13 PM, Eduardo Valentin wrote: > > On Thu, Aug 28, 2014 at 10:12:32AM +0200, Geert Uytterhoeven wrote: > >> - r8a7792 (R-Car V2H) >

Re: [PATCH v2] thermal: rcar: Add binding docs for new R-Car Gen2 SoCs

2014-09-06 Thread Eduardo Valentin
Hello Geert, On Thu, Aug 28, 2014 at 10:12:32AM +0200, Geert Uytterhoeven wrote: > - r8a7792 (R-Car V2H) > - r8a7793 (R-Car M2-N) > - r8a7794 (R-Car E2) > > r8a7791 is now called "R-Car M2-W". > > Signed-off-by: Geert Uytterhoeven I don't have any concerns on this patch and will be add

  1   2   >