Re: [PATCH v7 0/6] wlcore: add device-tree support

2015-03-24 Thread Eliad Peller
hi Nikita, On Tue, Mar 24, 2015 at 1:37 PM, Nikita Kiryanov nik...@compulab.co.il wrote: Hi Eliad, On 03/18/2015 06:38 PM, Eliad Peller wrote: Add device-tree support to the wlcore (wl12xx/wl18xx) driver. Update the current users to use the bindings instead of pdata-quirks. Finally

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Eliad Peller
On Mon, Mar 23, 2015 at 10:21 AM, Sekhar Nori nsek...@ti.com wrote: On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Eliad Peller
hi Sekhar, On Mon, Mar 23, 2015 at 9:51 AM, Sekhar Nori nsek...@ti.com wrote: + Ido On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its

Re: [PATCH v7 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-19 Thread Eliad Peller
hi Pontus, On Thu, Mar 19, 2015 at 4:05 PM, Pontus Fuchs pontus.fu...@gmail.com wrote: On 2015-03-18 17:38, Eliad Peller wrote: Replace all the pdata-quirks for setting wl12xx/wl18xx platform data with proper DT definitions. Signed-off-by: Eliad Peller el...@wizery.com Acked-by: Javier

[PATCH v7 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-18 Thread Eliad Peller
Replace all the pdata-quirks for setting wl12xx/wl18xx platform data with proper DT definitions. Signed-off-by: Eliad Peller el...@wizery.com Acked-by: Javier Martinez Canillas jav...@dowhile0.org Acked-by: Enric Balletbo i Serra eballe...@gmail.com Tested-by: Tony Lindgren t...@atomide.com

[PATCH v7 0/6] wlcore: add device-tree support

2015-03-18 Thread Eliad Peller
compilation (remove platform data) * additional minor changes in driver code v6: * Add Luca's patches to pass irq_trigger/freq * Support wl12xx as well * Update all relevant platforms Eliad Peller (4): dt: bindings: add TI's wilink wireless device wlcore: add device-tree support ARM: dts: add

[PATCH v7 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-18 Thread Eliad Peller
Coelho l...@coelho.fi [Eliad - small fixes, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com --- v7: rebase arch/arm/mach-davinci/board-da850-evm.c | 3 +- arch/arm/mach-omap2/pdata-quirks.c | 29 drivers/net/wireless/ti/wl12xx/main.c | 60

[PATCH v7 3/6] dt: bindings: add TI's wilink wireless device

2015-03-18 Thread Eliad Peller
Add device tree binding documentation for TI's wilink (wl12xx and wl18xx) wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- .../devicetree/bindings/net/wireless/ti,wlcore.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v7 1/6] wlcore: set irq_trigger in board files instead of hiding behind a quirk

2015-03-18 Thread Eliad Peller
the quirk, have the board files set the irq_trigger explicitly. This will allow us to use standard irq DT definitions later on. Signed-off-by: Luciano Coelho l...@coelho.fi [Eliad - rebase, add irq_trigger field and pass it, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com

[PATCH v7 4/6] wlcore: add device-tree support

2015-03-18 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com Tested-by: Sébastien Szymanski sebastien.szyman...@armadeus.com

[PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-18 Thread Eliad Peller
...@coelho.fi Signed-off-by: Eliad Peller el...@wizery.com --- v7: * fix spi compilation (Tony) * remove irq/irq_trigger from wlcore_platdev_data (they are being passed separately) arch/arm/mach-davinci/Kconfig | 11 --- arch/arm/mach-davinci/board-da850-evm.c| 113

Re: [PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-17 Thread Eliad Peller
Martinez Canillas jav...@dowhile0.org: Hello Eliad, On Thu, Mar 12, 2015 at 1:09 PM, Eliad Peller el...@wizery.com wrote: Replace all the pdata-quirks for setting wl12xx/wl18xx platform data with proper DT definitions. The patch was compile-tested only. Signed-off-by: Eliad Peller

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-17 Thread Eliad Peller
On Mon, Mar 16, 2015 at 8:24 PM, Tony Lindgren t...@atomide.com wrote: * Sebastian Reichel s...@ring0.de [150316 11:26]: Hi, On Mon, Mar 16, 2015 at 08:29:39AM -0700, Tony Lindgren wrote: * Arnd Bergmann a...@arndb.de [150315 05:10]: On Sunday 15 March 2015 10:50:42 Eliad Peller wrote

Re: [PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-15 Thread Eliad Peller
On Fri, Mar 13, 2015 at 5:27 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150312 05:09]: --- a/arch/arm/mach-omap2/pdata-quirks.c +++ b/arch/arm/mach-omap2/pdata-quirks.c -static void __init omap3_evm_legacy_init(void) -{ - legacy_init_wl12xx(3840, 0

Re: [PATCH v6 0/6] wlcore: add device-tree support

2015-03-15 Thread Eliad Peller
hi Sébastien, On Fri, Mar 13, 2015 at 6:11 PM, Sébastien Szymanski sebastien.szyman...@armadeus.com wrote: Hello, On 03/12/2015 01:09 PM, Eliad Peller wrote: NOTE: all the platform patches were compile-tested only. I'm looking for some wl12xx card (that i should have somewhere) to test

Re: [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-15 Thread Eliad Peller
+Kalle On Fri, Mar 13, 2015 at 5:00 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150312 05:09]: From: Luciano Coelho l...@coelho.fi Instead of defining an enumeration with the FW specific values for the different clock rates, use the actual frequency instead

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-15 Thread Eliad Peller
On Fri, Mar 13, 2015 at 5:13 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150312 05:10]: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members into the platform

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Eliad Peller
On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are

[PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-12 Thread Eliad Peller
Coelho l...@coelho.fi [Eliad - small fixes, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/mach-davinci/board-da850-evm.c | 3 +- arch/arm/mach-omap2/pdata-quirks.c | 29 drivers/net/wireless/ti/wl12xx/main.c | 60

[PATCH v6 0/6] wlcore: add device-tree support

2015-03-12 Thread Eliad Peller
-tested only. I'm looking for some wl12xx card (that i should have somewhere) to test the wl12xx changes (wrt. clocks), but haven't found it yet. v6: * Add Luca's patches to pass irq_trigger/freq * Support wl12xx as well * Update all relevant platforms Eliad Peller (4): dt: bindings: add TI's

[PATCH v6 4/6] wlcore: add device-tree support

2015-03-12 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com --- v6: parse frequency properties, add wl12xx compatible strings

[PATCH v6 1/6] wlcore: set irq_trigger in board files instead of hiding behind a quirk

2015-03-12 Thread Eliad Peller
the quirk, have the board files set the irq_trigger explicitly. This will allow us to use standard irq DT definitions later on. Signed-off-by: Luciano Coelho l...@coelho.fi [Eliad - rebase, add irq_trigger field and pass it, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com

[PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-12 Thread Eliad Peller
Replace all the pdata-quirks for setting wl12xx/wl18xx platform data with proper DT definitions. The patch was compile-tested only. Signed-off-by: Eliad Peller el...@wizery.com --- v6: add wl12xx definitions as well arch/arm/boot/dts/am335x-evmsk.dts | 11 arch/arm/boot/dts

[PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-12 Thread Eliad Peller
(and doesn't have DT bindings), so remove the relevant code/Kconfig option from the board file (as suggested by Sekhar Nori) Signed-off-by: Luciano Coelho l...@coelho.fi Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/mach-davinci/Kconfig | 11 --- arch/arm/mach-davinci

[PATCH v6 3/6] dt: bindings: add TI's wilink wireless device

2015-03-12 Thread Eliad Peller
Add device tree binding documentation for TI's wilink (wl12xx and wl18xx) wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v6: add wl12xx, use IRQ_TYPE_LEVEL_HIGH .../devicetree/bindings/net/wireless/ti,wlcore.txt | 47 ++ 1 file changed, 47 insertions(+) create

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
hi Javier, On Wed, Mar 11, 2015 at 2:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-11 Thread Eliad Peller
On Wed, Mar 11, 2015 at 11:51 AM, Arnd Bergmann a...@arndb.de wrote: +static void wlcore_del_platform_data(struct wl12xx_platform_data *pdata) +{ + kfree(pdata); +} + This function seems to be an unnecessary, why not just call kfree() directly? Or better, maybe the

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
hi Javier, On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: --- a/arch/arm/boot/dts

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
On Wed, Mar 11, 2015 at 1:34 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: I think that patch [0] should not be needed since for external clocks, the IP providing the clocks should have its own clock driver and for internal clocks, a property should be used instead as you said. If

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: I was expecting you to remove all calls to legacy_init_wl12xx from this file, including

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 6:18 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150310 09:11]: On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren

[PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-09 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

[PATCH v5 1/3] dt: bindings: add wl18xx wireless device

2015-03-09 Thread Eliad Peller
Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- .../devicetree/bindings/net/wireless/ti,wl18xx.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ti

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

2015-03-09 Thread Eliad Peller
On Mon, Mar 9, 2015 at 10:50 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 09:18:46 Eliad Peller wrote: On Sun, Mar 8, 2015 at 11:53 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 08 March 2015 13:13:13 Eliad Peller wrote: I've looked up the what boards actually use

[PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-09 Thread Eliad Peller
Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining the platform data through the pdata-quirks. The patch was compile-tested only. Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 9

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-09 Thread Eliad Peller
On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@ vmmc-supply = lbep5clwmc_wlen; bus

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

2015-03-09 Thread Eliad Peller
On Sun, Mar 8, 2015 at 11:53 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 08 March 2015 13:13:13 Eliad Peller wrote: I've looked up the what boards actually use this data and found that all of them already support booting from DT: some omap2 boards using arch/arm/mach-omap2/pdata

[PATCH v4 1/2] dt: bindings: add wl18xx wireless device

2015-03-08 Thread Eliad Peller
Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v4: use specific wl18xx model numbers (Arnd) .../devicetree/bindings/net/wireless/ti,wl18xx.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644

Re: [PATCH v3 1/2] dt: bindings: add wl18xx wireless device

2015-03-08 Thread Eliad Peller
On Fri, Feb 27, 2015 at 10:14 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 19 February 2015 18:13:20 Eliad Peller wrote: +Required properties: + - compatible : Should be ti,wl18xx. Do not use wildcards in the compatible string, use specific model numbers. ok. i'll change it to ti

[PATCH v4 2/2] wl18xx: add basic device-tree support

2015-03-08 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

Re: [PATCH v2] wlcore: add basic device-tree support

2015-03-08 Thread Eliad Peller
hi Luca, On Fri, Feb 27, 2015 at 9:31 AM, Luca Coelho l...@coelho.fi wrote: Hi, On Sun, 2015-02-15 at 13:09 +0200, Eliad Peller wrote: When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

2015-03-08 Thread Eliad Peller
On Fri, Feb 27, 2015 at 10:26 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 19 February 2015 18:13:21 Eliad Peller wrote: + +static struct wl12xx_platform_data *wlcore_probe_of(struct device *dev) +{ + struct device_node *np = dev-of_node; + struct wl12xx_platform_data

[PATCH v3 2/2] wl18xx: add basic device-tree support

2015-02-19 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

[PATCH v3 1/2] dt: bindings: add wl18xx wireless device

2015-02-19 Thread Eliad Peller
Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v3: * make the bindings device-specific (wl18xx) (Arnd, Mark) * split bindings and driver changes (Arnd) * make interrupt-parent optional (Arnd) * make unit-address same as reg

Re: [PATCH v2] wlcore: add basic device-tree support

2015-02-18 Thread Eliad Peller
On Tue, Feb 17, 2015 at 5:45 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Feb 17, 2015 at 03:39:03PM +, Eliad Peller wrote: On Mon, Feb 16, 2015 at 12:06 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 15 February 2015 13:09:10 Eliad Peller wrote: s + +This node provides

Re: [PATCH v2] wlcore: add basic device-tree support

2015-02-17 Thread Eliad Peller
On Mon, Feb 16, 2015 at 12:06 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 15 February 2015 13:09:10 Eliad Peller wrote: s + +This node provides properties for controlling the wilink wireless device. The +node is expected to be specified as a child node to the SDIO controller

[PATCH v2] wlcore: add basic device-tree support

2015-02-15 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

SDIO device binding

2014-12-11 Thread Eliad Peller
hi, I'm looking for the proper way to pass SDIO device properties using devicetree. There seems to be a patchset sent previously by Sascha Hauer to handle it, but for some reason it didn't get merged, and i can't find any further discussion regarding the patches.

Re: SDIO device binding

2014-12-11 Thread Eliad Peller
On Thu, Dec 11, 2014 at 5:37 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 11 December 2014 at 14:32, Eliad Peller el...@wizery.com wrote: hi, I'm looking for the proper way to pass SDIO device properties using devicetree. There seems to be a patchset sent previously by Sascha Hauer

[PATCH] wlcore: add basic device-tree support

2014-07-09 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

Re: [PATCH] wlcore: add basic device-tree support

2014-07-09 Thread Eliad Peller
On Wed, Jul 9, 2014 at 2:00 PM, Yegor Yefremov yegorsli...@googlemail.com wrote: On Wed, Jul 9, 2014 at 11:31 AM, Eliad Peller el...@wizery.com wrote: When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from