Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support

2015-05-27 Thread Fabrice Gasnier
On 05/27/2015 05:43 PM, Arnd Bergmann wrote: On Wednesday 27 May 2015 17:31:46 Arnd Bergmann wrote: Yes, that works. However there are two problems with the approach: - we have to change all PCI host drivers on ARM to do this in order to remove the ARM-specific pcibios_msi_controller() funct

Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support

2015-05-27 Thread Fabrice Gasnier
On 05/27/2015 03:24 PM, Zhou Wang wrote: there is still code in bios32 that requires pci_sys_data. Right. >No matters pci_common_init_dev() is being called or not : > >You can see pcibios_msi_controller() has a weak definition (in drivers/pci/msi.c). >But bios32 defines it for arm. Then it's

Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support

2015-05-26 Thread Fabrice Gasnier
Hi zhou, On 05/26/2015 04:49 AM, Zhou Wang wrote: struct pcie_port { >+#ifdef CONFIG_ARM >+/* >+ * this is a temporary hack to let the driver work on >+ * both arm32 and arm64. it can be removed after the >+ * arm32 cleanup is complete and bios32.c has stopped >+ * referenc

Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support

2015-05-25 Thread Fabrice Gasnier
Hi Zhou, On 05/25/2015 03:48 PM, Jingoo Han wrote: >so how about we set 0 as default value of pp->root_bus_nr, then use >pci_create_root_bus(pp->dev, pp->root_bus_nr, &dw_pcie_ops, pp, &res); >to create root bus? I agree with your opinion. However, I still want to wait for other people's opinio

Re: [PATCH v3 4/5] pci: designware: remove pci_common_init_dev()

2015-05-25 Thread Fabrice Gasnier
Hi Bjorn, On 05/06/2015 09:22 PM, Bjorn Helgaas wrote: It's not completely obvious that replacing pci_common_init_dev() with dw_pcie_setup() is equivalent. Here are my notes from trying to convince myself that this is correct. I think your changelog could stand some enhancement. It would be i

Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller

2015-03-18 Thread Fabrice Gasnier
cie_driver, st_pcie_probe); +} +device_initcall(pcie_init); I think the module unload comment is a bit odd for built-in only code. +MODULE_AUTHOR("Fabrice Gasnier "); +MODULE_DESCRIPTION("PCI express Driver for ST SoCs"); +MODULE_LICENSE("GPL v2"); These three m

Re: [STLinux Kernel] [PATCH] ARM: STi: Add STiH410 SoC support

2015-03-05 Thread Fabrice Gasnier
Hi Peter, On 03/05/2015 02:29 PM, Peter Griffin wrote: Hi Fabrice, On Thu, 05 Mar 2015, Fabrice GASNIER wrote: This patch adds support to STiH410 SoC. Once Maximes comments have been addressed: - Maxime's comment was on the commit message. I sent a v2 for this ;-). Thanks, Fa

[PATCH v2] ARM: STi: Add STiH410 SoC support

2015-03-05 Thread Fabrice GASNIER
This patch adds support to STiH410 SoC. Please note "st,stih410" is already present in device tree. The problem is that it is missing the entry in the match table, and so the L2 cache and other cpus than 0 don't get initialized. Signed-off-by: Fabrice Gasnier Acked-by:

[PATCH] ARM: STi: Add STiH410 SoC support

2015-03-05 Thread Fabrice GASNIER
This patch adds support to STiH410 SoC. Signed-off-by: Fabrice Gasnier --- Documentation/devicetree/bindings/arm/sti.txt | 4 arch/arm/mach-sti/board-dt.c | 1 + 2 files changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/sti.txt b/Documentation