On 05/27/2015 03:24 PM, Zhou Wang wrote:
there is still code in bios32 that requires pci_sys_data.
Right.
No matters pci_common_init_dev() is being called or not :
You can see pcibios_msi_controller() has a weak definition (in
drivers/pci/msi.c).
But bios32 defines it for arm. Then it's
On 05/27/2015 05:43 PM, Arnd Bergmann wrote:
On Wednesday 27 May 2015 17:31:46 Arnd Bergmann wrote:
Yes, that works. However there are two problems with the approach:
- we have to change all PCI host drivers on ARM to do this in order to remove
the ARM-specific pcibios_msi_controller()
Hi zhou,
On 05/26/2015 04:49 AM, Zhou Wang wrote:
struct pcie_port {
+#ifdef CONFIG_ARM
+/*
+ * this is a temporary hack to let the driver work on
+ * both arm32 and arm64. it can be removed after the
+ * arm32 cleanup is complete and bios32.c has stopped
+ * referencing
Hi Zhou,
On 05/25/2015 03:48 PM, Jingoo Han wrote:
so how about we set 0 as default value of pp-root_bus_nr, then use
pci_create_root_bus(pp-dev, pp-root_bus_nr, dw_pcie_ops, pp, res);
to create root bus?
I agree with your opinion. However, I still want to wait for other
people's opinions.
Hi Bjorn,
On 05/06/2015 09:22 PM, Bjorn Helgaas wrote:
It's not completely obvious that replacing pci_common_init_dev() with
dw_pcie_setup() is equivalent. Here are my notes from trying to convince
myself that this is correct. I think your changelog could stand some
enhancement. It would be
think the module unload comment is a bit odd for built-in only code.
+MODULE_AUTHOR(Fabrice Gasnier fabrice.gasn...@st.com);
+MODULE_DESCRIPTION(PCI express Driver for ST SoCs);
+MODULE_LICENSE(GPL v2);
These three macros will be, basically, always preprocessed away as long
as this code can't
This patch adds support to STiH410 SoC.
Signed-off-by: Fabrice Gasnier fabrice.gasn...@st.com
---
Documentation/devicetree/bindings/arm/sti.txt | 4
arch/arm/mach-sti/board-dt.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm
This patch adds support to STiH410 SoC.
Please note st,stih410 is already present in device tree.
The problem is that it is missing the entry in the match table,
and so the L2 cache and other cpus than 0 don't get initialized.
Signed-off-by: Fabrice Gasnier fabrice.gasn...@st.com
Acked
Hi Peter,
On 03/05/2015 02:29 PM, Peter Griffin wrote:
Hi Fabrice,
On Thu, 05 Mar 2015, Fabrice GASNIER wrote:
This patch adds support to STiH410 SoC.
Once Maximes comments have been addressed: -
Maxime's comment was on the commit message.
I sent a v2 for this ;-).
Thanks,
Fabrice
