Re: [PATCH v3 0/3] usb: renesas_usbhs: More compat strings

2015-12-16 Thread Felipe Balbi
Hi, Simon Horman writes: > Hi, > > this short series adds generic, and soc-specific r8a7792 and r8a7793 compat > strings to the Renesas USBHS driver. The intention is to provide a complete > set of compat strings for known R-Car SoCs. > > Changes since v2: > * Split documentation of SoC names in

Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-16 Thread Felipe Balbi
Hi, Arnd Bergmann writes: >> +struct renesas_usb3; >> +struct renesas_usb3_request { >> +struct usb_request req; >> +struct list_headqueue; >> +}; > > There is already a list_head in struct usb_request. Could you use that? > (I don't know, just asking because this looks odd)

Re: [4.4-rc][PATCH v2] ARM: dts: am4372: fix clock source for arm twd and global timers

2015-12-08 Thread Felipe Balbi
nstead of 5. > > Hence, fix it by adding mpu_periphclk ("fixed-factor-clock") and use > it for clocking ARM TWD and Global timer (same way as on OMAP4). > > Cc: Tony Lindgren > Cc: Felipe Balbi > Cc: Tero Kristo > Fixes:commit 8cbd4c2f6a99 ("arm: boot: d

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Felipe Balbi
Hi, Peter Chen writes: >> seriously ? Is this really all ? What about that reset line below ? > > The clock is PHY input clock on the HUB, this clock may from SoC's > PLL. oh, you might have misunderstood my comment. I'm saying that there is more than one thing you could cache in your private s

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-07 Thread Felipe Balbi
Hi, Peter Chen writes: > diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile > index 45fd4ac..da52e9a 100644 > --- a/drivers/usb/misc/Makefile > +++ b/drivers/usb/misc/Makefile > @@ -29,3 +29,4 @@ obj-$(CONFIG_USB_CHAOSKEY) += chaoskey.o > > obj-$(CONFIG_USB_SISUSBVGA)

Re: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3

2015-12-04 Thread Felipe Balbi
Hi, Peter Ujfalusi writes: > @@ -174,12 +182,44 @@ > }; > > edma: edma@4900 { > - compatible = "ti,edma3"; > - ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2"; > - reg = <0x4900 0x1>, > -

Re: [PATCH v4 2/5] spi: spi-ti-qspi: add mmap mode read support

2015-11-30 Thread Felipe Balbi
Hi, Vignesh R writes: > ti-qspi controller provides mmap port to read data from SPI flashes. > mmap port is enabled in QSPI_SPI_SWITCH_REG. ctrl module register may > also need to be accessed for some SoCs. The QSPI_SPI_SETUP_REGx needs to > be populated with flash specific information like read

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Felipe Balbi
Hi, Tim Bird writes: > On 11/16/2015 09:21 AM, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >>> On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: >>>> >>>> >>>> On 11/10/2015 07:14 PM, Peter Ch

Re: [PATCH] usb: dwc2: add support of hi6220

2015-11-20 Thread Felipe Balbi
"Herrero, Gregory" writes: > Hi Felipe, > > I just realized this patch miss "dma_desc_fs_enable" property in > params_hi6220. (drivers/usb/dwc2/platform.c:57) > > You need to apply this patch: > > diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c > index d5102c4..2dfdae3 1006

Re: [PATCH] usb: dwc2: add support of hi6220

2015-11-20 Thread Felipe Balbi
Hi, John Youn writes: > On 11/19/2015 11:04 AM, Felipe Balbi wrote: >> >> Hi, >> >> Zhangfei Gao writes: >>> Support hisilicon,hi6220-usb for HiKey board >>> >>> Signed-off-by: Zhangfei Gao >> >> doesn't apply: >&

Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage

2015-11-20 Thread Felipe Balbi
Hi, Andy Gross writes: > This patch adds documentation for the optional syscon-tcsr property in the > Qualcomm DWC3 node. The syscon-tcsr specifies the register and bit used to > configure the TCSR USB phy mux register. > > Signed-off-by: Andy Gross > --- > Documentation/devicetree/bindings/u

Re: [PATCH 2/4] usb: dwc3: qcom: Configure TCSR phy mux register

2015-11-20 Thread Felipe Balbi
Hi, Andy Gross writes: > This patch adds automatic configuration of the TCSR phy mux register based on > the syscon-tcsr devicetree entry. This configuration is optional, as some > platforms may not require the mux selection. > > Signed-off-by: Andy Gross just when I find a way to make a gene

Re: [PATCH] usb: dwc2: add support of hi6220

2015-11-19 Thread Felipe Balbi
Hi, Zhangfei Gao writes: > Support hisilicon,hi6220-usb for HiKey board > > Signed-off-by: Zhangfei Gao doesn't apply: Applying: usb: dwc2: add support of hi6220 error: drivers/usb/dwc2/platform.c: does not match index Patch failed at 0001 usb: dwc2: add support of hi6220 The copy of the patc

Re: [PATCH 1/2] usb: doc: dwc3-xilinx: Add devicetree bindings

2015-11-18 Thread Felipe Balbi
Hi, Rob Herring writes: > On Wed, Nov 18, 2015 at 5:02 PM, Felipe Balbi wrote: >> >> Hi, >> >> Rob Herring writes: >>> On Wed, Nov 18, 2015 at 06:20:31PM +0530, Subbaraya Sundeep Bhatta wrote: >>>> This patch adds binding doc for Xilinx DWC3

Re: [PATCH 1/2] usb: doc: dwc3-xilinx: Add devicetree bindings

2015-11-18 Thread Felipe Balbi
Hi, Rob Herring writes: > On Wed, Nov 18, 2015 at 06:20:31PM +0530, Subbaraya Sundeep Bhatta wrote: >> This patch adds binding doc for Xilinx DWC3 glue driver. >> >> Signed-off-by: Subbaraya Sundeep Bhatta > > I really dislike how the DWC3 binding has been done. The sub-node here > is pointle

Re: [PATCH 2/2] usb: dwc3: Add Xilinx ZynqMP platform specific glue layer

2015-11-18 Thread Felipe Balbi
Hi, Subbaraya Sundeep Bhatta writes: > This patch adds glue driver for DWC3 core in Xilinx ZynqMP SOC. > DWC3 glue layer is hardware layer around Synopsys DesignWare > USB3 core. Its purpose is to supply Synopsys IP with required clocks > and interface it with the rest of the SoC. > > Signed-off

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-16 Thread Felipe Balbi
Hi, Peter Chen writes: > On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: >> >> >> On 11/10/2015 07:14 PM, Peter Chen wrote: >> > On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote: >> >> This fixes a bug where if you disconnect and re-connect the USB cable, >> >> the gadget dri

Re: [PATCH v2 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-05 Thread Felipe Balbi
Hi, Rob Herring writes: > On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: >> Add qspi memory mapped region entries for AM43xx based SoCs. Also, >> update the binding documents for the controller to document this change. >> >> Signed-off-by: Vignesh R > > Acked-by: Rob Herring > >>

Re: [PATCH] dmaengine: edma: Add dummy driver skeleton for edma3-tptc

2015-11-04 Thread Felipe Balbi
ill add a dummy driver skeleton without probe or remove > callbacks provided. > > Signed-off-by: Peter Ujfalusi > Reported-by: Olof Johansson This fixes the problem I also reported on linux-omap [1] Tested-by: Felipe Balbi [1] http://marc.info/?l=linux-omap&m=14466542903201

Re: [PATCH v2 3/4] ARM: dts: DRA7: Add timer12 node

2015-10-05 Thread Felipe Balbi
Suman Anna writes: > Add the DT node for Timer12 present on DRA7 family of > SoCs. Timer12 is present in PD_WKUPAON power domain, and > has the same capabilities as the other timers, except for > the fact that it serves as a secure timer on HS devices > and is clocked only from the secure 32K clo

Re: [PATCH 1/3][v4] Documentation: dt: dwc3: Add snps,quirk-frame-length-adjustment property

2015-10-02 Thread Felipe Balbi
On Thu, Sep 24, 2015 at 09:42:59AM +, RAJESH BHAGAT wrote: > Hi Felipe, > > Any comments on the below [v4] patches? > > [PATCH 1/3][v4] Documentation: dt: dwc3: Add > snps,quirk-frame-length-adjustment property https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=next&id=37

Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

2015-09-30 Thread Felipe Balbi
On Thu, Sep 24, 2015 at 11:18:01AM -0500, Rob Herring wrote: > On Thu, Sep 24, 2015 at 4:26 AM, Subbaraya Sundeep Bhatta > wrote: > > Hi Peter, > > > >> -Original Message- > >> From: Peter Chen [mailto:peter.c...@freescale.com] > >> Sent: Thursday, September 24, 2015 2:41 PM > >> To: Subba

Re: [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts

2015-09-14 Thread Felipe Balbi
interrupt-parent = <&gpio0>; > - interrupts = <31 0>; > + interrupts = <31 IRQ_TYPE_EDGE_FALLING>; for AM437x SK: Acked-by: Felipe Balbi Seems like there are no changes considering driver was always using IRQF_TRIGGER_FALLING. -- balbi signature.asc Description: Digital signature

Re: [PATCH] of: device: fix NULL pointer dereference on driver removal

2015-08-26 Thread Felipe Balbi
On Wed, Aug 26, 2015 at 08:14:36AM -0500, Rob Herring wrote: > On Tue, Aug 25, 2015 at 2:34 PM, Felipe Balbi wrote: > > If we don't insert resources into the resource tree, > > calls to of_platform_depopulate() will end up in NULL > > pointer dereferences because the r

[PATCH] of: device: fix NULL pointer dereference on driver removal

2015-08-25 Thread Felipe Balbi
/0x54) [ 28.626172] Code: eb0354bf e5957010 e3a020f4 e59f10f0 (e5973008) [ 28.632722] ---[ end trace d2a21fc5d73a2dfd ]--- Cc: Signed-off-by: Felipe Balbi --- very easy to trigger with 'modprobe -r dwc3-omap' on any of TI's platform sporting dwc3 drivers/of/device.c | 23 ++

Re: [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string

2015-08-06 Thread Felipe Balbi
On Thu, Aug 06, 2015 at 06:55:57AM +0530, Keerthy wrote: > > > On Wednesday 05 August 2015 10:21 PM, Felipe Balbi wrote: > >On Wed, Aug 05, 2015 at 09:48:08PM +0530, Keerthy wrote: > >> > >> > >>On Wednesday 05 August 2015 09:44 PM, Felipe Balbi wrot

Re: [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string

2015-08-05 Thread Felipe Balbi
On Wed, Aug 05, 2015 at 09:48:08PM +0530, Keerthy wrote: > > > On Wednesday 05 August 2015 09:44 PM, Felipe Balbi wrote: > >On Wed, Aug 05, 2015 at 09:21:05PM +0530, Keerthy wrote: > >>Felipe, > >> > >>On Wednesday 05 August 2015 09:01 PM, Felipe Balbi

Re: [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string

2015-08-05 Thread Felipe Balbi
On Wed, Aug 05, 2015 at 09:21:05PM +0530, Keerthy wrote: > Felipe, > > On Wednesday 05 August 2015 09:01 PM, Felipe Balbi wrote: > >On Wed, Aug 05, 2015 at 04:19:45PM +0530, Keerthy wrote: > >>Compared to da830-rtc compatibility am3352-rtc is more compatible to > >&g

Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-08-05 Thread Felipe Balbi
On Wed, Aug 05, 2015 at 07:42:24PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 04 August 2015 09:36 PM, Felipe Balbi wrote: > > On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: > >> No functional change. Previously omap_control_phy_p

Re: [PATCH 1/8] ARM: dts: AM4372: Reorder the rtc compatible string

2015-08-05 Thread Felipe Balbi
On Wed, Aug 05, 2015 at 04:19:45PM +0530, Keerthy wrote: > Compared to da830-rtc compatibility am3352-rtc is more compatible to > the one in am437x. Hence adding the am3352-rtc compatible to cover the > entire feature set. > > The ti,am4372-rtc has no Documentation and not used even in the driver

Re: [PATCH 5/7] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:44PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to power same comment as before. > off the PHY during probe. But once phy-omap-usb2 driver is adapted to > use syscon, omap_control_phy_power() cannot be us

Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to power there is a slight functional change. You moved PHY power off from before to after pm_runtime_enable(), clk_prepare_enable() and creation of the PHY

Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Add separate functions for pll, > clocks and syscon to make ti_pipe3_probe clean. > > Signed-off-by: Kishon Vijay Abraham I I think this needs to be splitted into smaller patches. Seems like the very

Re: [PATCH] usb: musb: omap2430: use *syscon* framework API to write to mailbox register

2015-08-04 Thread Felipe Balbi
Hi, On Tue, Aug 04, 2015 at 07:36:09PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to write to the mailbox register > and start using *syscon* framework to do the same. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/oma

Re: [PATCH v8 00/23] usb gadget update for OTG 2.0

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:00:31AM +0800, Li Jun wrote: > On Thu, Jul 30, 2015 at 09:10:06AM -0500, Felipe Balbi wrote: > > On Thu, Jul 30, 2015 at 09:46:58AM +0800, Li Jun wrote: > > > On Wed, Jul 29, 2015 at 09:11:41PM -0500, Felipe Balbi wrote: > > > > On Thu, Ju

Re: [PATCH v8 00/23] usb gadget update for OTG 2.0

2015-07-30 Thread Felipe Balbi
On Thu, Jul 30, 2015 at 09:46:58AM +0800, Li Jun wrote: > On Wed, Jul 29, 2015 at 09:11:41PM -0500, Felipe Balbi wrote: > > On Thu, Jul 30, 2015 at 07:24:03AM +0800, Li Jun wrote: > > > On Wed, Jul 29, 2015 at 10:04:27AM -0500, Felipe Balbi wrote: > > > > On Mon, Ju

Re: [PATCH v8 00/23] usb gadget update for OTG 2.0

2015-07-29 Thread Felipe Balbi
On Thu, Jul 30, 2015 at 07:24:03AM +0800, Li Jun wrote: > On Wed, Jul 29, 2015 at 10:04:27AM -0500, Felipe Balbi wrote: > > On Mon, Jul 27, 2015 at 03:21:59PM +0800, Peter Chen wrote: > > > On Thu, Jul 23, 2015 at 11:37:24AM +0800, Li Jun wrote: > > > > Change for v8:

Re: [PATCH v8 00/23] usb gadget update for OTG 2.0

2015-07-29 Thread Felipe Balbi
On Mon, Jul 27, 2015 at 03:21:59PM +0800, Peter Chen wrote: > On Thu, Jul 23, 2015 at 11:37:24AM +0800, Li Jun wrote: > > Change for v8: > > - Add Peter's ACk for chipidea driver; and Roger's Reviewed-by for patch > > 07, 21~23. > > - Add ci->is_otg condition before enable ci->gadget.is_otg for c

Re: [PATCH 1/3] Documentation: dt: dwc3: Add snps,configure-fladj property

2015-07-23 Thread Felipe Balbi
On Thu, Jul 23, 2015 at 11:07:09AM +, Badola Nikhil wrote: > > -Original Message- > > From: Mark Rutland [mailto:mark.rutl...@arm.com] > > Sent: Thursday, July 23, 2015 4:27 PM > > To: Badola Nikhil-B46172 > > Cc: linux-ker...@vger.kernel.org; devicetree@vger.kernel.org; ba...@ti.com >

Re: [PATCH v7 08/23] usb: chipidea: set usb otg capabilities

2015-07-22 Thread Felipe Balbi
On Mon, Jul 13, 2015 at 09:03:14AM +0800, Peter Chen wrote: > On Thu, Jul 09, 2015 at 09:22:09PM +0800, Li Jun wrote: > > On Thu, Jul 09, 2015 at 11:57:39AM +0300, Roger Quadros wrote: > > > Hi, > > > > > > On 09/07/15 10:18, Li Jun wrote: > > > > Init and update otg capabilities by DT, set gadget

Re: [PATCH v7 00/23] usb gadget update for OTG 2.0

2015-07-22 Thread Felipe Balbi
On Thu, Jul 09, 2015 at 03:18:37PM +0800, Li Jun wrote: > Change for v7: > - Free otg descriptor when failure of bind in patch 21, 22, 23. > add Roger's Reviewed-by for patch 10~20. > - Choose the lesser otg-rev if otg-rev has been set before update by DT, > remove 0x0300 in supported otg-rev l

Re: [PATCH v3 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs

2015-07-22 Thread Felipe Balbi
Hi, On Wed, Jul 22, 2015 at 10:05:43PM +0800, Chunfeng Yun wrote: > support usb3.0 phy of mt65xx SoCs > > Signed-off-by: Chunfeng Yun you missed Kishon here. > --- > drivers/phy/Kconfig | 9 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-mt65xx-usb3.c | 426 > ++

Re: [PATCH] usb: phy: msm: Add D+/D- lines route control

2015-07-21 Thread Felipe Balbi
On Wed, Jul 08, 2015 at 12:45:54PM +0300, Ivan T. Ivanov wrote: > apq8016-sbc board is using Dual SPDT USB Switch (TC7USB40MU), > witch is controlled by GPIO to de/multiplex D+/D- USB lines to > USB2513B Hub and uB connector. Add support for this. > > Signed-off-by: Ivan T. Ivanov doesn't apply:

Re: [PATCH v5 1/3] musb: sunxi: Add support for the Allwinner sunxi musb controller

2015-07-06 Thread Felipe Balbi
On Sat, Jun 13, 2015 at 02:42:08PM +0200, Hans de Goede wrote: > This is based on initial code to get the Allwinner sunxi musb controller > supported by Chen-Yu Tsai and Roman Byshko. > > This adds support for the Allwinner sunxi musb controller in both host only > and otg mode. Peripheral only mo

Re: [PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288

2015-07-06 Thread Felipe Balbi
On Mon, Jul 06, 2015 at 11:06:35AM -0700, Doug Anderson wrote: > Felipe, > > On Mon, Jul 6, 2015 at 10:48 AM, Felipe Balbi wrote: > > On Mon, Jun 22, 2015 at 04:52:21PM -0700, Douglas Anderson wrote: > >> This series of patches, together with > >> <https:

Re: [PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288

2015-07-06 Thread Felipe Balbi
On Mon, Jun 22, 2015 at 04:52:21PM -0700, Douglas Anderson wrote: > This series of patches, together with > from Chris Zhong and a > dts change allow us to wake up from a USB device on rk3288 boards. > The patches were tested on rk3288-jerry in the chro

Re: [PATCH v2 01/20] ARM: omap2plus_defconfig: Enable audio related config options

2015-07-02 Thread Felipe Balbi
selected by the CONFIG_SND_AM33XX_SOC_EVM option, but > the aim is to convert all boards to use simple card. > > Signed-off-by: Peter Ujfalusi Acked-by: Felipe Balbi > --- > arch/arm/configs/omap2plus_defconfig | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 03:52:49PM +0300, Peter Ujfalusi wrote: > On 07/02/2015 03:23 PM, Felipe Balbi wrote: > > On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: > >> The sound support consist only Headset output on the board and can be > >> ha

Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: > The sound support consist only Headset output on the board and can be > handled by "simple-audio-card" > > Signed-off-by: Peter Ujfalusi Still works fine: Tested-by: Felipe Balbi one question though, sh

Re: [PATCH 1/2] ARM: DTS: am437x-sk-evm: Add sleep pin settings for mcasp1

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 02:58:05PM +0300, Peter Ujfalusi wrote: > When McASP is not in use the pins can be put to sleep mode to conserve > power. > > Signed-off-by: Peter Ujfalusi Tested-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH 0/2] ARM: DTS: am437x-sk-evm: Use simple-card for audio support

2015-07-02 Thread Felipe Balbi
Hi, On Thu, Jul 02, 2015 at 02:58:04PM +0300, Peter Ujfalusi wrote: > Hi, > > There is no reason to use the davinci-evm machine driver's compatible for > audio > support since the setup is simple and the common simple-audio-card can handle > it > just fine. > Also add McASP1 sleep pin configura

Re: [PATCH 2/2] ARM: dts: am4372: Add emif node

2015-06-02 Thread Felipe Balbi
On Wed, May 06, 2015 at 12:25:33PM -0500, Dave Gerlach wrote: > Add node for TI AM4372 EMIF. > > Signed-off-by: Dave Gerlach Tony, this patch fixes the regression I just reported at [1], care to pick this one up ? Tested-by: Felipe Balbi Acked-by: Felipe Balbi [1] http://marc.info

Re: [PATCH v4 2/2] musb: Add support for the Allwinner sunxi musb controller

2015-06-02 Thread Felipe Balbi
On Sun, May 31, 2015 at 06:10:26PM +0200, Hans de Goede wrote: > This is based on initial code to get the Allwinner sunxi musb controller > supported by Chen-Yu Tsai and Roman Byshko. > > This adds support for the Allwinner sunxi musb controller in both host only > and otg mode. Peripheral only mo

Re: [PATCH v4 0/2] Remaining sunxi musb patches

2015-06-02 Thread Felipe Balbi
Hi, On Tue, Jun 02, 2015 at 09:14:05AM +0200, Hans de Goede wrote: > >>>Here is an updated version of the remaining (not yet merged in Felipe's > >>>tree) > >>>sunxi musb patches. > >>> > >>>The "phy-sun4i-usb: Add full support for usb0 phy / OTG" patch has been > >>>updated with a small bug-fix a

Re: [PATCH v4 0/2] Remaining sunxi musb patches

2015-06-01 Thread Felipe Balbi
On Mon, Jun 01, 2015 at 11:30:45AM -0700, Hans de Goede wrote: > Hi, > > On Sunday, May 31, 2015 at 6:10:32 PM UTC+2, Hans de Goede wrote: > > > > Hi Kishon & Felipe, > > > > Here is an updated version of the remaining (not yet merged in Felipe's > > tree) > > sunxi musb patches. > > > > The "

Re: [PATCH 4/6] usb: phy: add usb3.0 phy driver for mt65xx SoCs

2015-06-01 Thread Felipe Balbi
On Wed, May 27, 2015 at 07:48:01PM +0800, chunfeng@mediatek.com wrote: > From: Chunfeng Yun > > Signed-off-by: Chunfeng Yun no commit log => no commit, sorry. And it's too late for v4.2. I'll defer this until v4.3 -- balbi signature.asc Description: Digital signature

Re: [PATCH 3/6] xhci: probe phy before add usb_hcd

2015-05-27 Thread Felipe Balbi
On Wed, May 27, 2015 at 07:48:00PM +0800, chunfeng@mediatek.com wrote: > From: Chunfeng Yun > > find the phy driver before add primary usb_hcd to avoid acessing > xHCI register which may hangup the system when the phy is not loaded > yet and the related powers or clocks put in phy driver are

Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller

2015-05-26 Thread Felipe Balbi
On Tue, May 26, 2015 at 06:36:30PM +0200, Hans de Goede wrote: > Hi, > > On 05/26/2015 05:48 PM, Felipe Balbi wrote: > >On Fri, Mar 20, 2015 at 08:11:15PM +0100, Hans de Goede wrote: > >>This is based on initial code to get the Allwinner sunxi musb controller > >

Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller

2015-05-26 Thread Felipe Balbi
On Fri, Mar 20, 2015 at 08:11:15PM +0100, Hans de Goede wrote: > This is based on initial code to get the Allwinner sunxi musb controller > supported by Chen-Yu Tsai and Roman Byshko. > > This adds support for the Allwinner sunxi musb controller in both host only > and otg mode. Peripheral only mo

Re: [PATCH 1/3] phy-sun4i-usb: Add a sunxi specific function for setting squelch-detect

2015-05-26 Thread Felipe Balbi
On Sun, Mar 29, 2015 at 12:50:46PM +0200, Hans de Goede wrote: > The sunxi otg phy has a bug where it wrongly detects a high speed squelch > when reset on the root port gets de-asserted with a lo-speed device. > > The workaround for this is to disable squelch detect before de-asserting > reset, an

Re: [PATCH v2 04/13] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-05-11 Thread Felipe Balbi
On Fri, Mar 20, 2015 at 08:11:13PM +0100, Hans de Goede wrote: > The generic fifo functions already use non wrapped accesses in various > cases through the iowrite#_rep functions, and all platforms which override > the default musb_read[b|w] / _write[b|w] functions also provide their own > fifo acc

Re: [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral

2015-03-17 Thread Felipe Balbi
k on this EVM. > > Signed-off-by: Roger Quadros on subject: x14 ? other than that Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-03-13 Thread Felipe Balbi
Hi, On Fri, Mar 13, 2015 at 01:14:01AM +, yoshihiro shimoda wrote: > > > > diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c > > > > b/drivers/usb/renesas_usbhs/mod_gadget.c > > > > index e0384af77e56..e9d75d85be59 100644 > > > > --- a/drivers/usb/renesas_usbhs/mod_gadget.c > > > > +++ b/dr

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-03-12 Thread Felipe Balbi
Hi, On Thu, Mar 12, 2015 at 05:40:56AM +, yoshihiro shimoda wrote: > Hi, > > > On Thu, Mar 12, 2015 at 04:33:41AM +, yoshihiro shimoda wrote: > > > Hi Geert-san again, > > > > > > > Hi Geert-san, > > > > > > > > Thank you for the reply again! > > > > > > > > > Hi Shimoda-san, > > > > > >

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-03-11 Thread Felipe Balbi
Hi, On Thu, Mar 12, 2015 at 04:33:41AM +, yoshihiro shimoda wrote: > Hi Geert-san again, > > > Hi Geert-san, > > > > Thank you for the reply again! > > > > > Hi Shimoda-san, > > > > > > On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda > > > wrote: > > > > According to the gadget.h, a "co

Re: [PATCH v5 0/5] Add support for Fujitsu USB host controller

2015-03-10 Thread Felipe Balbi
On Sun, Feb 22, 2015 at 12:25:35PM +0800, Sneeker Yeh wrote: > These patches add support for XHCI compliant Host controller found > on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ > The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 > driver > and last four

Re: SPDX-License-Identifier

2015-02-25 Thread Felipe Balbi
On Wed, Feb 25, 2015 at 10:49:51PM +0100, Pavel Machek wrote: > Hi! > > > > >Is one tag per directory sufficient? Is one tag per file sufficient? > > > >How about one tag per package? If package, then isn't a single tag for > > > >the whole kernel source tree sufficient, as we all know the overa

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-25 Thread Felipe Balbi
On Wed, Feb 25, 2015 at 09:28:36PM +0800, zhangfei wrote: > +static void hi6220_detect_work(struct work_struct *work) > +{ > + struct hi6220_priv *priv = > + container_of(work, struct hi6220_priv, work.work); > + int gpio_id, gpio_vbus; >

Re: [PATCH] ARM: dts: am335x-bone*: usb0 is hardwired for peripheral

2015-02-24 Thread Felipe Balbi
-) Thanks Reviewed-by: Felipe Balbi Acked-by: Felipe Balbi > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi > b/arch/arm/boot/dts/am335x-bone-common.dtsi > index 6cc25ed.

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi
Hi, On Sun, Feb 22, 2015 at 11:10:36AM +0800, zhangfei wrote: > >>+static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) > >>+{ > >>+ struct usb_otg *otg = priv->phy.otg; > >>+ > >>+ if (!otg->gadget) > >>+ return; > >>+ >

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi
On Wed, Feb 11, 2015 at 11:10:31AM +0200, Baruch Siach wrote: > Hi Peter, Felipe, > > > > new drivers only on drivers/phy/, sorry. > > > > This driver has many USB dependencies, like otg, gadget. I don't know it > > can use generic phy currently. > > I would like to remind you the thread at > h

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi
On Tue, Feb 10, 2015 at 10:53:23PM +0800, zhangfei wrote: > > > On 02/10/2015 10:48 PM, Felipe Balbi wrote: > >On Tue, Feb 10, 2015 at 05:10:04PM +0800, Zhangfei Gao wrote: > >>Add usb phy controller for hi6220 platform > >> > >>Signed-off-by: Zhangfei

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi
On Wed, Feb 11, 2015 at 01:30:53AM +, Peter Chen wrote: > > > > Signed-off-by: Zhangfei Gao > > > --- > > > drivers/usb/phy/Kconfig | 9 ++ > > > drivers/usb/phy/Makefile | 1 + > > > drivers/usb/phy/phy-hi6220-usb.c | 306 > > > +++ >

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-21 Thread Felipe Balbi
Hi, On Sat, Feb 21, 2015 at 11:03:05PM +0800, zhangfei wrote: > +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) > +{ > + struct usb_otg *otg = priv->phy.otg; > + > + if (!otg->gadget) > + return; > + > + if (on) > + usb_ga

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-20 Thread Felipe Balbi
Hi, On Fri, Feb 20, 2015 at 11:44:37PM +0800, zhangfei wrote: > Hi, Balbi > > On 02/20/2015 10:41 PM, Felipe Balbi wrote: > > >>+static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) > >>+{ > >>+ struct usb_otg *otg = priv-&

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-20 Thread Felipe Balbi
Hi, On Thu, Feb 12, 2015 at 03:37:26PM +0800, Zhangfei Gao wrote: > Add usb phy controller for hi6220 platform > > Signed-off-by: Zhangfei Gao > --- > drivers/phy/Kconfig | 9 ++ > drivers/phy/Makefile | 1 + > drivers/phy/phy-hi6220-usb.c | 306 > +

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-19 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 11:07:21AM +0800, zhangfei wrote: > Hi, Balbi > > On 02/18/2015 10:35 PM, Felipe Balbi wrote: > >On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: > >>Hi, Kishon > >> > >>On 02/18/2015 01:35 PM, Kishon Vijay Abraham I

Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 10:39:53PM +0800, Sneeker Yeh wrote: > Hi, > 2015/2/18 下午10:34 於 "Felipe Balbi" 寫道: > > > > On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote: > > > Hi > > > > > > This looks correct, but if you are s

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: > Hi, Kishon > > On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: > >>Add usb phy controller for hi6220 platform > >> > >>Signed-off-by: Zhangfei Gao > >>--- > >

Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote: > Hi > > This looks correct, but if you are still going to make a new series fixing > Felipe's comments then the following tiny nitpicks could be fixed as well. > > Otherwise > > Acked-by: Mathias Nyman > > Felipe, Do you want to

Re: [PATCH v4 5/5] usb: dwc3: add Fujitsu Specific Glue layer

2015-02-17 Thread Felipe Balbi
On Tue, Feb 17, 2015 at 01:41:37PM +0800, Sneeker Yeh wrote: > This patch adds support for Synopsis DesignWare USB3 IP Core found > on Fujitsu Socs. > > Signed-off-by: Sneeker Yeh > --- > .../devicetree/bindings/usb/fujitsu-dwc3.txt | 33 > drivers/usb/dwc3/Kconfig

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-02-10 Thread Felipe Balbi
Hi, On Tue, Feb 10, 2015 at 11:12:40PM +, Paul Walmsley wrote: > > > > > > > > hm... modulemode SWCTRL causes wait_target_ready to fail. Any > > > > > > > > hints ? > > > > > > > > > > > > > > gets stuck in transition state. PRCM_CM_WKUP_DBGSS_CLKCTRL is > > > > > > > always > > > > > > > r

Re: [PATCH v3 4/5] usb: phy: load usb phy earlier

2015-02-10 Thread Felipe Balbi
On Tue, Feb 10, 2015 at 03:04:28PM +0800, Peter Chen wrote: > This patch does not belong to phy, so, doesn't need to > add phy in subject, meanwhile, please add GregKH as TO list, > he is the right one to queue this patch. > > Reply-To: > In-Reply-To: <1423554627-694-5-git-send-email-zhangfei

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-10 Thread Felipe Balbi
On Tue, Feb 10, 2015 at 05:10:04PM +0800, Zhangfei Gao wrote: > Add usb phy controller for hi6220 platform > > Signed-off-by: Zhangfei Gao > --- > drivers/usb/phy/Kconfig | 9 ++ > drivers/usb/phy/Makefile | 1 + > drivers/usb/phy/phy-hi6220-usb.c | 306 > ++

[RFC/PATCH 1/2] of: move of_property_read_bool further down

2015-02-05 Thread Felipe Balbi
A follow-up patch will make use of of_property_read_u32() to allow for boolean properties to have a value, this is just in preparation for that patch in order to make review easier. Signed-off-by: Felipe Balbi --- include/linux/of.h | 32 1 file changed, 16

[RFC/PATCH 2/2] of: allow for boolean flags to have value

2015-02-05 Thread Felipe Balbi
that the description here is but one example and it's likely many others have faced something similar. Signed-off-by: Felipe Balbi --- include/linux/of.h | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/include/linux/of.h b/include/linux/of.h inde

Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-30 Thread Felipe Balbi
Hi, On Thu, Jan 29, 2015 at 10:23:12AM -0600, Felipe Balbi wrote: > On Tue, Jan 27, 2015 at 09:22:50AM -0600, Felipe Balbi wrote: > > Hi, > > > > On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote: > > > These patches add support for XHCI compliant Host con

Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-29 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 09:22:50AM -0600, Felipe Balbi wrote: > Hi, > > On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote: > > These patches add support for XHCI compliant Host controller found > > on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ &

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 11:13:08AM -0800, Sören Brinkmann wrote: > On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote: > > On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: > > > A reset through a GPIO is optional. Don't fail probing w

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 11:15:32AM -0600, Felipe Balbi wrote: > On Tue, Jan 27, 2015 at 05:12:05PM +, Paul Walmsley wrote: > > Hi > > > > On Tue, 27 Jan 2015, Felipe Balbi wrote: > > > > > On Mon, Jan 26, 2015 at 01:49:33PM -0600, Felipe Balbi wrote: &

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 05:12:05PM +, Paul Walmsley wrote: > Hi > > On Tue, 27 Jan 2015, Felipe Balbi wrote: > > > On Mon, Jan 26, 2015 at 01:49:33PM -0600, Felipe Balbi wrote: > > > On Mon, Jan 26, 2015 at 10:56:40AM -0600, Felipe Balbi wrote: > > > &g

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-27 Thread Felipe Balbi
On Mon, Jan 26, 2015 at 01:49:33PM -0600, Felipe Balbi wrote: > Hi, > > On Mon, Jan 26, 2015 at 10:56:40AM -0600, Felipe Balbi wrote: > > > the references below are from SPRUHL7 > > > > > > On Fri, 23 Jan 2015, Felipe Balbi wrote: > > > > &

Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-27 Thread Felipe Balbi
Hi, On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote: > These patches add support for XHCI compliant Host controller found > on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ > The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 > driver > and last

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Felipe Balbi
On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: > A reset through a GPIO is optional. Don't fail probing when it is > missing. > > Reported-by: Andreas Färber > Signed-off-by: Soren Brinkmann > --- > Hi Andreas, > > does this do the trick? > > Thanks, > Sören > >

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-26 Thread Felipe Balbi
Hi, On Mon, Jan 26, 2015 at 10:56:40AM -0600, Felipe Balbi wrote: > > the references below are from SPRUHL7 > > > > On Fri, 23 Jan 2015, Felipe Balbi wrote: > > > > > Without hwmod data for DebugSS, performance monitors > > > have no chance of running

Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-26 Thread Felipe Balbi
Hi, On Mon, Jan 26, 2015 at 02:04:35AM +, Paul Walmsley wrote: > Hi > > the references below are from SPRUHL7 > > On Fri, 23 Jan 2015, Felipe Balbi wrote: > > > Without hwmod data for DebugSS, performance monitors > > have no chance of running on AM43xx d

Re: [PATCH 3/4] clk: ti: 43xx: add debugss clocks to DT_CLK() table

2015-01-23 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 05:11:43PM -0600, Felipe Balbi wrote: > without these entries, omap_hwmod will not be > able to find debugss clocks. > > Signed-off-by: Felipe Balbi > --- > drivers/clk/ti/clk-43xx.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff

[PATCH 2/4] arm: dts: am4372: add missing debugss clocks

2015-01-23 Thread Felipe Balbi
These clocks are needed so that OMAP HWMOD can control them when we're using performance monitors. Signed-off-by: Felipe Balbi --- arch/arm/boot/dts/am43xx-clocks.dtsi | 51 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/am43xx-clocks

[PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data

2015-01-23 Thread Felipe Balbi
Without hwmod data for DebugSS, performance monitors have no chance of running on AM43xx devices. Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 40 ++ arch/arm/mach-omap2/prcm43xx.h | 1 + 2 files changed, 41 insertions

[PATCH 0/4] arm: am43xx: add PMU support

2015-01-23 Thread Felipe Balbi
Hi all, with these patches we can use perf with AM43xx devices and get actual statistics. Full boot logs: http://hastebin.com/yoxaxurohu Felipe Balbi (4): arm: omap: hwmod: 43xx: add DebugSS hwmod data arm: dts: am4372: add missing debugss clocks clk: ti: 43xx: add debugss clocks to

  1   2   3   4   5   6   7   >