Re: [PATCH v2 2/3] soc: brcmstb: Add Bus Interface Unit control setup

2015-09-18 Thread Gregory Fong
On Thu, Sep 17, 2015 at 10:42 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 16/09/15 23:08, Gregory Fong wrote: >>> [...] >>> diff --git a/drivers/soc/brcmstb/biuctrl.c b/drivers/soc/brcmstb/biuctrl.c >>> new file mode 100644 >>> index

Re: [PATCH v2 1/3] Documentation: bindings: brcmstb: Document write-pairing

2015-09-17 Thread Gregory Fong
On Tue, Sep 15, 2015 at 11:14 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > Document the hif-cpubiuctrl node a bit more, and add a documentation > entry for the optional "brcm,write-pairing" property. > > Signed-off-by: Florian Fainelli <f.faine...@gma

Re: [PATCH v2 3/3] ARM: brcmstb: Setup BIU control registers during boot

2015-09-17 Thread Gregory Fong
ers. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Gregory Fong <gregory.0...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/3] soc: brcmstb: Add Bus Interface Unit control setup

2015-09-17 Thread Gregory Fong
hifcpubiuctrl_regs(); > + if (ret) > + return ret; > + > + ret = mcp_write_pairing_set(); > + if (ret) { > + pr_err("MCP: Unable to disable write pairing!\n"); > + return ret; The return value isn't used in p

[PATCH v2 1/2] watchdog: bcm7038: add device tree binding documentation

2015-08-27 Thread Gregory Fong
Add device tree binding documentation for the watchdog hardware block on bcm7038 and newer SoCs. Signed-off-by: Justin Chen justinpo...@gmail.com --- .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644

[PATCH v2 0/2] watchdog: driver for BCM7038 and newer chips.

2015-08-27 Thread Gregory Fong
This driver is for a watchdog block contained in all Broadcom Set-top Box chips since BCM7038. BCM7038 was made public during the 2004 CES, and since then, many chips use this watchdog block including some cable modem chips. Changes since v1: Removed clock-frequency because it brought unnecessary

[PATCH v2 2/2] watchdog: Watchdog driver for Broadcom Set-Top Box

2015-08-27 Thread Gregory Fong
Watchdog driver for Broadcom 7038 and newer chips. Signed-off-by: Justin Chen justinpo...@gmail.com --- drivers/watchdog/Kconfig | 8 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/bcm7038_wdt.c | 235 + 3 files changed, 244

Re: [PATCH v2 2/2] watchdog: Watchdog driver for Broadcom Set-Top Box

2015-08-27 Thread Gregory Fong
Gah, sorry, my email client did something really weird. Sorry for the duplication, please don't reply to those. -- Gregory-- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4 2/4] gpio: brcmstb: Add interrupt and wakeup source support

2015-08-13 Thread Gregory Fong
On Thu, Aug 13, 2015 at 4:11 AM, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Aug 1, 2015 at 3:17 AM, Gregory Fong gregory.0...@gmail.com wrote: Uses the gpiolib irqchip helpers. For this to work, the irq setup function is called once per bank instead of once per device. Note

[PATCH v4 0/4] GPIO support for BRCMSTB

2015-07-31 Thread Gregory Fong
(merged from v2 to GPIO tree) - ARM Kconfig changes (merged from v2 to arm-soc tree) - fix for null ptr deref in driver remove (merged from v3) Previous versions: v1: https://lkml.org/lkml/2015/5/6/199 v2: https://lkml.org/lkml/2015/5/28/853 v3: https://lkml.org/lkml/2015/6/17/960 Gregory Fong (4

[PATCH v4 2/4] gpio: brcmstb: Add interrupt and wakeup source support

2015-07-31 Thread Gregory Fong
: - of_gpiochip_find_and_xlate() - of_get_named_gpiod_flags() drivers/gpio/gpiolib.c: - gpiochip_find() Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v4: - when checking parent_irq, use = 0 or 0 since 0 is NO_IRQ. drivers/gpio/Kconfig| 1 + drivers/gpio/gpio-brcmstb.c | 262

[PATCH v4 4/4] ARM: dts: brcmstb: add BCM7445 GPIO nodes

2015-07-31 Thread Gregory Fong
Need the aon_pm_l2_intc and irq0_aon_intc descriptions, so included those as well. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v4. arch/arm/boot/dts/bcm7445.dtsi | 50 ++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v4 3/4] gpio: brcmstb: support wakeup from S5 cold boot

2015-07-31 Thread Gregory Fong
/brcmstb-gpio/f04172c0.gpio/power/wakeup enabled # cat /sys/bus/platform/drivers/brcmstb-gpio/f04172c0.gpio/power/wakeup_count 1 Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v4: rename __brcmstb_gpio_irq_set_wake() to brcmstb_gpio_priv_set_wake(). drivers/gpio/gpio-brcmstb.c | 56

[PATCH v4 1/4] dt-bindings: brcmstb-gpio: document properties for wakeup

2015-07-31 Thread Gregory Fong
, #interrupt-cells, and brcm,gpio-bank-widths from hex to dec - use phandles Reviewed-by: Brian Norris computersforpe...@gmail.com Acked-by: Florian Fainelli f.faine...@gmail.com Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v4: no changes from v3 .../devicetree/bindings/gpio/brcm,brcmstb

Re: [PATCH v3 3/4] gpio: brcmstb: Add interrupt and wakeup source support

2015-07-13 Thread Gregory Fong
On Mon, Jul 13, 2015 at 5:58 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong gregory.0...@gmail.com wrote: Uses the gpiolib irqchip helpers. For this to work, the irq setup function is called once per bank instead of once per device. Note

Re: [PATCH v3 4/4] gpio: brcmstb: support wakeup from S5 cold boot

2015-07-13 Thread Gregory Fong
On Mon, Jul 13, 2015 at 6:03 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong gregory.0...@gmail.com wrote: For wake from S5, we need to: - register a reboot handler - set wakeup capability before requesting IRQ so wakeup count is incremented

Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend

2015-06-18 Thread Gregory Fong
Norris computersforpe...@gmail.com Acked-by: Gregory Fong gregory.0...@gmail.com -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] soc: brcmstb: add system suspend support for STB SoCs

2015-06-18 Thread Gregory Fong
On Thu, Jun 18, 2015 at 5:11 PM, Brian Norris computersforpe...@gmail.com wrote: Hi, This patch set introduces system suspend/resume support for Broadcom STB SoCs. There are two suspend modes (S2 and S3) as well as a related low-power shutdown mode (S5). Along with the core PM support,

Re: [PATCH 2/7] Documentation: dt: brcmstb: add waketimer documentation

2015-06-18 Thread Gregory Fong
On Thu, Jun 18, 2015 at 5:11 PM, Brian Norris computersforpe...@gmail.com wrote: Signed-off-by: Brian Norris computersforpe...@gmail.com Acked-by: Gregory Fong gregory.0...@gmail.com -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [PATCH 5/7] soc: brcmstb: add wake-timer driver

2015-06-18 Thread Gregory Fong
this cast. [snip] Acked-by: Gregory Fong gregory.0...@gmail.com -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 0/4] GPIO support for BRCMSTB

2015-06-17 Thread Gregory Fong
v1 to GPIO tree) - Initial GPIO support w/o interrupts (merged from v2 to GPIO tree) - ARM Kconfig changes (merged from v2 to arm-soc tree) Previous revisions: v1: https://lkml.org/lkml/2015/5/6/199 v2: https://lkml.org/lkml/2015/5/28/853 Gregory Fong (4): gpio: brcmstb: fix null ptr dereference

[PATCH v3 1/4] gpio: brcmstb: fix null ptr dereference in driver remove

2015-06-17 Thread Gregory Fong
list head right after allocating the priv struct to both avoid the null pointer dereference that could occur today. To guard against potential future changes, check for null pointer in remove. Reported-by: Tim Ross tr...@broadcom.com Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v3

[PATCH v3 2/4] dt-bindings: brcmstb-gpio: document properties for wakeup

2015-06-17 Thread Gregory Fong
, #interrupt-cells, and brcm,gpio-bank-widths from hex to dec - use phandles Reviewed-by: Brian Norris computersforpe...@gmail.com Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v3: Update per Brian's suggestions described in above message. .../devicetree/bindings/gpio/brcm,brcmstb-gpio.txt | 35

[PATCH v3 3/4] gpio: brcmstb: Add interrupt and wakeup source support

2015-06-17 Thread Gregory Fong
: - of_gpiochip_find_and_xlate() - of_get_named_gpiod_flags() drivers/gpio/gpiolib.c: - gpiochip_find() Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v3: - combine commits to add interrupt support and allow GPIOs to be wakeup sources - change to use the gpiolib irqchip helpers, reducing unnecessary code

[PATCH v3 4/4] gpio: brcmstb: support wakeup from S5 cold boot

2015-06-17 Thread Gregory Fong
/brcmstb-gpio/f04172c0.gpio/power/wakeup enabled # cat /sys/bus/platform/drivers/brcmstb-gpio/f04172c0.gpio/power/wakeup_count 1 Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v3. drivers/gpio/gpio-brcmstb.c | 56 - 1 file changed, 50

Re: [PATCH 0/3] GPIO support for BRCMSTB

2015-06-02 Thread Gregory Fong
On Tue, Jun 2, 2015 at 2:05 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, May 27, 2015 at 5:26 AM, Gregory Fong gregory.0...@gmail.com wrote: I've now actually attempted to use the gpiolib irqchip code. This driver can't directly use gpiochip_irqchip_add() because of the multiple

Re: [PATCH v2 4/6] gpio: brcmstb: Allow GPIOs to be wakeup sources

2015-06-02 Thread Gregory Fong
On Fri, May 29, 2015 at 5:43 PM, Brian Norris computersforpe...@gmail.com wrote: On Thu, May 28, 2015 at 07:14:08PM -0700, Gregory Fong wrote: Several drivers (e.g. gpio-keys) allow for GPIOs to be configured as wakeup sources, and this GPIO controller supports that through a separate

Re: [PATCH v2 4/6] gpio: brcmstb: Allow GPIOs to be wakeup sources

2015-06-02 Thread Gregory Fong
On Tue, Jun 2, 2015 at 6:45 AM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, May 29, 2015 at 4:14 AM, Gregory Fong gregory.0...@gmail.com wrote: Several drivers (e.g. gpio-keys) allow for GPIOs to be configured as wakeup sources, and this GPIO controller supports that through

Re: [PATCH v2 3/6] dt-bindings: brcmstb-gpio: document properties for wakeup

2015-05-29 Thread Gregory Fong
On Fri, May 29, 2015 at 5:36 PM, Brian Norris computersforpe...@gmail.com wrote: On Thu, May 28, 2015 at 07:14:07PM -0700, Gregory Fong wrote: Some brcmstb GPIO controllers can be used to wake from suspend, so use the de facto standard property 'wakeup-source' to mark the nodes of controllers

Re: [PATCH v2 3/6] dt-bindings: brcmstb-gpio: document properties for wakeup

2015-05-29 Thread Gregory Fong
On Fri, May 29, 2015 at 6:37 PM, Brian Norris computersforpe...@gmail.com wrote: On Fri, May 29, 2015 at 05:57:50PM -0700, Gregory Fong wrote: On Fri, May 29, 2015 at 5:36 PM, Brian Norris computersforpe...@gmail.com wrote: On Thu, May 28, 2015 at 07:14:07PM -0700, Gregory Fong wrote

Re: [PATCH v2 2/6] gpio: brcmstb: Add interrupt support

2015-05-29 Thread Gregory Fong
On Fri, May 29, 2015 at 5:10 PM, Brian Norris computersforpe...@gmail.com wrote: A few small comments: On Thu, May 28, 2015 at 07:14:06PM -0700, Gregory Fong wrote: v2: - since imask member of bank struct was removed, just read and write from mask reg and don't maintain a shadow

[PATCH v2 1/6] gpio: Add GPIO support for Broadcom STB SoCs

2015-05-28 Thread Gregory Fong
expanders used with it must dynamically assign GPIO numbers after this driver has finished registering its GPIOs. Does not implement the interrupt-controller portion yet, will be done in a future commit. List-usage-fixed-by: Brian Norris computersforpe...@gmail.com Signed-off-by: Gregory Fong

[PATCH v2 2/6] gpio: brcmstb: Add interrupt support

2015-05-28 Thread Gregory Fong
. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v2: - since imask member of bank struct was removed, just read and write from mask reg and don't maintain a shadow - warn on invalid IRQs - move some irq setup to a separate function since probe is getting unwieldy drivers/gpio/Kconfig

[PATCH v2 4/6] gpio: brcmstb: Allow GPIOs to be wakeup sources

2015-05-28 Thread Gregory Fong
the IRQCHIP_MASK_ON_SUSPEND irq_chip flag because UPG GIO doesn't have any of its own wakeup source configuration. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v2. drivers/gpio/gpio-brcmstb.c | 53 + 1 file changed, 53 insertions(+) diff

[PATCH v2 6/6] ARM: brcmstb: Add default gpio number

2015-05-28 Thread Gregory Fong
to be higher in the future, so set it to 1024. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v2. arch/arm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e717642..bbe6bf7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm

[PATCH v2 3/6] dt-bindings: brcmstb-gpio: document properties for wakeup

2015-05-28 Thread Gregory Fong
is different from the regular IRQ. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- New in v2. .../devicetree/bindings/gpio/brcm,brcmstb-gpio.txt | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb

[PATCH v2 5/6] ARM: brcmstb: Select ARCH_WANT_OPTIONAL_GPIOLIB

2015-05-28 Thread Gregory Fong
Select ARCH_WANT_OPTIONAL_GPIOLIB from BRCMSTB to allow GPIOLIB and GPIO_BRCMSTB to be enabled. Signed-off-by: Gregory Fong gregory.0...@gmail.com --- v2: this was split out so that it can go through the ARM SoC tree. arch/arm/mach-bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 0/6] GPIO support for BRCMSTB

2015-05-28 Thread Gregory Fong
number for BRCMSTB The device tree bindings from v1 were merged to the GPIO tree, so this patchset only contains an addition to allow GPIOs to be used as a wakeup source (patch 3). The initial bindings from v1 can be found at https://lkml.org/lkml/2015/5/6/200 . Gregory Fong (6): gpio: Add GPIO

Re: [PATCH 0/3] GPIO support for BRCMSTB

2015-05-26 Thread Gregory Fong
Hi Linus, On Wed, May 13, 2015 at 1:59 AM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, May 12, 2015 at 9:38 PM, Gregory Fong gregory.0...@gmail.com wrote: On Tue, May 12, 2015 at 3:59 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, May 6, 2015 at 10:37 AM, Gregory Fong

Re: [PATCH 2/3] gpio: Add GPIO support for Broadcom STB SoCs

2015-05-07 Thread Gregory Fong
On Thu, May 07, 2015 at 10:18:49AM +0200, Paul Bolle wrote: Just a nit: a license mismatch. On Wed, 2015-05-06 at 01:37 -0700, Gregory Fong wrote: --- /dev/null +++ b/drivers/gpio/gpio-brcmstb.c + * This program is free software; you can redistribute it and/or + * modify it under

Re: [PATCH 1/2] ARM: dts: brcmstb: un-hexify clock frequency

2015-03-18 Thread Gregory Fong
On Wed, Mar 18, 2015 at 5:31 PM, Brian Norris computersforpe...@gmail.com wrote: This value makes much more sense in decimal. Signed-off-by: Brian Norris computersforpe...@gmail.com Acked-by: Gregory Fong gregory.0...@gmail.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v7 5/9] ARM: Enable erratum 798181 for Broadcom Brahma-B15

2014-02-26 Thread Gregory Fong
Hi Will, On Wed, Feb 26, 2014 at 2:47 AM, Will Deacon will.dea...@arm.com wrote: On Wed, Feb 26, 2014 at 10:29:08AM +, Marc Carino wrote: From: Gregory Fong gregory.0...@gmail.com Broadcom Brahma-B15 (r0p0..r0p2) is also affected by Cortex-A15 erratum 798181, so enable the workaround