Hi Josh,
Thanks for a patch update. I think it looks good as a first step in your
patch series, just a minor comment below:
On Tue, 10 Feb 2015, Josh Wu wrote:
> In async probe, there is a case that ov2640 is probed before the
> host device which provided 'mclk'.
> To support this async probe,
It is common among dmaengine drivers to use a tasklet for bottom half
interrupt processing. Convert nbpfaxi to do the same.
Signed-off-by: Guennadi Liakhovetski
---
drivers/dma/nbpfaxi.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/dma
lists before freeing descriptor cache.
Signed-off-by: Guennadi Liakhovetski
---
drivers/dma/nbpfaxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c
index 77c5a89..5b40ac8 100644
--- a/drivers/dma/nbpfaxi.c
+++ b/drivers/dma/nbpfaxi.c
@@ -1054,6
Hi Vinod,
On Fri, 1 Aug 2014, Vinod Koul wrote:
> On Thu, Jul 31, 2014 at 03:42:44PM +0200, Guennadi Liakhovetski wrote:
> > Ok. This doesn't seem to progress. You suggested in your previous mail,
> > that I can provide an incremental patch to add devm_free(_thre
On Thu, 31 Jul 2014, Vinod Koul wrote:
> On Sat, Jul 26, 2014 at 09:32:18PM +0200, Guennadi Liakhovetski wrote:
> > On Fri, 25 Jul 2014, Vinod Koul wrote:
> > > And please also see there were regression on few of them, recently dw was
> > > fixed for this case. Simil
Hi Vinod,
On Mon, 28 Jul 2014, Guennadi Liakhovetski wrote:
> > Looking at the code again, I think we need to free irq (you can call
> > devm_free_irq()) and call syncronize_irq so that anything pending is
> > flushed. So if you can send follow up patch doing these in .remove
Hi Vinod,
On Mon, 28 Jul 2014, Vinod Koul wrote:
> On Sat, Jul 26, 2014 at 09:32:18PM +0200, Guennadi Liakhovetski wrote:
> > On Fri, 25 Jul 2014, Vinod Koul wrote:
> >
> > > On Fri, Jul 25, 2014 at 05:00:53PM +0200, Guennadi Liakhovetski wrote:
> > > > Hi Vi
Hi Josh,
Thanks for a prompt update! A couple of minor questions:
On Fri, 25 Jul 2014, Josh Wu wrote:
> This patch add the DT support for Atmel ISI driver.
> It use the same v4l2 DT interface that defined in video-interfaces.txt.
>
> Signed-off-by: Josh Wu
> Cc: devicetree@vger.kernel.org
> Re
On Fri, 25 Jul 2014, Vinod Koul wrote:
> On Fri, Jul 25, 2014 at 05:00:53PM +0200, Guennadi Liakhovetski wrote:
> > Hi Vinod,
> >
> > On Fri, 25 Jul 2014, Vinod Koul wrote:
> >
> > Thanks for your review. However, I find the following a bit odd. As you
> &g
o the author. Now, to specific comments.
> On Sat, Jul 19, 2014 at 12:48:51PM +0200, Guennadi Liakhovetski wrote:
> > This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
> > the AMBA AXI bus.
> >
>
> > +struct nbpf_desc {
> > + struct
(re-adding Cc)
On Wed, 23 Jul 2014, Robert Jarzmik wrote:
> Guennadi Liakhovetski writes:
>
> > Add device-tree support to pxa_camera host driver.
> >
> > Signed-off-by: Robert Jarzmik
> > [g.liakhovet...@gmx.de: added of_node_put()]
> >
Add device-tree support to pxa_camera host driver.
Signed-off-by: Robert Jarzmik
[g.liakhovet...@gmx.de: added of_node_put()]
Signed-off-by: Guennadi Liakhovetski
---
Robert, could you review and test this version, please?
Thanks
Guennadi
drivers/media/platform/soc_camera/pxa_camera.c | 81
Hi Robert,
Thanks for an updated patch. One question:
On Sun, 29 Jun 2014, Robert Jarzmik wrote:
> Add device-tree support to pxa_camera host driver.
>
> Signed-off-by: Robert Jarzmik
>
> ---
> Since V1: Mark's review
> - tmp u32 to long conversion for clock rate
> - use d
The nbpfaxi dmaengine driver doesn't define any new bindings, it only
uses standard dmaengine bindings and defines 3 flags for the 3rd parameter
of the "dmas" property.
Signed-off-by: Guennadi Liakhovetski
Acked-by: Arnd Bergmann
---
v4: no change, added Arnd's ack - tha
This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
the AMBA AXI bus.
Signed-off-by: Guennadi Liakhovetski
---
v4:
1. comment from Arnd: use dma_get_any_slave_channel() instead of
dma_request_channel()
2. fixed 64-bit compile printk format warnings
drivers/dma/Kconfig
Hi Arnd,
Thanks for the review!
On Mon, 14 Jul 2014, Arnd Bergmann wrote:
> On Sunday 13 July 2014 22:00:11 Guennadi Liakhovetski wrote:
> > Hi all,
> >
> > On 10th of May I submitted 2 patches
> >
> > http://thread.gmane.org/gmane.linux.drivers.devicetr
Hi all,
On 10th of May I submitted 2 patches
http://thread.gmane.org/gmane.linux.drivers.devicetree/73577
of which 1 adds documentation for DT bindings for a dmaengine driver. The
driver doesn't add any new bindings, only standard bindings are used and
the respective generic document is refere
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
> Add device-tree support to pxa_camera host driver.
>
> Signed-off-by: Robert Jarzmik
> ---
> drivers/media/platform/soc_camera/pxa_camera.c | 80
> ++
> 1 file changed, 80 insertions(+)
>
> diff --git a/drivers/media/platfor
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
> Add documentation for pxa_camera host interface.
As mentioned in another comment: this is driver DT bindings description,
not interface documentation.
Thanks
Guennadi
>
> Signed-off-by: Robert Jarzmik
> ---
> .../devicetree/bindings/media/pxa-cam
Hi Robert,
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
> Add documentation for the Micron mt9m111 image sensor.
A nitpick: this isn't documentation for the sensor:) This is driver DT
bindings' documentation.
Thanks
Guennadi
>
> Signed-off-by: Robert Jarzmik
> ---
> .../devicetree/bindings/m
Hi Robert,
Thanks for the patch.
On Sun, 15 Jun 2014, Robert Jarzmik wrote:
> Add device-tree support for mt9m111 camera sensor.
>
> Signed-off-by: Robert Jarzmik
> ---
> drivers/media/i2c/soc_camera/mt9m111.c | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/dr
On Wed, 11 Jun 2014, Chris Ball wrote:
> Hi Guennadi,
>
> On Sat, May 31 2014, Guennadi Liakhovetski wrote:
> > This patch adds a driver for the Renesas usdhi6rol0 SD/SDIO host controller
> > in both PIO and DMA modes.
> >
> > Signed-off-by: Guennadi Liakhovet
This patch adds a driver for the Renesas usdhi6rol0 SD/SDIO host controller
in both PIO and DMA modes.
Signed-off-by: Guennadi Liakhovetski
---
v4: replaced several numerical values with macros
.../devicetree/bindings/mmc/usdhi6rol0.txt | 33 +
drivers/mmc/host/Kconfig
, Guennadi Liakhovetski wrote:
> The nbpfaxi dmaengine driver doesn't define any new bindings, it only
> uses standard dmaengine bindings and defines 3 flags for the 3rd parameter
> of the "dmas" property.
>
> Signed-off-by: Guennadi Liakhovetski
> ---
>
> v3:
Hi Chris,
What's the status of this patch? Would be great to get it in for 3.16.
Thanks
Guennadi
On Sat, 26 Apr 2014, Guennadi Liakhovetski wrote:
> This patch adds a driver for the Renesas usdhi6rol0 SD/SDIO host controller
> in both PIO and DMA modes.
>
> Signed
2014 at 11:15:28AM +0200, Guennadi Liakhovetski wrote:
> > Hi Vinod,
> >
> > Thanks for a review.
> >
> > On Wed, 7 May 2014, Vinod Koul wrote:
> >
> > > On Sat, Apr 26, 2014 at 02:03:44PM +0200, Guennadi Liakhovetski wrote:
> > > >
soc_camera_host_register() and your isi_camera_try_bus_param() can also be
called immediately from it if all required I2C devices are already
available? If your I2C subdevice drivers defer probing until the host has
probed, then you could initialise .width_flags after
soc_camera_host_register(),
This patch adds a driver for the Renesas usdhi6rol0 SD/SDIO host controller
in both PIO and DMA modes.
Signed-off-by: Guennadi Liakhovetski
---
v3:
1. remove a redundant TODO
2. update the timeout to 4 seconds
.../devicetree/bindings/mmc/usdhi6rol0.txt | 33 +
drivers/mmc/host
This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
the AMBA AXI bus.
Signed-off-by: Guennadi Liakhovetski
---
v3: addressed iddues, pointed out by Vinod, thanks
1. remove superfluous cookie caching
2. add residue calculation for queued transfers
3. store noth source and
The nbpfaxi dmaengine driver doesn't define any new bindings, it only
uses standard dmaengine bindings and defines 3 flags for the 3rd parameter
of the "dmas" property.
Signed-off-by: Guennadi Liakhovetski
---
v3: split out from v2, no changes otherwise
Documentation/devicetr
On Sat, 10 May 2014, Guennadi Liakhovetski wrote:
[snip]
> > > + nbpf = devm_kzalloc(dev, sizeof(*nbpf) + num_channels *
> > > + sizeof(nbpf->chan[0]), GFP_KERNEL);
> > I think we have devm_kcalloc for these things?
>
> Ah, ok, missed this, t
Hi Vinod,
Thanks for a review.
On Wed, 7 May 2014, Vinod Koul wrote:
> On Sat, Apr 26, 2014 at 02:03:44PM +0200, Guennadi Liakhovetski wrote:
> > This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
> > the AMBA AXI bus.
> >
>
> > diff --
wait = USDHI6_WAIT_FOR_REQUEST;
> > + host->timeout = msecs_to_jiffies(1000);
> In all places you use host->timeout, the code uses host->timeout * 4.
> Wouldn't it better to just set it here to 4 seconds?
ok, I'll do that for v3.
Thanks
Guenn
This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
the AMBA AXI bus.
Signed-off-by: Guennadi Liakhovetski
---
v2:
1. corrected copyright and a Renesas email for proper attribution
2. use %pad for dma_addr_t
3. use devm_request_irq() instead of the threaded version
4
This patch adds a driver for the Renesas usdhi6rol0 SD/SDIO host controller
in both PIO and DMA modes.
Signed-off-by: Guennadi Liakhovetski
---
v2: copyright and Sob email changed
.../devicetree/bindings/mmc/usdhi6rol0.txt | 33 +
drivers/mmc/host/Kconfig
This patch adds a driver for the Renesas v08r07s01e SD/SDIO host controller
in both PIO and DMA modes.
Signed-off-by: Guennadi Liakhovetski
---
Tested on a Xilinx zc706-based board with SD, MMC and SDIO cards.
.../devicetree/bindings/mmc/v08r07s01e.txt | 33 +
drivers/mmc/host
This patch adds a driver for NBPF DMAC IP cores from Renesas, designed for
the AMBA AXI bus.
Signed-off-by: Guennadi Liakhovetski
---
Tested on a Xilinx zc706-based board with an SD-host (driver will be
submitted shortly) and a PL011 UART.
Documentation/devicetree/bindings/dma/nbpfaxi.txt
isi_platform_data));
> + if (pdata)
> + memcpy(&isi->pdata, pdata, sizeof(struct isi_platform_data));
> + else/* dt probe */
> + atmel_isi_probe_dt(isi, pdev);
> +
> isi->active = NULL;
> spin_lock_init(&isi->lock);
>
deo - no, because v4l2 and drm drivers want to use it
> > >>
> > >> Just pointing out a missing location (which might be rejected due to
> > >> similar
> > >> concerns), there's also drivers/media, which isn't V4L-specific.
> > >
&g
39 matches
Mail list logo
