On 12/16/15 14:17, tiffany lin wrote:
> Hi Hans,
>
>
> On Tue, 2015-12-15 at 15:17 +0100, Hans Verkuil wrote:
>>
>> On 12/15/15 14:51, tiffany lin wrote:
>>> We are not familiar with v4l2-compliance utility, we will check how to
>>> use
On 12/15/15 14:51, tiffany lin wrote:
> Hi Hans,
>
> Thanks for your time.
>
> On Mon, 2015-12-14 at 13:50 +0100, Hans Verkuil wrote:
>> Hi Tiffany,
>>
>> My apologies for the long delay, but I finally have time to do a review of
>> this
>> co
On 12/11/2015 11:16 PM, Benoit Parrot wrote:
> Mauro Carvalho Chehab wrote on Thu [2015-Dec-03
> 11:19:22 -0200]:
>>> +static int cal_enum_framesizes(struct file *file, void *fh,
>>> + struct v4l2_frmsizeenum *fsize)
>>> +{
>>> + struct cal_ctx *ctx = video_drvdata(file
Hi Tiffany,
My apologies for the long delay, but I finally have time to do a review of this
code.
On 12/11/2015 10:55 AM, Tiffany Lin wrote:
> From: Andrew-CT Chen
>
> Add v4l2 layer encoder driver for MT8173
>
> Signed-off-by: Tiffany Lin
> ---
> drivers/media/platform/Kconfig
On 11/17/2015 01:54 PM, Tiffany Lin wrote:
> ==
> Introduction
> ==
>
> The purpose of this RFC is to discuss the driver for a hw video codec
> embedded in the Mediatek's MT8173 SoCs. Mediatek Video Codec is able to
> handle video encoding of in a range of formats.
>
> Th
Hi Mikhail,
Just one small thing, see below...
On 07/21/2015 04:00 AM, Mikhail Ulyanov wrote:
> This series of patches contains a driver for the JPEG codec integrated
> peripheral found in the Renesas R-Car SoCs and associated DT documentation.
>
> This series of patches is against the 'master'
On 07/14/2015 12:10 PM, Philipp Zabel wrote:
> Am Montag, den 13.07.2015, 13:07 +0200 schrieb Hans Verkuil:
>> On 07/10/2015 03:11 PM, Philipp Zabel wrote:
>>> This is useful to subscribe to HDMI hotplug events via the
>>> V4L2_CID_DV_RX_POWER_PRESENT control.
>>&
On 07/14/15 12:10, Philipp Zabel wrote:
> Hi Hans,
>
> Am Montag, den 13.07.2015, 12:57 +0200 schrieb Hans Verkuil:
> [...]
>>> @@ -69,6 +72,7 @@ static const struct v4l2_dv_timings_cap
>>> tc358743_timings_cap = {
>>>
>>> struct tc358743_sta
On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> This is useful to subscribe to HDMI hotplug events via the
> V4L2_CID_DV_RX_POWER_PRESENT control.
>
> Signed-off-by: Philipp Zabel
> ---
> drivers/media/i2c/tc358743.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/i2c/t
On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> Signed-off-by: Philipp Zabel
> ---
> drivers/media/i2c/tc358743.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index 48d1575..0be6d9f 100644
> --- a/drivers/me
On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> Add support for probing the TC358743 subdevice from device tree.
> The reference clock must be supplied using the common clock bindings.
> MIPI CSI-2 specific properties are parsed from the OF graph endpoint
> node and support for a non-continuous MIPI
On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> Add support for registering the sensor subdevice using the v4l2-async API.
>
> Signed-off-by: Philipp Zabel
> ---
> drivers/media/i2c/tc358743.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/media/i2c/tc358743.c b/d
Hi Benoit,
Thanks for the patch! I do have a few comments, though. See below.
On 06/16/2015 07:29 PM, Benoit Parrot wrote:
> The Camera Adaptation Layer (CAL) is a block which consists of a dual
> port CSI2/MIPI camera capture engine.
> Port #0 can handle CSI2 camera connected to up to 4 data lan
On 06/16/2015 07:29 PM, Benoit Parrot wrote:
> The Camera Adaptation Layer (CAL) is a block which consists of a dual
> port CSI2/MIPI camera capture engine.
> This camera engine is currently found on DRA72xx family of devices.
>
> Port #0 can handle CSI2 camera connected to up to 4 data lanes.
> P
Hi Prabhakar,
I'm sorry, but I still have some comments for this driver...
On 03/20/2015 01:26 PM, Lad Prabhakar wrote:
> From: Benoit Parrot
>
> this patch adds support for omnivision's ov2659
> sensor, the driver supports following features:
> 1: Asynchronous probing
> 2: DT support
> 3: Medi
Hi Prabhakar,
On 03/15/2015 11:34 AM, Lad Prabhakar wrote:
> From: Benoit Parrot
>
> this patch adds support for omnivision's ov2659
> sensor, the driver supports following features:
> 1: Asynchronous probing
> 2: DT support
> 3: Media controller support
>
> Signed-off-by: Benoit Parrot
> Sign
On 03/09/2015 09:09 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the review.
>
> On Wednesday 04 March 2015 16:11:43 Hans Verkuil wrote:
>> Hi Laurent,
>>
>> Almost OK :-)
>
> Great :-)
>
>> Two small issues remain, see below.
Hi Laurent,
Almost OK :-)
Two small issues remain, see below.
On 03/04/15 15:51, Laurent Pinchart wrote:
> Xilinx platforms have no hardwired video capture or video processing
> interface. Users create capture and memory to memory processing
> pipelines in the FPGA fabric to suit their particula
On 03/03/15 23:15, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the review.
>
> On Tuesday 03 March 2015 12:28:24 Hans Verkuil wrote:
>> Hi Laurent,
>>
>> Thanks for this patch. I do have a few comments, see below. Note that I am
>> OK with the ne
Hi Laurent,
Thanks for this patch. I do have a few comments, see below. Note that I am
OK with the new DT format description.
On 03/02/2015 02:48 AM, Laurent Pinchart wrote:
> Xilinx platforms have no hardwired video capture or video processing
> interface. Users create capture and memory to memo
On 01/22/15 04:01, Laurent Pinchart wrote:
> Hi Hans and Chris,
>
> On Monday 01 December 2014 22:13:38 Laurent Pinchart wrote:
>> Xilinx platforms have no hardwired video capture or video processing
>> interface. Users create capture and memory to memory processing
>> pipelines in the FPGA fabric
On 12/09/2014 08:43 PM, Lad, Prabhakar wrote:
> From: Benoit Parrot
>
> This patch adds Video Processing Front End (VPFE) driver for
> AM437X family of devices
> Driver supports the following:
> - V4L2 API using MMAP buffer access based on videobuf2 api
> - Asynchronous sensor/decoder sub device
On 12/08/14 23:21, Lad, Prabhakar wrote:
> From: Benoit Parrot
>
> This patch adds Video Processing Front End (VPFE) driver for
> AM437X family of devices
> Driver supports the following:
> - V4L2 API using MMAP buffer access based on videobuf2 api
> - Asynchronous sensor/decoder sub device regis
On 12/06/2014 02:07 PM, Lad, Prabhakar wrote:
> From: Benoit Parrot
>
> This patch adds Video Processing Front End (VPFE) driver for
> AM437X family of devices
> Driver supports the following:
> - V4L2 API using MMAP buffer access based on videobuf2 api
> - Asynchronous sensor/decoder sub device
Hi Prabhakar,
Sorry, there are still a few items that need to be fixed.
If you can make a v4 with these issues addressed, then I can still make a
pull request, although it depends on Mauro whether it is still accepted for
3.19.
On 12/04/2014 12:12 AM, Lad, Prabhakar wrote:
> From: Benoit Parrot
On 12/03/14 01:29, Lad, Prabhakar wrote:
> From: Benoit Parrot
>
> This patch adds Video Processing Front End (VPFE) driver for
> AM437X family of devices
> Driver supports the following:
> - V4L2 API using MMAP buffer access based on videobuf2 api
> - Asynchronous sensor/decoder sub device regis
On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil wrote:
>> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>>> Hi all,
>>>
>>> Thanks for the patch, review comments are below.
>>>
>>>
On 12/01/2014 11:17 PM, Prabhakar Lad wrote:
> Hi Hans,
>
> Thanks for the review.
>
> On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
>> Hi all,
>>
>> Thanks for the patch, review comments are below.
>>
>> For the next version I would appreciat
On 12/01/2014 11:11 AM, Hans Verkuil wrote:
> Hi all,
>
> Thanks for the patch, review comments are below.
>
> For the next version I would appreciate if someone can test this driver with
> the latest v4l2-compliance from the v4l-utils git repo. If possible test
> stre
Hi all,
Thanks for the patch, review comments are below.
For the next version I would appreciate if someone can test this driver with
the latest v4l2-compliance from the v4l-utils git repo. If possible test
streaming
as well (v4l2-compliance -s), ideally with both a sensor and a STD receiver
in
Hi Mauro,
On 11/11/2014 12:07 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 21 Oct 2014 17:07:00 +0200
> Sebastian Reichel escreveu:
>
>> This switches back to the normal regulator API (but use
>> managed variant) in preparation for device tree support.
>
> This patch broke compilation. Please be
Hi Sebastian,
I've tested the whole 8-part patch series with my si4713 USB dev board, and it
is working fine.
I've accepted patches 1-4. The others need to be reposted since patch 5 had a
change request.
Regards,
Hans
On 11/07/2014 01:49 PM, Hans Verkuil wrote:
> On 1
m code (only DT boot has been tested).
>(The legacy platform code is supposed to removed in the near future
> anyways)
>
> Changes since RFCv1 (requested by Hans Verkuil):
> - splitted the patchset into more patches
> - replaced dev_info with dev_dbg for missing regulato
On 11/03/2014 02:42 PM, Laurent Pinchart wrote:
> On Monday 03 November 2014 14:36:26 Hans Verkuil wrote:
>> On 11/03/2014 02:13 PM, Laurent Pinchart wrote:
>>> Hi Jean-Michel,
>>>
>>> Thank you for the patch.
>>
>>> On Wednesday 10
On 11/03/2014 02:13 PM, Laurent Pinchart wrote:
> Hi Jean-Michel,
>
> Thank you for the patch.
>
> On Wednesday 10 September 2014 11:43:54 Jean-Michel Hautbois wrote:
>
>> +static int lmh0395_s_routing(struct v4l2_subdev *sd, u32 input, u32 output,
>> +u32 config)
Hi Laurent,
Some small nitpicks...
On 11/02/2014 03:53 PM, Laurent Pinchart wrote:
> Xilinx platforms have no hardwired video capture or video processing
> interface. Users create capture and memory to memory processing
> pipelines in the FPGA fabric to suit their particular needs, by
> instantia
r for the Video Timing Controller (VTC) IP core. While
> not strictly a video processing IP core, the VTC is required by other video IP
> core drivers.
>
> Finally, patch 13/13 adds a first video IP core driver for the Test Pattern
> Generator (TPG). Drivers for other IP cores w
On 11/01/2014 02:24 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the review. I've fixed most of the issues you've pointed out,
> please find my replies to the remaining ones below.
>
> On Tuesday 30 September 2014 16:03:34 Hans Verkuil wrote:
>> O
Hi Laurent,
Here is an initial review of this driver:
On 09/29/14 22:27, Laurent Pinchart wrote:
> Xilinx platforms have no hardwired video capture or video processing
> interface. Users create capture and memory to memory processing
> pipelines in the FPGA fabric to suit their particular needs,
On 08/29/2014 03:28 PM, Jean-Michel Hautbois wrote:
> This patch uses DT in order to parse addresses for dummy devices of adv7604.
> If nothing is defined, it uses default addresses.
> The main prupose is using two adv76xx on the same i2c bus.
>
> Signed-off-by: Jean-Michel Hautbois
> ---
> .../
On 08/25/2014 02:39 PM, Hans Verkuil wrote:
> On 08/25/2014 02:29 PM, Mikhail Ulyanov wrote:
>> This patch contains driver for Renesas R-Car JPEG codec.
>>
>> Cnanges since v1:
>> - s/g_fmt function simplified
>> - default format for queues added
>>
On 08/25/2014 02:29 PM, Mikhail Ulyanov wrote:
> This patch contains driver for Renesas R-Car JPEG codec.
>
> Cnanges since v1:
> - s/g_fmt function simplified
> - default format for queues added
> - dumb vidioc functions added to be in compliance with standard api:
> jpu_s_pri
On 08/22/2014 01:39 PM, Mikhail Ulianov wrote:
> Hi Hans,
>
> Thanks for your comments.
>
> I have a question on default width, height and sizeimage values
> m2m driver should return in case when we try to run G_FMT on just
> opened device. Is there any preferable values? v4l2-compliance tool
> w
Hi Mikhail,
I did a quick scan over the source code and I noticed a few things that aren't
right. The easiest for you is probably to run the v4l2-compliance tool over
your driver and it should tell you what needs to be fixed. The things I
noticed are: querycap doesn't fill in bus_info (should be '
Thanks for this patch series!
I've got some comments below...
Regards,
Hans
On 03/19/2014 08:13 AM, Shaik Ameer Basha wrote:
> This patch adds memory to memory (m2m) interface functionality
> for the SCALER driver.
>
> [arun...@samsung.com: fix compilation issues]
>
> Signed-off-by: S
On 02/11/14 13:08, Laurent Pinchart wrote:
> Hi Hans,
>
> On Tuesday 11 February 2014 10:23:03 Hans Verkuil wrote:
>> On 02/05/14 17:42, Laurent Pinchart wrote:
>>> Parse the device tree node to populate platform data.
>>>
>>> Cc: devicetree@vger.kern
On 02/05/14 17:42, Laurent Pinchart wrote:
> Parse the device tree node to populate platform data.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Laurent Pinchart
> ---
> .../devicetree/bindings/media/i2c/adv7604.txt | 56
> drivers/media/i2c/adv7604.c
47 matches
Mail list logo
