It looks like braces may be mising. Please check.
julia
On Mon, 7 Dec 2015, kbuild test robot wrote:
> Hi Priit,
>
> [auto build test WARNING on mripard/sunxi/for-next]
> [also build test WARNING on next-20151203]
> [cannot apply to input/next v4.4-rc4]
>
> url:
> https://github.com/0day-
On Wed, 18 Nov 2015, Brian Norris wrote:
> (changing subject, add devicetree@vger.kernel.org)
>
> On Tue, Nov 17, 2015 at 11:33:25PM +0100, Julia Lawall wrote:
> > On Tue, 17 Nov 2015, Brian Norris wrote:
> > > On Tue, Nov 17, 2015 at 06:48:39PM +0100, Julia Lawal
On Sun, 8 Nov 2015, Andy Shevchenko wrote:
> On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote:
> > Remove unneeded variable used to store return value.
> >
> > Generated by: scripts/coccinelle/misc/returnvar.cocci
> >
> > CC: Sinan Kaya
> > Sign
On Sun, 8 Nov 2015, Andy Shevchenko wrote:
> On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote:
> > Remove unneeded variable used to store return value.
> >
> > Generated by: scripts/coccinelle/misc/returnvar.cocci
> >
> > CC: Sinan Kaya
> > Sign
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Sinan Kaya
Signed-off-by: Fengguang Wu
---
hidma_ll.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/dma/qcom/hidma_ll.c
+++ b/drivers/dma/qcom/hidma_
On Thu, 22 Oct 2015, Rob Herring wrote:
> +Russell who raised issues with these iterators recently.
>
> On Thu, Oct 22, 2015 at 4:02 AM, Julia Lawall wrote:
> > The various for_each device_node iterators performs an of_node_get on each
> > iteration, so a break out of
;
@@
for_each_child_of_node(root,n) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
//
Signed-off-by: Julia Lawall
---
drivers/of/platform.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
exit from the function, which requires an of_node_put.
Signed-off-by: Julia Lawall
---
drivers/of/irq.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 171798d..902b89b 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
//
Signed-off-by: Julia Lawall
---
drivers/of/overlay.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
The various for_each device_node iterators performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.
The complete semantic patch that fixes this problem is
(http://coccinelle.lip6.fr):
//
@r@
local idexpression n;
expression e1,e2;
iterator name for_each_node
;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
//
Combine the puts into code at the end of the function, for conciseness.
Signed-off-by: Julia Lawall
---
drivers/of/unittest.c |8
On Fri, 8 Aug 2014, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote:
> > From: Julia Lawall
> >
> > Of_node_put supports NULL as its argument, so the initial test is not
> > necessary.
> >
> > Sugges
: Julia Lawall
Cc: Gilles Muller
Cc: Nicolas Palix
Cc: Grant Likely
Cc: Rob Herring
Cc: devicetree@vger.kernel.org
Signed-off-by: Stephen Boyd
Acked-by: Grant Likely
Signed-off-by: Julia Lawall
---
v3: Removed unneeded rule bad_of_table. Placed * in context rule on the
closing brace
On Tue, 3 Jun 2014, Stephen Boyd wrote:
> On 06/03/14 03:15, Julia Lawall wrote:
> > Failure to terminate an of_device_id table can lead to confusing
> > failures depending on where the compiler places the array. Add a
> > check to make sure these tables are terminat
Failure to terminate an of_device_id table can lead to confusing
failures depending on where the compiler places the array. Add a
check to make sure these tables are terminated. Thanks to Mitchel
Humpherys for coming up with the pattern initially.
Cc: Mitchel Humpherys
Cc: Julia Lawall
Cc
tial pattern.
>
> Cc: Mitchel Humpherys
> Cc: Julia Lawall
> Cc: Gilles Muller
> Cc: Nicolas Palix
> Cc: Grant Likely
> Cc: Rob Herring
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Stephen Boyd
> ---
> scripts/coccinelle/misc/of_table.cocci | 81
>
16 matches
Mail list logo
