Re: [PATCH-V5 4/4] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-07-01 Thread Krzysztof Kozłowski
2015-07-01 16:43 GMT+09:00 Lee Jones lee.jo...@linaro.org: On Tue, 30 Jun 2015, Krzysztof Kozłowski wrote: 2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along

Re: [PATCH-V5 4/4] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-29 Thread Krzysztof Kozłowski
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Looks okay, ---

Re: [RESEND-PATCH] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

2015-05-04 Thread Krzysztof Kozłowski
2015-05-05 13:07 GMT+09:00 Pankaj Dubey pankaj.du...@samsung.com: From: Yadwinder Singh Brar yadi.b...@samsung.com This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt

Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger

2015-04-29 Thread Krzysztof Kozłowski
2015-04-27 23:02 GMT+09:00 Nicolae, Anda-maria anda-maria.nico...@intel.com: However after looking at the code I got different question. You are reading here and in few other places the RT9455_REG_IRQ1. Isn't the register auto-cleared? No, RT9455_REG_IRQ1 is not cleared after reading. Let me

Re: [PATCH v3 03/10] clk: samsung: exynos5433: Fix CLK_PCLK_MONOTONIC_CNT's register correctly.

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 20:36 GMT+09:00 Chanwoo Choi cw00.c...@samsung.com: From: Jonghwa Lee jonghwa3@samsung.com CLK_PCLK_MONOTONIC_CNT's register is now assigned with wrong one. Its correct register is ENABLE_PCLK_MIF_SECURE_MONOTONIC_CNT. Signed-off-by: Jonghwa Lee jonghwa3@samsung.com

Re: [PATCH v3 02/10] clk: samsung: exynos5433: Fix wrong offset of PCLK_MSCL_SECURE_SMMU_JPEG

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 20:36 GMT+09:00 Chanwoo Choi cw00.c...@samsung.com: From: Jonghwa Lee jonghwa3@samsung.com This patch fixes the wrong offoset of PCLK_MSCL_SECURE_SMMU_JPEG in CMU_MSCL domain. Fixes: b274bbfd8b4a94cb5bd6f (clk: samsung: exynos5433: Add clocks for CMU_MSCL domain Cc:

Re: [PATCH v3 09/10] clk: samsung: exynos5433: Add CLK_IGNORE_UNUSED flag to clocks for sercure monitor call

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 20:36 GMT+09:00 Chanwoo Choi cw00.c...@samsung.com: From: Jonghwa Lee jonghwa3@samsung.com This patch adds 'CLK_IGNORE_UNUSED' flag to clocks which is required for operation of secure monitor call (smc). System will hang when it executes 'smc' with one of those clock is

Re: [PATCH v3 04/10] clk: samsung: exynos5433: Fix wrong parent clock of sclk_apollo clock

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 20:36 GMT+09:00 Chanwoo Choi cw00.c...@samsung.com: This patch fixes the wrong parent clock of sclk_apollo clock from 'div_apollo_pll' to 'div_apollo2'. Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Tomasz Figa tomasz.f...@gmail.com Signed-off-by: Chanwoo Choi

Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 22:06 GMT+09:00 Nicolae, Anda-maria anda-maria.nico...@intel.com: (...) + +static void rt9455_batt_presence_work_callback(struct work_struct *work) +{ + struct rt9455_info *info = container_of(work, struct rt9455_info, +

Re: [PATCH v3 10/10] clk: samsung: exynos5433: Add CLK_IGNORE_UNUSED flag to prevent the hang for suspend-to-ram

2015-04-27 Thread Krzysztof Kozłowski
2015-04-27 20:36 GMT+09:00 Chanwoo Choi cw00.c...@samsung.com: From: Jonghwa Lee jonghwa3@samsung.com Some clocks are required being unmasked for suspend-to-ram. Otherwise, PMU (Power Management Unit) will stick and power line never down. You mean will stuck and never power down? One

Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger

2015-04-25 Thread Krzysztof Kozłowski
2015-04-24 16:57 GMT+09:00 Anda-Maria Nicolae anda-maria.nico...@intel.com: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Hi, Some comments below. Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com ---

Re: [PATCH 0/7] ARM: dts: Refactor Exynos5 boards for phandle notation

2015-04-13 Thread Krzysztof Kozłowski
2015-04-13 5:07 GMT+09:00 Arnd Bergmann a...@arndb.de: On Sunday 12 April 2015 21:24:47 Krzysztof Kozlowski wrote: The phandle notation reduces possible mistakes when overriding nodes by child board files and reduces duplication of addresses. The patchset refactors Exynos5 boards to use the

Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver

2015-02-16 Thread Krzysztof Kozłowski
2015-02-16 14:51 GMT+01:00 Lee Jones lee.jo...@linaro.org: On Wed, 04 Feb 2015, Jaewon Kim wrote: This patch adds MAX77843 core/irq driver to support PMIC, MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, LED and Haptic device. Cc: Lee Jones lee.jo...@linaro.org Signed-off-by:

Re: [PATCH 5/6] regulator: max77843: Add max77843 regulator driver

2015-01-22 Thread Krzysztof Kozłowski
2015-01-23 6:02 GMT+01:00 Jaewon Kim jaewon02@samsung.com: This patch adds new regulator driver to support max77843 MFD(Multi Function Device) chip`s regulators. The Max77843 has two voltage regulators for USB safeout. Cc: Mark Brown broo...@kernel.org Signed-off-by: Beomho Seo

Re: [PATCH 2/6] extcon: max77843: Add max77843 MUIC driver

2015-01-22 Thread Krzysztof Kozłowski
2015-01-23 6:02 GMT+01:00 Jaewon Kim jaewon02@samsung.com: This patch adds MAX77843 extcon driver to support for MUIC(Micro USB Interface Controller) device by using EXTCON subsystem to handle various external connectors. Cc: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Jaewon Kim

Re: [PATCH 3/6] power: max77843_charger: Add Max77843 charger device driver

2015-01-22 Thread Krzysztof Kozłowski
2015-01-23 6:02 GMT+01:00 Jaewon Kim jaewon02@samsung.com: From: Beomho Seo beomho@samsung.com This patch adds device driver of max77843 charger. This driver provide initialize each charging mode(e.g. fast charge, top-off mode and constant charging mode so on.). Additionally, control

Re: [PATCH] mfd: max77686: Fix parent of rtc device

2014-12-02 Thread Krzysztof Kozłowski
On 02.12.2014 13:45, Yadwinder Singh Brar wrote: rtc have different i2c client than power(pmic) block. So rtc device should sit under its own i2c client in device hierarchy, which reflects in sysfs also. This patch modifies code to register rtc cell with rtc-dev as parent. Without this

Re: [PATCH 2/5] regulator: s2mps11: Add support S2MPS13 regulator device

2014-11-17 Thread Krzysztof Kozłowski
On 17.11.2014 01:42, Chanwoo Choi wrote: This patch adds S2MPS13 regulator device to existing S2MPS11 device driver. The S2MPS13 has just different number of regulators from S2MPS14. The S2MPS13 regulator device includes LDO[1-40] and BUCK[1-10]. Cc: Mark Brown broo...@kernel.org

Re: [PATCH 3/5] clk: s2mps11: Add the support for S2MPS13 PMIC clock

2014-11-17 Thread Krzysztof Kozłowski
On 17.11.2014 01:42, Chanwoo Choi wrote: This patch adds the support for S2MPS13 PMIC clock which is same with existing S2MPS14 RTC IP. But, S2MPS13 uses all of clocks (32khz_{ap|bt|cp}). Cc: Mike Turquette mturque...@linaro.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com ---

Re: [PATCH 4/5] rtc: s5m: Add the support for S2MPS13 RTC

2014-11-17 Thread Krzysztof Kozłowski
On 17.11.2014 01:42, Chanwoo Choi wrote: This patch adds only the compatible string for S2MPS13 clock which is identical with S2MPS14 clock driver. Cc: Alessandro Zummo a.zu...@towertech.it Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/rtc/rtc-s5m.c | 15 ++-

Re: [PATCH 5/5] mfd: s2mps11: Add binding documentation for Samsung S2MPS13 PMIC

2014-11-17 Thread Krzysztof Kozłowski
On 17.11.2014 01:43, Chanwoo Choi wrote: This patch adds the binding documentation for Samsung S2MPS13 PMIC which is similiar with existing S2MPS14 PMIC. S2MPS13 has the different number of regulators from S2MPS14 and RTC/Clock is the same with the S2MPS14. Cc: Lee Jones lee.jo...@linaro.org