Re: [PATCH v12 0/6] Altera PCIe host controller driver with MSI support

On Fri, Oct 30, 2015 at 7:22 AM, Bjorn Helgaas wrote: >> >>> >> >>> I applied these to pci/host-altera for v4.4, thanks! >> >>> >> >>> I squashed these into three patches: >> >>> >> >>> - add msi.h to Kbuild >> >>> - add Altera host driver (including DT binding and

Re: [PATCH v12 0/6] Altera PCIe host controller driver with MSI support

On Wed, Oct 28, 2015 at 9:02 AM, Bjorn Helgaas <bhelg...@google.com> wrote: > On Tue, Oct 27, 2015 at 7:56 PM, Ley Foon Tan <lf...@altera.com> wrote: >> On Tue, Oct 27, 2015 at 10:26 PM, Bjorn Helgaas <helg...@kernel.org> wrote: >>> Hi Ley, >>> >

Re: [PATCH v12 0/6] Altera PCIe host controller driver with MSI support

On Tue, Oct 27, 2015 at 10:26 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > Hi Ley, > > On Fri, Oct 23, 2015 at 06:27:09PM +0800, Ley Foon Tan wrote: >> This is the 12th version of patch set to add support for Altera PCIe host >> controller with MSI feature on

[PATCH v12 0/6] Altera PCIe host controller driver with MSI support

ttp://www.kernelhub.org/?msg=853553=2 [v9]: https://lkml.org/lkml/2015/10/13/998 [v10]: https://lkml.org/lkml/2015/10/19/139 [v11]: https://lkml.org/lkml/2015/10/22/206 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI vendor ID pci:host: Add Altera PCIe host controller driver pci: alt

[PATCH v12 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v12 2/6] pci: add Altera PCI vendor ID

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49c..08e4462 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +

[PATCH v12 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-al

[PATCH v12 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8577ad9..96b9fac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7958,6 +7958,14 @@ F: include/linux/pci* F: arch/x

[PATCH v12 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v12 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/binding

Re: [PATCH v11 3/6] pci:host: Add Altera PCIe host controller driver

On Fri, Oct 23, 2015 at 1:31 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > Hi Ley, > > On Thu, Oct 22, 2015 at 05:27:28PM +0800, Ley Foon Tan wrote: >> This patch adds the Altera PCIe host controller driver. > >> +static void altera_pcie_fixups(struct pci_bus *bus)

[PATCH v11 0/6] Altera PCIe host controller driver with MSI support

org/lkml/2015/10/19/139 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI vendor ID pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe MSI driver Documentation: dt-bindings: pci: altera pcie device tree binding MAINTAINERS: Add Altera PCIe and

[PATCH v11 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-al

[PATCH v11 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v11 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8577ad9..96b9fac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7958,6 +7958,14 @@ F: include/linux/pci* F: arch/x

[PATCH v11 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v11 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

Re: [PATCH v11 2/6] pci: add Altera PCI vendor ID

On Fri, Oct 23, 2015 at 6:13 AM, Bjorn Helgaas <helg...@kernel.org> wrote: > On Thu, Oct 22, 2015 at 05:27:27PM +0800, Ley Foon Tan wrote: >> Signed-off-by: Ley Foon Tan <lf...@altera.com> >> --- >> include/linux/pci_ids.h | 2 ++ >> 1 file changed, 2 i

[PATCH v10 0/6] Altera PCIe host controller driver with MSI support

193 [v8]: http://www.kernelhub.org/?msg=853553=2 [v9]: https://lkml.org/lkml/2015/10/13/998 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI vendor ID pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe MSI driver Documentation: dt-bindings: pci: alt

[PATCH v10 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

[PATCH v10 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-al

[PATCH v10 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v10 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v10 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8577ad9..96b9fac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7958,6 +7958,14 @@ F: include/linux/pci* F: arch/x

[PATCH v10 2/6] pci: add Altera PCI vendor ID

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49c..08e4462 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Oct 14, 2015 at 9:32 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday 14 October 2015 18:01:46 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 5:36 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: &

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote: >> +static int altera_pcie_remove(struct platform_device *pdev) >> +{ >> + struct altera_pcie *pcie

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Oct 14, 2015 at 5:36 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: &

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > On Wednesday 14 October 2015 10:41:29 Ley Foo

[PATCH v9 2/6] pci: add Altera PCI vendor ID

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49c..08e4462 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +

[PATCH v9 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v9 0/6] Altera PCIe host controller driver with MSI support

/31/267 [v3]: http://www.kernelhub.org/?msg=811940=2 [v4]: https://lkml.org/lkml/2015/8/17/141 [v5]: https://lkml.org/lkml/2015/8/25/238 [v6]: https://lkml.org/lkml/2015/9/1/177 [v7]: https://lkml.org/lkml/2015/9/20/193 [v8]: http://www.kernelhub.org/?msg=853553=2 Ley Foon Tan (6): arm: add ms

[PATCH v9 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-al

[PATCH v9 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

[PATCH v9 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5f46784..0f55f38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7943,6 +7943,14 @@ F: include/linux/pci* F: arch/x

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

On Mon, Oct 12, 2015 at 8:03 PM, Arnd Bergmann wrote: > > On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > > > I don't know if this should be a kernel taint, a simple warning in > > dmesg, or what. I guess the tainting mechanism is probably too > > general-purpose for

[PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-al

[PATCH v8 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

[PATCH v8 0/6] Altera PCIe host controller driver with MSI support

2015/9/20/193 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI vendor ID pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe MSI driver Documentation: dt-bindings: pci: altera pcie device tree binding MAINTAINERS: Add Altera PCIe and MSI drivers m

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > +

Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

On Sat, Oct 3, 2015 at 5:56 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Friday 02 October 2015 15:53:44 Ley Foon Tan wrote: >> > Strictly speaking, if you have undocumented bindings downstream that >> > is your problem and we don't have to accept them as-is upstream.

Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

On Tue, Sep 29, 2015 at 1:31 AM, Rob Herring <r...@kernel.org> wrote: > On Mon, Sep 28, 2015 at 12:38 AM, Ley Foon Tan <lf...@altera.com> wrote: >> On Sat, Sep 26, 2015 at 11:55 AM, Rob Herring <r...@kernel.org> wrote: >>> >>> On 09/20/2015 09:13

Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

On Tue, Sep 29, 2015 at 3:38 AM, Arnd Bergmann wrote: > On Monday 28 September 2015 12:31:36 Rob Herring wrote: >> >> > + >> >> > +Required properties: >> >> > +- compatible : should contain "altr,pcie-root-port-1.0" >> >> > +- reg: a list of physical base

Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

On Sat, Sep 26, 2015 at 11:55 AM, Rob Herring <r...@kernel.org> wrote: > > On 09/20/2015 09:13 PM, Ley Foon Tan wrote: > > This patch adds the bindings for Altera PCIe host controller driver and > > Altera PCIe MSI driver. > > > > Signed-of

Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Sep 23, 2015 at 2:33 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: > On Mon, 21 Sep 2015 10:13:04 +0800 > Ley Foon Tan <lf...@altera.com> wrote: > >> This patch adds the Altera PCIe host controller driver. >> >> Signed-off-by: Ley Foon Tan <lf.

[PATCH v7 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v7 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 591 + 3 files change

[PATCH v7 2/6] pci: add Altera PCI vendor ID

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49c..08e4462 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +

[PATCH v7 0/6] Altera PCIe host controller driver with MSI support

5/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 [v3]: http://www.kernelhub.org/?msg=811940=2 [v4]: https://lkml.org/lkml/2015/8/17/141 [v5]: https://lkml.org/lkml/2015/8/25/238 [v6]: https://lkml.org/lkml/2015/9/1/177 Ley Foon Tan (6): arm: add msi.h to Kbuild pci: add Altera PCI ven

[PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

[PATCH v7 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab7..eeb9ec9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7938,6 +7938,14 @@ F: include/linux/pci* F: arch/x

Re: [PATCH v6 0/6] Altera PCIe host controller driver with MSI support

On Tue, Sep 1, 2015 at 6:40 PM, Marc Zyngier <marc.zyng...@arm.com> wrote: > On 01/09/15 11:30, Ley Foon Tan wrote: >> This is the 6th version of patch set to add support for Altera PCIe host >> controller with MSI feature on Altera FPGA device families. This patchset >&

Re: [PATCH v6 3/6] pci:host: Add Altera PCIe host controller driver

On Tue, Sep 8, 2015 at 5:19 PM, Lorenzo Pieralisi <lorenzo.pieral...@arm.com> wrote: > On Fri, Sep 04, 2015 at 09:29:14AM +0100, Ley Foon Tan wrote: >> On Wed, Sep 2, 2015 at 12:33 AM, Lorenzo Pieralisi >> <lorenzo.pieral...@arm.com> wrote: > > [...] > >>

Re: [PATCH v6 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Sep 2, 2015 at 12:33 AM, Lorenzo Pieralisi <lorenzo.pieral...@arm.com> wrote: > > On Tue, Sep 01, 2015 at 11:30:05AM +0100, Ley Foon Tan wrote: > > [...] > > > +static void altera_pcie_retrain(struct pci_dev *dev) > > +{

[PATCH v6 1/6] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: "include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory" Signed-off-by: Ley Foon Tan <lf...@altera.com> --- arch/arm/include/asm/Kbuild | 1 + 1 file chan

[PATCH v6 2/6] pci: add Altera PCI vendor ID

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index fcff8f8..9e62bcc 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1550,6 +

[PATCH v6 0/6] Altera PCIe host controller driver with MSI support

or ID [1]: https://lkml.org/lkml/2015/7/23/172 History: --- [v1]: https://lkml.org/lkml/2015/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 [v3]: http://www.kernelhub.org/?msg=811940=2 [v4]: https://lkml.org/lkml/2015/8/17/141 [v5]: https://lkml.org/lkml/2015/8/25/238 Ley Foon Tan (6): arm: ad

[PATCH v6 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt

[PATCH v6 6/6] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan <lf...@altera.com> --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b60e2b2..d70fe18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7780,6 +7780,14 @@ F: include/linux/pci* F: arch/x

[PATCH v6 4/6] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan <lf...@altera.com> Reviewed-by: Marc Zyngier <marc.zyng...@arm.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/h

[PATCH v6 3/6] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan <lf...@altera.com> --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 593 + 3 files change

Re: [PATCH v5 3/5] pci: altera: Add Altera PCIe MSI driver

); +} + +subsys_initcall(altera_msi_init); + +MODULE_AUTHOR(Ley Foon Tan lf...@altera.com); +MODULE_DESCRIPTION(Altera PCIe MSI support); +MODULE_LICENSE(GPL v2); Once you've fixed the above issues, you can add my: Reviewed-by: Marc Zyngier marc.zyng...@arm.com Okay, thanks. Thanks. Regards

Re: [PATCH v5 2/5] pci:host: Add Altera PCIe host controller driver

On Tue, Aug 25, 2015 at 7:39 PM, Marc Zyngier marc.zyng...@arm.com wrote: + +static void altera_pcie_retrain(struct pci_dev *dev) +{ + u16 linkcap, linkstat; + + /* + * Set the retrain bit if the PCIe rootport support 2.5GB/s, but + * current speed is 2.5 GB/s.

[PATCH v5 3/5] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c

[PATCH v5 1/5] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/arm/include/asm/Kbuild | 1 + 1 file changed, 1 insertion

[PATCH v5 5/5] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan lf...@altera.com --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 569568f..c87e451 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7779,6 +7779,14 @@ F: include/linux/pci* F: arch/x86/pci

[PATCH v5 2/5] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 588 + 3 files changed, 596 insertions

[PATCH v5 0/5] Altera PCIe host controller driver with MSI support

: --- [v1]: https://lkml.org/lkml/2015/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 [v3]: http://www.kernelhub.org/?msg=811940p=2 [v4]: https://lkml.org/lkml/2015/8/17/141 Ley Foon Tan (5): arm: add msi.h to Kbuild pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe

[PATCH v5 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 28 + .../devicetree/bindings/pci/altera-pcie.txt| 49

Re: [PATCH v4 2/5] pci:host: Add Altera PCIe host controller driver

On Wed, Aug 19, 2015 at 3:11 AM, Dinh Nguyen dinh.li...@gmail.com wrote: On Mon, Aug 17, 2015 at 4:09 AM, Ley Foon Tan lf...@altera.com wrote: This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 7

Re: [PATCH v4 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

On Wed, Aug 19, 2015 at 3:22 AM, Dinh Nguyen dinh.li...@gmail.com wrote: On Mon, Aug 17, 2015 at 4:09 AM, Ley Foon Tan lf...@altera.com wrote: This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com

[PATCH v4 5/5] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan lf...@altera.com --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fd60784..32f5287 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7759,6 +7759,14 @@ F: include/linux/pci* F: arch/x86/pci

[PATCH v4 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 27 .../devicetree/bindings/pci/altera-pcie.txt| 49 ++ 2

[PATCH v4 2/5] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 543 + 3 files changed, 551 insertions

[PATCH v4 1/5] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/arm/include/asm/Kbuild | 1 + 1 file changed, 1 insertion

[PATCH v4 3/5] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c

[PATCH v4 0/5] Altera PCIe host controller driver with MSI support

: --- [v1]: https://lkml.org/lkml/2015/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 [v3]: http://www.kernelhub.org/?msg=811940p=2 Ley Foon Tan (5): arm: add msi.h to Kbuild pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe MSI driver Documentation: dt

Re: [PATCH v3 2/5] pci:host: Add Altera PCIe host controller driver

On Fri, Aug 7, 2015 at 10:34 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 07/08/15 08:42, Ley Foon Tan wrote: This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile

Re: [PATCH v3 3/5] pci: altera: Add Altera PCIe MSI driver

On Fri, Aug 7, 2015 at 10:44 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 07/08/15 08:43, Ley Foon Tan wrote: This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers

Re: [PATCH v3 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

On Fri, Aug 7, 2015 at 3:43 PM, Ley Foon Tan lf...@altera.com wrote: This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 27

[PATCH v3 2/5] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 532 + 3 files changed, 540 insertions

[PATCH v3 1/5] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/arm/include/asm/Kbuild | 1 + 1 file changed, 1 insertion

[PATCH v3 3/5] pci: altera: Add Altera PCIe MSI driver

This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c

[PATCH v3 0/5] Altera PCIe host controller driver with MSI support

MODULE_DEVICE_TABLE - pcie-altera-msi: move INTMASK to _alloc() - change from clear_bit to __clear_bit - change to use irq_set_chained_handler_and_data - fix coding style History: --- [v1]: https://lkml.org/lkml/2015/7/28/395 [v2]: https://lkml.org/lkml/2015/7/31/267 Ley Foon Tan (5): arm: add msi.h

[PATCH v3 5/5] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan lf...@altera.com --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fd60784..32f5287 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7759,6 +7759,14 @@ F: include/linux/pci* F: arch/x86/pci

[PATCH v3 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 27 .../devicetree/bindings/pci/altera-pcie.txt| 49 ++ 2

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

On Fri, Jul 31, 2015 at 8:12 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 31/07/15 11:15, Ley Foon Tan wrote: This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. I've reviewed the initial drop of this code; basic courtesy

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

On Mon, Aug 3, 2015 at 6:53 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 03/08/15 11:37, Ley Foon Tan wrote: + msg-address_lo = lower_32_bits(addr); + msg-address_hi = upper_32_bits(addr); + msg-data = data-hwirq; + + mask = msi_readl(msi, MSI_INTMASK); + mask |= 1

Re: [PATCH v2 2/5] pci:host: Add Altera PCIe host controller driver

On Fri, Jul 31, 2015 at 8:34 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 31/07/15 11:15, Ley Foon Tan wrote: This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile

[PATCH v2 5/5] MAINTAINERS: Add Altera PCIe and MSI drivers maintainer

Signed-off-by: Ley Foon Tan lf...@altera.com --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fd60784..32f5287 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7759,6 +7759,14 @@ F: include/linux/pci* F: arch/x86/pci

[PATCH v2 4/5] Documentation: dt-bindings: pci: altera pcie device tree binding

This patch adds the bindings for Altera PCIe host controller driver and Altera PCIe MSI driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- .../devicetree/bindings/pci/altera-pcie-msi.txt| 27 .../devicetree/bindings/pci/altera-pcie.txt| 49 ++ 2

[PATCH v2 1/5] arm: add msi.h to Kbuild

Include asm-generic/msi.h to support CONFIG_GENERIC_MSI_IRQ_DOMAIN. This to fix compilation error: include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/arm/include/asm/Kbuild | 1 + 1 file changed, 1 insertion

[PATCH v2 2/5] pci:host: Add Altera PCIe host controller driver

This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan lf...@altera.com --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 526 + 3 files changed, 535 insertions

[PATCH v2 0/5] Altera PCIe host controller driver with MSI support

/395 Ley Foon Tan (5): arm: add msi.h to Kbuild pci:host: Add Altera PCIe host controller driver pci: altera: Add Altera PCIe MSI driver Documentation: dt-bindings: pci: altera pcie device tree binding MAINTAINERS: Add Altera PCIe and MSI drivers maintainer .../devicetree/bindings/pci

Re: [PATCH 4/6] pci: altera: Add Altera PCIe MSI driver

On Wed, Jul 29, 2015 at 5:15 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 29/07/15 09:52, Ley Foon Tan wrote: On Wed, Jul 29, 2015 at 1:58 AM, Marc Zyngier marc.zyng...@arm.com wrote: Hi Ley, On 28/07/15 11:45, Ley Foon Tan wrote: This patch adds Altera PCIe MSI driver. This soft IP

Re: [PATCH 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Jul 29, 2015 at 4:35 PM, Paul Bolle pebo...@tiscali.nl wrote: On di, 2015-07-28 at 18:45 +0800, Ley Foon Tan wrote: --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig +config PCIE_ALTERA + bool Altera PCIe controller + depends on ARCH_SOCFPGA + depends

Re: [PATCH 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, Jul 29, 2015 at 9:19 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Tue, Jul 28, 2015 at 11:45:42AM +0100, Ley Foon Tan wrote: [...] +static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) +{ + int err, res_valid = 0; + struct device

Re: [PATCH 4/6] pci: altera: Add Altera PCIe MSI driver

On Wed, Jul 29, 2015 at 1:58 AM, Marc Zyngier marc.zyng...@arm.com wrote: Hi Ley, On 28/07/15 11:45, Ley Foon Tan wrote: This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Can't you read this configuration from the HW

  1   2   >