Re: [PATCH v3 2/5] dt-bindings: mediatek: Modify pinctrl bindings for mt2701

2016-01-07 Thread Linus Walleij
On Mon, Dec 28, 2015 at 8:09 AM, Biao Huang <biao.hu...@mediatek.com> wrote: > Signed-off-by: Biao Huang <biao.hu...@mediatek.com> Patch applied with the ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the bo

Re: [PATCH v3 5/5] arm: dts: Add pinctrl/GPIO/EINT node for mt2701

2016-01-07 Thread Linus Walleij
On Thu, Dec 31, 2015 at 12:23 PM, Matthias Brugger <matthias@gmail.com> wrote: > On 28/12/15 08:09, Biao Huang wrote: >> >> Add pinctrl and GPIO node to mt2701.dtsi >> >> Signed-off-by: Biao Huang <biao.hu...@mediatek.com> >> Acked-by: Linus Wallei

Re: [PATCH] gpiolib: always initialize *flags from of_get_named_gpio_flags

2016-01-03 Thread Linus Walleij
untered, we don't actually get to the place that uses the flags > if CONFIG_OF is disabled because we won't enter the DT parser code. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe de

Re: [GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5

2015-12-24 Thread Linus Walleij
ps://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git > tags/samsung-drivers-4.5 > > for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: > > pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 > +0900) OK I pulled this into th

Re: [PATCH] of/irq: Export of_irq_count()

2015-12-22 Thread Linus Walleij
nt > function though. Perhaps we should make one? Usually it is just used > for allocating some driver data. If that is the case, is it really > enough data to not just allocate the max? Hm that seems like a bigger solution. Should we try to mitigate the issue by making the Qualcomm

Re: [PATCH 1/2 v2] ARM: l2x0: make it possible to disable outer sync from DT

2015-12-22 Thread Linus Walleij
On Sun, Dec 20, 2015 at 5:11 PM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > It would be nice to have a faster response though, because Linus Walleij > put this in the patch system on the 15th December, and I could have > applied it without waiting for DT pe

Re: [PATCH 1/2] dt-bindings: GPIO: Add generic serializer binding

2015-12-22 Thread Linus Walleij
ot; string, and not "is-a:" string. Compatible ranges from the specific to the more generic so compatible = "ti,74165", "pisosr"; is just fine. Something will match if there is a suitable driver. The OS may choose to provide something part-specific or somet

Re: [PATCH] gpio: sx150x: Add support for sx1502

2015-12-22 Thread Linus Walleij
On Tue, Dec 15, 2015 at 11:01 PM, Peter Rosin <p...@lysator.liu.se> wrote: > From: Peter Rosin <p...@axentia.se> > > Signed-off-by: Peter Rosin <p...@axentia.se> Patch applied with Rob's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the l

Re: [PATCH resend] pinctrl: sunxi: Add A80 special pin controller

2015-12-22 Thread Linus Walleij
ed-by: Rob Herring <r...@kernel.org> > --- > > Linus, can we have this one included for 4.5? Yep. Patch rebased and applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support

2015-12-22 Thread Linus Walleij
problem, I'd be OK with this getting > stalled for a bit longer if someone could look at the other > one) Lee can you merge the core driver if it's OK? Then we have includes etc in place to merge subdrivers for the next merge window. Yours, Linus Walleij -- To unsubscribe from this list: se

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-22 Thread Linus Walleij
dozen architecture issues in the GPIO subsystem so I am busy refactoring the whole know universe :D But I still intend to persue the series. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of/irq: Export of_irq_count()

2015-12-22 Thread Linus Walleij
rt > the symbol make it available to modules. > > Signed-off-by: Mark Brown <broo...@kernel.org> Thanks Mark. Reviewed-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the

Re: [PATCH 1/2] ARM: l2x0: make it possible to disable outer sync from DT

2015-12-14 Thread Linus Walleij
On Thu, Dec 10, 2015 at 3:20 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thursday 10 December 2015 15:14:15 Linus Walleij wrote: >> Some RealView platforms have broken outer_sync, see: >> http://marc.info/?l=linux-kernel=144846940516899=2 >> >> We got rid of the

Re: [PATCH 1/2] ARM: l2x0: make it possible to disable outer sync from DT

2015-12-14 Thread Linus Walleij
On Thu, Dec 10, 2015 at 3:32 PM, Mark Rutland <mark.rutl...@arm.com> wrote: > On Thu, Dec 10, 2015 at 03:14:15PM +0100, Linus Walleij wrote: >> Some RealView platforms have broken outer_sync, see: >> http://marc.info/?l=linux-kernel=144846940516899=2 >> >> We go

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-14 Thread Linus Walleij
On Fri, Dec 11, 2015 at 3:06 PM, Rob Herring <robh...@kernel.org> wrote: > On Fri, Dec 11, 2015 at 6:39 AM, Linus Walleij <linus.wall...@linaro.org> > wrote: >> On Fri, Dec 4, 2015 at 6:31 PM, Martyn Welch >> <martyn.we...@collabora.co.uk> wrote: >> >

[PATCH 1/2 v2] ARM: l2x0: make it possible to disable outer sync from DT

2015-12-14 Thread Linus Walleij
t;a...@arndb.de> Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- ChangeLog v2->v3: - Update description, reference Catalins initial commit in the commit blurb. --- Documentation/devicetree/bindings/arm/l2cc.txt | 3 +++ arch/arm/mm/cache-l2

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-11 Thread Linus Walleij
bindings/gpio/gpio.txt and put directly in the gpiochip node. Maybe as an extension of the existing hogs, but that has already been tried. While we can agree on a device tree binding, the kernel still needs major refactoring to actually expose named GPIOs to userspace, and that should be done using

Re: [PATCH 1/2] dt-bindings: GPIO: Add generic serializer binding

2015-12-11 Thread Linus Walleij
maybe you don't need to have this in the device tree but instead it can be determined from the compatible string? In that case do that. > + - load-gpios : GPIO pin specifier attached to load enable, this > + pin is pulsed before reading from the device to &

Re: [PATCH 2/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Linus Walleij
ERNEL); > + if (!gpio->buffer) > + return -ENOMEM; > + > + gpio->load_gpio = devm_gpiod_get(>dev, "load", GPIOD_OUT_LOW); > + if (IS_ERR(gpio->load_gpio)) { > + ret = PTR_ERR(gpio->load_gpio); > + if (ret != -ENOENT &

Re: [PATCH 0/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Linus Walleij
SN65HVS88x series as well as other 74x165 style devices. Pretty interesting, I'd like you to CC SPI maintainer Mark Brown on this patch series, and the SPI mailing list. Looking closer at the code. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-11 Thread Linus Walleij
am refactoring the world to create a proper chardev ABI for GPIO instead. See: http://marc.info/?l=linux-gpio=144550276512673=2 So for the moment, NACK on this, please participate in creating the *right* ABI for GPIO instead of trying to shoehorn stuff into the dying sysfs ABI. Yours, Linus

Re: [PATCH v5 2/4] pinctrl: sunxi: Add H3 PIO controller support

2015-12-11 Thread Linus Walleij
Patch applied with Rob's & Maxime's ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 1/8] pinctrl: rockchip: add support for the rk3228

2015-12-11 Thread Linus Walleij
On Wed, Dec 9, 2015 at 10:04 AM, Jeffy Chen <jeffy.c...@rock-chips.com> wrote: > The pinctrl of rk3228 is much the same as rk3288's, but > without pmu. > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Patch applied with Heiko's and Rob's Review/ACK

Re: [PATCH v2 1/4] pinctrl: rockchip: add support for the rk3228

2015-12-11 Thread Linus Walleij
de> > Acked-by: Rob Herring <r...@kernel.org> > > --- > > Changes in v2: None Same as I applied then, I also added the same Review/ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.ker

Re: [PATCH 1/2] ARM: mvebu: add kirkwood compatibles for cloudengine boards

2015-12-11 Thread Linus Walleij
On Wed, Dec 9, 2015 at 4:27 PM, Gregory CLEMENT <gregory.clem...@free-electrons.com> wrote: > Hi Linus, > > On mer., déc. 09 2015, Linus Walleij <linus.wall...@linaro.org> wrote: > >> On Fri, Nov 27, 2015 at 12:00 AM, Linus Walleij >> <linus.wall

Re: [PATCH v3 0/6] pinctrl: meson: enable support for external GPIO interrupts

2015-12-10 Thread Linus Walleij
y. > - irq_of_phandle_args_to_fwspec discarded I don't know where this patch set is standing but I get the impression that it still needs revising so waiting for a v4. Given the complex nature of the IRQs I will probably want Marc to provide his Review/ACK before applying. Yours, L

Re: [PATCH v2 3/3] ARM: dts: enable GPIO-a for Broadcom NSP

2015-12-10 Thread Linus Walleij
On Fri, Dec 4, 2015 at 6:12 PM, Yendapally Reddy Dhananjaya Reddy <yrdre...@broadcom.com> wrote: > This enables the GPIO-a support for Broadcom NSP SoC > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdre...@broadcom.com> Acked-by: Linus Walleij <linus.wall...@l

Re: [PATCH v2 4/9] pinctrl: Add support STM32 MCUs

2015-12-10 Thread Linus Walleij
eviewing of large chunks of code takes time. It would be great if I could have some Reviewed-by tags from someone else who's familiar with pin control. Patrice: do you have a chance to review this driver and help us? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

2015-12-10 Thread Linus Walleij
On Tue, Dec 1, 2015 at 8:40 PM, Andrew F. Davis <a...@ti.com> wrote: > On 11/30/2015 02:26 AM, Linus Walleij wrote: >> >> On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis <a...@ti.com> wrote: >> >>> This patch adds support for the TPS65912 PMIC GPIOs. &g

[PATCH 1/2] ARM: l2x0: make it possible to disable outer sync from DT

2015-12-10 Thread Linus Walleij
this, spurious crashes would occur if we try to set up the cache properly. Cc: Russell King <li...@arm.linux.org.uk> Cc: Arnd Bergmann <a...@arndb.de> Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- Documentation/devicetree/bindings/arm/l2c

Re: [PATCH 1/4] dt-bindings: gpio: update desription of LPC32xx GPIO controller

2015-12-10 Thread Linus Walleij
ntroller, and that is >> why even setting up trigger type has to percolate up to >> the parent? Explain this in this document. > > Will extend this description. Generally your understanding is correct, a > requested GPIO interrupt is propagated to an IRQ chip interrupt, the h

Re: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support

2015-12-09 Thread Linus Walleij
renamed the .dev field of struct gpio_chip to .parent but I'm bombing out another 150 or so patches today, ridding all GPIO drivers in the kernel of container_of(). A bit painful but nothing to what tglx has gone through for refactoring IRQ chips... Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH 1/2] ARM: mvebu: add kirkwood compatibles for cloudengine boards

2015-12-09 Thread Linus Walleij
On Fri, Nov 27, 2015 at 12:00 AM, Linus Walleij <linus.wall...@linaro.org> wrote: > This adds the compatible strings for Cloudengine PogoPlug E02 and > series 4. The former already has a devicetree in the kernel. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linu

Re: [PATCH 3/5] pinctrl: dt bindings: Add pinfunc header file for mt2701

2015-12-09 Thread Linus Walleij
On Thu, Nov 26, 2015 at 9:44 AM, Biao Huang <biao.hu...@mediatek.com> wrote: > Add pinfunc header file, mt2701 related dts will include it > > Signed-off-by: Biao Huang <biao.hu...@mediatek.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> Take this through ARM

Re: [PATCH 1/5] ARM: mediatek: Add MT2701 config options for mediatek SoCs.

2015-12-09 Thread Linus Walleij
fig options so we can build for one SoC only. Add MT2701. > > Signed-off-by: Erin Lo <erin...@mediatek.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> FWIW, take this through the ARM SoC tree, since it's just a Kconfig symbol, the pin control patches should be possible

Re: [PATCH 5/5] arm: dts: Add pinctrl/GPIO/EINT node for mt2701

2015-12-09 Thread Linus Walleij
On Thu, Nov 26, 2015 at 9:44 AM, Biao Huang <biao.hu...@mediatek.com> wrote: > Add pinctrl and GPIO node to mt2701.dtsi > > Signed-off-by: Biao Huang <biao.hu...@mediatek.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> Take this through the ARM SoC tree as

Re: [PATCH 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

2015-12-09 Thread Linus Walleij
: Biao Huang <biao.hu...@mediatek.com> This looks uncontroversial, but I would like to have some of the other Mediatek driver authors send their Ack/Review tags, so Hongzhou & Yingjoe: can you review this and the other patch to the pin control driver? Yours, Linus Walleij -- To unsubscrib

Re: [PATCH] pinctrl: qcom: Add msm8996 pinctrl driver

2015-12-01 Thread Linus Walleij
> Cc: Bjorn Andersson <bjorn.anders...@sonymobile.com> > Signed-off-by: Joonwoo Park <joonw...@codeaurora.org> > [sb...@codeaurora.org: Remove duplicate entries and enums] > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> Patch applied with the ACKs! Yours, Linus Wa

Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pm8994 gpio support

2015-12-01 Thread Linus Walleij
rs...@sonymobile.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> Patch applied with the ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] pinctrl: qcom: spmi-mpp: Add pm8994 mpp support

2015-12-01 Thread Linus Walleij
@sonymobile.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> Patch applied with the ACKs! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 1/5] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC

2015-12-01 Thread Linus Walleij
On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis <a...@ti.com> wrote: > The TPS65912 PMIC contains several regulators and a GPIO controller. > Add bindings for the TPS65912 PMIC. > > Signed-off-by: Andrew F. Davis <a...@ti.com> Acked-by: Linus Walleij <linus.wall..

Re: [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP

2015-12-01 Thread Linus Walleij
.@broadcom.com> > > Looks like a sane pinctrl node here, unless there are objections, I > would like to go ahead and apply this for v4.5, thanks! I'm waiting for an indication from the other BCM pinctrl maintainers to tell whether this SoC is unique enough to deserve its own driver. Y

Re: [PATCH v2 4/7] pinctrl: Add new compatible string to GPIO controller driver

2015-11-30 Thread Linus Walleij
Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/7] pinctrl: use ngpios propety from DT

2015-11-30 Thread Linus Walleij
ned-off-by: Pramod Kumar <pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a

Re: [PATCH 4/4] gpio: lpc32xx: add new LPC32xx GPIO controller driver

2015-11-30 Thread Linus Walleij
lpc32xx_gpio_set; > + > + bank->chip.to_irq = lpc32xx_gpio_to_irq; > + > + bank->chip.base = id * 32; Use -1 instead so you get a dynamically assigned base. > + bank->chip.ngpio= ngpio; > + bank-

Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

2015-11-30 Thread Linus Walleij
On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis <a...@ti.com> wrote: > This patch adds support for the TPS65912 PMIC GPIOs. > > TPS65912 has five configurable GPIOs that can be used for several > purposes. > > Signed-off-by: Andrew F. Davis <a...@ti.com> > Revie

Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

2015-11-30 Thread Linus Walleij
gpio->tps = dev_get_drvdata(pdev->dev.parent); > + gpio->gpio_chip = template_chip; No gpio->gpio_chip.parent = >dev? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel

Re: [PATCH v3 1/5] pinctrl/lantiq: updating devicetree binding description

2015-11-30 Thread Linus Walleij
"xrx200" or "xrx300" and marks the "lantiq,pinctrl-xway", > "lantiq,pinctrl-ase" and "lantiq,pinctrl-xr9" compatible strings as > DEPRECATED. > > Signed-off-by: Martin Schiller <mschil...@tdt.de> > Acked-by: Rob Herring <r..

Re: [PATCH v3 2/5] pinctrl/lantiq: introduce new dedicated devicetree bindings

2015-11-30 Thread Linus Walleij
ube, xRX100 and > xRX200 families, which makes it impossible to use only one xway_mfp table. > > This patch also adds support for the xRX300 family. > > Signed-off-by: Martin Schiller <mschil...@tdt.de> > --- > Changes in v3: > None Patch applied. Yours, Linus Walleij

Re: [PATCH v3 4/5] pinctrl/lantiq: Fix GPIO Setup of GPIO Port3

2015-11-30 Thread Linus Walleij
oved this change into a separate patch Patch applied, I conjured a commit blurb because this was missing one. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] dt-bindings: gpio: update desription of LPC32xx GPIO controller

2015-11-30 Thread Linus Walleij
of thing and just latches the GPIO line out to an IRQ line on the interrupt controller, and that is why even setting up trigger type has to percolate up to the parent? Explain this in this document. > + gpio-output-only; You forgot to documen this property. Yours

Re: [PATCH v3 3/5] pinctrl/lantiq: update devicetree binding in dts file

2015-11-30 Thread Linus Walleij
On Thu, Nov 26, 2015 at 11:00 AM, Martin Schiller <mschil...@tdt.de> wrote: > This patch updates the compatible string in the easy50712.dts file to the new > "lantiq,danube-pinctrl". > > Signed-off-by: Martin Schiller <mschil...@tdt.de> > --- > Change

Re: [PATCH v3 5/5] pinctrl/lantiq: Implement gpio_chip.to_irq

2015-11-30 Thread Linus Walleij
ing on? I take it that the Lantiq has a dedicated IRQ line for some of the GPIO lines, referred to as external interrupts, and then you just go in and grab that frm the external interrupt unit like this? Looks OK, just send an updated patch with some more explanations. Yours, Linus Walleij -- To unsub

Re: [PATCH v2 6/7] Documentation: Rename gpio controller name from cygnus to iproc

2015-11-30 Thread Linus Walleij
lt;pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied. Added Rob Herring's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in

Re: [PATCH v4 4/4] gpio: tps65086: Add GPO driver for the TPS65086 PMIC

2015-11-30 Thread Linus Walleij
> (...) > + gpio->tps = dev_get_drvdata(pdev->dev.parent); > + gpio->chip = template_chip; > + gpio->chip.dev = gpio->tps->dev; We have renamed this to .parent in linux-next and it needs to be altered to compile upstream. Yours, Linus Walleij --

Re: [PATCH 0/4] gpio: lpc32xx: add new LPC32xx GPIO controller driver

2015-11-30 Thread Linus Walleij
ng > to the new driver should not impact any GPIO consumers. Has it been tested on the old hardware too? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 1/5] of/irq: export of_irq_find_parent again

2015-11-30 Thread Linus Walleij
o of the stuff to the next merge window or set it up on an immutable branch I can pull. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/5] pinctrl: meson: enable support for external GPIO interrupts

2015-11-30 Thread Linus Walleij
caded irqchips, but instead just shunt the line through to some other interrupt controller through a mux or latch. We might need to add some handling to gpiolib core that does this, like gpiochip_add_irq_mux() that sets up the irqdomain we have for GPIOLIB_IRQCHIP to be used like this and pull this c

Re: [PATCH v2 2/7] dts: define ngpios property in gpio controller's node

2015-11-30 Thread Linus Walleij
Reviewed-by: Scott Branden <sbran...@broadcom.com> Acked-by I see that Florian has already picked it up, nice! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/7] dt-binding: Add ngpios property to GPIO controller node

2015-11-30 Thread Linus Walleij
: Pramod Kumar <pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied with Rob's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body o

Re: [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc

2015-11-30 Thread Linus Walleij
: Pramod Kumar <pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied. Required some rebasing so check the result. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH v2 7/7] pinctrl: Rename gpio driver from cygnus to iproc

2015-11-30 Thread Linus Walleij
er. > > Signed-off-by: Pramod Kumar <pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> > Acked-by: Rob Herring <r...@kernel.org> Patch applied. Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH v3 2/2] gpiolib: Add GPIO initialization

2015-11-29 Thread Linus Walleij
is missing a gpiod_parse_flags(). Will fix this and resend > tomorrow. I haven't seen a new version, am I looking in the wrong places? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ARM: mvebu: add kirkwood compatibles for cloudengine boards

2015-11-26 Thread Linus Walleij
This adds the compatible strings for Cloudengine PogoPlug E02 and series 4. The former already has a devicetree in the kernel. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- Documentation/devicetree/bindings/arm/marvell,kirkwood.txt | 2 ++

Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

2015-11-18 Thread Linus Walleij
On Tue, Nov 17, 2015 at 5:11 PM, Andrew F. Davis <a...@ti.com> wrote: > On 11/17/2015 03:17 AM, Linus Walleij wrote: >> >> On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <a...@ti.com> wrote: >> >>> Add support for the TPS65086 PMIC GPOs. >>&g

Re: [PATCH v3 1/2] dt-bindings: GPIO: Add gpio-initval

2015-11-18 Thread Linus Walleij
istics of the line rather than driving it in any way. Anyway the input/output-low/output-high is already merged, and in use for hogs. We looked at using -gpios in a self-referential manner, but that made it impossible to name the lines, and that is a desired property. Hogged lines need names so we can figure out who i

Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

2015-11-17 Thread Linus Walleij
indings documentation actually so I guess it goes there. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/7] ARM: at91/dt: sama5d2: add pio controller node

2015-11-17 Thread Linus Walleij
On Tue, Nov 10, 2015 at 1:30 AM, Olof Johansson <o...@lixom.net> wrote: > On Mon, Sep 21, 2015 at 11:24 AM, Linus Walleij > <linus.wall...@linaro.org> wrote: >> On Wed, Sep 16, 2015 at 8:37 AM, Ludovic Desroches >> <ludovic.desroc...@atmel.com> wrote: >&

Re: [RFC 0/3] Adding support for NI Ettus Research USRP E3XX pinconf

2015-11-17 Thread Linus Walleij
if I'm using the pinctrl framework correctly to achieve this, > any suggestions on how to change a pin from output to input, as the bindings > documentation explicitly states 'input-enable' does *not* affect output. Look at pin controllers also implementing GPIO chips. Yours, Linus Walleij --

Re: [PATCH 2/2] ARM: u300: remove regulator-compatible usage

2015-11-17 Thread Linus Walleij
lues of the node's > name and the regulator-compatible match for all the regulators. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Patch applied to ux500-devicetree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetr

Re: [PATCH 1/2] ls2080a/dts: Add little endian property for GPIO IP block

2015-11-17 Thread Linus Walleij
On Mon, Nov 16, 2015 at 7:56 PM, Li Yang <le...@freescale.com> wrote: > On Mon, Nov 16, 2015 at 9:11 AM, Linus Walleij <linus.wall...@linaro.org> > wrote: >> On Tue, Nov 3, 2015 at 12:19 PM, Liu Gang <gang@freescale.com> wrote: >> >>> The GPIO

Re: [PATCH 1/2] ARM: ux500: remove regulator-compatible usage

2015-11-17 Thread Linus Walleij
lues of the node's > name and the regulator-compatible match for all the regulators. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Patch applied on my ux500-devicetree branch, will be in my first pull request to ARM SoC. Yours, Linus Walleij -- To unsubscr

Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

2015-11-17 Thread Linus Walleij
ps65086_gpio_get(struct gpio_chip *gc, unsigned offset) > +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset, Just get/set and no get_direction/direction_input/direction_output? Are you sure? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH v3 3/6] Documentation: tps65086: Add DT bindings for the TPS65086 GPO controller

2015-11-17 Thread Linus Walleij
On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <a...@ti.com> wrote: > The TPS65086 PMIC contains several regulators and a GPO controller. > Add bindings for the TPS65086 GPO controller. > > Signed-off-by: Andrew F. Davis <a...@ti.com> Patch applied to the GPIO tree with

Re: [PATCH 1/2] ls2080a/dts: Add little endian property for GPIO IP block

2015-11-16 Thread Linus Walleij
r up in the desriptions. Just for Freescale seems a bit too local. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform

2015-11-16 Thread Linus Walleij
t I would do two patches: - One that switches MPC8xxx to using GENERIC_GPIO - One that adds BE support using that infrastructure It will result in a lot less code. I think. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a me

Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP

2015-11-16 Thread Linus Walleij
n code is minimal. Also, the fact that the change is part > of up-streamed code, I didn't alter with the variable name. Shall I > change it in the next patch? Sure do it any way as long as the end result looks fine. It was not a big issue anyways. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 2/2] iio: st_sensors: support open drain mode

2015-11-16 Thread Linus Walleij
eneric_buffer on both similtaneously... OK I'll see if we can get the trigger to return IRQ_HANDLED or IRQ_NO_IRQ. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH 2/2] iio: st_sensors: support open drain mode

2015-11-16 Thread Linus Walleij
On Mon, Nov 16, 2015 at 9:57 AM, Linus Walleij <linus.wall...@linaro.org> wrote: > On Mon, Nov 16, 2015 at 7:15 AM, Denis Ciocca <denis.cio...@st.com> wrote: > >> I'm not convinced about this one. If we declare sensors output as open drain, >> interrupt can be shar

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-11-14 Thread Linus Walleij
rking? We can't break the DT ABI, so I guess not. A bit confused here, I can't really see what I should do with the patch... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] iio: st_sensors: support open drain mode

2015-11-13 Thread Linus Walleij
m> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- Documentation/devicetree/bindings/iio/st-sensors.txt | 3 +++ drivers/iio/accel/st_accel_core.c| 8 drivers/iio/common/st_sensors/st_sensors_core.c | 20 drivers/iio

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-11-10 Thread Linus Walleij
ems like a pretty good idea to me. Hm! That's a clever idea. I'll take a spin on that. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP

2015-11-09 Thread Linus Walleij
ess or so. "secondary_boot" sounds like a function you call to boot the second core. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 2/3] pinctrl: e3xx: Adding support for NI Ettus Research USRP E3xx pinconf

2015-11-09 Thread Linus Walleij
tor, > + unsigned long *configs, > + unsigned num_configs) > +{ > + return -EAGAIN; > +} Maybe you should group this with the other group callbacks. Apart from these remarks it looks pretty nice. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/19] ARM: dts: ste: replace legacy *,wakeup property with wakeup-source

2015-11-05 Thread Linus Walleij
On Tue, Oct 27, 2015 at 1:46 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 27/10/15 12:34, Linus Walleij wrote: >> On Wed, Oct 21, 2015 at 12:10 PM, Sudeep Holla <sudeep.ho...@arm.com> >> wrote: >> >>> Though the keyboard and other driver will co

Re: [PATCH RESEND 3/4] ARM: BCM: Add SMP support for Broadcom NSP

2015-11-05 Thread Linus Walleij
a charm for us. So see of you really need this horror story with copied assembly code from realview etc. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] gpio: dt-bindings: document the official use of "ngpios"

2015-10-30 Thread Linus Walleij
wrt.org> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- Documentation/devicetree/bindings/gpio/gpio.txt | 24 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt inde

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-10-30 Thread Linus Walleij
Also, this patch will conflict with [1]. I'll probably take [1] soon, so > one of us will have to rebase this. Sure I'll rebase on whatever you say. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vge

Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

2015-10-30 Thread Linus Walleij
ooks like a fine driver, can't really see anything wrong with it so: Reviewed-by: Linus Walleij <linus.wall...@linaro.org> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, > gpio_chip) I would rewrite that to static inline however. Lee can take this into the MFD t

Re: [PATCH 07/11] pinctrl: use ngpios propety from DT

2015-10-30 Thread Linus Walleij
following but all right... With gpio ranges the GPIO to pins are mapped, and they can switch functions at runtime. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] mtd: create a partition type device tree binding

2015-10-29 Thread Linus Walleij
du...@arm.com> Reported-by: Liviu Dudau <liviu.du...@arm.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- .../devicetree/bindings/mtd/mtd-physmap.txt| 2 ++ .../devicetree/bindings/mtd/partition.txt | 35 +++--- 2 files changed, 33 inse

Re: [PATCH v2 1/3] gpio: xgene: add support to configure GPIO line as input, output or external IRQ pin

2015-10-29 Thread Linus Walleij
e_irq); > + else > + irq_set_handler_locked(d, handle_level_irq); > + > + return 0; > +} If you are assigning hadle_edge_irq() your irqchip *must* have an .irq_ack() callback that acknowledges the IRQs as they come in. This makes me suspect that you haven

Re: [PATCH v2 2/3] gpio: arizona: Support Cirrus Logic CS47L24 and WM1831

2015-10-29 Thread Linus Walleij
On Wed, Oct 28, 2015 at 12:42 PM, Lee Jones <lee.jo...@linaro.org> wrote: > On Tue, 27 Oct 2015, Linus Walleij wrote: > >> On Mon, Oct 19, 2015 at 4:13 PM, Richard Fitzgerald >> <r...@opensource.wolfsonmicro.com> wrote: >> >> > The CS47L

Re: [PATCH 07/11] pinctrl: use ngpios propety from DT

2015-10-29 Thread Linus Walleij
traditional use of ngpios. But on the other hand: git grep ngpio Documentation/devicetree/bindings/gpio/ Gives at hand that the use of ngpio[s] is a complete mess. :( I will think about patching the standard bindings to fix this mess and include your case. Give me some time. Yours, Linus Wal

Re: [PATCH 02/11] pinctrl: Remove GPIO to Pinctrl pin mapping from driver

2015-10-27 Thread Linus Walleij
viewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied with a small subject tweak. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kerne

Re: [PATCH 04/11] dt-binding: Add new compatible string for gpio controller driver

2015-10-27 Thread Linus Walleij
ay Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Patch applied with subject tweak. Think about Rob's comment to add an overarching SoC compatible string, please. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetr

Re: [PATCH 08/11] pinctrl: Add new compatible string to GPIO controller driver

2015-10-27 Thread Linus Walleij
On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar wrote: > This compatible string should be used for all new iproc based future > SoCs having the same GPIO controller hardware. > > Signed-off-by: Pramod Kumar > Reviewed-by: Ray Jui >

Re: [PATCH v2 2/3] gpio: arizona: Support Cirrus Logic CS47L24 and WM1831

2015-10-27 Thread Linus Walleij
On Mon, Oct 19, 2015 at 4:13 PM, Richard Fitzgerald <r...@opensource.wolfsonmicro.com> wrote: > The CS47L24 and WM1831 codecs only have two GPIO lines, but are > otherwise similar to the WM8280. > > Signed-off-by: Richard Fitzgerald <r...@opensource.wolfsonmicro.com>

Re: [PATCH 01/11] dt-bindings: pinctrl: Optional DT property to support pin mappings

2015-10-27 Thread Linus Walleij
his mapping via DT. > > Signed-off-by: Pramod Kumar <pramo...@broadcom.com> > Reviewed-by: Ray Jui <r...@broadcom.com> > Reviewed-by: Scott Branden <sbran...@broadcom.com> Applied with Rob's ACK and a tweak to the subject line. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node

2015-10-27 Thread Linus Walleij
er *provides* is to be determined by the compatible-string. ngpios is used to restrict the number of lines *used* or *routed* from the number *available*. (I hope that is what the code does as well.) Such as if 12 GPIOs are used of the 32 available on 32bits in a register. Update this description

  1   2   3   4   5   6   7   8   9   10   >