However I cannot check the resistor values for the other chips or test them.
For other chips the driver code works as earlier Eg. it does not check the
dt bindings at all
Signed-off-by: Matti Vaittinen
---
Delta to v5
-Actually sent correct patch
drivers/rtc/rtc-ds1
Some DS13XX devices have "trickle chargers". Introduce a device tree binding
for the resistor and diode configuration for enabling trickle charger.
Signed-off-by: Matti Vaittinen
Acked-by: Jason Cooper
---
Delta to v4
-This is the correct patch.
.../devicetree/bindings/i
On Tue, Sep 09, 2014 at 01:38:39PM +0300, Matti Vaittinen wrote:
> + diode = of_property_read_bool(client->dev.of_node, "diode-connected");
Please ignore this patch. I've accidentally sent the wrong version!
Sorry, I will send the correct one as soon as possible.
Br.
Mat
On Tue, Sep 09, 2014 at 01:38:39PM +0300, Matti Vaittinen wrote:
> rtc: ds1307: add trickle charger device tree binding.
>
> Some DS13XX devices have "trickle chargers". Introduce a device tree
> binding for specifying the trickle charger configuration for ds1339.
>
&g
would have worked on other allready supported chips.
However I cannot check the resistor values for the other chips or test them.
For other chips the driver code works as earlier Eg. it does not check the
dt bindings at all.
Signed-off-by: Matti Vaittinen
---
drivers/rtc/rtc-ds1
Documentation: dt-bindings: trickle charger dt binding document for ds1339
Some DS13XX devices have "trickle chargers". Introduce a device tree binding
for the resistor and diode configuration for enabling trickle charger.
Signed-off-by: Matti Vaittinen
---
Delta to v3:
On Mon, Sep 08, 2014 at 07:26:57AM -0400, ext Jason Cooper wrote:
> Matti,
>
> On Mon, Sep 08, 2014 at 10:32:24AM +0300, Matti Vaittinen wrote:
> > ---
>
> Here. Otherwise, it'll get included in the commit message, which I
> don't think was your intention.
O
d and let the driver to choose the defaults? But yes, I have
no problem with inverting the default to be diode-connected.
Then one question regarding the "process". Now if I cook up fourth patch
with inverted diode-connected default for ds1339, should I collect new
acks for this new patch
DS13XX devices have "trickle chargers". Introduce a device tree binding
for specifying the trickle charger configuration for ds1339.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/i2c/trivial-devices.txt| 1 -
.../devicetree/bindings/rtc/dallas,ds1339.txt | 18 +
ome DS13XX devices have "trickle chargers". Introduce a device tree binding
for specifying the trickle charger configuration for ds1339.
Note that the patch _only_ iplements device tree bindings to ds1339
chip because I only had access to that specific chip.
Signed-off
'; I was under the impression that this
> > described whether or not there was an external diode. Perhaps I've
> > misunderstood?
>
> iiuc from the link ds1339 ds, the register configuration is enabling
> internal diodes and resistors for the trickle charge configurat
On Fri, Aug 29, 2014 at 11:40:02AM +0100, ext Mark Rutland wrote:
> On Fri, Aug 29, 2014 at 08:34:25AM +0100, Matti Vaittinen wrote:
> > On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote:
> > > On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote:
>
rgers". Introduce a device tree binding
for specifying the trickle charger setup value.
Signed-off-by: Matti Vaittinen
---
.../devicetree/bindings/i2c/trivial-devices.txt| 1 -
.../devicetree/bindings/rtc/dallas,ds1339.txt | 24 ++
drivers/rtc/rt
; > On Thu, Aug 28, 2014 at 04:51:57PM +0100, Guenter Roeck wrote:
> > > > > On Thu, Aug 28, 2014 at 01:59:15PM +0100, Mark Rutland wrote:
> > > > > > On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote:
> > > > > > >
On Thu, Aug 28, 2014 at 01:59:15PM +0100, ext Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote:
> > Patch adding support for specifying trickle charger setup from device
> > tree. Patch is based on linux-next tree.
> >
> >
&
Patch adding support for specifying trickle charger setup from device
tree. Patch is based on linux-next tree.
Some DS13XX devices have "trickle chargers". Introduce a device tree binding
for specifying the setup and register values.
Signed-off-by: Matti Vaittinen
---
.../devicetre
16 matches
Mail list logo
