Re: [PATCH] st33zp24 fix when using irq mode

2015-03-19 Thread Peter Hüwe
Hi, great timing :) I just sent the pull request for 4.1 out yesterday :) But thanks for spotting and fixing it. Found bugs are good bugs, and fixed ones are even better. Am Donnerstag, 19. März 2015, 22:15:08 schrieb Christophe Ricard: > Hi, > > Please find in this patch a fix that fix an impr

Re: [PATCH v8 0/4] st33zp24 new architecture proposal and st33zp24 spi driver

2015-03-14 Thread Peter Hüwe
Hi Christophe, > Do you see any issue with this patch series to hit kernel revision 4.1 ? sorry for the delay. No I think v8 is fine (hey it's already v8 ;-)) I added it to my tree (for-james) and will include it in the next pull request which will be sent in a few days. Thanks for your patche

Re: [PATCH v7 0/4] st33zp24 new architecture proposal and st33zp24 spi driver

2015-02-10 Thread Peter Hüwe
Hi Christophe, > > Any news on this patchset ? > > Unfortunately not - I'm still lacking behind due to a big cold I caught. I'll add it once I pushed the fixes for 3.20 out. (still waiting on vicky's fixed patchset) Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree"

Re: [PATCH v4 3/4] tpm/st33zp24/spi: Add st33zp24 spi phy

2015-01-26 Thread Peter Hüwe
Am Sonntag, 25. Januar 2015, 22:11:32 schrieb Christophe Ricard: > st33zp24 TIS 1.2 support also SPI. It is using a proprietary protocol to > transport TIS data. > > Reviewed-by: Jason Gunthorpe > Signed-off-by: Christophe Ricard > --- > drivers/char/tpm/st33zp24/Kconfig | 10 + > drivers/cha

Re: [PATCH v4 2/4] tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)

2015-01-26 Thread Peter Hüwe
Hi Christophe, some superficial (and picky) reviews below - in general I like it. Peter Am Sonntag, 25. Januar 2015, 22:11:31 schrieb Christophe Ricard: > tpm_i2c_stm_st33 is a TIS 1.2 TPM with a core interface which can be used > by different phy such as i2c or spi. The core part is called st33

Re: [PATCH v4 1/4] tpm/tpm_i2c_stm_st33: Replace access to io_lpcpd from struct st33zp24_platform_data to tpm_stm_dev

2015-01-26 Thread Peter Hüwe
Hi Christophe, Am Sonntag, 25. Januar 2015, 22:11:30 schrieb Christophe Ricard: > io_lpcpd is accessible from struct tpm_stm_dev. > struct st33zp24_platform_data is only valid when using static platform > configuration data, not when using dts. > > Reviewed-by: Jason Gunthorpe > Signed-off-by: Ch

Re: [PATCH v4 0/4] st33zp24 new architecture proposal and st33zp24 spi driver

2015-01-26 Thread Peter Hüwe
Hi Christophe, Am Sonntag, 25. Januar 2015, 22:11:29 schrieb Christophe Ricard: > Hi, > > The following patchset: > - propose a new architecture allowing to share a core st33zp24 data > management layer with different phy (i2c & spi). For st33zp24 both phy > have a proprietary transport protocol.

Re: [PATCH v3 0/4] st33zp24 new architecture proposal and st33zp24 spi driver

2015-01-25 Thread Peter Hüwe
Am Sonntag, 25. Januar 2015, 16:34:53 schrieb Christophe Ricard: > Hi, > > The following patchset: > - propose a new architecture allowing to share a core st33zp24 data > management layer with different phy (i2c & spi). For st33zp24 both phy > have a proprietary transport protocol. Both are relyin

Re: [PATCH v2 00/10] st33zp24 new architecture proposal and st33zp24 spi driver

2015-01-17 Thread Peter Hüwe
Am Dienstag, 13. Januar 2015, 23:13:08 schrieb Christophe Ricard: > Hi, > > The following patchset: > - clean the current tpm_i2c_stm_st33 driver > - propose a new architecture allowing to share a core st33zp24 data > management layer with different phy (i2c & spi). For st33zp24 both phy > have a

Re: [PATCH v2 04/10] tpm/tpm_i2c_stm_st33: Replace access to io_lpcpd from struct st33zp24_platform_data to tpm_stm_dev

2015-01-17 Thread Peter Hüwe
Am Dienstag, 13. Januar 2015, 23:13:12 schrieb Christophe Ricard: > io_lpcpd is accessible from struct tpm_stm_dev. > struct st33zp24_platform_data is only valid when using static platform > configuration data, not when using dts. > > Reviewed-by: Jasob Gunthorpe > Signed-off-by: Christophe Ricar

Re: [PATCH v2 08/10] tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)

2015-01-17 Thread Peter Hüwe
Am Dienstag, 13. Januar 2015, 23:13:16 schrieb Christophe Ricard: > tpm_i2c_stm_st33 is a TIS 1.2 TPM with a core interface which can be used > by different phy such as i2c or spi. The core part is called st33zp24 which > is also the main part reference. > > include/linux/platform_data/tpm_stm_st3

Re: [PATCH v2 09/10] tpm/st33zp24/spi: Add st33zp24 spi phy

2015-01-17 Thread Peter Hüwe
Am Dienstag, 13. Januar 2015, 23:13:17 schrieb Christophe Ricard: > st33zp24 TIS 1.2 support also SPI. It is using a proprietary protocol to > transport TIS data. > > Reviewed-by: Jasob Gunthorpe > Signed-off-by: Christophe Ricard > + > +MODULE_AUTHOR("Christophe Ricard (tpmsupp...@st.com)"); >

Re: [PATCH v2 00/10] st33zp24 new architecture proposal and st33zp24 spi driver

2015-01-17 Thread Peter Hüwe
Hi, > v2 takes into account feedbacks from Jason Gunthorpe. On most patches you have written jaso_b_ instead of jason ... I'll fix this. And for some kind of reason not every patch shows up in patchwork like 1/10 - I'll have to investigate this. Peter -- To unsubscribe from this list: send th

Re: [PATCH v2 10/10] tpm/st33zp24/dts/st33zp24-spi: Add dts documentation for st33zp24 spi phy

2015-01-17 Thread Peter Hüwe
Am Dienstag, 13. Januar 2015, 23:13:18 schrieb Christophe Ricard: > +Example (for ARM-based BeagleBoard xM with ST33ZP24 on SPI2): > + > +&i2c2 { ^^^ I2C for SPI?! Doubt this is correct :) > + > +status = "okay"; > + > +st33zp24@0 { > + Peter -- To unsubscribe from this list

Re: [PATCH v6 00/15] ST33 I2C TPM driver cleanup

2014-12-01 Thread Peter Hüwe
Am Montag, 1. Dezember 2014, 19:32:45 schrieb Christophe Ricard: > Hi Peter, > > I have seen one mistake done during the rebase on v5 on patch > 0010-tpm-tpm_i2c_stm_st33-Add-devicetree-structure. > ~~ Please discard v5. ~~ > > This new patchset version is taking into account as much as possible

Re: [PATCH v4 00/15] ST33 I2C TPM driver cleanup

2014-11-30 Thread Peter Hüwe
Hi Christophe, > Thank you for your feedback (on Sunday :)). > > To be honest i missed those warnings. I figured they come when CONFIG_OF > is not set :/. > > No problem to send a v5 with tpm/tpm_i2c_stm_st33: Fix potential bug in > tpm_stm_i2c_send and replace r by ret. The purpose here was mor

Re: [PATCH v4 00/15] ST33 I2C TPM driver cleanup

2014-11-30 Thread Peter Hüwe
Hi Christophe, sorry for the late reply :/ > This new patchset version is taking into account as much as possible > Jason Gunthorpe feedbacks. I hope, i am not missing any. > > It still brings: > - Some few code clean up from code style up to structure > - Device tree support keeping static pla

Re: [PATCH v4 09/15] tpm/tpm_i2c_stm_st33/dts/st33zp24_i2c: Add DTS Documentation

2014-11-30 Thread Peter Hüwe
Hi, can I get an ACK from the device tree gurus? Am Sonntag, 19. Oktober 2014, 23:11:19 schrieb Christophe Ricard: > st33zp24 tpm can be seen as a trivial i2c device as other i2c tpm. > However several other properties needs to be documented such as lpcpd. > > Reviewed-By: Jason Gunthorpe > Sig

Re: [PATCH 00/16] ST33 I2C TPM driver cleanup

2014-10-07 Thread Peter Hüwe
Hi Christophe, Am Dienstag, 7. Oktober 2014, 22:02:53 schrieb Christophe Ricard: > Hi Peter, > > The following patchset brings: > - Some few code clean up from code style up to structure > - Device tree support keeping static platform data configuration support. > - Fix irq support. > - Update t