Re: [linux-sunxi] Re: [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support

2015-10-27 Thread Peter Korsgaard
c configuration isn't critical to get something running. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs

2015-09-17 Thread Peter Korsgaard
list_for_each_entry(rng, &rng_list, list) { > -if (strcmp(rng->name, buf) == 0) { > + if (sysfs_streq(rng->name, buf)) { Looks good. Acked-by: Peter Korsgaard -- Venlig hilsen, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 2/6] hwrng: core: Simplify RNG switching from sysfs

2015-09-13 Thread Peter Korsgaard
t; err = -ENODEV; > list_for_each_entry(rng, &rng_list, list) { > -if (strcmp(rng->name, buf) == 0) { > + > +if (buf[len-1] == '\n') > +snip = 1; /* Snip one character */ > + How about using sysfs_streq() instead, which is

Re: [PATCH 7/8] gpio/mpc8xxx: Convert to platform device interface.

2015-01-20 Thread Peter Korsgaard
; otherwise continue. Indeed - Sorry, I must have been confused yesterday. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/8] gpio/mpc8xxx: Convert to platform device interface.

2015-01-19 Thread Peter Korsgaard
>>>>> "Ricardo" == Ricardo Ribalda Delgado writes: > This way we do not need to transverse the device tree manually. > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Grant Likely > Cc: Rob Herring > Cc: Peter Korsgaard > Cc: device

Re: [PATCH 7/8] gpio/mpc8xxx: Convert to platform device interface.

2015-01-19 Thread Peter Korsgaard
>>>>> "Ricardo" == Ricardo Ribalda Delgado writes: > This way we do not need to transverse the device tree manually. > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Grant Likely > Cc: Rob Herring > Cc: Peter Korsgaard > Cc: device

Re: [PATCH 4/6] hwrng: atmel: Add TRNG DT binding doc

2014-09-30 Thread Peter Korsgaard
der to wait for data as > requested by hwrng code when the wait argument is true). > Thus I prefer to keep it as required. Ok, fine by me. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.k

Re: [PATCH 4/6] hwrng: atmel: Add TRNG DT binding doc

2014-09-30 Thread Peter Korsgaard
h of the register set of this block > +- interrupts : the interrupt number for the TRNG block The interrupt isn't strictly speaking required as it isn't used by the driver, but as 9G45 has the signal wired up I guess it makes sense. Acked-by: Peter Korsgaard -- Bye, Peter Kor

Re: [PATCH 3/6] hwrng: atmel: add DT support

2014-09-30 Thread Peter Korsgaard
>>>>> "Boris" == Boris Brezillon writes: > Add DT support. > Make the driver depend on CONFIG_OF as at91sam9g45 was the only SoC making > use of the TRNG block and this SoC is now fully migrated to DT. > Signed-off-by: Boris Brezillon Acked-by: Peter

Re: [PATCH 2/6] hwrng: atmel: use clk_prepapre_enable/_disable_unprepare

2014-09-30 Thread Peter Korsgaard
>>>>> "Boris" == Boris Brezillon writes: > Use clk_prepapre_enable/_disable_unprepare instead of clk_enable/disable > to work properly with the CCF. s/prepapre/prepare/ Other than that, looks fine to me. Acked-by: Peter Korsgaard > Signed-off-by: Boris