Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5

2015-10-20 Thread Rob Clark
On Mon, Oct 19, 2015 at 1:49 AM, Archit Taneja wrote: > > On 10/18/2015 08:49 AM, Bjorn Andersson wrote: >> >> On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja >> wrote: >>> >>> MDP5 has a different compatible string (which causes checkpatch warnings

Re: [GIT PULL] On-demand device probing

2015-10-17 Thread Rob Clark
On Sat, Oct 17, 2015 at 12:56 PM, Greg Kroah-Hartman wrote: >> I'm guessing the time is a matter of probing and undoing the probes >> rather than slow h/w. We could maybe improve things by making sure >> drivers move what they defer on to the beginning of probe, but

Re: [GIT PULL] On-demand device probing

2015-10-17 Thread Rob Clark
On Sat, Oct 17, 2015 at 2:27 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Sat, Oct 17, 2015 at 01:54:43PM -0400, Rob Clark wrote: >> On Sat, Oct 17, 2015 at 12:56 PM, Greg Kroah-Hartman >> <gre...@linuxfoundation.org> wrote: >> >> I'm g

Re: [GIT PULL] On-demand device probing

2015-10-17 Thread Rob Clark
On Sat, Oct 17, 2015 at 2:59 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Sat, Oct 17, 2015 at 02:45:34PM -0400, Rob Clark wrote: >> On Sat, Oct 17, 2015 at 2:27 PM, Greg Kroah-Hartman >> <gre...@linuxfoundation.org> wrote: >> > On Sat, O

Re: [GIT PULL] On-demand device probing

2015-10-17 Thread Rob Clark
On Sat, Oct 17, 2015 at 3:04 PM, Noralf Trønnes <nor...@tronnes.org> wrote: > > Den 17.10.2015 20:45, skrev Rob Clark: >> >> On Sat, Oct 17, 2015 at 2:27 PM, Greg Kroah-Hartman >> <gre...@linuxfoundation.org> wrote: >>> >>> On

Re: [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev

2015-09-17 Thread Rob Clark
On Wed, Sep 16, 2015 at 5:48 AM, Xinliang Liu wrote: > > > On 16 September 2015 at 02:25, Rob Herring wrote: > Hi Rob, thanks a lot for reply:-) > >> On 09/15/2015 04:37 AM, Xinwei Kong wrote: >> > If you config DRM_HISI_FBDEV optional, this patch will

Re: [PATCH 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-08-25 Thread Rob Clark
On Mon, Aug 24, 2015 at 9:47 AM, Rob Herring robherri...@gmail.com wrote: On Mon, Aug 17, 2015 at 1:30 PM, Eric Anholt e...@anholt.net wrote: Stephen Warren swar...@wwwdotorg.org writes: On 08/12/2015 06:56 PM, Eric Anholt wrote: Signed-off-by: Eric Anholt e...@anholt.net This one

Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties.

2015-08-10 Thread Rob Clark
On Mon, Aug 10, 2015 at 6:27 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: On Mon 10 Aug 15:07 PDT 2015, Rob Herring wrote: [..] -- qcom,hdmi-tx-ddc-clk-gpio: ddc clk pin -- qcom,hdmi-tx-ddc-data-gpio: ddc data pin -- qcom,hdmi-tx-hpd-gpio: hpd pin +-

Re: [PATCH v1 7/7] ARM: dts: ifc6410: add inforce LVDS panel support

2015-08-10 Thread Rob Clark
On Mon, Aug 10, 2015 at 7:25 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: On Tue 28 Jul 05:54 PDT 2015, Srinivas Kandagatla wrote: This patch adds LVDS panel for IFC6410. My ifc6410 doesn't have a LVDS display, so I don't think these nodes belong in this dts file. fwiw, my

Re: [PATCH v1 4/7] ARM: dts: apq8064: Add MDP support

2015-08-06 Thread Rob Clark
On Wed, Aug 5, 2015 at 9:27 PM, Stephen Boyd sb...@codeaurora.org wrote: On 07/28/2015 05:54 AM, Srinivas Kandagatla wrote: @@ -618,5 +633,77 @@ compatible = qcom,tcsr-apq8064, syscon; reg = 0x1a40 0x100; }; + +

Re: [PATCH v1 4/7] ARM: dts: apq8064: Add MDP support

2015-07-28 Thread Rob Clark
On Tue, Jul 28, 2015 at 1:31 PM, Andreas Färber afaer...@suse.de wrote: Hi, Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla: From: Rob Clark robdcl...@gmail.com This patch adds MDP node to APQ8064 dt. Signed-off-by: Rob Clark robdcl...@gmail.com [Srinivas Kandagatla] : updated with new

Re: [PATCH v1 7/7] ARM: dts: ifc6410: add inforce LVDS panel support

2015-07-28 Thread Rob Clark
On Tue, Jul 28, 2015 at 1:50 PM, Andreas Färber afaer...@suse.de wrote: Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla: This patch adds LVDS panel for IFC6410. Signed-off-by: Rob Clark robdcl...@gmail.com [Rob Clark: WIP patch] Signed-off-by: Srinivas Kandagatla srinivas.kandaga

Re: [PATCH] backlight: pm8941-wled: Add default-brightness property

2015-07-24 Thread Rob Clark
On Fri, Jul 24, 2015 at 11:39 AM, Rob Herring robherri...@gmail.com wrote: On Fri, Jul 24, 2015 at 8:10 AM, Rob Clark robdcl...@gmail.com wrote: On Thu, Jul 23, 2015 at 3:52 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Add the possibility of specifying the default brightness in DT

Re: [PATCH] backlight: pm8941-wled: Add default-brightness property

2015-07-24 Thread Rob Clark
On Thu, Jul 23, 2015 at 3:52 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Add the possibility of specifying the default brightness in DT. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- This depends on the patch moving pm8941-wled to backlight [1]. The dt

Re: [PATCH] backlight: pm8941-wled: Move PM8941 WLED driver to backlight

2015-07-21 Thread Rob Clark
-by: Bjorn Andersson bjorn.anders...@sonymobile.com Tested-by: Rob Clark robdcl...@gmail.com (also on a z3, with work-in-progress panel driver for the AUO panel + drm/msm) BR, -R --- .../devicetree/bindings/leds/leds-pm8941-wled.txt | 5 +- drivers/leds/Kconfig

Re: [PATCH 00/21] On-demand device registration

2015-06-03 Thread Rob Clark
On Mon, May 25, 2015 at 10:53 AM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: Hello, I have a problem with the panel on my Tegra Chromebook taking longer than expected to be ready during boot (Stéphane Marchesin reported what is basically the same issue in [0]), and have looked into

Re: [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs

2015-04-16 Thread Rob Clark
On Thu, Apr 16, 2015 at 11:21 AM, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Apr 15, 2015 at 11:01:17AM -0400, Rob Clark wrote: On Wed, Apr 15, 2015 at 9:34 AM, Catalin Marinas catalin.mari...@arm.com wrote: On Tue, Apr 14, 2015 at 05:48:48PM -0400, Rob Clark wrote: Just

Re: [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs

2015-04-15 Thread Rob Clark
On Wed, Apr 15, 2015 at 9:34 AM, Catalin Marinas catalin.mari...@arm.com wrote: On Tue, Apr 14, 2015 at 05:48:48PM -0400, Rob Clark wrote: Just speaking as an outsider to this topic, but seems like most/all tablets/phones/etc ship with signed firmware. Which means for most of the population

Re: [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 5:17 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Tue, Apr 14, 2015 at 02:49:04PM -0500, Kumar Gala wrote: On Apr 14, 2015, at 11:36 AM, Mark Rutland mark.rutl...@arm.com wrote: On Fri, Apr 10, 2015 at 11:05:29AM +0100, Catalin Marinas wrote: On Thu, Apr 09,

Re: [PATCH v2 06/12] ARM: dts: apq8064: Add MDP support

2015-04-10 Thread Rob Clark
On Fri, Apr 10, 2015 at 4:21 PM, Stephen Boyd sb...@codeaurora.org wrote: That's true, These are existing bindings, so I can't change it as part of this patch, However I will make another patch to fix this in both drivers and DT for good reasons. Just noticed that bindings are not consistent

Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id

2015-03-10 Thread Rob Clark
On Tue, Mar 10, 2015 at 3:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:10:08 Kumar Gala wrote: The top level qcom,msm-id and qcom,board-id are utilized by bootloaders on Qualcomm MSM platforms to determine which device tree should be utilized and passed to the

Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id

2015-03-05 Thread Rob Clark
On Thu, Mar 5, 2015 at 8:59 PM, Olof Johansson o...@lixom.net wrote: On Thu, Mar 5, 2015 at 12:23 PM, Kumar Gala ga...@codeaurora.org wrote: On Mar 5, 2015, at 1:42 PM, Kevin Hilman khil...@kernel.org wrote: Kumar Gala ga...@codeaurora.org writes: The top level qcom,msm-id and qcom,board-id

Re: [PATCH 03/14] drm/bridge: make bridge registration independent of drm flow

2015-01-30 Thread Rob Clark
On Tue, Jan 20, 2015 at 11:38 AM, Ajay Kumar ajaykumar...@samsung.com wrote: Currently, third party bridge drivers(ptn3460) are dependent on the corresponding encoder driver init, since bridge driver needs a drm_device pointer to finish drm initializations. The encoder driver passes the

Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs

2014-11-27 Thread Rob Clark
On Thu, Nov 27, 2014 at 4:56 PM, Arnd Bergmann a...@arndb.de wrote: On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: On Thu, Nov 27, 2014 at 2:08 AM, Mark yao mark@rock-chips.com wrote: On 2014年11月27日 10:12, Dave Airlie wrote: Hi Dave Do you mean that I need send

Re: [PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support

2014-09-27 Thread Rob Clark
On Sat, Sep 27, 2014 at 4:12 PM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: +static int atmel_hlcdc_rgb_mode_valid(struct drm_connector *connector, + struct drm_display_mode *mode) +{ + return MODE_OK; +} your _mode_valid()

Re: [PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support

2014-09-26 Thread Rob Clark
BREZILLON boris.brezil...@free-electrons.com Tested-by: Ludovic Desroches ludovic.desroc...@atmel.com A few small comments below, but with those addressed it has my Reviewed-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Rob Clark
On Tue, Sep 23, 2014 at 10:12 PM, Mark yao mark@rock-chips.com wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com Looks like my comments are addressed, so: Reviewed-by: Rob Clark robdcl...@gmail.com --- Changes

Re: [PATCH v5 00/11] drm: add support for Atmel HLCDC Display Controller

2014-09-25 Thread Rob Clark
On Mon, Sep 8, 2014 at 4:43 AM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hello, This patch series adds support for Atmel HLCDC (HLCD Controller) available on some Atmel SoCs (i.e. the sama5d3 family). The HLCDC actually provides a Display Controller and a PWM device, hence I

Re: [PATCH v4 5/5] drm/rockchip: Add support for Rockchip Soc EDP

2014-09-23 Thread Rob Clark
On Tue, Sep 23, 2014 at 4:47 AM, cym c...@rock-chips.com wrote: On Tuesday, September 23, 2014 03:20 AM, Rob Clark wrote: On Mon, Sep 22, 2014 at 7:02 AM, Mark yao mark@rock-chips.com wrote: This adds support for Rockchip soc edp found on rk3288 Signed-off-by: Mark Yao mark@rock

Re: [PATCH v4 5/5] drm/rockchip: Add support for Rockchip Soc EDP

2014-09-23 Thread Rob Clark
On Tue, Sep 23, 2014 at 9:56 AM, Rob Clark robdcl...@gmail.com wrote: On Tue, Sep 23, 2014 at 4:47 AM, cym c...@rock-chips.com wrote: On Tuesday, September 23, 2014 03:20 AM, Rob Clark wrote: On Mon, Sep 22, 2014 at 7:02 AM, Mark yao mark@rock-chips.com wrote: This adds support

Re: [PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Rob Clark
Vetter - init cursor plane with universal api, remove unnecessary cursor set,move Changes in v4: Adviced by David Herrmann - remove drm_platform_*() usage, use register drm device directly. Adviced by Rob Clark - remove special mmap ioctl, do userspace mmap with normal mmap() or mmap

Re: [PATCH v4 5/5] drm/rockchip: Add support for Rockchip Soc EDP

2014-09-22 Thread Rob Clark
On Mon, Sep 22, 2014 at 7:02 AM, Mark yao mark@rock-chips.com wrote: This adds support for Rockchip soc edp found on rk3288 Signed-off-by: Mark Yao mark@rock-chips.com Signed-off-by: Jeff Chen jeff.c...@rock-chips.com --- Changes in v2: - fix code sytle - use some define from

Re: [RFCv2] drm/msm: DT support for 8960/8064

2014-07-17 Thread Rob Clark
On Thu, Jul 17, 2014 at 4:10 AM, divya ojha odivy...@gmail.com wrote: Hi Rob, On Tue, Jul 8, 2014 at 9:30 PM, Rob Clark robdcl...@gmail.com wrote: Now that we (almost) have enough dependencies in place (MMCC, RPM, etc), add necessary DT support so that we can use drm/msm on upstream kernel

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-16 Thread Rob Clark
On Tue, Jul 15, 2014 at 9:25 PM, Olav Haugan ohau...@codeaurora.org wrote: On 7/13/2014 4:43 AM, Rob Clark wrote: On Sun, Jul 13, 2014 at 5:43 AM, Will Deacon will.dea...@arm.com wrote: On Sat, Jul 12, 2014 at 01:57:31PM +0100, Rob Clark wrote: On Sat, Jul 12, 2014 at 8:22 AM, Arnd Bergmann

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-14 Thread Rob Clark
On Mon, Jul 14, 2014 at 2:24 AM, Thierry Reding thierry.red...@gmail.com wrote: On Sat, Jul 12, 2014 at 08:57:31AM -0400, Rob Clark wrote: On Sat, Jul 12, 2014 at 8:22 AM, Arnd Bergmann a...@arndb.de wrote: [...] The way that Thierry's binding does that is the obvious solution

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-13 Thread Rob Clark
On Sun, Jul 13, 2014 at 5:43 AM, Will Deacon will.dea...@arm.com wrote: On Sat, Jul 12, 2014 at 01:57:31PM +0100, Rob Clark wrote: On Sat, Jul 12, 2014 at 8:22 AM, Arnd Bergmann a...@arndb.de wrote: On Saturday 12 July 2014, Rob Clark wrote: Was there actually a good reason for having

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-12 Thread Rob Clark
On Sat, Jul 12, 2014 at 5:39 AM, Will Deacon will.dea...@arm.com wrote: Hi Rob, On Fri, Jul 11, 2014 at 09:55:14PM +0100, Rob Clark wrote: On Fri, Jul 4, 2014 at 11:29 AM, Thierry Reding thierry.red...@gmail.com wrote: From: Thierry Reding tred...@nvidia.com ok, so I was working through

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-12 Thread Rob Clark
On Sat, Jul 12, 2014 at 8:22 AM, Arnd Bergmann a...@arndb.de wrote: On Saturday 12 July 2014, Rob Clark wrote: Was there actually a good reason for having the device link to the iommu rather than the other way around? How much would people hate it if I just ignore the generic bindings

Re: [RESEND PATCH v3 05/11] drm: add Atmel HLCDC Display Controller support

2014-07-12 Thread Rob Clark
On Sat, Jul 12, 2014 at 2:16 PM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hello, On Mon, 7 Jul 2014 18:42:58 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: +int atmel_hlcdc_layer_disable(struct atmel_hlcdc_layer *layer) +{ + struct

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-11 Thread Rob Clark
On Fri, Jul 4, 2014 at 11:29 AM, Thierry Reding thierry.red...@gmail.com wrote: From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the

[RFCv2] drm/msm: DT support for 8960/8064

2014-07-08 Thread Rob Clark
Now that we (almost) have enough dependencies in place (MMCC, RPM, etc), add necessary DT support so that we can use drm/msm on upstream kernel. Signed-off-by: Rob Clark robdcl...@gmail.com --- I thought I sent this already, but looks like I've forgot. I've updated the names for the GPIO

Re: [RFC] drm/msm: DT support for 8960/8064

2014-07-03 Thread Rob Clark
On Thu, Jul 3, 2014 at 5:15 AM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Jul 02, 2014 at 10:01:40PM +0100, Rob Clark wrote: On Wed, Jul 2, 2014 at 2:09 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Jul 01, 2014 at 07:57:35PM +0100, Rob Clark wrote: Now that we (almost) have

Re: [RFC] drm/msm: DT support for 8960/8064

2014-07-03 Thread Rob Clark
On Thu, Jul 3, 2014 at 12:36 PM, sv...@codeaurora.org wrote: Hi Rob, Now that we (almost) have enough dependencies in place (MMCC, RPM, etc), add necessary DT support so that we can use drm/msm on upstream kernel. Signed-off-by: Rob Clark robdcl...@gmail.com --- Commence bikeshedding

Re: [RFC] drm/msm: DT support for 8960/8064

2014-07-02 Thread Rob Clark
On Wed, Jul 2, 2014 at 10:26 AM, Jordan Crouse jcro...@codeaurora.org wrote: On 07/01/2014 12:57 PM, Rob Clark wrote: diff --git a/Documentation/devicetree/bindings/drm/msm/gpu.txt b/Documentation/devicetree/bindings/drm/msm/gpu.txt new file mode 100644 index 000..6e33efe --- /dev

Re: [RFC] drm/msm: DT support for 8960/8064

2014-07-02 Thread Rob Clark
On Wed, Jul 2, 2014 at 1:12 PM, Olof Johansson o...@lixom.net wrote: On Wed, Jul 2, 2014 at 7:26 AM, Jordan Crouse jcro...@codeaurora.org wrote: On 07/01/2014 12:57 PM, Rob Clark wrote: diff --git a/Documentation/devicetree/bindings/drm/msm/gpu.txt b/Documentation/devicetree/bindings/drm/msm

Re: [RFC] drm/msm: DT support for 8960/8064

2014-07-02 Thread Rob Clark
On Wed, Jul 2, 2014 at 2:09 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Jul 01, 2014 at 07:57:35PM +0100, Rob Clark wrote: Now that we (almost) have enough dependencies in place (MMCC, RPM, etc), add necessary DT support so that we can use drm/msm on upstream kernel. Signed-off

[RFC] drm/msm: DT support for 8960/8064

2014-07-01 Thread Rob Clark
Now that we (almost) have enough dependencies in place (MMCC, RPM, etc), add necessary DT support so that we can use drm/msm on upstream kernel. Signed-off-by: Rob Clark robdcl...@gmail.com --- Commence bikeshedding :-) Documentation/devicetree/bindings/drm/msm/gpu.txt | 51

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Rob Clark
On Thu, Feb 27, 2014 at 8:00 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote: For the i.MX6 display subsystem there is no clear single master device, and the physical configuration changes across the SoC family. The

Re: ARM topic: Is DT on ARM the solution, or is there something better?

2013-10-24 Thread Rob Clark
On Thu, Oct 24, 2013 at 3:28 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Wed, Oct 23, 2013 at 09:14:17PM -0400, Rob Clark wrote: On Mon, Oct 21, 2013 at 5:27 AM, Sascha Hauer s.ha...@pengutronix.de wrote: If a subsystem doesn't work well with DT, then the choices are either

Re: ARM topic: Is DT on ARM the solution, or is there something better?

2013-10-23 Thread Rob Clark
On Mon, Oct 21, 2013 at 5:27 AM, Sascha Hauer s.ha...@pengutronix.de wrote: If a subsystem doesn't work well with DT, then the choices are either: (a) don't use DT with the subsystem The underlying problem has nothing to do with DT. Multi component hardware does exist and won't vanish when