[PATCH] arm64/dts: Add missing DMA Abort interrupt to Juno

2016-01-07 Thread Robin Murphy
leaving it locked up and waiting to time out. CC: Liviu Dudau <liviu.du...@arm.com> CC: Sudeep Holla <sudeep.ho...@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: Robin Murphy <robin.mur...@arm.com> --- arch/arm64/boot/dts/arm/juno-base.dtsi | 1 + 1 fil

Re: [PATCH v7 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-18 Thread Robin Murphy
On 18/12/15 08:09, Yong Wu wrote: This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu --- drivers/iommu/Kconfig | 14 + drivers/iommu/Makefile| 1 + drivers/iommu/mtk_iommu.c | 734

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Robin Murphy
On 16/12/15 05:59, Yong Wu wrote: On Tue, 2015-12-15 at 12:37 +, Robin Murphy wrote: On 15/12/15 03:28, Yong Wu wrote: On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: +static int mtk_iommu_attach_device(struct iommu_domain

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-15 Thread Robin Murphy
On 15/12/15 03:28, Yong Wu wrote: On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: +static int mtk_iommu_attach_device(struct iommu_domain *domain, + struct device *dev) +{ + struct

Re: [PATCH v5 2/4] drm: Add support for ARM's HDLCD controller.

2015-12-10 Thread Robin Murphy
On 08/12/15 16:52, Liviu Dudau wrote: On Tue, Dec 08, 2015 at 04:25:27PM +, Robin Murphy wrote: Hi Liviu, On 07/12/15 12:11, Liviu Dudau wrote: The HDLCD controller is a display controller that supports resolutions up to 4096x4096 pixels. It is present on various development boards

Re: [PATCH v5 2/4] drm: Add support for ARM's HDLCD controller.

2015-12-08 Thread Robin Murphy
<airl...@linux.ie> > Cc: Robin Murphy <robin.mur...@arm.com> I've given this a spin on my Juno, and the first thing of note is this: hdlcd 7ff6.hdlcd: master bind failed: -517 hdlcd 7ff5.hdlcd: master bind failed: -517 scpi_protocol scpi: SCP Protocol 1.0 Firmware 1.9.0 ve

Re: Preprocessor arithmetic in dtsi files (base + offset)

2015-11-26 Thread Robin Murphy
On 26/11/15 16:23, Geert Uytterhoeven wrote: [...] I guess this would work, too? scu_container@2000 { compatible = "simple-bus"; ranges = <0x0 0x2000 0x1>; #address-cells = <1>; #size-cells = <1>; scu: scu@0 {

Re: [PATCH v5 4/6] memory: mediatek: Add SMI driver

2015-10-27 Thread Robin Murphy
On 09/10/15 03:23, Yong Wu wrote: [...] +static int mtk_smi_probe(struct platform_device *pdev) +{ + struct device *dev = >dev; + struct mtk_smi_data *smidata; + int ret; + + if (!dev->pm_domain) + return -EPROBE_DEFER; + + smidata = devm_kzalloc(dev,

Re: [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-10-27 Thread Robin Murphy
On 09/10/15 03:23, Yong Wu wrote: [...] +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include Nit: ordering? +#include +#include "io-pgtable.h" [...] +struct mtk_iommu_data { + void __iomem

Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform

2015-10-20 Thread Robin Murphy
On 20/10/15 09:45, Chen Feng wrote: iommu/hisilicon: Add hi6220-SoC smmu driver A brief description of the smmu and what capabilities it provides wouldn't go amiss here. Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin ---

Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table allocator.

2015-10-09 Thread Robin Murphy
On 09/10/15 16:57, Will Deacon wrote: On Tue, Sep 22, 2015 at 03:12:47PM +0100, Yong Wu wrote: I would like to show you a problem I met, The recursion here may lead to stack overflow while we test FHD video decode. From the log, I get the internal variable in the error case: the

Re: [PATCH v2 3/3] irqchip/gicv3-its: Handle OF device tree "msi-map" properties.

2015-09-23 Thread Robin Murphy
On 23/09/15 19:18, Marc Zyngier wrote: On Wed, 23 Sep 2015 18:52:59 +0100 Will Deacon wrote: On Wed, Sep 23, 2015 at 06:08:39PM +0100, David Daney wrote: On 09/23/2015 10:01 AM, Marc Zyngier wrote: On Tue, 22 Sep 2015 17:00:06 -0700 David Daney

Re: [PATCH v4 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-09-11 Thread Robin Murphy
On 03/08/15 11:21, Yong Wu wrote: This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu --- [...] +/* + * There is only one iommu domain called the m4u domain that + * all Multimedia modules share. + */ +static struct

Re: [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-07-27 Thread Robin Murphy
On 16/07/15 10:04, Yong Wu wrote: This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu yong...@mediatek.com [...] +static void mtk_iommu_flush_pgtable(void *ptr, size_t size, void *cookie) +{ + struct mtk_iommu_domain *domain = cookie; +

Re: [PATCH v3 3/6] iommu: add ARM short descriptor page table allocator.

2015-07-27 Thread Robin Murphy
On 27/07/15 05:21, Yong Wu wrote: [...] +static arm_short_iopte +__arm_short_pte_prot(struct arm_short_io_pgtable *data, int prot, bool large) +{ + arm_short_iopte pteprot; + + pteprot = ARM_SHORT_PTE_S | ARM_SHORT_PTE_nG; + pteprot |= large ? ARM_SHORT_PTE_TYPE_LARGE : +

Re: [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-07-27 Thread Robin Murphy
On 27/07/15 16:31, Russell King - ARM Linux wrote: On Mon, Jul 27, 2015 at 02:23:26PM +0100, Robin Murphy wrote: On 16/07/15 10:04, Yong Wu wrote: This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu yong...@mediatek.com [...] +static void

Re: [PATCH 3/3] Docs: dt: add PCI IOMMU map bindings

2015-07-24 Thread Robin Murphy
Hi Mark, This looks sane, and lets me describe the thing I have on my desk, so I'm happy. I have a couple of general thoughts below, but I don't intend that they should stand in the way of this proposal as-is. On 23/07/15 17:52, Mark Rutland wrote: The existing IOMMU bindings are able to

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-20 Thread Robin Murphy
On 18/03/15 11:22, Yong Wu wrote: Hi Tomasz, Thanks very much for your review. please help check below. The others I will fix in the next version. Hi Robin, There are some place I would like you can have a look and give me some suggestion. On Wed, 2015-03-11 at 19:53 +0900, Tomasz Figa

Re: [PATCH/RFC 4/4] iommu/arm-smmu: Support deferred probing

2015-02-06 Thread Robin Murphy
Hi Laura, As a heads up, I'm still vainly hoping to move the ARM SMMU driver entirely over to the generic framework - there's an iommu/dev branch on top of the iommu/dma branch I pushed earlier[1] which you might want to take a peek at to check if we're likely to end up pulling in different

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-28 Thread Robin Murphy
On 28/01/15 11:05, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote: On 01/27/2015 06:27 AM, Robin Murphy wrote: On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev-coherent_dma_mask + 1

Re: [PATCH v5 3/8] of: fix size when dma-range is not used

2015-01-28 Thread Robin Murphy
Hi Murali, [sorry, missed replying to yesterday's version] On 27/01/15 21:00, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev-coherent_dma_mask + 1 instead of dev-coherent_dma_mask. Also add code to check invalid values of size configured

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-27 Thread Robin Murphy
Hi Murali, On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev-coherent_dma_mask + 1 instead of dev-coherent_dma_mask. To detect overflow when mask is set to max of u64, add a check, log error and return. Some platform use

Re: [PATCH v4 6/6] arm: dma-mapping: updates to limit dma_mask and iommu mapping size

2015-01-27 Thread Robin Murphy
Hi Murali, On 23/01/15 22:32, Murali Karicheri wrote: Limit the dma_mask to minimum of dma_mask and dma_base + size - 1. Also arm_iommu_create_mapping() has size parameter of size_t and arm_setup_iommu_dma_ops() can take a value higher than that. So limit the size to SIZE_MAX. Signed-off-by:

[PATCH] arm64: dts: add baud rate to Juno stdout-path

2015-01-22 Thread Robin Murphy
Rutland mark.rutl...@arm.com Signed-off-by: Robin Murphy robin.mur...@arm.com --- arch/arm64/boot/dts/arm/juno.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts index cb3073e..d429129 100644 --- a/arch/arm64/boot

Re: [PATCH] of: amba: use of_dma_configure for AMBA devices

2014-09-18 Thread Robin Murphy
Thanks Catalin/Will/Rob, On 17/09/14 19:05, Will Deacon wrote: On Wed, Sep 17, 2014 at 06:47:19PM +0100, Rob Herring wrote: On Wed, Sep 17, 2014 at 12:03 PM, Will Deacon will.dea...@arm.com wrote: On Wed, Sep 17, 2014 at 12:56:07PM +0100, Robin Murphy wrote: Commit 591c1e (of: configure

[PATCH] of: amba: use of_dma_configure for AMBA devices

2014-09-17 Thread Robin Murphy
Commit 591c1e (of: configure the platform device dma parameters) introduced a common mechanism to configure DMA from DT properties. AMBA devices created from DT can take advantage of this, too. Signed-off-by: Robin Murphy robin.mur...@arm.com --- drivers/of/platform.c | 7 +++ 1 file changed