Hi Jacek,
On Mon, Jun 08, 2015 at 09:21:10AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 06/03/2015 10:59 PM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Wed, Jun 03, 2015 at 09:56:39AM +0200, Jacek Anaszewski wrote:
> >>Hi Sakari,
> >>
&
Hi Jacek,
On Wed, Jun 03, 2015 at 09:56:39AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 06/02/2015 05:32 PM, Sakari Ailus wrote:
> >Hi, Jacek!
> >
> >On Tue, Jun 02, 2015 at 11:13:54AM +0200, Jacek Anaszewski wrote:
> >>Hi Sakari,
> >>
&
Hi, Jacek!
On Tue, Jun 02, 2015 at 11:13:54AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 06/01/2015 10:59 PM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Mon, May 25, 2015 at 05:13:57PM +0200, Jacek Anaszewski wrote:
> >>This patch adds helper fun
acek Anaszewski
> Acked-by: Kyungmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
> Cc: Sakari Ailus
For this and the rest in the set:
Acked-by: Sakari Ailus
Many thanks to you for your efforts on this! It's great to see it in this
state after all the review rounds. :-)
--
Ki
Hi Sylwester,
On Mon, May 25, 2015 at 02:00:33PM +0200, Sylwester Nawrocki wrote:
> Hi,
>
> On 23/05/15 14:03, Sakari Ailus wrote:
> > On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
> >> flash-leds = <&flash_xx &image_sensor_x>, <.
r V4L2 Flash sub-devices is disabled in the kernel
> config the functions' empty versions will be used.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> Cc: Sakari Ailus
> Cc: Hans Verkuil
Thanks for adding indicator support!
Acked-by: Sakari Ailus
d with NULL or error
pointer argument.
Acked-by: Sakari Ailus
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More m
Hi Sylwester,
On Mon, May 25, 2015 at 04:28:22PM +0200, Sylwester Nawrocki wrote:
> On 25/05/15 14:50, Jacek Anaszewski wrote:
> >> On 23/05/15 14:03, Sakari Ailus wrote:
> >>> >> On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
>
his awhile, I'm ok with removing the vendor prefix as well.
Let me know what you think.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to ma
Hi Sylwester,
On Thu, May 21, 2015 at 06:58:59PM +0200, Sylwester Nawrocki wrote:
> Hi Sakari,
>
> On 21/05/15 16:20, Sakari Ailus wrote:
> > On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
> >> > On 21/05/15 13:32, Sakari Ailus wrote:
>
Hi Sylwester,
On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
> On 21/05/15 13:32, Sakari Ailus wrote:
> >>>> @@ -147,6 +149,8 @@ Example:
> >>>> > >> clocks = <&camera 0>;
Hi Jacek,
On Thu, May 21, 2015 at 11:10:49AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 05/21/2015 12:00 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Wed, May 20, 2015 at 04:10:15PM +0200, Jacek Anaszewski wrote:
> >>This patch adds examples f
can think of --- either put the property
under the bridge (ISP) driver's device node as a temporary solution that
works on a few ISP drivers, or think how sensor modules should be modelled,
in which case we'd have some idea how lens device would be taken into
account.
Cc Sebastia
die
> Cc: devicetree@vger.kernel.org
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Sebastian,
On Thu, Apr 16, 2015 at 07:24:42AM +0200, Sebastian Reichel wrote:
> Hi Sakari,
>
> Since this driver won't make it into 4.1 anyways, I have one more
> comment:
>
> On Thu, Apr 16, 2015 at 02:37:13AM +0300, Sakari Ailus wrote:
...
> > @@ -308,16 +
From: Pavel Machek
Add device tree support for adp1653 flash LED driver.
Signed-off-by: Pavel Machek
Signed-off-by: Sakari Ailus
---
Hi folks,
Here's an updated adp1653 DT patch, with changes since v7:
- Include of.h and gpio/consumer.h instead of of_gpio.h and gpio.h.
- Don't
yungmin Park
> Cc: Lee Jones
> Cc: Chanwoo Choi
> Cc: Bryan Wu
> Cc: Richard Purdie
> Cc: devicetree@vger.kernel.org
Thanks!
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line &qu
igurable current can omit this
>> property" refer to both led-max-microamp and flash-max-microamp?
>>
>> I would drop the "Above...for the IC." paragraph and instead add
>> something like:
>>
>> "For controllers that have no configurable current the
utions, Inc.
Please maintain the alphabetic order. With that fixed,
Acked-by: Sakari Ailus
> sbs Smart Battery System
> schindler Schindler
> seagate Seagate Technology PLC
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubsc
Hi Jacek,
On Wed, Apr 08, 2015 at 12:23:23PM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 04/08/2015 11:11 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Wed, Apr 08, 2015 at 10:54:52AM +0200, Jacek Anaszewski wrote:
> >>Hi Sakari,
> >>
&
Hi Jacek,
On Wed, Apr 08, 2015 at 10:54:52AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 04/03/2015 02:09 PM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Tue, Mar 31, 2015 at 03:52:37PM +0200, Jacek Anaszewski wrote:
> >>Description of flash LED
llowed* another current might not be noticeable,leading a
>>>> potential spelling error to cause the LED being run at too high current.
>>>
>>> Where did he point this out? Do you think about the current version
>>> of the leds/common.txt documentation or
ree.
>
> I'm ok with that.
Thanks. The patch is applied here:
git://linuxtv.org/sailus/media_tree.git, branch adp1653
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" i
e-gpios: Reference to the GPIO that controls the power for the chip.
How about:
enable-gpios: Specifier of the GPIO connected to EN pin
I can make the changes if you're ok with that, otherwise please send v7. Then
I'll apply that to my tree.
--
Kind regards,
Sakari Ailus
e-mail: sakari.a
;No gpio node\n");
+ return -EINVAL;
+ }
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a messa
CTIVE_HIGH>; /* 88 */
> +
> + flash {
> + flash-timeout-us = <50>;
> + flash-max-microamp = <32>;
> + max-microamp = <5>;
> + };
> + indicator {
> + max-microamp = <17500>;
> + };
> + };
>
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 03, 2015 at 10:29:53PM +0200, Pavel Machek wrote:
> On Fri 2015-04-03 14:23:56, Sakari Ailus wrote:
> > Hi Pavel,
> >
> > On Fri, Apr 03, 2015 at 10:23:44AM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > > Hi Pawel,
> > >
Hi Jacek,
On Wed, Mar 25, 2015 at 09:52:02AM +0100, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 03/25/2015 02:06 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Fri, Mar 20, 2015 at 04:03:29PM +0100, Jacek Anaszewski wrote:
> >>This patch adds a descript
c: Bryan Wu
> Cc: Richard Purdie
> Cc: Pavel Machek
> Cc: Sakari Ailus
> Cc: devicetree@vger.kernel.org
> ---
> Documentation/devicetree/bindings/leds/common.txt | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/Document
-max-microamp = <32>;
> + max-microamp = <5>;
> + };
> + indicator {
> + max-microamp = <17500>;
> + };
> + };
> diff --git a/drivers/media/i2c/adp1653.c b/drivers/medi
ask the errors if the code
> changed...
Indeed, that's true. This is comparing "adp1653" vs. comparing
"adi,adp1653". I think I still prefer the latter since it's got also the
vendor prefix included.
Suppose we change this later and someone misspelled the vendo
adp1653_pm_ops = {
> > > +static const struct dev_pm_ops adp1653_pm_ops = {
> > > .suspend = adp1653_suspend,
> > > .resume = adp1653_resume,
> > > };
> > >
> > >
> >
> > A corresponding change to the N900 d
flash-timeout-us = <50>;
> + flash-max-microamp = <32>;
> + max-microamp = <5>;
> + };
> + indicator {
> + max-microamp = <17500>;
> + }
Hi Jacek,
On Mon, Mar 30, 2015 at 09:36:37AM +0200, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 03/28/2015 11:55 PM, Sakari Ailus wrote:
> >On Fri, Mar 27, 2015 at 02:49:38PM +0100, Jacek Anaszewski wrote:
> >>This patch adds device tree binding documentation for
> &g
Hi Jacek,
On Fri, Mar 27, 2015 at 02:49:43PM +0100, Jacek Anaszewski wrote:
> This patch extends LED Flash class documention by
> the description of interactions with v4l2-flash sub-device.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> Acked-by: Sakari Ail
ski
> Acked-by: Kyungmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger
n Park
> Acked-by: Sakari Ailus
> Cc: Lee Jones
> Cc: Chanwoo Choi
> Cc: Bryan Wu
> Cc: Richard Purdie
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 61
>
> 1 file changed, 61 insertions(+)
>
> diff --git a/Documentation/devi
Free Software Foundation.
> + */
> +
> +#include
You might not need this anymore.
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
pace need these? The fault codes are strings in the
sysfs interface.
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
Mor
ggers.c with EXPORT_SYMBOL_GPL macro.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the l
ngmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
> Cc: Sakari Ailus
> Cc: devicetree@vger.kernel.org
Thanks for the patch!
Acked-by: Sakari Ailus
--
Sakari Ailus
sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body o
#x27;d think so.
>
> >> +
> >> + mutex_init(&led->lock);
> >> + INIT_WORK(&led->work_brightness_set, ktd2692_brightness_set_work);
> >> +
> >> + platform_set_drvdata(pdev, led);
> >> +
> >> + ret = led_
2_led_brightness_set_sync;
> + led_cdev->flags |= LED_CORE_SUSPENDRESUME;
> + led_cdev->flags |= LED_DEV_CAP_FLASH;
You could unify the above two lines.
> +
> + mutex_init(&led->lock);
> + INIT_WORK(&led->work_brightness_set, ktd2692_brightness_se
+ flashes = <&camera_flash>, <&system_torch>;
> status = "okay";
> #address-cells = <1>;
> #size-cells = <1>;
There will be other kind of devices that have somewhat similar relationship.
They just h
t;>+#include
> >>>>+#include
> >>>>+#include "../../leds/leds.h"
> >>>
> >>>What do you need from leds.h? Shouldn't this be e.g. under include/linux
> >>>instead?
>
> I need led_trigger_remove function.
It's exported but defined in what is obviously a private header file to the
framework. Could it be moved to include/linux/leds.h instead?
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jacek,
On Mon, Mar 23, 2015 at 10:54:11AM +0100, Jacek Anaszewski wrote:
> Hi Sakari,
>
> On 03/21/2015 11:49 PM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Fri, Mar 20, 2015 at 04:03:22PM +0100, Jacek Anaszewski wrote:
> >>+Optional properties of th
);
> + of_node_put(led_cdev->dev->of_node);
> + v4l2_ctrl_handler_free(sd->ctrl_handler);
> + media_entity_cleanup(&sd->entity);
> +}
> +EXPORT_SYMBOL_GPL(v4l2_flash_release);
It'd be very nice if v4l2_flash_release() could graciously behave with NU
Hi Jacek,
On Mon, Mar 23, 2015 at 04:32:12PM +0100, Jacek Anaszewski wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> On 03/22/2015 02:21 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >Some comments below. Please also get an ack from Sylwester! :-)
>
> N
Hi Jacek,
On Mon, Mar 23, 2015 at 04:08:10PM +0100, Jacek Anaszewski wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> On 03/22/2015 01:22 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >Thanks for the updated set. Some comments below.
> >
> >On
imc-is data structure
> @@ -123,6 +132,8 @@ struct fimc_md {
> struct fimc_csis_info csis[CSIS_MAX_ENTITIES];
> struct fimc_sensor_info sensor[FIMC_MAX_SENSORS];
> int num_sensors;
> + struct fimc_flash_info flash[FIMC_MAX_FLASHES];
> + int num_flashes;
&g
acek Anaszewski
> Acked-by: Kyungmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
> Cc: Sakari Ailus
> ---
> drivers/leds/leds-max77693.c | 149
> +++---
> 1 file changed, 141 insertions(+), 8 deletions(-)
>
> diff --git a/dri
subsystem device driver. In case the
> support for V4L2 Flash sub-devices is disabled in the kernel
> config the functions' empty versions will be used.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> Cc: Sakari Ailus
> Cc: Hans Verkuil
> ---
> dr
m_get_drvdata(pdev);
> +
> + led_classdev_flash_unregister(&led->fled_cdev);
> + cancel_work_sync(&led->work_brightness_set);
> +
> + mutex_destroy(&led->lock);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id a
entity name, but then
the name of the device would be different in the LED framework and Media
controller.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the b
ch mode. The leds can be triggered
> externally or by software.
>
> Signed-off-by: Jacek Anaszewski
> Signed-off-by: Andrzej Hajda
> Acked-by: Kyungmin Park
> Cc: Bryan Wu
> Cc: Richard Purdie
> Cc: Lee Jones
> Cc: Chanwoo Choi
Thanks for the update once again!
Ac
ov2659->link_frequency->val =
+ ov2659->pdata->link_frequency;
You should simply use v4l2_ctrl_s_ctrl_int64() in ..._set_fmt() as this
isn't really a proper volatile control, but its value depends on the format.
--
Sakari Ailus
sakari.ai...
qs = devm_kzalloc(&client->dev,
> > > + size * sizeof(*link_freqs),
> >
> > You could simply use prop->length here. I think that'd look nicer.
>
> How about devm_kcalloc(&client->dev, size, sizeof(*link_freqs)) a
Hi Jacek,
On Thu, Mar 12, 2015 at 04:45:11PM +0100, Jacek Anaszewski wrote:
> This patch extends LED Flash class documention by
> the description of interactions with v4l2-flash sub-device.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> Acked-by: Sakari Ail
On Mon, Mar 16, 2015 at 02:19:04AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Saturday 07 March 2015 23:41:07 Sakari Ailus wrote:
> > The syscon register isn't part of the ISP, use it through the syscom driver
> > regmap instead. The syscom block is conside
->ctrls, &ov2659_ctrl_ops,
> + V4L2_CID_PIXEL_RATE, pdata->link_frequency,
> + pdata->link_frequency, 1, pdata->link_frequency);
Are the formats that you advertise correct? If so, you should divide the
link frequency by two to get
LE_DEVICE_TABLE(i2c, mt9v032_id);
>
> +#if IS_ENABLED(CONFIG_OF)
> +static const struct of_device_id mt9v032_of_match[] = {
> + { .compatible = "aptina,mt9v022" },
> + { .compatible = "aptina,mt9v022m" },
> + { .compatible = "aptina,mt9v024" },
>
Hi Tony,
Thanks for the comments!!
On Mon, Mar 09, 2015 at 08:20:38AM -0700, Tony Lindgren wrote:
> * Sakari Ailus [150307 15:44]:
> > Hi Laurent,
> >
> > On Sun, Mar 08, 2015 at 01:34:17AM +0200, Laurent Pinchart wrote:
> > > Hi Sakari,
> &
On Sun, Mar 08, 2015 at 01:51:51AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:13 Sakari Ailus wrote:
> > The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx.
> > Especially the phy
Hi Laurent,
On Thu, Mar 12, 2015 at 01:48:02AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:12 Sakari Ailus wrote:
> > Add the ISP device to omap3 DT include file and add support to the driver to
> > u
Hi Sebastian,
Thanks for the comments!
On Fri, Mar 13, 2015 at 10:34:53AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Mar 13, 2015 at 01:03:21AM +0200, Sakari Ailus wrote:
> > [...]
> >
> > > > +Required properties
> > > > +===
lk_frequency is the frequency of the external clock, not the
pixel rate. If I understand correctly, you should use the value of the
link-frequency property instead (as long as it's one pixel per clock).
With this fixed,
Acked-by: Sakari Ailus
> + v4l2_ctrl_new_std_menu_items(&ov2659-
Hi Laurent,
On Fri, Mar 13, 2015 at 01:11:03AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Friday 13 March 2015 01:03:21 Sakari Ailus wrote:
> > On Thu, Mar 12, 2015 at 01:39:07AM +0200, Laurent Pinchart wrote:
> > > On Saturday 07 March 2015 23:41:11 Sakari Ail
Hi Laurent,
On Thu, Mar 12, 2015 at 01:39:07AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:11 Sakari Ailus wrote:
> > Signed-off-by: Sakari Ailus
> > ---
> > .../devicetree/bindings/
On Fri, Mar 13, 2015 at 12:23:27AM +0200, Sakari Ailus wrote:
...
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(bus->lane_polarity); i++) {
> > > + polarity = of_prop_next_u32(prop, polarity, &v);
> > > + if (!p
Hi Laurent,
On Sun, Mar 08, 2015 at 01:49:26AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:10 Sakari Ailus wrote:
> > Add lane_polarity field to struct v4l2_of_bus_mipi_csi2 and write the
> > contents of
Hi Laurent,
On Wed, Mar 11, 2015 at 08:09:11PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Wednesday 11 March 2015 13:04:43 Sakari Ailus wrote:
> > On Sun, Mar 08, 2015 at 11:33:27AM +, Lad Prabhakar wrote:
> > > From: Benoit Parrot
> > >
Hi Prabhakar,
On Sun, Mar 08, 2015 at 11:33:27AM +, Lad Prabhakar wrote:
> From: Benoit Parrot
>
> this patch adds support for omnivision's ov2659
> sensor, the driver supports following features:
> 1: Asynchronous probing
> 2: DT support
> 3: Media controller support
>
> Signed-off-by: Ben
support
>
> Signed-off-by: Benoit Parrot
> Signed-off-by: Lad, Prabhakar
Now that DT support is included, could you document it as well? There's a
single proprerty to document.
--
Cheers,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe fr
quot;,
> +&pdata->link_frequency);
This is actually documented as being a 64-bit array.
The smiapp wasn't even reading it from the endpoint node. Oh well...
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To
Hi Jacek,
On Mon, Mar 09, 2015 at 01:19:32PM +0100, Jacek Anaszewski wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> On 03/09/2015 11:54 AM, Sakari Ailus wrote:
> >Hi Jacek,
> >
> >On Wed, Mar 04, 2015 at 05:14:31PM +0100, Jacek Anaszewski wrote:
> &
q = link_freqs[0];
> > + }
If you're interested in just a single value, you can use
of_property_read_u64().
> > + pdata->clk_pol = !!(endpoint.bus.parallel.flags &
> > + V4L2_MBUS_PCLK_SAMPLE_RISING);
> > +
> > +done:
> > + o
= <2400>;
> +
> + camera_flash: flash-led {
> + label = "max77693-flash1";
> + led-sources = <0>, <1>;
> + max-microamp = <50>;
> + flash-max-microamp = <125>;
> + flash-timeout-us = <100>;
> + };
> };
> };
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Laurent,
On Sun, Mar 08, 2015 at 01:56:13AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:14 Sakari Ailus wrote:
> > Add support for the primary camera of the Nokia N950 and N9.
> >
>
Hi Laurent,
On Sun, Mar 08, 2015 at 01:46:02AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> (CC'ing Sylwester)
>
> On Saturday 07 March 2015 23:41:09 Sakari Ailus wrote:
> > Add lane-polarity property to endpoint nodes. This esse
Hi Laurent,
On Sun, Mar 08, 2015 at 01:34:17AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> (CC'ing linux-omap and Tony)
Thanks.
> On Saturday 07 March 2015 23:41:07 Sakari Ailus wrote:
> > The syscon register isn't part of
lock, but works much
better on serial busses.
It'd documented in video-interfaces.txt.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord
The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx.
Especially the phy-type property is different.
Signed-off-by: Sakari Ailus
---
arch/arm/boot/dts/omap34xx.dtsi | 15 +++
arch/arm/boot/dts/omap36xx.dtsi | 15 +++
2 files changed, 30
Add lane-polarity property to endpoint nodes. This essentially tells that
the order of the differential signal wires is inverted.
Signed-off-by: Sakari Ailus
---
Documentation/devicetree/bindings/media/video-interfaces.txt |5 +
1 file changed, 5 insertions(+)
diff --git a
The video port clock is l3_ick divided by vpclk_div. This clock must be high
enough for the external pixel rate. The video port requires two clock cycles
to process a pixel.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/ispcsi2.c |8 +++-
include/media/omap3isp.h
From: Laurent Pinchart
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/omap3isp/isp.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media/platform/omap3isp/isp.c
index a607f26..01356dd 100644
--- a/dr
Move the code which connects the external entity to an ISP entity into a
separate function. This disconnects it from parsing the platform data.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 147 +
1 file changed, 74 insertions(+), 73
strictly needed by the
DT support but there's no harm from that either: the device now can be used
without sensors, for instance.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c | 10 --
drivers/media/platform/omap3isp/ispvideo.c |6 +++---
2 files
: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-of.c | 21 -
include/media/v4l2-of.h |3 +++
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-of.c
b/drivers/media/v4l2-core/v4l2-of.c
index b4ed9a9..a7a855e 100644
--- a
Print a warning when the driver is used with platform data. Existing
platform data user should move to DT now.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media
Add the ISP device to omap3 DT include file and add support to the driver to
use it.
Also obtain information on the external entities and the ISP configuration
related to them through the Device Tree in addition to the platform data.
Signed-off-by: Sakari Ailus
---
drivers/media/platform
Add support for the primary camera of the Nokia N950 and N9.
Signed-off-by: Sakari Ailus
---
arch/arm/boot/dts/omap3-n9.dts | 39 ++
arch/arm/boot/dts/omap3-n950-n9.dtsi |4
arch/arm/boot/dts/omap3-n950.dts | 39
If an uninitialised v4l2_subdev struct was passed to
media_entity_create_link(), one of the BUG_ON()'s in the function will be
hit since media_entity.num_pads will be zero. Avoid this by checking whether
the num_pads field is non-zero for the interface.
Signed-off-by: Sakari Ailus
---
dr
The omap3isp MMIO register block is contiguous in the MMIO register space
apart from the fact that the ISP IOMMU register block is in the middle of
the area. Ioremap it at two occasions, and keep the rest of the layout of
the register space internal to the omap3isp driver.
Signed-off-by: Sakari
Rename VDD_CSIPHY1 as vdd-csiphy1 and VDD_CSIPHY2 as vdd-csiphy2.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media/platform/omap3isp/isp.c
index
data. The platform data related structs can be later removed once
the support for platform data can be removed.
Signed-off-by: Sakari Ailus
Cc: Mike Rapoport
Cc: Igor Grinberg
---
arch/arm/mach-omap2/board-cm-t35.c | 57 +++---
drivers/media/platform/omap3isp/isp.c
The syscon register isn't part of the ISP, use it through the syscom driver
regmap instead. The syscom block is considered to be from 343x on ISP
revision 2.0 whereas 15.0 is assumed to have 3630 syscon.
Signed-off-by: Sakari Ailus
---
arch/arm/boot/dts/omap3.dtsi|2 +-
Signed-off-by: Sakari Ailus
---
.../devicetree/bindings/media/ti,omap3isp.txt | 64
MAINTAINERS|1 +
2 files changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti,omap3isp.txt
diff --git a
The mutex was not destroyed correctly if dma_coerce_mask_and_coherent()
failed for some reason.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media
Hi folks,
I've had this patchset hanging around for a long, long time, and now it's
time to send it out to linux-media.
For OMAP 3, first there are a few patches for random and tiny bugfixes and
then preparation for DT support (including compile tested rework of cm-t35
board code).
The lane-pola
Only the histogram sub-block driver uses the physical address. Do not store
it for other sub-blocks.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/isp.c |3 ++-
drivers/media/platform/omap3isp/isp.h |6 +++---
drivers/media/platform/omap3isp/isphist.c |2
1 - 100 of 185 matches
Mail list logo
