Re: [PATCH v2 0/3] ARM: keystone: add ecc error interrupt handling

2015-06-25 Thread Stephen Boyd
On 06/25/2015 08:04 AM, santosh shilimkar wrote: > On 6/25/2015 7:31 AM, Vitaly Andrianov wrote: >> This patch series adds support for arm L1/L2 ecc and ddr3 ecc error >> handling >> for Keystone devices >> >> Change Log >> >> v2: >> - removing unused and sorting headers of keystone.c are moved to

Re: [PATCH v6 6/9] nvmem: qfprom: Add Qualcomm QFPROM support.

2015-06-24 Thread Stephen Boyd
On 06/22/2015 04:09 PM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c > new file mode 100644 > index 000..7f7a82f > --- /dev/null > +++ b/drivers/nvmem/qfprom.c > @@ -0,0 +1,89 @@ > > + > +#include > +#include > +#include > +#include > +#include

Re: [PATCH 2/9] drivers: clk: st: Incorrect register offset used for lock_status

2015-06-24 Thread Stephen Boyd
On 06/23/2015 07:09 AM, Gabriel Fernandez wrote: > Incorrect register offset used for sthi407 clockgenC > > Signed-off-by: Pankaj Dev This needs your Signed-off-by too -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscri

Re: [PATCH 1/9] drivers: clk: st: Incorrect clocks status

2015-06-24 Thread Stephen Boyd
On 06/23/2015 07:09 AM, Gabriel Fernandez wrote: > In the clk_summary output, the h/w status of DivMux is incorrect > (Parent and Enable status), since the clk_mux_ops.get_parent() > returns -ERRCODE when clock is OFF. > > Signed-off-by: Pankaj Dev > Signed-off-by: Gabriel Fernandez > --- > driv

Re: [PATCH v5 03/11] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-23 Thread Stephen Boyd
On 06/18/2015 05:46 AM, Srinivas Kandagatla wrote: > Many thanks for review. > > On 16/06/15 23:43, Stephen Boyd wrote: >> On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote: >>> >>>> + >>>> +static int nvmem_add_cells(struct nvmem_device *nvme

Re: [PATCH 6/9] arm: twr-k70f120m: clock source drivers for Kinetis SoC

2015-06-23 Thread Stephen Boyd
On 06/23/2015 02:19 PM, Paul Osmialowski wrote: > > diff --git a/drivers/clk/clk-kinetis.c b/drivers/clk/clk-kinetis.c > new file mode 100644 > index 000..dea1054 > --- /dev/null > +++ b/drivers/clk/clk-kinetis.c > @@ -0,0 +1,226 @@ > +/* > + * clk-kinetis.c - Clock driver for Kinetis K70 MCG >

Re: [PATCH v3 2/3] clk: stm32: Add clock driver for STM32F4[23]xxx devices

2015-06-22 Thread Stephen Boyd
On 06/10, Daniel Thompson wrote: > The driver supports decoding and statically modelling PLL state (i.e. > we inherit state from bootloader) and provides support for all > peripherals that support simple one-bit gated clocks. The covers all > peripherals whose clocks come from the AHB, APB1 or APB2

Re: [PATCH v3 1/3] dt-bindings: Document the STM32F4 clock bindings

2015-06-22 Thread Stephen Boyd
On 06/10, Daniel Thompson wrote: > This adds documentation of device tree bindings for the clock related > portions of the STM32 RCC block. > > Signed-off-by: Daniel Thompson > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Coll

Re: [PATCH v3 2/3] clk: stm32: Add clock driver for STM32F4[23]xxx devices

2015-06-22 Thread Stephen Boyd
On 06/10, Daniel Thompson wrote: > The driver supports decoding and statically modelling PLL state (i.e. > we inherit state from bootloader) and provides support for all > peripherals that support simple one-bit gated clocks. The covers all > peripherals whose clocks come from the AHB, APB1 or APB2

Re: [PATCH v3 0/3] clk: stm32: Add clock driver for STM32F4[23]xxx devices

2015-06-22 Thread Stephen Boyd
On 06/10, Daniel Thompson wrote: > This patchset implements a clock driver for STM32F42xxx and STM32F43xxx > series devices. It supports decoding the state configured by the > bootloader (PLL, clock select, bus dividers) and all the gates clocks. > It does not currently support the I2S and SAI PLLs

Re: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT

2015-06-19 Thread Stephen Boyd
Node > > This describes the OPPs belonging to a device. This node can have following > @@ -63,11 +74,16 @@ This describes the OPPs belonging to a device. This node > can have following >reference an OPP. > > Optional properties: > +- opp-name: Name of the OPP table, to un

Re: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT

2015-06-19 Thread Stephen Boyd
On 06/18, Viresh Kumar wrote: > On 17-06-15, 18:30, Stephen Boyd wrote: > > An operating-point(s?)-names property seems ok... but doesn't that mean > > that every CPU that uses the OPP has to have the same list of > > operating-point-names? > > Why do you think so

Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain

2015-06-18 Thread Stephen Boyd
On 06/18/2015 08:30 AM, Guenter Roeck wrote: > On Wed, Jun 17, 2015 at 06:04:54PM -0700, Stephen Boyd wrote: > [ ... ] >> What happened to this series? I want to add shutdown support to my >> platform and I need to write a register on the PMIC in one driver to >> configure

Re: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT

2015-06-17 Thread Stephen Boyd
On 06/17/2015 06:47 AM, Rob Herring wrote: > On Wed, Jun 17, 2015 at 8:33 AM, Viresh Kumar wrote: >> On 17-06-15, 08:23, Rob Herring wrote: + operating-points-v2 = <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast>; >>> You've made a fundamental change here in that thi

Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain

2015-06-17 Thread Stephen Boyd
On 10/06/2014 10:28 PM, Guenter Roeck wrote: > Various drivers implement architecture and/or device specific means to > remove power from the system. For the most part, those drivers set the > global variable pm_power_off to point to a function within the driver. > > This mechanism has a number of

Re: [PATCH v5 10/11] nvmem: sunxi: Move the SID driver to the nvmem framework

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:45 AM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile > index caea611..cc46791 100644 > --- a/drivers/nvmem/Makefile > +++ b/drivers/nvmem/Makefile > @@ -9,3 +9,5 @@ nvmem_core-y += nvmem-mmio.o > # Devices > obj-$(CONFI

Re: [PATCH v5 09/11] nvmem: qfprom: Add bindings for qfprom

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: > This patch adds bindings for qfprom found in QCOM SOCs. QFPROM driver > is based on simple nvmem framework. > > Signed-off-by: Srinivas Kandagatla > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a

Re: [PATCH v5 08/11] nvmem: qfprom: Add Qualcomm QFPROM support.

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig > index f157b6d..e665e23 100644 > --- a/drivers/nvmem/Kconfig > +++ b/drivers/nvmem/Kconfig > @@ -8,3 +8,18 @@ menuconfig NVMEM > from both the Linux Kernel and the userspace. >

Re: [PATCH v5 07/11] nvmem: Add simple nvmem-mmio consumer helper functions.

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/nvmem-mmio.c b/drivers/nvmem/nvmem-mmio.c > new file mode 100644 > index 000..0d8131f > --- /dev/null > +++ b/drivers/nvmem/nvmem-mmio.c > @@ -0,0 +1,69 @@ > +/* > + * Copyright (C) 2015 Srinivas Kandagatla > + * >

Re: [PATCH v5 06/11] nvmem: Add bindings for simple nvmem framework

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:44 AM, Srinivas Kandagatla wrote: > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.txt > b/Documentation/devicetree/bindings/nvmem/nvmem.txt > new file mode 100644 > index 000..ecea654 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.txt > @@ -

Re: [PATCH v5 05/11] nvmem: Add nvmem_device based consumer apis.

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 8a4b358..68ee8d1 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -436,6 +436,51 @@ static int __nvmem_device_put(struct nvmem_device *nvmem) > return 0;

Re: [PATCH v5 03/11] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote: > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > new file mode 100644 > index 000..6c2f0b1 > --- /dev/null > +++ b/drivers/nvmem/core.c > @@ -0,0 +1,398 @@ > +/* > + * nvmem framework core. > + * > + * Copyright (C) 2015 Srinivas

Re: [PATCH v5 04/11] nvmem: Add a simple NVMEM framework for consumers

2015-06-16 Thread Stephen Boyd
On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote: > @@ -379,6 +380,351 @@ int nvmem_unregister(struct nvmem_device *nvmem) [...] > + > + return nvmem; > +} > + > +static int __nvmem_device_put(struct nvmem_device *nvmem) Why does this return int? It's not used anywhere. > +{ > + module_p

Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

2015-06-12 Thread Stephen Boyd
On 06/11/2015 08:13 PM, Rob Herring wrote: > On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd wrote: >> Add support for over current protection (OCP), pin control >> selection, soft start and soft start strength, auto-mode, input >> current limiting, and pull down. >&g

[PATCH v3] regulator: Add QCOM SPMI regulator driver

2015-06-12 Thread Stephen Boyd
Add an SPMI regulator driver for Qualcomm's PM8841, PM8941, and PM8916 PMICs. This driver is based largely on code from codeaurora.org[1]. [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/regulator/qpnp-regulator.c?h=msm-3.10 Cc: David Collins Cc: Signed-off-by: St

Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

2015-06-12 Thread Stephen Boyd
On 06/11, Rob Herring wrote: > On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd wrote: > > Add support for over current protection (OCP), pin control > > selection, soft start and soft start strength, auto-mode, input > > current limiting, and pull down. > > > > Cc:

[PATCH v2 3/6] regulator: Add pull down support

2015-06-11 Thread Stephen Boyd
Some regulators need to be configured to pull down a resistor when the regulator is disabled. Add an op (set_pull_down) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 1 + drivers/regulator/core.c

[PATCH v2 2/6] regulator: Add system_load constraint

2015-06-11 Thread Stephen Boyd
Some regulators have a fixed load that isn't captured by consumers that the kernel knows about. Add a constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ drivers/regulator/core.c

[PATCH v2 5/6] regulator: Add input current limit support

2015-06-11 Thread Stephen Boyd
Some regulators can limit their input current (typically annotated as ilim). Add an op (set_input_current_limit) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 1 + drivers/regulator/core.c

[PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

2015-06-11 Thread Stephen Boyd
Add support for over current protection (OCP), pin control selection, soft start and soft start strength, auto-mode, input current limiting, and pull down. Cc: Signed-off-by: Stephen Boyd --- Changes from v1: * New patch split from original SPMI regulator driver .../bindings/regulator/qcom

[PATCH v2 4/6] regulator: Add soft start support

2015-06-11 Thread Stephen Boyd
Some regulators support a "soft start" feature where the voltage ramps up slowly when the regulator is enabled. Add an op (set_soft_start) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulat

[PATCH v2 1/6] regulator: Add QCOM SPMI regulator driver

2015-06-11 Thread Stephen Boyd
Add an SPMI regulator driver for Qualcomm's PM8841, PM8941, and PM8916 PMICs. This driver is based largely on code from codeaurora.org[1]. [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/regulator/qpnp-regulator.c?h=msm-3.10 Cc: David Collins Cc: Signed-off-by: St

[PATCH v2 4/6] regulator: Add soft start support

2015-06-11 Thread Stephen Boyd
Some regulators support a "soft start" feature where the voltage ramps up slowly when the regulator is enabled. Add an op (set_soft_start) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulat

[PATCH v2 2/6] regulator: Add system_load constraint

2015-06-11 Thread Stephen Boyd
Some regulators have a fixed load that isn't captured by consumers that the kernel knows about. Add a constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ drivers/regulator/core.c

[PATCH v2 1/6] regulator: Add QCOM SPMI regulator driver

2015-06-11 Thread Stephen Boyd
Add an SPMI regulator driver for Qualcomm's PM8841, PM8941, and PM8916 PMICs. This driver is based largely on code from codeaurora.org[1]. [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/regulator/qpnp-regulator.c?h=msm-3.10 Cc: David Collins Cc: Signed-off-by: St

[PATCH v2 5/6] regulator: Add input current limit support

2015-06-11 Thread Stephen Boyd
Some regulators can limit their input current (typically annotated as ilim). Add an op (set_input_current_limit) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 1 + drivers/regulator/core.c

[PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

2015-06-11 Thread Stephen Boyd
Add support for over current protection (OCP), pin control selection, soft start and soft start strength, auto-mode, input current limiting, and pull down. Cc: Signed-off-by: Stephen Boyd --- Changes from v1: * New patch split from orignal SPMI regulator driver .../bindings/regulator/qcom

[PATCH v2 3/6] regulator: Add pull down support

2015-06-11 Thread Stephen Boyd
Some regulators need to be configured to pull down a resistor when the regulator is disabled. Add an op (set_pull_down) and a DT property + constraint to support this. Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/regulator/regulator.txt | 1 + drivers/regulator/core.c

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-11 Thread Stephen Boyd
On 06/08, Sascha Hauer wrote: > On Fri, Jun 05, 2015 at 05:59:12PM -0700, Stephen Boyd wrote: > > > > And similar things could be done for the reset driver. > > The problem I see with this approach is that we scatter the code for a > otherwise simple driver over a bunch

Re: [PATCH v2 00/14] ARM: shmobile: Add CPG Clock Domains

2015-06-08 Thread Stephen Boyd
* clk: shmobile: r8a7779: Add CPG Clock Domain support > clk: shmobile: rcar-gen2: Add CPG Clock Domain support > * clk: shmobile: rz: Add CPG Clock Domain support Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collabor

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-05 Thread Stephen Boyd
On 06/05, James Liao wrote: > Hi Stephen, > > On Thu, 2015-06-04 at 14:02 -0700, Stephen Boyd wrote: > > On 05/29, Sascha Hauer wrote: > > > Yes. I previously got the impression that the subsystem clocks are not > > > directly associated to the larbs, but

Re: [RFC PATCH 2/3] clk: stm32: Add clock driver for STM32F4[23]xxx devices

2015-06-05 Thread Stephen Boyd
On 06/05, Daniel Thompson wrote: > On 04/06/15 23:07, Stephen Boyd wrote: > >On 05/22, Daniel Thompson wrote: > >>+#include > > > >Are you using this include? > > Not very much? > > Turns out I was relying on these to get kzalloc() defined but there &

Re: [RFC PATCH 2/3] clk: stm32: Add clock driver for STM32F4[23]xxx devices

2015-06-04 Thread Stephen Boyd
On 05/22, Daniel Thompson wrote: > + > +#include Are you using this include? > +#include Are you using this include? > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include Are you using this include? > + > +static long clk_apb_mul_round_rate(struct cl

Re: [PATCH 1/5] clk: mediatek: Fix apmixedsys clock registration

2015-06-04 Thread Stephen Boyd
On 05/21, James Liao wrote: > The size of clk_data should be the same as CLK_APMIXED_NR_CLK > instead of ARRAY_SIZE(plls). CLK_APMIXED_* is numbered from 1, so > CLK_APMIXED_NR_CLK will be greater than ARRAY_SIZE(plls). > > Signed-off-by: James Liao > --- Applied to clk-next -- Qualcomm Innova

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-04 Thread Stephen Boyd
On 05/29, Sascha Hauer wrote: > On Fri, May 29, 2015 at 10:47:29AM +0800, James Liao wrote: > > Hi Sascha, > > > > > And really the driver matching "mediatek,mt8173-vencsys" should register > > > the necessary clocks and reset lines and call of_platform_populate on > > > the subnodes. The driver s

Re: [PATCH V7 1/3] OPP: Add new bindings to address shortcomings of existing bindings

2015-06-04 Thread Stephen Boyd
ave to change to support how multiple regulators will be matched up with the device using the OPP. But for now, Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line &

Re: [PATCH v4] Add TI CDCE925 I2C controlled clock synthesizer driver

2015-06-03 Thread Stephen Boyd
On 06/03/2015 03:25 PM, Michael Turquette wrote: Quoting Mike Looijmans (2015-06-02 22:25:19) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 9897f35..1c31704 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -78,6 +78,23 @@ config COMMON_CLK_SI570 This driver

Re: [PATCH V6 1/3] OPP: Add new bindings to address shortcomings of existing bindings

2015-06-02 Thread Stephen Boyd
On 05/28, Viresh Kumar wrote: > Current OPP (Operating performance point) device tree bindings have been > insufficient due to the inflexible nature of the original bindings. Over > time, we have realized that Operating Performance Point definitions and > usage is varied depending on the SoC and a

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-28 Thread Stephen Boyd
onnected to their consumers in the DT. > > It looks like you forgot to CC the clock subsystem maintainers: > > M: Mike Turquette > M: Stephen Boyd > Thanks, except I don't have the full patch context here to review the patch. > The description above sounds l

Re: [PATCH v2 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC

2015-05-22 Thread Stephen Boyd
On 05/04/15 05:42, Stanimir Varbanov wrote: > This adds Snapdragon 805 ARM-based SoC as multiplatform > compatible platform. > > Signed-off-by: Stanimir Varbanov > --- > arch/arm/mach-qcom/Kconfig |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-qc

Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings

2015-05-20 Thread Stephen Boyd
On 05/19/15 19:07, Viresh Kumar wrote: > On 19-05-15, 17:51, Stephen Boyd wrote: > >> Also I wonder if all properties should be optional? I don't have this >> scenario today, but perhaps the frequencies could be encoded in fuses, >> but the voltages wouldn't be an

Re: [PATCH v2 4/9] clocksource: mediatek: Use GPT as sched clock source

2015-05-20 Thread Stephen Boyd
On 05/20, Matthias Brugger wrote: > 2015-05-20 16:05 GMT+02:00 Yingjoe Chen : > > On Wed, 2015-05-20 at 13:02 +0200, Matthias Brugger wrote: > >> 2015-05-16 9:58 GMT+02:00 Yingjoe Chen : > >> > When cpu is in deep idle, arch timer will stop counting. Setup GPT as > >> > sched clock source so it can

Re: [PATCH] regulator: Add SPMI regulator driver

2015-05-13 Thread Stephen Boyd
On 05/13/15 04:41, Mark Brown wrote: > On Tue, May 12, 2015 at 02:39:47PM -0700, Stephen Boyd wrote: > > Lots of things with the DT bindings here. In general if you're > introducing lots of custom properties I'd recommend doing a patch series > which starts off with

Re: [PATCHv2] ARM: socfpga: dts: Add a clock node for sdmmc CIU

2015-05-13 Thread Stephen Boyd
On 04/14, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > The CIU(Card Interface Unit) get its clock from the sdmmc_clk_divided clock > which is used to clock the card. The sdmmc_clk_divided clock is the sdmmc_clk > passed through a fixed divider of 4. This patch adds the sdmmc_clk_

Re: [PATCH v2 06/12] ARM: dts: apq8064: Add MDP support

2015-04-10 Thread Stephen Boyd
On 04/10/15 12:39, Srinivas Kandagatla wrote: > > > On 10/04/15 18:04, Stephen Boyd wrote: >> On 04/10/15 05:34, Srinivas Kandagatla wrote: >>> @@ -250,6 +265,18 @@ >>> }; >>> }; >>> >>> +ext_3p3v: regula

Re: [PATCH v18 01/11] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-04-09 Thread Stephen Boyd
by: Mahesh Sivasubramanian , > Ai Li , Praveen Chidambaram > Original tree available at - > git://codeaurora.org/quic/la/kernel/msm-3.10.git > > Cc: Stephen Boyd > Cc: Arnd Bergmann > Cc: Kevin Hilman > Cc: Daniel Lezcano > Signed-off-by: Lina Iyer > --- Reviewed-by

Re: [PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers

2015-04-09 Thread Stephen Boyd
On 04/07, Srinivas Kandagatla wrote: > On 07/04/15 19:45, Stephen Boyd wrote: > >On 03/30, Srinivas Kandagatla wrote: > > > >Do you have an overview of how to use these APIs? Maybe some > >Documentation/ is in order? I'm mostly interested in how the > >blocks

Re: [PATCH v6 0/4] clk: Provide support for always-on clocks

2015-04-07 Thread Stephen Boyd
On 04/07, Lee Jones wrote: > Lots of platforms contain clocks which if turned off would prove fatal. > The only way to recover from these catastrophic failures is to restart > the board(s). Now, when a clock provider is registered with the > framework it is possible for a list of always-on clocks

Re: [PATCH v6 4/4] clk: dt: Introduce binding for always-on clock support

2015-04-07 Thread Stephen Boyd
On 04/07, Lee Jones wrote: > Signed-off-by: Lee Jones > --- Can you please add some commit text here? Why did we make this change? > .../devicetree/bindings/clock/clock-bindings.txt | 38 > ++ > 1 file changed, 38 insertions(+) > > diff --git a/Documentation/devicetree/b

Re: [PATCH v6 3/4] clk: Provide always-on clock support

2015-04-07 Thread Stephen Boyd
On 04/07, Lee Jones wrote: > Lots of platforms contain clocks which if turned off would prove fatal. > The only way to recover from these catastrophic failures is to restart > the board(s). Now, when a clock provider is registered with the > framework it is possible for a list of always-on clocks

Re: [PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers

2015-04-07 Thread Stephen Boyd
On 03/30, Srinivas Kandagatla wrote: > @@ -130,6 +138,37 @@ static struct class eeprom_class = { > .dev_release= eeprom_release, > }; > > +static int of_eeprom_match(struct device *dev, const void *eeprom_np) > +{ > + return dev->of_node == eeprom_np; > +} > + > +static struct eepr

Re: [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device

2015-04-02 Thread Stephen Boyd
On 04/02/15 15:26, Mark Brown wrote: > On Thu, Apr 02, 2015 at 03:00:37PM -0700, Stephen Boyd wrote: > >> What happens with debugfs when you have multiple pmics with the same >> named regulator? I thought that in this case we needed to make the names >> unique somehow or

Re: [PATCH v2 1/5] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-04-02 Thread Stephen Boyd
odes that can operate on these resources. > + > +== Regulators > + > +Regulator notes are identified by their compatible: s/notes/nodes/ Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsub

Re: [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device

2015-04-02 Thread Stephen Boyd
On 04/01/15 15:55, Bjorn Andersson wrote: > Stephen Boyd pointed out that the current design of the Qualcomm RPM and > regulator driver consumes 12-20kB of ram just for the platform_device structs. > > This series starts with a new revision of the dt binding documentation for the >

Re: [PATCH 2/7] clk: Add basic infrastructure for Pistachio clocks

2015-03-30 Thread Stephen Boyd
On 03/30/15 17:15, Andrew Bresticker wrote: > On Mon, Mar 30, 2015 at 4:59 PM, Stephen Boyd wrote: >> On 02/24/15 19:56, Andrew Bresticker wrote: >>> + >>> +void pistachio_clk_force_enable(struct pistachio_clk_provider *p, >>> + uns

Re: [PATCH 0/7] clk: Common clock support for IMG Pistachio

2015-03-30 Thread Stephen Boyd
bol. A branch with this series and the dependent patches > is available at [3]. I'd like this to go through the MIPS tree with > Mike's or Stephen's ACK if possible. > > Minor comment on patch 2, but otherwise Acked-by: Stephen Boyd -- Qualcomm Innovation Cen

Re: [PATCH 2/7] clk: Add basic infrastructure for Pistachio clocks

2015-03-30 Thread Stephen Boyd
On 02/24/15 19:56, Andrew Bresticker wrote: > + > +void pistachio_clk_force_enable(struct pistachio_clk_provider *p, > + unsigned int *clk_ids, unsigned int num) > +{ > + unsigned int i; > + int err; > + > + for (i = 0; i < num; i++) { > + struct

Re: [PATCH 0/3] arm: msm: Use timer DT node for qcom watchdog config

2015-03-26 Thread Stephen Boyd
On 02/20, Mathieu Olivari wrote: > This change is done as a follow-up to the following thread: > https://lkml.org/lkml/2014/10/1/436 > > qcom-wdt is currently assuming the presence of a dedicated node in DT > to gets its configuration. However, on msm architecture, the watchdog is > usually part o

Re: [PATCH V3 2/8] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

2015-03-25 Thread Stephen Boyd
rder to reduce > the memory footprint after the driver is initialized and unify the function > names with ARM64. > > Signed-off-by: Daniel Lezcano > Acked-by: Kevin Hilman > Acked-by: Rob Herring Thanks for moving to OF tables. We can merge smp ops and cpuidle ops later on. A

Re: [PATCH v3] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

2015-03-23 Thread Stephen Boyd
s for known > > PMIC's. Also print runtime detected chip revision information. > > > > Signed-off-by: Ivan T. Ivanov > > --- Looks OK to me. Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collab

[PATCH v3 06/13] clk: qcom: Add HFPLL driver

2015-03-20 Thread Stephen Boyd
On some devices (MSM8974 for example), the HFPLLs are instantiated within the Krait processor subsystem as separate register regions. Add a driver for these PLLs so that we can provide HFPLL clocks for use by the system. Cc: Signed-off-by: Stephen Boyd --- .../devicetree/bindings/clock/qcom

[PATCH v3 10/13] clk: qcom: Add KPSS ACC/GCC driver

2015-03-20 Thread Stephen Boyd
The ACC and GCC regions present in KPSSv1 contain registers to control clocks and power to each Krait CPU and L2. For CPUfreq purposes probe these devices and expose a mux clock that chooses between PXO and PLL8. Cc: Signed-off-by: Stephen Boyd --- .../devicetree/bindings/arm/msm/qcom,kpss

[PATCH v3 12/13] cpufreq: Add module to register cpufreq on Krait CPUs

2015-03-20 Thread Stephen Boyd
Register a cpufreq-generic device whenever we detect that a "qcom,krait" compatible CPU is present in DT. Cc: Signed-off-by: Stephen Boyd --- .../devicetree/bindings/arm/msm/qcom,pvs.txt | 38 drivers/cpufreq/Kconfig.arm| 9 + drivers/cpufre

[PATCH v3 00/13] Krait clocks + Krait CPUfreq

2015-03-20 Thread Stephen Boyd
robe code for krait-cc so that we just register clocks and don't enable or set rates Stephen Boyd (13): ARM: Add Krait L2 register accessor functions clk: mux: Split out register accessors for reuse clk: Avoid sending high rates to downstream clocks during set_rate clk: Add safe switch

[PATCH v3 11/13] clk: qcom: Add Krait clock controller driver

2015-03-20 Thread Stephen Boyd
The Krait CPU clocks are made up of a primary mux and secondary mux for each CPU and the L2, controlled via cp15 accessors. For Kraits within KPSSv1 each secondary mux accepts a different aux source, but on KPSSv2 each secondary mux accepts the same aux source. Cc: Signed-off-by: Stephen Boyd

Re: [PATCH 1/3] mfd: devicetree: qcom_rpm: document IPQ8064 resources

2015-03-18 Thread Stephen Boyd
On 11/24/14 02:38, Lee Jones wrote: > On Thu, 20 Nov 2014, Josh Cartwright wrote: > >> The IPQ8064 SoC has several RPM-controlled resources, an NSS fabrick >> clock and four regulator resources. Provide definitions for them. >> >> Signed-off-by: Josh Cartwright >> --- >> Documentation/devicetree

Re: [PATCH 2/6] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

2015-03-17 Thread Stephen Boyd
On 03/17/15 04:29, Lorenzo Pieralisi wrote: > On Mon, Mar 16, 2015 at 10:08:19PM +0000, Stephen Boyd wrote: >> On 03/03/15 04:29, Daniel Lezcano wrote: >>> The code is optimized to use the __init section intensively in order to >>> reduce >>> the memory footp

Re: [PATCH 2/6] ARM: cpuidle: Add a cpuidle ops structure to be used for DT

2015-03-16 Thread Stephen Boyd
On 03/03/15 04:29, Daniel Lezcano wrote: > > The code is optimized to use the __init section intensively in order to reduce > the memory footprint after the driver is initialized and unify the function > names with ARM64. > > In order to prevent multiple declarations and the specific cpuidle ops to

Re: [RFC PATCH v15 02/11] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-16 Thread Stephen Boyd
On 03/09/15 08:16, Lina Iyer wrote: > + > +static int qcom_idle_enter(int cpu, unsigned long index) > +{ > + if (!per_cpu(qcom_idle_ops, cpu)[index]) > + return -EOPNOTSUPP; Is this case still happening? > + > + return per_cpu(qcom_idle_ops, cpu)[index](cpu); > +} > + > +const

Re: [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus

2015-03-11 Thread Stephen Boyd
On 03/09/15 08:16, Lina Iyer wrote: > Register cpuidle ops for Krait Processor Sub-System. > Supports v1 and v2 versions of KPSS. > > Cc: Stephen Boyd > Cc: Arnd Bergmann > Cc: Kevin Hilman > Cc: Daniel Lezcano > Signed-off-by: Lina Iyer > --- > arch/arm

Re: [PATCH v2 2/3] arm64: qcom: Add support for Qualcomm MSM8916 SoC

2015-03-05 Thread Stephen Boyd
On 03/05, Kumar Gala wrote: > > On Mar 4, 2015, at 4:33 PM, Stephen Boyd wrote: > > > On 03/04/15 13:13, Kumar Gala wrote: > >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > >> index 1b8e973..4c8b119 100644 > >> --- a/arch/arm64/Kconfig &g

Re: [PATCH 4/4] regulator: qcom: Rework to single platform device

2015-03-04 Thread Stephen Boyd
On 03/04/15 16:30, Mark Brown wrote: > On Wed, Mar 04, 2015 at 11:35:43AM -0800, Stephen Boyd wrote: > >> There's another problem with this of_parse_cb design. The regulator >> framework requires supplies to be registered before consumers of the >> supplies are regist

Re: [PATCH v2 2/3] arm64: qcom: Add support for Qualcomm MSM8916 SoC

2015-03-04 Thread Stephen Boyd
On 03/04/15 13:13, Kumar Gala wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1b8e973..4c8b119 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -177,6 +177,15 @@ config ARCH_MEDIATEK > help > Support for Mediatek MT65xx & MT81xx ARMv8 SoCs > >

Re: [PATCH 4/4] regulator: qcom: Rework to single platform device

2015-03-04 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: > + match = of_match_device(rpm_of_match, &pdev->dev); > + for (reg = match->data; reg->name; reg++) { > + vreg = devm_kmalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL); > + if (!vreg) { > + dev_err(&pdev->de

Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

2015-03-04 Thread Stephen Boyd
On 03/04/15 02:19, Ivan T. Ivanov wrote: > + > +static const struct of_device_id pmic_spmi_id_table[] = { > + [COMMON_SUBTYPE] = { .compatible = "qcom,spmi-pmic" }, > + [PM8941_SUBTYPE] = { .compatible = "qcom,pm8941" }, > + [PM8841_SUBTYPE] = { .compatible = "qcom,pm8841" }, > +

Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

2015-03-04 Thread Stephen Boyd
On 03/04/15 02:19, Ivan T. Ivanov wrote: > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index 4b8beb2..a1af4e5 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > > + > +static void pmic_spmi_show_revid(struct regmap *map, struct device *

Re: [PATCH 4/4] regulator: qcom: Rework to single platform device

2015-03-03 Thread Stephen Boyd
On 03/03/15 15:52, Mark Brown wrote: > On Tue, Mar 03, 2015 at 02:32:35PM -0800, Bjorn Andersson wrote: >> On Tue 03 Mar 14:09 PST 2015, Stephen Boyd wrote: >>> How does this work for the case where we may not want to add all the >>> regulators that a PMIC supports. I&

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 14:17, Bjorn Andersson wrote: > On Tue 03 Mar 14:02 PST 2015, Stephen Boyd wrote: > >> On 03/03/15 13:54, Bjorn Andersson wrote: >>> On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: >>> >>>> On 03/02/15 20:25, Bjorn Andersson wrote: >>

Re: [PATCH 4/4] regulator: qcom: Rework to single platform device

2015-03-03 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: > - config.of_node = pdev->dev.of_node; > +static int rpm_reg_probe(struct platform_device *pdev) > +{ > + const struct rpm_regulator_data *reg; > + const struct of_device_id *match; > + struct regulator_config config = { }; > + struct r

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 13:54, Bjorn Andersson wrote: > On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: > >> On 03/02/15 20:25, Bjorn Andersson wrote: > [..] >>> + >>> +- vin_l1_l2_l12_l18-supply: >>> +- vin_l24-supply: >>> +- vin_l25-s

Re: [PATCH 3/4] regulator: qcom: Refactor of-parsing code

2015-03-03 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: > + > +static int rpm_reg_probe(struct platform_device *pdev) > +{ > + struct regulator_init_data *initdata; > + const struct qcom_rpm_reg *template; > + const struct of_device_id *match; > + struct regulator_config config = { }; > + str

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: > > += SUBNODES > + > +The RPM exposes resources to its subnodes. The below bindings specify the set > +of valid subnodes that can operate on these resources. > + > +== Regulators > + > +Regulator notes are identified by their compatible: > + > +- compatibl

Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices

2015-03-03 Thread Stephen Boyd
On 02/26, Ivan T. Ivanov wrote: > > Hi Stephan, > > Sorry for delayed answer. > > On Thu, 2015-02-19 at 16:49 -0800, Stephen Boyd wrote: > > On 02/03/15 04:17, Ivan T. Ivanov wrote: > > > Following set of patches add initial DT support for PMIC devices > &g

[PATCH v3 0/3] Scorpion PMU support

2015-02-27 Thread Stephen Boyd
ace differently (mrutland) * Dropped I-cache events that shouldn't be there (mrutland) * Fixed branch misprediction event (mrutland) Stephen Boyd (3): ARM: perf: Preparatory work for Scorpion PMU support ARM: perf: Only reset PMxEVCNTCR registers on reset ARM: perf: Add support for

[PATCH v3 3/3] ARM: perf: Add support for Scorpion PMUs

2015-02-27 Thread Stephen Boyd
Cc: Mark Rutland Cc: Neil Leeder Cc: Ashwin Chaugule Cc: Sheetal Sahasrabudhe Cc: Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/arm/pmu.txt | 2 + arch/arm/kernel/perf_event_cpu.c | 2 + arch/arm/kernel/perf_event_v7.c | 414

Re: [PATCH v2 2/2] ARM: perf: Add support for Scorpion PMUs

2015-02-27 Thread Stephen Boyd
On 02/25/15 08:58, Ashwin Chaugule wrote: > On 24 February 2015 at 12:23, Ashwin Chaugule > wrote: >> On 20 February 2015 at 15:16, Stephen Boyd wrote: >>> On 02/20, Will Deacon wrote: >>>> On Fri, Feb 13, 2015 at 06:24:09PM +, Stephen Boyd wrote: >>&

Re: [PATCH] regulator: qcom-rpm: Rework for single device

2015-02-26 Thread Stephen Boyd
On 02/26/15 16:00, Stephen Boyd wrote: > The RPM regulators are not individual devices. Creating platform > devices for each regulator bloats the kernel's runtime memory > footprint by ~12k. Let's rework this driver to be a single > platform device for all the RPM regulator

[PATCH] regulator: qcom-rpm: Rework for single device

2015-02-26 Thread Stephen Boyd
oo because now the regulators node contains a list of supplies at the package level for a particular PMIC model. Signed-off-by: Stephen Boyd --- On 02/24, Bjorn Andersson wrote: > On Wed 18 Feb 18:29 PST 2015, Stephen Boyd wrote: > > > On 02/18/15 13:08, Bjorn Andersson wrote: > &g

Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-26 Thread Stephen Boyd
On 02/26/15 12:09, Srinivas Kandagatla wrote: > > > On 26/02/15 19:31, Stephen Boyd wrote: >> On 02/22/15 23:54, Srinivas Kandagatla wrote: >>> +pm8921_s5: pm8921-s5 { >>> +compatible= "qcom,rpm-pm

Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-26 Thread Stephen Boyd
On 02/22/15 23:54, Srinivas Kandagatla wrote: > + pm8921_s5: pm8921-s5 { > + compatible = "qcom,rpm-pm8921-ftsmps"; > + reg = ; > + }; > + > + pm8921_s6: pm8921-s6 {

<    1   2   3   4   5   6   >