On 20/10/15 14:24, Krzysztof Kozlowski wrote:
> W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze:
>> > DECON IP requires this clock to access configuration registers.
>> >
>> > Signed-off-by: Andrzej Hajda
>> > ---
>> > Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +-
>> > 1 fi
On 20/10/15 12:34, Michael Turquette wrote:
>> diff --git a/include/dt-bindings/clock/exynos5433.h
>> b/include/dt-bindings/clock/exynos5433.h
>> > index 5bd80d5..4f0d566 100644
>> > --- a/include/dt-bindings/clock/exynos5433.h
>> > +++ b/include/dt-bindings/clock/exynos5433.h
>> > @@ -765,7 +765,
On 12/10/15 08:47, Krzysztof Kozlowski wrote:
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> > index 8f4d76c..525a93a 100644
>> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>
On 25/05/15 17:14, Jacek Anaszewski wrote:
> This patch adds support for external v4l2-flash devices.
> The support includes parsing "camera-flashes" DT property
"samsung,camera-flashes" ?
> and asynchronous sub-device registration.
> +static int fimc_md_register_flash_entities(struct fimc_md *f
On 25/05/15 14:50, Jacek Anaszewski wrote:
>> On 23/05/15 14:03, Sakari Ailus wrote:
>>> >> On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
>>>> >>> flash-leds = <&flash_xx &image_sensor_x>, <...>;
Hi,
On 23/05/15 14:03, Sakari Ailus wrote:
> On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
>> flash-leds = <&flash_xx &image_sensor_x>, <...>;
>
> One more matter to consider: xenon flash devices.
>
> How about samsung,came
Hi Sakari,
On 21/05/15 16:20, Sakari Ailus wrote:
> On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote:
>> > On 21/05/15 13:32, Sakari Ailus wrote:
>>>>>> > >>>> @@ -147,6 +149,8 @@ Example:
>>>&g
On 21/05/15 13:32, Sakari Ailus wrote:
@@ -147,6 +149,8 @@ Example:
> >> clocks = <&camera 0>;
> >> clock-names = "mclk";
> >>
> >>+ samsung,flash-led = <&rear_cam_flash>;
> >>+
> >>
Hello,
On 28/04/15 11:25, Chanwoo Choi wrote:
> Hi Valentin,
>
> On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg
> wrote:
>> > Hi Chanwoo,
>> >
>> > this is a kind reminder that the issue mentioned below is still
>> > present and made its way to v4.1-rc1.
>
> I sent the patch[1] to fix it. An
Hi Chanwoo,
On 27/04/15 13:36, Chanwoo Choi wrote:
> From: Jonghwa Lee
>
> Some clocks are required being unmasked for suspend-to-ram. Otherwise,
> PMU (Power Management Unit) will stick and power line never down.
>
> Signed-off-by: Jonghwa Lee
> Signed-off-by: Chanwoo Choi
> ---
> @@ -1718,
On 09/04/15 10:03, Sakari Ailus wrote:
> Jacek Anaszewski wrote:
>> On 04/08/2015 05:15 PM, Sylwester Nawrocki wrote:
>>> On 08/04/15 16:31, Jacek Anaszewski wrote:
>>>> Properties defining maximum values for LED currents and timeout should
>>>> be mand
On 09/04/15 09:23, Jacek Anaszewski wrote:
> On 04/08/2015 05:15 PM, Sylwester Nawrocki wrote:
>> > On 08/04/15 16:31, Jacek Anaszewski wrote:
>>> >> Properties defining maximum values for LED currents and timeout should
>>> >> be mandatory to avoid the
On 08/04/15 16:31, Jacek Anaszewski wrote:
> Properties defining maximum values for LED currents and timeout should
> be mandatory to avoid the risk of hardware damage. This patch fixes
> the issue.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> ---
> Documentation/devicetree/
Hi Jacek,
On 08/04/15 13:58, Jacek Anaszewski wrote:
>>> --- a/Documentation/devicetree/bindings/leds/common.txt
>>> >> +++ b/Documentation/devicetree/bindings/leds/common.txt
>>> >> @@ -29,13 +29,15 @@ Optional properties for child nodes:
>>> >>"ide-disk" - LED indicates disk activity
>>>
Hello,
On 31/03/15 15:52, Jacek Anaszewski wrote:
> Description of flash LEDs related properties was not precise regarding
> the state of corresponding settings in case a property is missing.
> Add relevant statements.
> Removed is also the requirement making the flash-max-microamp
> property obli
t;>>
>>> Signed-off-by: Jacek Anaszewski
>>> Acked-by: Kyungmin Park
>>> Cc: Sylwester Nawrocki
>>> ---
>>> .../devicetree/bindings/media/samsung-fimc.txt |8
>>> 1 file changed, 8 insertions(+)
>>>
>>>
On 23/03/15 16:59, Lee Jones wrote:
> On Mon, 23 Mar 2015, Pavel Machek wrote:
>
>> > On Mon 2015-03-23 15:02:13, Lee Jones wrote:
>>> > > On Mon, 23 Mar 2015, Pavel Machek wrote:
> > > On Mon 2015-03-23 12:07:43, Lee Jones wrote:
> > > > > This patch requires a DT Ack.
> > >
>
ible = "simple-audio-card";
> + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> + <&clock_audss EXYNOS_MOUT_I2S>,
> + <&clock_audss EXYNOS_DOUT_AUD_BUS>;
> + assi
gt; but it also reduces the risk of accessing the ISP CMU
> registers while the ISP power domain remains turned off
> (i.e. through the common clock framework by clk_summary)
>
> Signed-off-by: Beata Michalska
> Acked-by: Kyungmin Park
Acked-by: Sylwester Nawrocki
Kukjin, pleas
On 02/03/15 14:17, Beata Michalska wrote:
> From: Tomasz Figa
>
> Add clock controller for CMU ISP clock domain on Exynos3250,
> providing clocks for FIMC-IS subsystem.
>
> [b.michalska:use samsung_cmu_register_one to register
> the provider; updated DT binding documentation]
Thanks for moving
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Sylwester Nawrocki
> ---
> arch/arm/mach-exynos/pm_domains.c | 27 +++
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pm_domains.c
> b/arch/arm/mach
nd we'll need
to address those dependencies somehow.
Anyway, the subject patch looks OK to me, given that support for clocks/
clock-names in the exynos power domain device nodes has been merged
for quite long already.
The entire feature has been merged without PM or clk subsystem
maintainer ACK, I don
On 09/03/15 12:29, Laurent Pinchart wrote:
> On Monday 09 March 2015 11:35:52 Sylwester Nawrocki wrote:
>> On 08/03/15 14:45, Laurent Pinchart wrote:
>>> +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
>>> @@ -0,0 +1,41 @@
>>> +* Aptina 1/3
Hi Sakari,
On 09/03/15 11:57, Sakari Ailus wrote:
>>> +static struct mt9v032_platform_data *
>>> +mt9v032_get_pdata(struct i2c_client *client)
>>> +{
>>> + struct mt9v032_platform_data *pdata;
>>> + struct v4l2_of_endpoint endpoint;
>>> + struct device_node *np;
>>> + struct property *prop
Hi Laurent,
On 08/03/15 14:45, Laurent Pinchart wrote:
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
> @@ -0,0 +1,41 @@
> +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor
> +
> +The Aptina MT9V032 is a 1/3-inch CMOS active pixel digital image sensor with
> +an active array size
On 20/02/15 01:36, Andreas Färber wrote:
>>> >> So it seems the mclk is not always set up properly by the kernel,
>>> >> relying on firmware. Who's in charge of setting that clock up?
>> >
>> > Right, it seems audio is only working due the firmware doing some previous
>> > setup. Probably it works
On 09/02/15 13:17, Inki Dae wrote:
>> Instead I just added syscon support to the PHY layer, it's not perfect
>> > but fixes the issue for both DSI and CSI and doesn't strip the PHY layer
>> > which could potentially be useful.
>
> Ah, Right. I didn't check your patch set. Your way is a better idea
On 07/02/15 12:53, Inki Dae wrote:
> This patch fixes the issue that the try to get a phy object is failed
> to enable mipi phy.
>
> System and power management unit registers should be controlled by
> syscon framework. So this patch removes existing phy framework based
> codes and adds syscon sup
On 05/02/15 08:44, Pankaj Dubey wrote:
>> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = {
>> > +
>> > + /* ENABLE_PCLK_APOLLO */
>> > + GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo",
>> > + "div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO,
>> > +
Hi Chanwoo,
On 02/02/15 15:23, Chanwoo Choi wrote:
> +/*
> + * ATLAS_PLL & APOLLO_PLL & MEM0_PLL & MEM1_PLL & BUS_PLL & MFC_PLL
> + * & MPHY_PLL & G3D_PLL & DISP_PLL & ISP_PLL
> + */
> +static struct samsung_pll_rate_table exynos5443_pll_rates[] = {
> + PLL_35XX_RATE(25, 625, 6, 0),
>
Hi Chanwoo,
On 02/02/15 15:24, Chanwoo Choi wrote:
> This patch adds the mux/divider/gate clocks for CMU_BUS{0|1|2} domains
> which contain global data buses clocked at up the 400MHz. These blocks
> transfer data between DRAM and various sub-blocks. These clock domains
> also contain global periph
On 03/02/15 14:11, Mark Brown wrote:
> On Tue, Feb 03, 2015 at 12:04:16PM +0100, Sylwester Nawrocki wrote:
>
>>>> > >> Sorry, I should've said - I applied the ASoC patches, not these.
>>> > > Shall I take 13 to 15 DT patches in Samsung tree?
>
On 03/02/15 13:17, Sylwester Nawrocki wrote:
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c
>> b/drivers/clk/samsung/clk-exynos5433.c
>> > index 3d6164e..cf3f0ac 100644
>> > --- a/drivers/clk/samsung/clk-exynos5433.c
>> > +++ b/drivers/clk/samsung
MIF's clocks
> related to CMU_DISP should be always on state.
Are you sure we need to add anything to CMU_MIF in this patch ?
> Also, CMU_DISP must need the source clock of 'sclk_hdmi_spdif_disp'
> from CMU_TOP domain. This patch adds the clocks of CMU_TOP related to HDMI.
>
On 03/02/15 05:27, Kukjin Kim wrote:
> Mark Brown wrote:
>> On Wed, Jan 14, 2015 at 07:42:40PM +0100, Sylwester Nawrocki wrote:
>>> Clock related properties are added to the Exynos4 I2S device nodes
>>> so they can be referred to as clock providers. Missing i2s_opclk
Hi Kukjin,
On 16/01/15 18:30, Sylwester Nawrocki wrote:
> This is required to fix regression after introducing the PMU device
> nodes required for the PMU driver modified in commit
> 14fc8b93d47323561edf5d482d4a4b3ee1b90286
> ("ARM: EXYNOS: Add platform driver support for Exy
On 23/01/15 06:03, Inha Song wrote:
> +static int trats2_aif1_startup(struct snd_pcm_substream *substream)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card);
> + int ret;
> +
> + ret = clk_p
Hello Tobias,
On 24/01/15 02:53, Tobias Jakobi wrote:
> Hello,
>
> I've tested the series on my X2 and so far I haven't encountered any
> obvious issues with it.
>
> I have a small question though. With the move to simple-audio-card the
> old driver (selected by SND_SOC_ODROIDX2) is probably goi
On 23/01/15 06:03, Inha Song wrote:
> This patch add Trats2 audio subsystem bindings document.
>
> Signed-off-by: Inha Song
Reviewed-by: Sylwester Nawrocki
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@v
On 23/01/15 06:03, Inha Song wrote:
> This patch add WM1811 audio codec, I2S interface and the sound
> machine nodes to enable audio on exynos4412-trats2 board.
>
> Signed-off-by: Inha Song
Reviewed-by: Sylwester Nawrocki
--
To unsubscribe from this list: send the line "unsub
On 22/01/15 12:18, Inha Song wrote:
> This patch set clock out parent to XUSBXTI.
>
> Signed-off-by: Inha Song
> ---
> arch/arm/boot/dts/exynos4.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8168f1..020bb
On 22/01/15 12:18, Inha Song wrote:
> This patch add Trats2 audio subsystem bindings document.
>
> Signed-off-by: Inha Song
Acked-by: Sylwester Nawrocki
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel
On 22/01/15 12:17, Inha Song wrote:
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index fc67f97..8031423 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -245,3 +245,11 @@ config SND_SOC_ARNDALE_RT5631_ALC5631
> depends on SND_SOC_SAM
Hi,
On 09/01/15 16:23, Jacek Anaszewski wrote:
> This patch adds a description of 'flashes' property
> to the samsung-fimc.txt.
>
> Signed-off-by: Jacek Anaszewski
> Acked-by: Kyungmin Park
> ---
> .../devicetree/bindings/media/samsung-fimc.txt |7 +++
> 1 file changed, 7 insertio
Hi,
On 19/01/15 10:48, Inha Song wrote:
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> + sound {
> + compatible = "samsung,trats2-audio";
> + assigned-clocks = <&pmu_system_controller 0>;
> + assigned-cloc
Hi,
On 21/01/15 06:58, Inha Song wrote:
> Add MAX98090 audio codec, I2S interface and the sound nodes to support
> audio on Odroid-XU3 board.
>
> Signed-off-by: Inha Song
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34
> ++
> 1 file changed, 34 insertions(+
Hi Tuashar,
On 17/01/15 06:21, Tushar Behera wrote:
> On Thu, Jan 15, 2015 at 3:42 AM, Sylwester Nawrocki
> wrote:
>> Ensure the I2SMOD, I2SPSR registers, which are also exposed through
>> clk API are only accessed with the i2s->spinlock spinlock held.
>>
>>
I-2
camera sensors working again on Exynos4 boards.
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8168f1..250ee50 100644
--- a/arch/arm/boot/dts/exynos4.
CSI-2
camera sensors working again on Exynos4 boards.
Cc: Pankaj Dubey
Cc: Kukjin Kim
Signed-off-by: Sylwester Nawrocki
---
.../devicetree/bindings/phy/samsung-phy.txt|2 +-
drivers/phy/phy-exynos-mipi-video.c| 89 +---
include/linux/mfd/
Hi,
On 15/01/15 22:03, Pavel Machek wrote:
>> Perhaps we could use the 'reg' property to describe actual connections,
>> > I'm not sure if it's better than a LED specific property, e.g.
>> >
>> > max77387@52 {
>> > compatible = "nxp,max77387";
>> > #address-cells = <2>;
>> >
Hi,
On 15/01/15 06:49, Padma Venkat wrote:
> I posted patches after re-basing on your tree and after incorporating
> all comments from Vivek.
> Below is the link
> http://www.spinics.net/lists/linux-samsung-soc/msg40992.html
>
> Can you pick the patches?
Sure, I'm not forgetting it. I've updated
On 12/01/15 18:06, Mark Brown wrote:
> On Mon, Jan 12, 2015 at 10:55:29AM -0600, Rob Herring wrote:
>> > On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski
>>> > > There are however devices that don't fall into this category, i.e. they
>>> > > have many outputs, that can be connected to a single LE
-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |6 ++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi |8 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index
ch doesn't configure the CDCLK clock in
struct snd_soc_dai_ops hw_params callback and the issue should be
now resolved by using clk API, i.e. having the codec enabling/
disabling the CDCLK clock as required.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsu
Now when the CDCLK I2S output clock can be handled through the clock
API the Odroid X2/U3 can be switched to the simple-audio-card DT binding.
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |3 +++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 19
Ensure the I2SMOD, I2SPSR registers, which are also exposed through
clk API are only accessed with the i2s->spinlock spinlock held.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 81 +--
1 file changed, 51 insertions(+),
K that clock is supposed to be handled outside
the sound machine driver.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/odroidx2_max98090.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/odroidx2_max98090.c
b/sound/soc/samsung/odroidx2_m
I2S1, I2S2 on Exynos4 SoC series have limited functionality compared
to I2S0, "samsung,s3c6410-i2s" compatible should be used for them.
Cc: sta...@vger.kernel.org
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |4 ++--
1 file changed, 2 insertions(+), 2
The new DT properties required for the I2S device node to be referred
as a clock provider and corresponding clock indices definition is added.
Signed-off-by: Sylwester Nawrocki
---
.../devicetree/bindings/sound/samsung-i2s.txt | 22
include/dt-bindings/sound/samsung
I2SMOD, I2SPSR registers are made also accessible through the
clk API.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 2bac719..20cc51f 100644
The code to get pointer to the other DAI is repeated multiple
times. Add a helper function and use it instead.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b
These functions may fail so let's properly report any errors.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index e5473ee..aa52b41 100644
hard coded (0x100) register region size in the driver.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 45 +++--
1 file changed, 7 insertions(+), 38 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index aa52b4
tive,
so if runtime PM is enabled it can idle the device by turning off the clock.
Correcting this issue is left for a separate patch series, as we need to
ensure the BUSCLK clock is always enabled when required.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 25
Acquire the I2S interface clock in driver probe() callback
as it's a per-device not a per-DAI clock. While at it switch
to the resource managed clk_get().
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 19 +++
1 file changed, 7 insertions(+), 12 dele
The usage of this goto seems unjustified, use if/else statement instead.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index cab2a2a..2bac719
Tidy up the samsung_i2s_get_driver_data() function by using
IS_ENABLE() instead of #ifdef and add missing braces for
the 'else' part. Also ensure we are not dereferencing NULL
'match' pointer.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c |9
luded
in this series.
This whole series may need more testing on other SoCs, so far I only tested
it on Odroid Exynos4412 X2, with the I2S working in slave mode.
[1]
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-September/081753.html
Sylwester Nawrocki (15):
ASoC: samsung
On 06/01/15 19:15, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 02:55:36PM +0100, Sylwester Nawrocki wrote:
>> > I2S1, I2S2 on Exynos4 SoC series have limited functionality compared
>> > to I2S0, "samsung,s3c6410-i2s" compatible should be used for them.
>> >
On 06/01/15 19:06, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 02:55:26PM +0100, Sylwester Nawrocki wrote:
>> Gating the I2S bus clock in the driver's runtime PM callbacks has
>> currently really no effect since the clock is being enabled
>> in the DAI's probe() an
On 06/01/15 19:14, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 02:55:22PM +0100, Sylwester Nawrocki wrote:
>> > Tidy up the samsung_i2s_get_driver_data() function by using
>> > IS_ENABLE() instead of #ifdef and add missing braces for
>> > the 'else' part. A
Hi,
On 19/12/14 14:23, Padmavathi Venna wrote:
> Add required clk support for I2S,PCM amd SPDIF
There is a non-trivial conflict with the MSCL CMU patch, could you
please resend rebased onto my exynos7 branch:
git://linuxtv.org/snawrocki/samsung.git for-v3.20/clk/exynos7 ?
Is exynos7420 document
Hi Vivek,
On 25/11/14 12:48, Vivek Gautam wrote:
> On Sat, Nov 22, 2014 at 8:42 PM, Kukjin Kim wrote:
>> > On 11/22/14 17:40, Kishon Vijay Abraham I wrote:
>>> >> On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote:
...
>>> I took dwc3 driver patches.
>>> >>
>>> >> I took the phy patches
Hi Josh,
On 22/12/14 11:32, Josh Wu wrote:
>>> +Required Properties:
>>> >> +- compatible: Must be "ovti,ov2640"
>> > I believe it is preferred to put it as "Should contain", rather than
>> > "Must be".
>
> I don't have a strong opinion here. After check many documents, it seems
> many people use
I2S1, I2S2 on Exynos4 SoC series have limited functionality compared
to I2S0, "samsung,s3c6410-i2s" compatible should be used for them.
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arc
Now when the CDCLK I2S output clock can be handled through the clock
API the Odroid X2/U3 can be switched to the simple-audio-card DT binding.
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |3 +++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 19
-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |6 ++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi |8 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index
k and the issue should be
now resolved by using clk API, i.e. having the codec enabling/
disabling the CDCLK clock as required.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 113 ++-
1 file changed, 93 insertions(+), 20 deletions(-
K that clock is supposed to be handled outside
the sound machine driver.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/odroidx2_max98090.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/odroidx2_max98090.c
b/sound/soc/samsung/odroidx2_m
I2SMOD, I2SPSR registers are made also accessible through the
clk API.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index cd66e58..b5b6b1e 100644
The new DT properties required for the I2S device node to be referred
as a clock provider and corresponding clock indices definition is added.
Signed-off-by: Sylwester Nawrocki
---
.../devicetree/bindings/sound/samsung-i2s.txt | 22
include/dt-bindings/sound/samsung
Ensure the I2SMOD, I2SPSR registers, which are also exposed through
clk API are only accessed with the i2s->spinlock spinlock held.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 81 +--
1 file changed, 51 insertions(+),
The usage of this goto seems unjustified, use if/else statement instead.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index c4d4ccc..cd66e58
much. It will allow us to register a clock
provider already in samsung_i2s_probe() function.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung
The code to get pointer to the other DAI is repeated multiple
times. Add a helper function and use it instead.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b
Acquire the I2S interface clock in driver probe() callback
as it's a per-device not a per-DAI clock. While at it switch
to the resource managed clk_get().
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 19 +++
1 file changed, 7 insertions(+), 12 dele
hard coded (0x100) register region size in the driver.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 45 +++--
1 file changed, 7 insertions(+), 38 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 8ab673
Tidy up the samsung_i2s_get_driver_data() function by using
IS_ENABLE() instead of #ifdef and add missing braces for
the 'else' part. Also ensure we are not dereferencing NULL
'match' pointer.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c |9
These functions may fail so let's properly report any errors.
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 430298c..8ab6734 100644
The 'gpios' field in 'struct i2s' is now unused, this change
seems to be missing in commit 0429ffeff460c4302bd1520e6
("ASoC: samsung: Remove obsolete GPIO based DT pinmuxing").
Signed-off-by: Sylwester Nawrocki
---
sound/soc/samsung/i2s.c |1 -
1 file change
.
[1]
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-September/081753.html
Sylwester Nawrocki (16):
ASoC: samsung: i2s: Remove unused gpios field from struct i2s
ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup
ASoC: samsung: i2s: Add return value checks in probe()
Hi Josh,
On 18/12/14 03:27, Josh Wu wrote:
> Add the document for ov2640 dt.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Josh Wu
Acked-by: Sylwester Nawrocki
It seems "ovti" is not in the list of vendor prefixes. You may want
to send a patch adding it to Do
On 12/12/14 21:03, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 06:45:50PM +0100, Sylwester Nawrocki wrote:
>
>> +Optional Properties:
>>
>> - samsung,idma-addr: Internal DMA register base address of the audio
>>sub system(used in secondary sound source).
>&
: devicetree@vger.kernel.org
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |6 ++
arch/arm/boot/dts/exynos4412-odroid-common.dtsi |7 +--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot
Now when the CDCLK I2S output clock can be handled through the clock
API the Odroid X2/U3 can be switched to the simple-audio-card DT binding.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sylwester Nawrocki
---
arch/arm/boot/dts/exynos4.dtsi |3 +++
arch/arm/boot/dts
ch doesn't configure the CDCLK clock in
struct snd_soc_dai_ops hw_params callback and the issue should be
now resolved by using clk API, i.e. having the codec enabling/
disabling the CDCLK clock as required.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sylwester Nawrocki
---
.../devicetree
Hi,
On 04/12/14 17:12, Pavel Machek wrote:
+- maxim,boost-mode :
> >>+ In boost mode the device can produce up to 1.2A of total current
> >>+ on both outputs. The maximum current on each output is reduced
> >>+ to 625mA then. If there are two child led nodes defi
On 10/12/14 11:02, Jacek Anaszewski wrote:
+Optional properties:
>>> +- maxim,fleds : Array of current outputs in order: fled1, fled2.
s/current outputs/LED current regulator outputs used/ ?
>>> +Note: both current outputs can be connected to a single led
s/led/LED ? And there
Hi,
On 27/11/14 12:56, Chanwoo Choi wrote:
> On 11/27/2014 08:41 PM, Arnd Bergmann wrote:
>> > On Thursday 27 November 2014 16:35:08 Chanwoo Choi wrote:
>>> >> + - "samsung,exynos5433-cmu-bus0", "samsung,exynos5433-cmu-bus1"
>>> >> +and "samsung,exynos5433-cmu-bus2" - clock controller compati
Hi Abhilash,
On 24/10/14 16:32, Abhilash Kesavan wrote:
> On Wed, Oct 8, 2014 at 11:18 AM, Abhilash Kesavan
> wrote:
>> On Tue, Oct 7, 2014 at 9:46 AM, Kukjin Kim wrote:
>>> Tomasz Figa wrote:
On 30.09.2014 17:12, Abhilash Kesavan wrote:
> On Mon, Sep 22, 2014 at 2:22 PM, Tomasz Figa
1 - 100 of 317 matches
Mail list logo
