[PATCH v3] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-10-07 Thread Timo Sigurdsson
t the default voltages inherited by sun7i-a20.dtsi. Signed-off-by: Timo Sigurdsson --- Changes since v2: - (Re)Added board-specific OPP after Kevin Hilman reported problems with the default voltages at lower frequencies --- arch/arm/boot/dts/sun7i-a20-bananapi.dts

Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-10-07 Thread Timo Sigurdsson
Hi Maxime, Maxime Ripard schrieb am 07.10.2015 19:49: > Hi Timo, > > On Wed, Oct 07, 2015 at 05:49:18PM +0200, Timo Sigurdsson wrote: >> Hi Kevin, >> Hi Maxime, >> >> Kevin Hilman schrieb am 07.10.2015 16:36: >> >> > "Timo Sigurdsson"

Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-10-07 Thread Timo Sigurdsson
Hi Kevin, Hi Maxime, Kevin Hilman schrieb am 07.10.2015 16:36: > "Timo Sigurdsson" writes: >> I still think that the lower voltages may be the cause of your problem >> with that specific board, so could you please test the attached patch on >> top of my patch

Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-10-05 Thread Timo Sigurdsson
Hi Kevin, Kevin Hilman schrieb am 24.09.2015 19:57: > kernelci.org started finding boot faiulres[1] on bananapi linux-next > around next-20150918, but it was only failing in some labs and not > others. I finally bisected it down to this patch, which landed in > linux-next in the form of 2d665a8a8

Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-09-25 Thread Timo Sigurdsson
Hi Kevin, Kevin Hilman schrieb am 25. Sept 2015 01:57: > On Tue, Aug 18, 2015 at 8:36 AM, Maxime Ripard > wrote: >> On Sun, Aug 02, 2015 at 06:18:25PM +0200, Timo Sigurdsson wrote: >>> sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 >>> P

[PATCH v2] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to meet SoC specifications

2015-08-04 Thread Timo Sigurdsson
x27;t stable across all SoCs and boards out there. Signed-off-by: Timo Sigurdsson --- Changes since v1: - Fixed checkpatch warnings - Changed the commit message and title to clarify that this is not a board-specific issue, but rather a limitation by the SoC --- arch/arm/boot/dts/sun7i-a20.dts

Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-08-04 Thread Timo Sigurdsson
Hi Maxime, Maxime Ripard schrieb am 03.08.2015 11:47: > What regulator provides the 3.3V regulator used in the rest of this DT > then (MMC, GMAC) ? For GMAC, there is a reg_gmac_3v3 defined in sun7i-a20-bananapi.dts [1]. MMC uses reg_vcc3v3 included from sunxi-common-regulators.dtsi. Am I missing

Re: [linux-sunxi] [PATCH] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to a level all boards can supply

2015-08-04 Thread Timo Sigurdsson
Hi Maxime, Maxime Ripard schrieb am 03.08.2015 11:34: > On Mon, Aug 03, 2015 at 11:03:52AM +0200, Timo Sigurdsson wrote: >> Julian Calaby schrieb am 03.08.2015 06:22: >> > My only real objection here is are there boards that can go down to >> > 0.9v and if so, won&#

Re: [PATCH] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to a level all boards can supply

2015-08-04 Thread Timo Sigurdsson
Hi Maxime, Maxime Ripard schrieb am 03.08.2015 11:13: > On Sun, Aug 02, 2015 at 09:23:06PM +0200, Timo Sigurdsson wrote: >> sun7i-a20.dtsi contains an cpufreq operating point at 0.9 volts. Most A20 >> boards >> (or all?), however, do not allow the voltage to go below 1.0V

Re: [linux-sunxi] [PATCH] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to a level all boards can supply

2015-08-03 Thread Timo Sigurdsson
Hi again, Julian Calaby schrieb am 03.08.2015 06:22: > My only real objection here is are there boards that can go down to > 0.9v and if so, won't this change make them less power efficient in > the almost-idle case? And are those power savings enough to justify > not accepting this patch? It wil

Re: [linux-sunxi] [PATCH] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to a level all boards can supply

2015-08-03 Thread Timo Sigurdsson
Hi Julian, Julian Calaby schrieb am 03.08.2015 01:35: >> sun7i-a20.dtsi contains an cpufreq operating point at 0.9 volts. Most A20 >> boards >> (or all?), however, do not allow the voltage to go below 1.0V. Thus, raise >> the >> voltage for the lowest operating point to 1.0V so all boards can act

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-08-02 Thread Timo Sigurdsson
Hi Stefan, you didn't include me in your answer, hence the late reply... Stefan Monnier schrieb am 29.07.2015 02:02: >> IMHO for a common maximum opp that's a good approach. But for the lowest >> frequency setting, it would seem more logical to me, to raise the voltage >> to a point where all boa

[PATCH] ARM: dts: sunxi: Raise minimum CPU voltage for sun7i-a20 to a level all boards can supply

2015-08-02 Thread Timo Sigurdsson
sun7i-a20.dtsi contains an cpufreq operating point at 0.9 volts. Most A20 boards (or all?), however, do not allow the voltage to go below 1.0V. Thus, raise the voltage for the lowest operating point to 1.0V so all boards can actually use it. Signed-off-by: Timo Sigurdsson --- arch/arm/boot/dts

[PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

2015-08-02 Thread Timo Sigurdsson
sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 PMU driver, so add them to allow for voltage-scaling with cpufreq-dt. Signed-off-by: Timo Sigurdsson --- Changes since v1 (RFC): - Dropped the changes to the cpufreq operating points and renamed the patch accord

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Hans de Goede schrieb am 28.07.2015 16:24: > I've no problem with Timo submitting a cleaned up version of his > patch and you taking that instead. I just wanted to point out that > I do have a similar patch pending. Ok, I will do that. It might take a couple of days, though, as I will be movi

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Maxime Ripard schrieb am 28.07.2015 14:55: >> IMHO for a common maximum opp that's a good approach. But for the lowest >> frequency setting, it would seem more logical to me, to raise the voltage >> to a point where all boards will run fine with them, unless those boards >> cannot handle the

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Maxime Ripard schrieb am 28.07.2015 14:55: >> > I plan to submit this for 4.3. >> >> Ok, then I guess we can drop my patch. > > Please don't. Ok. > It was used in mainline, and reverted because it was not stable > enough. Well, the explanation given was, it was not stable because of the mi

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Maxime Ripard schrieb am 28.07.2015 14:49: > I don't feel like holding patches that were posted before you did > because you did them some time ago and never submitted them is > reasonnable and / or encouraging for new submitters of patches. > > I'd really like to get more sunxi-people contri

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Chen-Yu Tsai schrieb am 27.07.2015 15:14: >> ChenYu (in the CC), since you did most of the original work here, do >> you know why we have an op at 0.9 volt, but none of our boards allow the >> voltage to go that low in the regulator settings ? > > I'm on vacation now, so apologies for the bad

Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-28 Thread Timo Sigurdsson
Hi, Hans de Goede schrieb am 27.07.2015 14:43: >>> I've a simular patch here: >>> >>> https://github.com/jwrdegoede/linux-sunxi/commit/6a30b7d5be6012b81e5e1439a444e41c0ac1afc1 >>> >>> I did not submit this upstream yet as it is part of a series to enable the >>> otg >>> controller on the bananapi

[RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi

2015-07-26 Thread Timo Sigurdsson
thing important? Signed-off-by: Timo Sigurdsson --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 47 +--- 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 9f7b472..2bcbb0e 10