Re: [PATCH v5 2/4] clk: rockchip: set an ID for crypto clk

2015-11-25 Thread Zain
On 2015年11月25日 16:14, Heiko Stübner wrote: > Hi Zain, > > Am Mittwoch, 25. November 2015, 13:43:31 schrieb Zain Wang: >> Set an ID for crypto clk, so that it can be called in other part. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >&g

[PATCH v5 4/4] ARM: dts: rockchip: Add Crypto node for rk3288

2015-11-24 Thread Zain Wang
Add Crypto node for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v5: - None Changed in v4: - None Changed in v3: - add reset property Changed in v2: - None Changed in

[PATCH v5 0/4] crypto: add crypto accelerator support for rk3288

2015-11-24 Thread Zain Wang
the prio of cipher - add Kconfig Zain Wang (4): crypto: rockchip/crypto - add DT bindings documentation clk: rockchip: set an ID for crypto clk Crypto: rockchip/crypto - add crypto driver for rk3288 ARM: dts: rockchip: Add Crypto node for rk3288 .../devicetree/bindings/crypto/rockchip

[PATCH v5 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-24 Thread Zain Wang
Crypto driver support: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Tested-by: Heiko Stuebner <he...@

[PATCH v5 2/4] clk: rockchip: set an ID for crypto clk

2015-11-24 Thread Zain Wang
Set an ID for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Acked-by: Michael Turquette <mturque...@baylibre.com> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v5: - None Changed in v4: - None Changed in

[PATCH v5 1/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-24 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v5: - None Changed in v4: - None Changed in v3: - add reset prope

Re: [PATCH v4 2/4] clk: rockchip: set an ID for crypto clk

2015-11-23 Thread Zain
On 2015年11月24日 07:24, Heiko Stübner wrote: > Hi Zain, > > Am Dienstag, 17. November 2015, 12:00:45 schrieb Zain Wang: >> Set an ID for crypto clk, so that it can be called in other part. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >&g

Re: [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-23 Thread Zain
On 2015年11月23日 20:51, Herbert Xu wrote: > On Tue, Nov 17, 2015 at 12:00:46PM +0800, Zain Wang wrote: >> +static void rk_ablk_hw_init(struct rk_crypto_info *dev) >> +{ >> +struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(dev->ablk_req); >>

[PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-16 Thread Zain Wang
Crypto driver support: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Tested-by: Heiko Stuebner <he...@

[PATCH v4 4/4] ARM: dts: rockchip: Add Crypto node for rk3288

2015-11-16 Thread Zain Wang
Add Crypto node for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v4: - None Changed in v3: - add reset property Changed in v2: - None Changed in v1: - remove the _c

[PATCH v4 1/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-16 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v4: - None Changed in v3: - add reset property Changed in v

[PATCH v4 2/4] clk: rockchip: set an ID for crypto clk

2015-11-16 Thread Zain Wang
Set an ID for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> Acked-by: Michael Turquette <mturque...@baylibre.com> Tested-by: Heiko Stuebner <he...@sntech.de> --- Changed in v4: - None Changed in v3: - None Changed in v

[PATCH v4 0/4] crypto: add crypto accelerator support for rk3288

2015-11-16 Thread Zain Wang
more dev_xxx in probe - modify the prio of cipher - add Kconfig Zain Wang (4): crypto: rockchip/crypto - add DT bindings documentation clk: rockchip: set an ID for crypto clk Crypto: rockchip/crypto - add crypto driver for rk3288 ARM: dts: rockchip: Add Crypto node for rk3288 .../devicetree

Re: [PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-15 Thread Zain
On 2015年11月15日 06:41, Heiko Stuebner wrote: > Hi Zain, > > Am Freitag, 13. November 2015, 14:44:43 schrieb Zain: >> On 2015年11月12日 20:32, Heiko Stuebner wrote: >>> Hi Zain, >>> >>> I was able to sucessfully test your crypto-driver, but have found some &

Re: [PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-12 Thread Zain
On 2015年11月12日 20:32, Heiko Stuebner wrote: > Hi Zain, > > I was able to sucessfully test your crypto-driver, but have found some > improvements below that should probably get looked at: > > Am Mittwoch, 11. November 2015, 14:35:58 schrieb Zain Wang: >> Crypto driver

Re: [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk

2015-11-12 Thread Zain
On 2015年11月12日 16:40, Heiko Stuebner wrote: > Am Donnerstag, 12. November 2015, 09:13:20 schrieb Zain: >> On 2015年11月12日 07:57, Heiko Stuebner wrote: >>> Am Mittwoch, 11. November 2015, 14:35:57 schrieb Zain Wang: >>>> Set an ID for crypto clk, so that

Re: [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk

2015-11-11 Thread Zain
On 2015年11月12日 07:57, Heiko Stuebner wrote: > Am Mittwoch, 11. November 2015, 14:35:57 schrieb Zain Wang: >> Set an ID for crypto clk, so that it can be called in other part. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> > this should go in together w

Re: [PATCH v3 1/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-11 Thread Zain
Hi Rob, On 2015年11月12日 04:24, Rob Herring wrote: > On Wed, Nov 11, 2015 at 02:35:56PM +0800, Zain Wang wrote: >> Add DT bindings documentation for the rk3288 crypto drivers. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> > Acked-by: Rob Herrin

[PATCH v3 1/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-10 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v3: - add reset property Changed in v2: - None Changed in v1: - remove the _crypto suffix - use "rockchip,rk3288-crypto" instead of "rock

[PATCH v3 0/4] crypto: add crypto accelerator support for rk3288

2015-11-10 Thread Zain Wang
hash - add weak key detection - changed some variate's type Changed in v1: - modify some variate's name - modify some variate's type - modify some return value - remove or modify some print info - use more dev_xxx in probe - modify the prio of cipher - add Kconfig Zain Wang (4): crypto

[PATCH v3 2/4] clk: rockchip: set an ID for crypto clk

2015-11-10 Thread Zain Wang
Set an ID for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v3: - None Changed in v2: - None Changed in v1: - define SCLK_CRYPTO in rk3288-cru.h - use SCLK_CRYPTO instead of SRST_CRYPTO drivers/clk/rockchip/clk-

[PATCH v3 4/4] ARM: dts: rockchip: Add Crypto node for rk3288

2015-11-10 Thread Zain Wang
Add Crypto node for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v3: - add reset property Changed in v2: - None Changed in v1: - remove the _crypto suffix - use "rockchip,rk3288-crypto" instead of "rockch

[PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

2015-11-10 Thread Zain Wang
Crypto driver support: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v3: - add OF depended in K

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-08 Thread Zain
Hi Heiko, Thanks for your serious comments always. On 2015年11月08日 07:19, Heiko Stuebner wrote: > Hi Zain, > > looks like my comment on v1 came later than your v2 submission, > so here it is again :-) > > Am Freitag, 6. November 2015, 09:17:21 schrieb Zain Wang: >&

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-06 Thread Zain
On 2015年11月06日 18:12, Heiko Stuebner wrote: > Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang: >> Add Crypto drivers for rk3288 including crypto controller and dma clk. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >> --- >> >>

Re: [PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-06 Thread Zain
Hi On 2015年11月06日 17:00, Heiko Stuebner wrote: > Am Freitag, 6. November 2015, 09:17:24 schrieb Zain Wang: >> Add DT bindings documentation for the rk3288 crypto drivers. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >> --- >> >>

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-06 Thread Zain
Hi: On 2015年11月06日 10:00, Caesar Wang wrote: > the subject should be add the node/info for crypto... ok! done! > > 在 2015年11月06日 09:17, Zain Wang 写道: >> Add Crypto drivers for rk3288 including crypto controller and dma clk. >> >> Signed-off-by: Zain Wan

Re: [PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288

2015-11-06 Thread Zain
On 2015年11月06日 09:36, Caesar Wang wrote: > Hi > > 在 2015年11月06日 09:17, Zain Wang 写道: >> This commit support three cipher(AES/DES/DES3) and two >> chainmode(ecb/cbc), >> and the more algorithms and new hash drivers will be added later on. >> >> Changed

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-06 Thread Zain
Hi On 2015年11月06日 09:54, Caesar Wang wrote: > I guess the subject: > "crypto: rockchip: " > > Maybe better. ok! done! > > 在 2015年11月06日 09:17, Zain Wang 写道: >> The names registered are: >> ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_

[PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288

2015-11-05 Thread Zain Wang
some variate's type - modify some return value - remove or modify some print info - use more dev_xxx in probe - modify the prio of cipher - add Kconfig Zain Wang (4): Crypto: Crypto driver support aes/des/des3 for rk3288 clk: rockchip: set an id for crypto clk ARM: dts: rockchip: Add Crypto

[PATCH v2 2/4] clk: rockchip: set an id for crypto clk

2015-11-05 Thread Zain Wang
set an id for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v2: - None Changed in v1: - define SCLK_CRYPTO in rk3288-cru.h - use SCLK_CRYPTO instead of SRST_CRYPTO drivers/clk/rockchip/clk-rk3288.c | 2 +- i

[PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-05 Thread Zain Wang
Add Crypto drivers for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v2: - None Changed in v1: - remove the _crypto suffix - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288" arch/arm

[PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-05 Thread Zain Wang
The names registered are: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changed in v2: - remove some part abou

[PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation

2015-11-05 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- Changde in v2: - None Changed in v1: - remove the _crypto suffix - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288" - remove the description

Re: [PATCH v1 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-03 Thread Zain
Hi LABBE, On 2015年11月03日 16:59, LABBE Corentin wrote: > On Tue, Nov 03, 2015 at 01:52:05PM +0800, Zain Wang wrote: >> Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher >> mode. >> The names registered are: >> ecb(aes) cbc(aes) ecb(des)

[PATCH v1 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-02 Thread Zain Wang
Add Crypto drivers for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- arch/arm/boot/dts/rk3288.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi

[PATCH v1 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-02 Thread Zain Wang
Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher mode. The names registered are: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain

[PATCH v1 0/4] Crypto: add crypto accelerator support for rk3288

2015-11-02 Thread Zain Wang
This commit support three cipher(AES/DES/DES3) and two chainmode(ecb/cbc), and the more algorithms and new hash drivers will be added later on. Zain Wang (4): Crypto: Crypto driver support aes/des/des3 for rk3288 clk: rockchip: set an id for crypto clk ARM: dts: rockchip: Add Crypto drivers

[PATCH v1 4/4] crypto: rk_crypto - add DT bindings documentation

2015-11-02 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- .../devicetree/bindings/crypto/rockchip-crypto.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/

[PATCH v1 2/4] clk: rockchip: set an id for crypto clk

2015-11-02 Thread Zain Wang
set an id for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- drivers/clk/rockchip/clk-rk3288.c | 2 +- include/dt-bindings/clock/rk3288-cru.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-02 Thread Zain
Hi Stephan, On 2015年10月30日 16:59, Stephan Mueller wrote: > Am Freitag, 30. Oktober 2015, 16:22:46 schrieb Zain Wang: > > Hi Zain, > >> Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher >> mode. The names registered are: >>ecb(aes)

Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-02 Thread Zain
Hi LABBE, On 2015年10月30日 16:58, LABBE Corentin wrote: > On Fri, Oct 30, 2015 at 04:22:46PM +0800, Zain Wang wrote: >> Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher >> mode. >> The names registered are: >> ecb(aes) cbc(aes) ecb(des)

Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

2015-11-02 Thread Zain
Hi Mark On 2015年10月30日 22:03, Mark Rutland wrote: > On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote: >> Add DT bindings documentation for the rk3288 crypto drivers. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >> --- >> .../d

Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-02 Thread Zain
Hi Heiko, On 2015年10月30日 22:26, Heiko Stuebner wrote: > Hi, > > first of all, thanks for working on this, it will be really cool to see the > crypto accelerator supported in the kernel :-) > > Am Freitag, 30. Oktober 2015, 16:22:46 schrieb Zain Wang: >> Crypto driver suppo

Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

2015-11-02 Thread Zain
Hi Mark, On 2015年11月02日 23:39, Rob Herring wrote: > On Mon, Nov 2, 2015 at 3:13 AM, Zain <zain.w...@rock-chips.com> wrote: >> Hi Mark >> >> On 2015年10月30日 22:03, Mark Rutland wrote: >>> On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote: >>>&

Re: [RESEND PATCH 2/4] clk: rockchip: set an id for crypto clk

2015-11-01 Thread Zain
Hi Heiko, On 2015年10月30日 16:54, Heiko Stuebner wrote: > Hi Zain, > > Am Freitag, 30. Oktober 2015, 16:22:47 schrieb Zain Wang: >> set an id for crypto clk, so that it can be called in other part. >> >> Signed-off-by: Zain Wang <zain.w...@rock-chips.com> >>

[RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

2015-10-30 Thread Zain Wang
Add DT bindings documentation for the rk3288 crypto drivers. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- .../devicetree/bindings/crypto/rk-crypto.txt | 31 ++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/cry

[RESEND PATCH 0/4] Crypto: add crypto accelerator support for rk3288

2015-10-30 Thread Zain Wang
This commit support three cipher(AES/DES/DES3) and two chainmode(ecb/cbc), and the more algorithms or new hash drivers will be added later on. Zain Wang (4): Crypto: Crypto driver support aes/des/des3 for rk3288 clk: rockchip: set an id for crypto clk ARM: dts: rockchip: Add Crypto drivers

[RESEND PATCH 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-10-30 Thread Zain Wang
Add Crypto drivers for rk3288 including crypto controller and dma clk. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- arch/arm/boot/dts/rk3288.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi

[RESEND PATCH 2/4] clk: rockchip: set an id for crypto clk

2015-10-30 Thread Zain Wang
set an id for crypto clk, so that it can be called in other part. Signed-off-by: Zain Wang <zain.w...@rock-chips.com> --- drivers/clk/rockchip/clk-rk3288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk

[RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-10-30 Thread Zain Wang
Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher mode. The names registered are: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain