Re: [PATCH v3 0/7] Introducing (yet again) Device Tree Overlays

2014-04-18 Thread delicious quinoa
On Thu, Apr 17, 2014 at 11:12 AM, Pantelis Antoniou wrote: > Hi Alan, > > Ugh, very sorry for the late reply; my mailer filed this somewhere I don't > look at very frequently. > > On Mar 28, 2014, at 8:27 PM, delicious quinoa wrote: > >> On Tue, Mar 18, 20

Re: [PATCH v3 0/7] Introducing (yet again) Device Tree Overlays

2014-04-17 Thread delicious quinoa
On Wed, Apr 16, 2014 at 4:33 PM, Rob Herring wrote: > On Wed, Apr 16, 2014 at 4:23 PM, delicious quinoa > wrote: >> On Thu, Apr 3, 2014 at 3:40 PM, delicious quinoa >> wrote: >>> On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa >>> wrote: >>&g

Re: [PATCH v3 0/7] Introducing (yet again) Device Tree Overlays

2014-04-16 Thread delicious quinoa
On Thu, Apr 3, 2014 at 3:40 PM, delicious quinoa wrote: > On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa > wrote: >> On Tue, Mar 18, 2014 at 4:55 PM, Pantelis Antoniou >> wrote: >>> The following patchset introduces Device Tree overlays, a method >>> of dy

Re: [PATCH 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller

2014-04-08 Thread delicious quinoa
On Tue, Apr 8, 2014 at 9:33 AM, Steffen Trumtrar wrote: > On Tue, Apr 08, 2014 at 09:29:50AM -0500, Thor Thayer wrote: >> On Tue, 2014-04-08 at 15:38 +0200, Steffen Trumtrar wrote: >> > Hi! >> > >> > On Mon, Apr 07, 2014 at 04:54:07PM -0500, ttha...@altera.com wrote: >> > > From: Thor Thayer >> >

Re: [PATCH v3 0/7] Introducing (yet again) Device Tree Overlays

2014-04-03 Thread delicious quinoa
On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa wrote: > On Tue, Mar 18, 2014 at 4:55 PM, Pantelis Antoniou > wrote: >> The following patchset introduces Device Tree overlays, a method >> of dynamically altering the kernel's live Device Tree, along with >> a gen

Re: [PATCH v3 2/7] OF: Introduce DT overlay support.

2014-03-28 Thread delicious quinoa
conditions > + * appropriately. Either the operation succeeds, or if it fails the > + * live tree is reverted to the state before the attempt. > + * Returns 0, or an error if the overlay attempt failed. > + */ > +int of_overlay(int count, struct of_overlay_info *ovinfo_tab);

Re: [PATCH v3 0/7] Introducing (yet again) Device Tree Overlays

2014-03-28 Thread delicious quinoa
;] (do_rmdir+0x120/0x150) from [<8010a800>] (SyS_rmdir+0x20/0x24) [<8010a800>] (SyS_rmdir+0x20/0x24) from [<8000eac0>] (ret_fast_syscall+0x0/0x30) Code: e1a04000 e59f0074 eb12b02b e5943010 (e5932018) ---[ end trace 1b8539e83d8e0ecc ]--- ./do-overlay-only: line 7: 175 Segm

Re: [PATCH v3 2/7] OF: Introduce DT overlay support.

2014-03-28 Thread delicious quinoa
On Tue, Mar 18, 2014 at 4:56 PM, Pantelis Antoniou wrote: > Introduce DT overlay support. > Using this functionality it is possible to dynamically overlay a part of > the kernel's tree with another tree that's been dynamically loaded. > It is also possible to remove node and properties. > > The cr

Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces

2014-03-21 Thread delicious quinoa
On Fri, Mar 21, 2014 at 1:14 PM, delicious quinoa wrote: > On Thu, Mar 20, 2014 at 2:55 PM, Sebastian Andrzej Siewior > wrote: >> The cycloneV has three gpio controllers, each one with 29 gpios. This patch >> adds the three controller with the gpio driver which is now sittin

Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces

2014-03-21 Thread delicious quinoa
here register 0...28. Hi Sebastian, The ref manual is wrong. It is 27. The last two aren't pinned out. Alan Tull aka delicious quinoa -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces

2014-03-21 Thread delicious quinoa
On Thu, Mar 20, 2014 at 2:55 PM, Sebastian Andrzej Siewior wrote: > The cycloneV has three gpio controllers, each one with 29 gpios. This patch > adds the three controller with the gpio driver which is now sitting the > gpio tree. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Sebastian Andrz

Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-03-06 Thread delicious quinoa
+++ b/drivers/gpio/Kconfig @@ -132,7 +132,7 @@ config GPIO_DWAPB tristate "Synopsys DesignWare APB GPIO driver" select GPIO_GENERIC select GENERIC_IRQ_CHIP - depends on OF_GPIO && IRQ_DOMAIN + depends on OF_GPIO help Say Y or M

Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-03-05 Thread delicious quinoa
show support for 1 gpio per port. >> - gpio-cells = <1> > > Patch applied! > > You've done a tremendous work on this driver and there is > absolutely nothing controversial about the bindings, so it is > my pleasure to include this driver. > > Yours, > Lin

Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-26 Thread delicious quinoa
On Tue, Feb 25, 2014 at 5:01 PM, Alan Tull wrote: > From: Jamie Iles > > The Synopsys DesignWare block is used in some ARM devices (picoxcell) > and can be configured to provide multiple banks of GPIO pins. > > Signed-off-by: Jamie Iles > Signed-off-by: Alan Tull > Reviewed-by: Sebastian Hessel

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-24 Thread delicious quinoa
On Mon, Feb 24, 2014 at 6:20 AM, Linus Walleij wrote: > On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa > wrote: > >> I am wondering about the change in usage of >> irq_find_mapping/irq_create_mapping. It seems like all the GPIO >> drivers that use irq domains d

Re: [PATCH] export of_irq_count

2014-02-12 Thread delicious quinoa
On Wed, Feb 12, 2014 at 12:32 PM, Rob Herring wrote: > On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa > wrote: >> From: Alan Tull >> >> export of_irq_count so it can be used in drivers that are built >> as modules. > > What drivers? Drivers generally s

[PATCH] export of_irq_count

2014-02-12 Thread delicious quinoa
From: Alan Tull export of_irq_count so it can be used in drivers that are built as modules. Signed-off-by: Alan Tull --- drivers/of/irq.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 9bcf2cf..5ed19f3 100644 --- a/drivers/of/irq.c +++ b/driver

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-12 Thread delicious quinoa
On Mon, Feb 10, 2014 at 5:06 AM, Linus Walleij wrote: > Hi Alan, this is starting to look good. I's like an ACK from a DT > maintainer on the bindings but can't see anything really controversial > about them. > > On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull wrote: > >> +static int dwapb_gpio_to_irq

Re: [PATCH v10] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-06 Thread delicious quinoa
struct dwapb_gpio_port *port) >> +{ >> + struct gpio_chip *gc = &port->bgc.gc; >> + struct device_node *node = gc->of_node; >> + struct irq_chip_generic *irq_gc; >> + unsigned int hwirq, ngpio = gc->ngpio; >> + struct irq_chip_type *ct; >> + int reg, err, irq; >> + >> + if (of_get_property(node, "interrupts", ®) == NULL) >> + return; > > of_get_property can take a NULL lenp (core OF code depends on this > fact), so you don't need the somewhat confusing ® here. > > Cheers, > Mark. Hi Mark, Thanks for the feedback. I have made the changes in v11, which I just sent out. Alan Tull aka delicious quinoa -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v9] gpio: add a driver for Synopsys DesignWare APB GPIO

2014-01-30 Thread delicious quinoa
On Thu, Jan 30, 2014 at 3:32 PM, Steffen Trumtrar wrote: > On Thu, Jan 30, 2014 at 03:15:11PM -0600, delicious quinoa wrote: >> On Thu, Jan 30, 2014 at 2:50 PM, Steffen Trumtrar >> wrote: >> > Hi! >> > >> > On Thu, Jan 30, 2014 at 01:40:04PM -0600, de

Re: [PATCH v9] gpio: add a driver for Synopsys DesignWare APB GPIO

2014-01-30 Thread delicious quinoa
On Thu, Jan 30, 2014 at 2:50 PM, Steffen Trumtrar wrote: > Hi! > > On Thu, Jan 30, 2014 at 01:40:04PM -0600, delicious quinoa wrote: >> On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar >> wrote: >> >> > Second: The interrupt is registered as "GIC 37"

Re: [PATCH v9] gpio: add a driver for Synopsys DesignWare APB GPIO

2014-01-30 Thread delicious quinoa
On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar wrote: > Second: The interrupt is registered as "GIC 37", which is a real interrupt on > the Socfpga. I would expect it to be marked as "GPIO 2xx" (or something in > that > range). The interrupt from the gpiochip itself isn't registered at all ?!

Re: [PATCH v9] gpio: add a driver for Synopsys DesignWare APB GPIO

2013-12-17 Thread delicious quinoa
On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar wrote: > Sorry for chiming in late. I tested your driver on the Sockit and the GPIOs > work fine (basically just tested the 4 HPS LEDS that are on this board). > > With the interrupt support I had a little trouble though: > The Sockit has an ADXL34

Re: [PATCH v9] gpio: add a driver for Synopsys DesignWare APB GPIO

2013-12-11 Thread delicious quinoa
On Fri, Dec 6, 2013 at 3:09 PM, Alan Tull wrote: > From: Alan Tull > > Hi Linus, > > If you don't have any further comments, can you take this patch? > > Alan Basically, this is a driver that Jamie wrote and was upstreaming a few years ago. For some reason it never quite made it into the kernel

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 4:53 PM, delicious quinoa wrote: > On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote: >> Hi Alan, >> >> One minor comment below, otherwise looks great! >> >> Signed-off-by: Jamie Iles >> >> Thanks, >> >> Jamie

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Wed, Dec 4, 2013 at 5:56 AM, Mark Rutland wrote: > On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote: >> From: Jamie Iles >> >> The Synopsys DesignWare block is used in some ARM devices (picoxcell) >> and can be configured to provide multiple banks of GPIO pins. >> >> Signed-off-by: Al

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote: > Hi Alan, > > One minor comment below, otherwise looks great! > > Signed-off-by: Jamie Iles > > Thanks, > > Jamie > > On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: >> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.

Re: [PATCH v7] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-11-21 Thread delicious quinoa
On Thu, Nov 21, 2013 at 6:28 AM, Sebastian Hesselbarth wrote: > On 11/20/2013 10:48 PM, Alan Tull wrote: >> >> From: Jamie Iles >> >> The Synopsys DesignWare block is used in some ARM devices (picoxcell) >> and can be configured to provide multiple banks of GPIO pins. >> >> Signed-off-by: Alan Tu

Re: [PATCH 1/1] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-11-20 Thread delicious quinoa
On Thu, Nov 7, 2013 at 6:33 AM, Sebastian Hesselbarth wrote: > On 11/06/13 23:49, Alan Tull wrote: >> >> From: Jamie Iles >> >> The Synopsys DesignWare block is used in some ARM devices (picoxcell) >> and can be configured to provide multiple banks of GPIO pins. >> >> Signed-off-by: Alan Tull >>

Re: [PATCH 3/3] DT: proc: Add runtime overlay interface in /proc

2013-11-07 Thread delicious quinoa
On Tue, Nov 5, 2013 at 12:41 PM, Pantelis Antoniou wrote: > + > + pr_info("%s: Applied #%d overlay segments @%d\n", __func__, > + od->ovinfo_cnt, od->id); > + This could be pr_debug so that we get normally get silence unless something fails, like insmod. Also please t

Re: [PATCH 1/1] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-11-07 Thread delicious quinoa
On Wed, Nov 6, 2013 at 5:44 PM, Sebastian Hesselbarth wrote: >>> +struct dwapb_gpio { >>> + struct device *dev; >>> + void __iomem*regs; >>> + struct dwapb_gpio_port *ports; >>> + unsigned intnr_ports; >>> + struct irq_domain *

Re: [PATCH 1/1] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-11-06 Thread delicious quinoa
On Wed, Nov 6, 2013 at 5:09 PM, Fabio Estevam wrote: > On Wed, Nov 6, 2013 at 8:49 PM, Alan Tull wrote: > >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + gpio->regs = devm_ioremap_resource(&pdev->dev, res); >> + if (!gpio->regs) { >> + err = -E

Re: [PATCH 3/3] use linear irq domain in gpio-dwapb

2013-11-05 Thread delicious quinoa
On Tue, Nov 5, 2013 at 3:32 PM, Sebastian Hesselbarth wrote: > On 11/05/2013 05:55 PM, Alan Tull wrote: >> >> From: Alan Tull >> >> * Changes to get gpio-dwapb (originally v3.2-rc7) driver building and >> working on current kernel. >> * Use linear irq domain. >> * Fix setting irq edge t

Re: gpio: dwapb: Synopsys Designware GPIO

2013-10-31 Thread delicious quinoa
On Thu, Oct 31, 2013 at 10:18 AM, Dinh Nguyen wrote: > Yes, we'll post a patch up on rocketboards-next and maybe we can post them > to the mailing list too? > Hi Steffen, I've posted a branch on rocketboards.orgs' linux-socfpga-next.git. The branch name is dwapb-gpio-3.11. The top five patches a