Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Off-by-one ay? Wasn't the original code tested? Signed-off-by: Jacek Anaszewski

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Off-by-one ay? Wasn't the original code

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver.

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Pavel Machek wrote: On Tue 2015-01-20 15:40:29, Lee Jones wrote: On Tue, 20 Jan 2015, Jacek Anaszewski wrote: On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Jacek Anaszewski wrote: On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Pavel Machek
On Tue 2015-01-20 15:40:29, Lee Jones wrote: On Tue, 20 Jan 2015, Jacek Anaszewski wrote: On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work

[PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-09 Thread Jacek Anaszewski
Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Chanwoo Choi

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-09 Thread Pavel Machek
On Fri 2015-01-09 16:22:57, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin