Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-18 Thread Sakari Ailus
Hi Richard, Richard Purdie wrote: > On Thu, 2014-08-14 at 07:39 +0300, Sakari Ailus wrote: >> Bryan and Richard, >> >> Your opinion would be much appreciated to a question myself and Jacek were >> pondering. Please see below. >> >> On Thu, Aug 07, 2014 at 03:12:09PM +0200, Jacek Anaszewski wrote:

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-18 Thread Richard Purdie
On Thu, 2014-08-14 at 07:39 +0300, Sakari Ailus wrote: > Bryan and Richard, > > Your opinion would be much appreciated to a question myself and Jacek were > pondering. Please see below. > > On Thu, Aug 07, 2014 at 03:12:09PM +0200, Jacek Anaszewski wrote: > > Hi Sakari, > > > > On 08/04/2014 02:

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-13 Thread Sakari Ailus
Bryan and Richard, Your opinion would be much appreciated to a question myself and Jacek were pondering. Please see below. On Thu, Aug 07, 2014 at 03:12:09PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 08/04/2014 02:50 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thank you for your continu

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-07 Thread Jacek Anaszewski
Hi Sakari, On 08/04/2014 02:50 PM, Sakari Ailus wrote: Hi Jacek, Thank you for your continued efforts on this! On Mon, Aug 04, 2014 at 02:35:26PM +0200, Jacek Anaszewski wrote: On 07/16/2014 11:54 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: ... diff --git a/include/linux/leds

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-04 Thread Sakari Ailus
Hi Jacek, Thank you for your continued efforts on this! On Mon, Aug 04, 2014 at 02:35:26PM +0200, Jacek Anaszewski wrote: > On 07/16/2014 11:54 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Jacek Anaszewski wrote: > >... > >>diff --git a/include/linux/leds.h b/include/linux/leds.h > >>index 1a130cc

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-04 Thread Jacek Anaszewski
Hi Sakari, On 07/16/2014 11:54 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: ... diff --git a/include/linux/leds.h b/include/linux/leds.h index 1a130cc..9bea9e6 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -44,11 +44,21 @@ struct led_classdev { #define LED_BLIN

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-07-16 Thread Sakari Ailus
Hi Jacek, Jacek Anaszewski wrote: ... diff --git a/include/linux/leds.h b/include/linux/leds.h index 1a130cc..9bea9e6 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -44,11 +44,21 @@ struct led_classdev { #define LED_BLINK_ONESHOT_STOP(1 << 18) #define LED_BLINK_INVER

[PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-07-11 Thread Jacek Anaszewski
This patch prepares ground for addition of LED Flash Class extension to the LED subsystem. Since turning the torch on must have guaranteed immediate effect the brightness_set op can't be used for it. Drivers must schedule a work queue task in this op to be compatible with led-triggers, which call b