Re: [PATCH] ARM: Kirkwood: Add DT description of QNAP 419

2014-01-15 Thread Arnd Bergmann
On Wednesday 15 January 2014 18:45:19 Andrew Lunn wrote: > > > But i'm also a little bit concerned by the "unique number" and this > > > ending up in /dev/input/by-path/platform-gpio_keys.3-event. Is this > > > path supposed to be stable? This unique number is not stable. An > > > unwitting change

Re: [PATCH] ARM: Kirkwood: Add DT description of QNAP 419

2014-01-15 Thread Andrew Lunn
> > But i'm also a little bit concerned by the "unique number" and this > > ending up in /dev/input/by-path/platform-gpio_keys.3-event. Is this > > path supposed to be stable? This unique number is not stable. An > > unwitting change to the DT could cause its value to change. Do we need > > to make

Re: [PATCH] ARM: Kirkwood: Add DT description of QNAP 419

2014-01-15 Thread Arnd Bergmann
On Saturday 11 January 2014, Andrew Lunn wrote: > The id of -1 causes platform_device_add() to set the device name to > plain "gpio-keys". > > When using DT, the device name is created by the function > of_device_make_bus_id(). It has the following comment: > > * This routine will first try usin

Re: [PATCH] ARM: Kirkwood: Add DT description of QNAP 419

2014-01-11 Thread Andrew Lunn
On Wed, Jan 08, 2014 at 09:48:37AM +, Ian Campbell wrote: > On Mon, 2014-01-06 at 23:49 +0100, Andrew Lunn wrote: Hi Ian I added in the devicetree list and the input list and added my thoughts below. > The other issue I spotted is > that /dev/input/by-path/platform-gpio-keys-event has > bec