Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Sinan Kaya
On 11/8/2015 4:39 PM, Daniel K. wrote: On 11/08/2015 07:45 AM, Julia Lawall wrote: Remove unneeded variable used to store return value. --- a/drivers/dma/qcom/hidma_ll.c +++ b/drivers/dma/qcom/hidma_ll.c @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev * static int hidma_ll_h

Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Daniel K.
On 11/08/2015 07:45 AM, Julia Lawall wrote: > Remove unneeded variable used to store return value. > > --- a/drivers/dma/qcom/hidma_ll.c > +++ b/drivers/dma/qcom/hidma_ll.c > @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev * > > static int hidma_ll_hw_start(struct hidma_lldev *llde

Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Timur Tabi
Andy Shevchenko wrote: >CC: Sinan Kaya >Signed-off-by: Fengguang Wu Who is the author? I suppose Fengguang is the reporter, right? These are Julia Lawall's coccinelle scripts that automatically run on patches and report problems. Just treat them like normal code reviews and incorporate the

Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Julia Lawall
On Sun, 8 Nov 2015, Andy Shevchenko wrote: > On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote: > > Remove unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > CC: Sinan Kaya > > Signed-off-by: Fengguang Wu > > Who is the author

Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Julia Lawall
On Sun, 8 Nov 2015, Andy Shevchenko wrote: > On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote: > > Remove unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > CC: Sinan Kaya > > Signed-off-by: Fengguang Wu Signed-off-by: Julia

Re: [PATCH] dma: fix returnvar.cocci warnings

2015-11-08 Thread Andy Shevchenko
On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote: > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > CC: Sinan Kaya > Signed-off-by: Fengguang Wu Who is the author? I suppose Fengguang is the reporter, right? > --- > > hidma

[PATCH] dma: fix returnvar.cocci warnings

2015-11-07 Thread Julia Lawall
Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Sinan Kaya Signed-off-by: Fengguang Wu --- hidma_ll.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/dma/qcom/hidma_ll.c +++ b/drivers/dma/qcom/hidma_