Re: [PATCH] iio: add support of the max5821

2014-07-15 Thread Antonio Borneo
On Tue, Jul 15, 2014 at 4:21 AM, Jonathan Cameron ji...@kernel.org wrote: On 14/07/14 18:32, Philippe Reynes wrote: Hi Jonathan, regarding your comment below snip +static int max5821_get_value(struct iio_dev *indio_dev, +int *val, int channel) +{ + struct

Re: [PATCH] iio: add support of the max5821

2014-07-15 Thread Jonathan Cameron
On July 15, 2014 9:56:17 AM GMT+01:00, Antonio Borneo borneo.anto...@gmail.com wrote: On Tue, Jul 15, 2014 at 4:21 AM, Jonathan Cameron ji...@kernel.org wrote: On 14/07/14 18:32, Philippe Reynes wrote: Hi Jonathan, regarding your comment below snip +static int max5821_get_value(struct

Re: [PATCH] iio: add support of the max5821

2014-07-14 Thread Jonathan Cameron
On 14/07/14 18:32, Philippe Reynes wrote: Signed-off-by: Philippe Reynes trem...@yahoo.fr Hi Philippe, Mostly looks good, a few things inline. Bigger ones are: 1) You need locking to prevent some state changes occuring mid way through a read (as it requires a register write then a read back

Re: [PATCH] iio: add support of the max5821

2014-07-14 Thread Peter Meerwald
Hello, some more nitpicking inline below regards, p. Mostly looks good, a few things inline. Bigger ones are: 1) You need locking to prevent some state changes occuring mid way through a read (as it requires a register write then a read back of a value). 2) Use a regulator for your