Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Stathis Voukelatos
On 26/01/15 19:39, Joe Perches wrote: This header file is the public API for the driver. Should it not live under the 'include' directory? Several other drivers seem to follow that convention. It depends on how public is public. If it's _really_ public, it should be in uapi. If it's kinda

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Daniel Borkmann
Hi Stathis, On 01/27/2015 12:15 PM, Stathis Voukelatos wrote: On 26/01/15 10:10, Daniel Borkmann wrote: Hello Daniel. Thank you for your feedback. Packet sockets could also be used for the driver interface to user space, however I think that both approaches would require the same amount of

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Mark Rutland
On Mon, Jan 26, 2015 at 10:16:18AM +, Stathis Voukelatos wrote: On 23/01/15 10:51, Mark Rutland wrote: diff --git a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt new file mode 100644

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Stathis Voukelatos
Hi Daniel, On 26/01/15 10:10, Daniel Borkmann wrote: Hello Daniel. Thank you for your feedback. Packet sockets could also be used for the driver interface to user space, however I think that both approaches would require the same amount of maintenance. We need to maintain a protocol consisting

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Stathis Voukelatos
Hi Florian, On 26/01/15 22:30, Florian Fainelli wrote: On 23/01/15 02:07, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-27 Thread Stathis Voukelatos
Hi Daniel, On 27/01/15 14:46, Daniel Borkmann wrote: Just wanted to clarify some implementation details for your approach. - The driver would need to create and register two net_device instances. One for sniffing Ethernet TX packets and one for RX. Hm, I would represent the whole device as a

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Joe Perches
On Mon, 2015-01-26 at 11:11 +, Stathis Voukelatos wrote: On 24/01/15 21:37, Joe Perches wrote: On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC.

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Stathis Voukelatos
On 23/01/15 11:20, Daniel Borkmann wrote: On 01/23/2015 11:07 AM, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Daniel Borkmann
Hi Stathis, On 01/26/2015 10:49 AM, Stathis Voukelatos wrote: On 23/01/15 11:20, Daniel Borkmann wrote: On 01/23/2015 11:07 AM, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Stathis Voukelatos
On 23/01/15 10:51, Mark Rutland wrote: diff --git a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt new file mode 100644 index 000..6b6e105 --- /dev/null +++

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Stathis Voukelatos
On 23/01/15 18:12, James Hogan wrote: diff --git a/drivers/net/pkt-sniffer/Kconfig b/drivers/net/pkt-sniffer/Kconfig new file mode 100644 index 000..26b4f98 --- /dev/null +++ b/drivers/net/pkt-sniffer/Kconfig @@ -0,0 +1,23 @@ +menuconfig PKT_SNIFFER +tristate Linn packet sniffer

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Stathis Voukelatos
On 24/01/15 21:37, Joe Perches wrote: On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Stathis Voukelatos
On 23/01/15 10:21, Arnd Bergmann wrote: On Friday 23 January 2015 10:07:01 Stathis Voukelatos wrote: +- interrupts : sniffer interrupt specifier +- clocks : specify the system clock for the peripheral +- clock-names : must contain the sys entry +- fifo-block-words : number of words in one data

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-26 Thread Florian Fainelli
On 23/01/15 02:07, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a user-defined pattern and timestamped. It sits

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-25 Thread Joe Perches
On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a user-defined pattern and

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-23 Thread James Hogan
Hi, A few general things below (I'll leave the actual networking bits for others to comment about). On Friday 23 January 2015 10:07:01 Stathis Voukelatos wrote: --- .../bindings/net/linn-ether-packet-sniffer.txt | 27 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 +

[PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-23 Thread Stathis Voukelatos
This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a user-defined pattern and timestamped. It sits between a 100M Ethernet MAC and PHY and is completely

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-23 Thread Mark Rutland
On Fri, Jan 23, 2015 at 10:07:01AM +, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a user-defined pattern and

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-23 Thread Daniel Borkmann
On 01/23/2015 11:07 AM, Stathis Voukelatos wrote: This patch adds support the Ethernet Packet Sniffer H/W module developed by Linn Products Ltd and found in the IMG Pistachio SoC. The module allows Ethernet packets to be parsed, matched against a user-defined pattern and timestamped. It sits

Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

2015-01-23 Thread Arnd Bergmann
On Friday 23 January 2015 10:07:01 Stathis Voukelatos wrote: +- interrupts : sniffer interrupt specifier +- clocks : specify the system clock for the peripheral +- clock-names : must contain the sys entry +- fifo-block-words : number of words in one data FIFO entry + +Example: +