Re: [PATCH] pinctrl: msm: Add msm8960 definitions

2014-06-17 Thread Andy Gross
On Tue, Jun 10, 2014 at 11:25:23AM -0700, Bjorn Andersson wrote: In general, it all looks good. I only have 2 areas of concern. The first is a nit and it has to do with alternate pins for functions. There really isn't a need for a separate function name. That would only be required if the

Re: [PATCH] pinctrl: msm: Add msm8960 definitions

2014-06-17 Thread Bjorn Andersson
On Tue, Jun 17, 2014 at 3:00 PM, Andy Gross agr...@codeaurora.org wrote: On Tue, Jun 10, 2014 at 11:25:23AM -0700, Bjorn Andersson wrote: In general, it all looks good. I only have 2 areas of concern. The first is a nit and it has to do with alternate pins for functions. There really

[PATCH] pinctrl: msm: Add msm8960 definitions

2014-06-10 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- .../bindings/pinctrl/qcom,msm8960-pinctrl.txt | 108 ++ drivers/pinctrl/Kconfig|8 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-msm8960.c