Re: [alsa-devel] [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-04-02 Thread Lori Hikichi
On 15-03-31 12:26 AM, Lars-Peter Clausen wrote: On 03/31/2015 05:16 AM, Scott Branden wrote: [...] +- ssp-port-id: The ssp port interface to use +Valid value are 0, 1, 2, or 3 (for spdif) How about using 'reg' as the property name here. It is the standard property name for identifying

Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-04-02 Thread Lori Hikichi
On 15-03-30 10:58 PM, Mark Brown wrote: On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote: +SSP Subnode properties: +- dai-name: The name of the DAI registered with ASOC ASoC. Okay. Why is this in the DT - it sounds like this is just an internal implementation detail for

Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-03-31 Thread Mark Brown
On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote: +Required properties: + - compatible : brcm,cygnus-audio + - #address-cells: 32bit valued, 1 cell. 1 + - #size-cells: 32bit valued, 1 cell. 1 + - reg : Should contain audio registers location and length + -

Re: [alsa-devel] [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-03-31 Thread Lars-Peter Clausen
On 03/31/2015 05:16 AM, Scott Branden wrote: [...] +- ssp-port-id: The ssp port interface to use + Valid value are 0, 1, 2, or 3 (for spdif) How about using 'reg' as the property name here. It is the standard property name for identifying or assigning an address to a sub-node. -- To

[PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-03-30 Thread Scott Branden
From: Lori Hikichi lhiki...@broadcom.com Add device tree binding documentation for the Cygnus SOC audio block Reviewed-by: Jonathan Richardson jonat...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com Signed-off-by: Lori Hikichi

Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

2015-03-30 Thread Mark Brown
On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote: +SSP Subnode properties: +- dai-name: The name of the DAI registered with ASOC ASoC. Why is this in the DT - it sounds like this is just an internal implementation detail for Linux, not a property of the hardware. +- mode: