Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-10-03 Thread Stefan Wahren
Hi Mark, hi Fabio, Mark Rutland mark.rutl...@arm.com hat am 29. September 2014 um 15:23 geschrieben: I would prefer a top level node for the subsystem that is not a simple-bus. Give it a compatible string and a well-defined set of base properties (looks like you just need the reg for

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Stefan Wahren
Hi Mark, Am 28.09.2014 um 12:22 schrieb Mark Brown: On Sat, Sep 27, 2014 at 12:59:47AM +, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Use subject lines matching the style for the subsystem. sorry i'm not sure what's wrong with

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Mark Brown
On Mon, Sep 29, 2014 at 08:00:50AM +0200, Stefan Wahren wrote: Am 28.09.2014 um 12:22 schrieb Mark Brown: Use subject lines matching the style for the subsystem. sorry i'm not sure what's wrong with the subject lines. Did you expect [PATCH 1/2] regulator: add binding for mxs regulator?

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Mark Rutland
On Sat, Sep 27, 2014 at 01:59:47AM +0100, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com --- .../bindings/regulator/mxs-regulator.txt | 36 1

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Stefan Wahren
Hi Mark, Am 29.09.2014 um 13:09 schrieb Mark Rutland: On Sat, Sep 27, 2014 at 01:59:47AM +0100, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com ---

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Mark Rutland
On Mon, Sep 29, 2014 at 12:53:22PM +0100, Stefan Wahren wrote: Hi Mark, Am 29.09.2014 um 13:09 schrieb Mark Rutland: On Sat, Sep 27, 2014 at 01:59:47AM +0100, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Signed-off-by: Stefan

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Stefan Wahren
Hi, Am 29.09.2014 um 14:41 schrieb Mark Rutland: Well, the simple-bus will cause the children to be probed. But it looks like you care about properties of the parent. I don't think that simple-bus is appropriate because it's not being handled as a transparent bridge from the PoV of the

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-29 Thread Mark Rutland
On Mon, Sep 29, 2014 at 02:10:07PM +0100, Stefan Wahren wrote: Hi, Am 29.09.2014 um 14:41 schrieb Mark Rutland: Well, the simple-bus will cause the children to be probed. But it looks like you care about properties of the parent. I don't think that simple-bus is appropriate because it's

Re: [PATCH 1/2] DT: add binding for mxs regulator

2014-09-28 Thread Mark Brown
On Sat, Sep 27, 2014 at 12:59:47AM +, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Use subject lines matching the style for the subsystem. +Required regulator properties: +- compatible: Must be fsl,mxs-regulator +- reg: Absolute

[PATCH 1/2] DT: add binding for mxs regulator

2014-09-26 Thread Stefan Wahren
This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com --- .../bindings/regulator/mxs-regulator.txt | 36 1 file changed, 36 insertions(+) create mode 100644