Re: [PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-28 Thread Doug Anderson
Ulf, On Tue, Jan 27, 2015 at 7:18 AM, Ulf Hansson wrote: >> I asked Addy to post upstream against mmc_send_tuning(), but I guess >> he didn't (he posted against Alex's NAKed patch instead). >> >> ...when I talked to him about it, Addy was asserting that when tuning >> fails it is important (at le

Re: [PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-27 Thread Ulf Hansson
On 26 January 2015 at 18:45, Doug Anderson wrote: > Ulf, > > On Mon, Jan 26, 2015 at 7:15 AM, Ulf Hansson wrote: >> On 26 January 2015 at 12:19, Addy Ke wrote: >>> We need to take the card pointer in execute_tuning() for mmc_send_status(), >> >> mmc_send_status() is an mmc core function, not int

Re: [PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-26 Thread Russell King - ARM Linux
On Mon, Jan 26, 2015 at 09:45:07AM -0800, Doug Anderson wrote: > Ulf, > > On Mon, Jan 26, 2015 at 7:15 AM, Ulf Hansson wrote: > > On 26 January 2015 at 12:19, Addy Ke wrote: > >> We need to take the card pointer in execute_tuning() for mmc_send_status(), > > > > mmc_send_status() is an mmc core

Re: [PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-26 Thread Doug Anderson
Ulf, On Mon, Jan 26, 2015 at 7:15 AM, Ulf Hansson wrote: > On 26 January 2015 at 12:19, Addy Ke wrote: >> We need to take the card pointer in execute_tuning() for mmc_send_status(), > > mmc_send_status() is an mmc core function, not intended for host's to call. > >> but mmc->card is NULL in tuni

Re: [PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-26 Thread Ulf Hansson
On 26 January 2015 at 12:19, Addy Ke wrote: > We need to take the card pointer in execute_tuning() for mmc_send_status(), mmc_send_status() is an mmc core function, not intended for host's to call. > but mmc->card is NULL in tuning state. So we need change the first parameter > of execute_tuning

[PATCH 1/2] mmc: core: use card pointer as the first parameter of execute_tuning()

2015-01-26 Thread Addy Ke
We need to take the card pointer in execute_tuning() for mmc_send_status(), but mmc->card is NULL in tuning state. So we need change the first parameter of execute_tuning() to card pointer(struct mmc_card * card). Signed-off-by: Addy Ke --- drivers/mmc/core/core.c | 2 +- drivers/mmc/h