Re: [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-14 Thread Koro Chen
On Fri, 2015-06-12 at 14:06 +0100, Mark Brown wrote: On Wed, Jun 10, 2015 at 10:24:34PM +0800, Koro Chen wrote: This is the DPCM based platform driver of AFE (Audio Front End) unit. Signed-off-by: Koro Chen koro.c...@mediatek.com Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Your

Re: [alsa-devel] [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-12 Thread Koro Chen
On Fri, 2015-06-12 at 09:37 +0200, Paul Bolle wrote: On Fri, 2015-06-12 at 09:55 +0800, Koro Chen wrote: On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote: (What does negating a bool twice do?) Because bool actually can be unsigned char, although actually in this driver, the caller

Re: [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-12 Thread Mark Brown
On Wed, Jun 10, 2015 at 10:24:34PM +0800, Koro Chen wrote: This is the DPCM based platform driver of AFE (Audio Front End) unit. Signed-off-by: Koro Chen koro.c...@mediatek.com Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Your signoff should be last if you're the one sending the patch.

Re: [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-11 Thread Paul Bolle
On Wed, 2015-06-10 at 22:24 +0800, Koro Chen wrote: --- /dev/null +++ b/sound/soc/mediatek/Kconfig +config SND_SOC_MEDIATEK + bool ASoC support for Mediatek chip + depends on ARCH_MEDIATEK + help + This adds ASoC platform driver support for Mediatek chip + that can

Re: [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-11 Thread Paul Bolle
On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote: Is SND_SOC_MEDIATEK perhaps meant to be bool? s/bool/tristate/, of course. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [alsa-devel] [PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-11 Thread Koro Chen
On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote: On Wed, 2015-06-10 at 22:24 +0800, Koro Chen wrote: --- /dev/null +++ b/sound/soc/mediatek/Kconfig +config SND_SOC_MEDIATEK + bool ASoC support for Mediatek chip + depends on ARCH_MEDIATEK + help + This adds ASoC

[PATCH 1/3] ASoC: mediatek: Add AFE platform driver

2015-06-10 Thread Koro Chen
This is the DPCM based platform driver of AFE (Audio Front End) unit. Signed-off-by: Koro Chen koro.c...@mediatek.com Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/sound/mtk-afe-pcm.txt | 45 + sound/soc/Kconfig |1 +