Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-09 Thread Arnd Bergmann
On Wednesday 08 October 2014 15:16:55 Scott Branden wrote: > It looks like I will also be able to add Northstar under the > ARCH_BCM_IPROC. This will be good momentum to cleaning up and > consolidate support going forward. > I will change the Kconfig such that ARCH_BCM_5301X selects ARCH_BCM_IPR

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
On 14-10-08 11:12 AM, Arnd Bergmann wrote: On Wednesday 08 October 2014 09:27:08 Scott Branden wrote: On 14-10-08 06:28 AM, Arnd Bergmann wrote: On Wednesday 08 October 2014 05:27:24 Scott Branden wrote: I don't think you need per-board config options. The main option above should be enough.

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
On 14-10-08 11:12 AM, Arnd Bergmann wrote: On Wednesday 08 October 2014 09:27:08 Scott Branden wrote: On 14-10-08 06:28 AM, Arnd Bergmann wrote: On Wednesday 08 October 2014 05:27:24 Scott Branden wrote: I don't think you need per-board config options. The main option above should be enough.

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 09:27:08 Scott Branden wrote: > On 14-10-08 06:28 AM, Arnd Bergmann wrote: > > On Wednesday 08 October 2014 05:27:24 Scott Branden wrote: > >>> > >>> I don't think you need per-board config options. The main option > >>> above should be enough. > >> This is not a per-bo

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
Thanks for comments - inline. On 14-10-08 06:10 AM, Rob Herring wrote: On Wed, Oct 8, 2014 at 12:27 AM, Scott Branden wrote: From: Jonathan Richardson Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. Reviewed-by: Ray Jui Reviewed-by: Desmond Liu Reviewed-by: JD (J

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
On 14-10-08 06:28 AM, Arnd Bergmann wrote: On Wednesday 08 October 2014 05:27:24 Scott Branden wrote: diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index fc93800..2dd3f78 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -5,6 +5,37 @@ menuconfig ARCH_

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 05:27:24 Scott Branden wrote: > >> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > >> index fc93800..2dd3f78 100644 > >> --- a/arch/arm/mach-bcm/Kconfig > >> +++ b/arch/arm/mach-bcm/Kconfig > >> @@ -5,6 +5,37 @@ menuconfig ARCH_BCM > >> > >> if AR

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Rob Herring
On Wed, Oct 8, 2014 at 12:27 AM, Scott Branden wrote: > From: Jonathan Richardson > > Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. > > Reviewed-by: Ray Jui > Reviewed-by: Desmond Liu > Reviewed-by: JD (Jiandong) Zheng > Tested-by: Jonathan Richardson > Signed-off-

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
Thanks for the review - comments inline. On 14-10-08 12:54 AM, Arnd Bergmann wrote: On Tuesday 07 October 2014 22:27:00 Scott Branden wrote: From: Jonathan Richardson Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. Reviewed-by: Ray Jui Reviewed-by: Desmond Liu Rev

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Russell King - ARM Linux
On Wed, Oct 08, 2014 at 04:17:29AM -0700, Scott Branden wrote: > Thanks - was unaware of this functionality. Will add .l2c_aux_val and > .l2c_aux mask to DT_MATCHINE_START. BUT, what happens when we need to > add trustzone support and make SMC call to secure monitor? You will then need to im

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Scott Branden
On 14-10-08 01:11 AM, Russell King - ARM Linux wrote: On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: +static void __init bcm_cygnus_init(void) +{ + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); + + l2x0_of_init(0, ~0UL); Please don't explicitly

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Russell King - ARM Linux
On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: > +static void __init bcm_cygnus_init(void) > +{ > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > + > + l2x0_of_init(0, ~0UL); Please don't explicitly call l2x0 initialisation. Instead, set the appropr

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-08 Thread Arnd Bergmann
On Tuesday 07 October 2014 22:27:00 Scott Branden wrote: > From: Jonathan Richardson > > Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. > > Reviewed-by: Ray Jui > Reviewed-by: Desmond Liu > Reviewed-by: JD (Jiandong) Zheng > Tested-by: Jonathan Richardson > Signed-

[PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-10-07 Thread Scott Branden
From: Jonathan Richardson Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. Reviewed-by: Ray Jui Reviewed-by: Desmond Liu Reviewed-by: JD (Jiandong) Zheng Tested-by: Jonathan Richardson Signed-off-by: Scott Branden --- arch/arm/mach-bcm/Kconfig | 31

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-09-18 Thread Jonathan Richardson
Hi Mark, Thanks for the feedback. On 14-09-16 05:00 PM, Mark Rutland wrote: > On Tue, Sep 16, 2014 at 08:58:12PM +0100, Jonathan Richardson wrote: >> Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. >> >> Reviewed-by: Ray Jui >> Reviewed-by: Desmond Liu >> Reviewed-by:

Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-09-16 Thread Mark Rutland
On Tue, Sep 16, 2014 at 08:58:12PM +0100, Jonathan Richardson wrote: > Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. > > Reviewed-by: Ray Jui > Reviewed-by: Desmond Liu > Reviewed-by: JD (Jiandong) Zheng > Tested-by: Jonathan Richardson > Signed-off-by: Jonathan Ric

[PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

2014-09-16 Thread Jonathan Richardson
Adds initial support for the Cygnus SoC based on Broadcom’s iProc series. Reviewed-by: Ray Jui Reviewed-by: Desmond Liu Reviewed-by: JD (Jiandong) Zheng Tested-by: Jonathan Richardson Signed-off-by: Jonathan Richardson --- arch/arm/mach-bcm/Kconfig| 34 +++ arch/arm/mach-bc