On 4 June 2014 10:48, Peter Griffin wrote:
> Hi Ulf,
>
> Thanks for reviewing, see my comments below: -
>
> On Fri, 23 May 2014, Ulf Hansson wrote:
>> > +static unsigned int sdhci_st_get_max_clk(struct sdhci_host *host)
>> > +{
>> > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>
Hi Maxime,
Thanks fo reviewing, see my comments below: -
> >+struct st_mmc_platform_data {
> >+struct reset_control *rstc;
> >+};
> Since it uses the generic reset framework, could we imagine moving
> the reset to the sdhci_pltfm_host struct?
> Doing this, we could get rid of st_mmc_platfo
Hi Srini,
Thanks for reviewing, see my comments below: -
On Fri, 23 May 2014, Srinivas Kandagatla wrote:
> >+struct st_mmc_platform_data {
> >+struct reset_control *rstc;
> >+};
>
> st_mmc_platform_data name is bit missleading as this data is not
> part of platform data. Probably you cou
Hi Lee,
Thanks for your feedback, all your other comments will be fixed in v2.
However see comments below for this patch
> > + clk_prepare_enable(clk);
>
> Move this down as far as it will go. When do you _need_ the clock
> running by?
>
> > + host->mmc->caps |= MMC_CAP_8_BIT_DATA | MMC_C
On 22 May 2014 17:18, Peter Griffin wrote:
> This platform driver adds initial support for the SDHCI host controller
> found on STMicroelectronics SoCs.
>
> It has been tested on STiH41x b2020 platforms currently.
>
> Signed-off-by: Peter Griffin
> Signed-off-by: Giuseppe Cavallaro
> ---
> driv
Hi Pete,
On 22/05/14 16:18, Peter Griffin wrote:
ifeq ($(CONFIG_CB710_DEBUG),y)
CFLAGS-cb710-mmc+= -DDEBUG
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
new file mode 100644
index 000..1790fa7
--- /dev/null
+++ b/drivers/mmc/host/sdhci-st.c
@@ -0,
> This platform driver adds initial support for the SDHCI host controller
> found on STMicroelectronics SoCs.
>
> It has been tested on STiH41x b2020 platforms currently.
>
> Signed-off-by: Peter Griffin
> Signed-off-by: Giuseppe Cavallaro
> ---
> drivers/mmc/host/Kconfig| 12 +++
> driv
Hi Peter
On 05/22/2014 05:18 PM, Peter Griffin wrote:
This platform driver adds initial support for the SDHCI host controller
found on STMicroelectronics SoCs.
It has been tested on STiH41x b2020 platforms currently.
Signed-off-by: Peter Griffin
Signed-off-by: Giuseppe Cavallaro
---
driver
This platform driver adds initial support for the SDHCI host controller
found on STMicroelectronics SoCs.
It has been tested on STiH41x b2020 platforms currently.
Signed-off-by: Peter Griffin
Signed-off-by: Giuseppe Cavallaro
---
drivers/mmc/host/Kconfig| 12 +++
drivers/mmc/host/Makefile
