Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-10 Thread Tomi Valkeinen
On 2013-12-10 12:56, Enric Balletbo Serra wrote: > Hi all, > > 2013/12/9 Javier Martinez Canillas : >> Hi Tomi, >> >> On Mon, Dec 9, 2013 at 4:30 PM, Tomi Valkeinen wrote: >>> On 2013-12-09 17:09, Javier Martinez Canillas wrote: Hi Tomi, On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkein

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-10 Thread Enric Balletbo Serra
Hi all, 2013/12/9 Javier Martinez Canillas : > Hi Tomi, > > On Mon, Dec 9, 2013 at 4:30 PM, Tomi Valkeinen wrote: >> On 2013-12-09 17:09, Javier Martinez Canillas wrote: >>> Hi Tomi, >>> >>> On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen >>> wrote: On 2013-12-06 10:57, Javier Martinez Cani

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-09 Thread Javier Martinez Canillas
Hi Tomi, On Mon, Dec 9, 2013 at 4:30 PM, Tomi Valkeinen wrote: > On 2013-12-09 17:09, Javier Martinez Canillas wrote: >> Hi Tomi, >> >> On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen wrote: >>> On 2013-12-06 10:57, Javier Martinez Canillas wrote: >>> > + tfp410: encoder@0 { > +

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-09 Thread Tomi Valkeinen
On 2013-12-09 17:09, Javier Martinez Canillas wrote: > Hi Tomi, > > On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen wrote: >> On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> + tfp410: encoder@0 { + compatible = "ti,tfp410"; + gpios = <&gpio1

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-09 Thread Javier Martinez Canillas
Hi Tomi, On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen wrote: > On 2013-12-06 10:57, Javier Martinez Canillas wrote: > >>> + tfp410: encoder@0 { >>> + compatible = "ti,tfp410"; >>> + gpios = <&gpio1 0 0>; /* 0, power-down */ >>> + >> >> Please use the constant

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-09 Thread Tomi Valkeinen
On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> + tfp410: encoder@0 { >> + compatible = "ti,tfp410"; >> + gpios = <&gpio1 0 0>; /* 0, power-down */ >> + > > Please use the constants from include/dt-bindings/ instead of magic > numbers, i.e: > > gpios =

Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-06 Thread Javier Martinez Canillas
Hi Tomi, On Wed, Dec 4, 2013 at 1:28 PM, Tomi Valkeinen wrote: > Signed-off-by: Tomi Valkeinen > --- > arch/arm/boot/dts/omap4-panda-common.dtsi | 102 > ++ > 1 file changed, 102 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi > b/arch/arm/

[PATCH 15/26] ARM: omap4-panda.dts: add display information

2013-12-04 Thread Tomi Valkeinen
Signed-off-by: Tomi Valkeinen --- arch/arm/boot/dts/omap4-panda-common.dtsi | 102 ++ 1 file changed, 102 insertions(+) diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi index 298e85020e1b..51a79756e67e 100644 --- a/ar