Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-27 Thread Brian Norris
On Thu, Aug 27, 2015 at 10:51:22PM +0200, Heiko Stuebner wrote: > Am Donnerstag, 27. August 2015, 12:30:51 schrieb Doug Anderson: > > If I understand correctly, the distinction between "standby" and "mem" > > is not too clearly defined, so if we wanted to use it for this it > > wouldn't be terrible

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-27 Thread Heiko Stuebner
Am Donnerstag, 27. August 2015, 12:30:51 schrieb Doug Anderson: > Hi, > > On Tue, Aug 18, 2015 at 11:19 PM, Heiko Stuebner wrote: > > great, just take into account the deep vs. shallow suspend modes :-) > > One note: do you think it would make sense to re-implement shallow > suspend as "standby"

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-27 Thread Doug Anderson
Hi, On Tue, Aug 18, 2015 at 11:19 PM, Heiko Stuebner wrote: > great, just take into account the deep vs. shallow suspend modes :-) One note: do you think it would make sense to re-implement shallow suspend as "standby"? I had a proof of concept doing that in

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Heiko Stuebner
Am Dienstag, 18. August 2015, 16:28:06 schrieb Brian Norris: > Now that I'm looking a little closer, it seems like other existing DTS's > are broken too, then. Jerry looks like it was converted to the > regulator-state-mem node binding, but the conversion doesn't seem to > make sense when I compare

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Brian Norris
On Tue, Aug 18, 2015 at 03:48:31PM -0700, Brian Norris wrote: > On Tue, Aug 18, 2015 at 09:17:06PM +0200, Heiko Stuebner wrote: > > Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris: > > > This DTS file was submitted with non-upstream bindings. I happened > > > across this while reviewing

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Brian Norris
On Tue, Aug 18, 2015 at 09:17:06PM +0200, Heiko Stuebner wrote: > Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris: > > This DTS file was submitted with non-upstream bindings. I happened > > across this while reviewing the jaq DTS. > > > > Signed-off-by: Brian Norris > > Cc: Alexandru

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Javier Martinez Canillas
On Tue, Aug 18, 2015 at 10:30 PM, Javier Martinez Canillas wrote: > On Tue, Aug 18, 2015 at 9:17 PM, Heiko Stuebner wrote: >>> >>> vcc5v_touch: SWITCH_REG2 { >>> regulator-name = "vcc5v_touch"; >>> - regulator-suspend-mem-disabled; >>> +

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Javier Martinez Canillas
Hello Heiko, On Tue, Aug 18, 2015 at 9:17 PM, Heiko Stuebner wrote: > Hi Brian, > > > thanks for catching these oversights, but see below > > Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris: >> This DTS file was submitted with non-upstream bindings. I happened >> across this while rev

Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Heiko Stuebner
Hi Brian, thanks for catching these oversights, but see below Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris: > This DTS file was submitted with non-upstream bindings. I happened > across this while reviewing the jaq DTS. > > Signed-off-by: Brian Norris > Cc: Alexandru M Stan > C

[PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties

2015-08-18 Thread Brian Norris
This DTS file was submitted with non-upstream bindings. I happened across this while reviewing the jaq DTS. Signed-off-by: Brian Norris Cc: Alexandru M Stan Cc: Douglas Anderson --- Tested on jaq, not minnie arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++-- 1 file changed, 6 insertions