> On May 23, 2014, at 3:40 PM, "Mark Brown" wrote:
>
>> On Fri, May 23, 2014 at 02:16:54PM -0500, Paul Handrigan wrote:
>> This patch adds support for the Cirrus Logic Stereo I2C CODEC
>
> This all looks pretty clean and nice, I have got a few comments below
> but they're all pretty small thin
; lgirdw...@gmail.com; robh...@kernel.org;
broo...@kernel.org; ga...@codeaurora.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: Add support for CS4265 CODEC
On 05/23/2014 09:16 PM, Paul Handrigan wrote:
[...]
A couple of trivial bits:
> @@ -300,6 +301,10 @@ config SND_SOC_CS42L73
> tr
On 05/23/2014 09:16 PM, Paul Handrigan wrote:
[...]
A couple of trivial bits:
@@ -300,6 +301,10 @@ config SND_SOC_CS42L73
tristate "Cirrus Logic CS42L73 CODEC"
depends on I2C
+config SND_SOC_CS4265
+ tristate "Cirrus Logic CS4265 CODEC"
+ depends on I2C
select REG
> On May 23, 2014, at 3:40 PM, "Mark Brown" wrote:
>
>> On Fri, May 23, 2014 at 02:16:54PM -0500, Paul Handrigan wrote:
>> This patch adds support for the Cirrus Logic Stereo I2C CODEC
>
> This all looks pretty clean and nice, I have got a few comments below
> but they're all pretty small thin
On Fri, May 23, 2014 at 02:16:54PM -0500, Paul Handrigan wrote:
> This patch adds support for the Cirrus Logic Stereo I2C CODEC
This all looks pretty clean and nice, I have got a few comments below
but they're all pretty small things.
> + SOC_SINGLE("De-emp 44.1kHz", CS4265_DAC_CTL, 1,
> +
This patch adds support for the Cirrus Logic Stereo I2C CODEC
Signed-off-by: Paul Handrigan
---
include/sound/cs4265.h| 18 ++
sound/soc/codecs/Kconfig | 5 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/cs4265.c | 716 ++
sound/soc/code