Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-18 Thread Javier Martinez Canillas
Hello Nick, On 08/15/2014 06:08 PM, Nick Dyer wrote: >> >> Any comments on this? I would really appreciate if you can expand on how >> this DT property is supposed to be used so I can re-spin the atmel support >> patch for Peach boards. > > The below patch improves the documentation for the gpio

Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-15 Thread Stephen Warren
On 08/15/2014 10:08 AM, Nick Dyer wrote: On 15/08/14 13:01, Javier Martinez Canillas wrote: By passing all these keycodes the touchpad worked as expected for me and the driver did the same than the Chrome OS driver that has these keycodes hardcoded when is_tp is true. at the protocol guide for

Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-15 Thread Nick Dyer
On 15/08/14 13:01, Javier Martinez Canillas wrote: >> By passing all these keycodes the touchpad worked as expected for me and the >> driver did the same than the Chrome OS driver that has these keycodes >> hardcoded >> when is_tp is true. >> >>> at the protocol guide for T19. >> >> I don't have a

Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-15 Thread Javier Martinez Canillas
Hello Nick, On 08/08/2014 04:52 PM, Javier Martinez Canillas wrote: On 08/07/2014 02:38 PM, Nick Dyer wrote: >> >> >> >> I'm afraid you have misunderstood the impact of this change to the way that >> the GPIOs coming in to the touch controller are mapped to key codes. Look > > Unfortunately ther

Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-08 Thread Javier Martinez Canillas
Hello Nick, On 08/07/2014 02:38 PM, Nick Dyer wrote: >> >> Also, the current documentation says that the array limit >> is four entries but the driver dynamically allocates the >> keymap array and does not limit the array size. > > There is a physical limit to the number of GPIOs on the device.

Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-07 Thread Nick Dyer
On 07/08/14 01:48, Javier Martinez Canillas wrote: > The Atmel maXTouch driver allows to dynamically define the > event keycodes set that the device is capable of. This may > not be evident when reading the DT binding document so add > an example to make it easier to understand how this works. > >

[PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

2014-08-06 Thread Javier Martinez Canillas
The Atmel maXTouch driver allows to dynamically define the event keycodes set that the device is capable of. This may not be evident when reading the DT binding document so add an example to make it easier to understand how this works. Also, the current documentation says that the array limit is f