Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-09 Thread Andrew Lunn
On Fri, Jan 09, 2015 at 01:46:10PM +0100, Imre Kaloz wrote: Hi Andrew, On Fri, 09 Jan 2015 01:26:18 +0100, Andrew Lunn and...@lunn.ch wrote: The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-09 Thread Imre Kaloz
Hi Andrew, On Fri, 09 Jan 2015 01:26:18 +0100, Andrew Lunn and...@lunn.ch wrote: The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the brightness of the LED. This is based on a driver from Belkin, but has

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Bryan Wu
On Thu, Jan 8, 2015 at 4:26 PM, Andrew Lunn and...@lunn.ch wrote: The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the brightness of the LED. This is based on a driver from Belkin, but has been

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Andrew Lunn
On Fri, Jan 09, 2015 at 06:06:05AM +0530, Varka Bhadram wrote: On Friday 09 January 2015 05:56 AM, Andrew Lunn wrote: The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the brightness of the LED. This

[PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Andrew Lunn
The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the brightness of the LED. This is based on a driver from Belkin, but has been extensively rewritten. Signed-off-by: Andrew Lunn and...@lunn.ch Cc:

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Varka Bhadram
On Friday 09 January 2015 05:56 AM, Andrew Lunn wrote: The TLC59116 is an I2C bus controlled 16-channel LED driver. Each LED output has its own 8-bit fixed-frequency PWM controller to control the brightness of the LED. This is based on a driver from Belkin, but has been extensively rewritten.

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Andrew Lunn
+static int +tlc59116_set_mode(struct regmap *regmap, uint8_t mode) Why not just us u8 instead of uint8_t? It is what the Belkin driver did. I can change this. +{ + uint8_t val = 0; + + if ((mode != MODE2_DIM) (mode != MODE2_BLINK)) + mode =