Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 21:27, Lucas Stach wrote: > No, we need the regulator to determine which OPPs are actually useable. > If the regulator is only supplying 1.1V we can only scale to 800MHz max, > which is the case for some of the industrial i.MX53 versions. Go and add another binding for this max-vol

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 21:05 +0530 schrieb Viresh Kumar: > On 26 May 2014 20:58, Lucas Stach wrote: > > The platform I'm working on supports cpu rail voltage regulation just > > fine. > > So, the regulator can be scaled to support all values from your dts > and we can work without MAX-volt pa

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 20:58, Lucas Stach wrote: > The platform I'm working on supports cpu rail voltage regulation just > fine. So, the regulator can be scaled to support all values from your dts and we can work without MAX-volt parameter here.. > I just want to make sure that the driver works properly

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 20:52 +0530 schrieb Viresh Kumar: > On 26 May 2014 19:28, Lucas Stach wrote: > > Right, the OPP in my example define the minimum required voltage for > > each frequency. This is in accordance to the OPP binding. But for this > > chip the datasheet explicitly says that it

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 19:28, Lucas Stach wrote: > Right, the OPP in my example define the minimum required voltage for > each frequency. This is in accordance to the OPP binding. But for this > chip the datasheet explicitly says that it is ok to power the cpu rail > with up to 1.4V, regardless of the cur

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 19:14 +0530 schrieb Viresh Kumar: > On 26 May 2014 18:41, Lucas Stach wrote: > > Just to mention that I am trying to help you and am not opposing any > change. We can add this field if its really required and I am just trying > to understand your problem and if we can s

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 18:41, Lucas Stach wrote: Just to mention that I am trying to help you and am not opposing any change. We can add this field if its really required and I am just trying to understand your problem and if we can solve it with current code. > No, setting voltage-tolerance to zero mea

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 18:26 +0530 schrieb Viresh Kumar: > On 26 May 2014 18:05, Lucas Stach wrote: [...] > > > 2. Usage of a fixed max voltage, rather than a voltage-tolerance. i.MX5 > > has a fixed maximum voltage, which is valid across all operating points. > > I'm really opposed to using

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 18:05, Lucas Stach wrote: > Ok I can push down the clock handling into the imx5 clk driver. Great !! > This leaves two more differences between imx5-cpufreq and cpufreq-cpu0: > > 1. Disabling of OPPs that could not be supported by the connected > regulator. I think this part can e

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 16:36 +0530 schrieb Viresh Kumar: > On 26 May 2014 16:15, Lucas Stach wrote: > > This driver handles the i.MX5 specific clock reparenting to be able to > > reprogramm the PLL. cpufreq-cpu0 can only change a postdivider of the > > PLL, which means we can't reach the exact

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 16:15, Lucas Stach wrote: > This driver handles the i.MX5 specific clock reparenting to be able to > reprogramm the PLL. cpufreq-cpu0 can only change a postdivider of the > PLL, which means we can't reach the exact OPP frequencies and can not > profit from the additional power savin

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
Am Montag, den 26.05.2014, 16:02 +0530 schrieb Viresh Kumar: > On 26 May 2014 15:45, Lucas Stach wrote: > > SoC specific driver to be able to handle PLL reprogramming > > for exact OPP frequencies and additional power saving. > > > > Signed-off-by: Lucas Stach > > --- > > .../devicetree/bindings

Re: [PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Viresh Kumar
On 26 May 2014 15:45, Lucas Stach wrote: > SoC specific driver to be able to handle PLL reprogramming > for exact OPP frequencies and additional power saving. > > Signed-off-by: Lucas Stach > --- > .../devicetree/bindings/cpufreq/cpufreq-imx5.txt | 43 +++ > drivers/cpufreq/Kconfig.arm

[PATCH 2/4] cpufreq: add i.MX5 cpufreq driver

2014-05-26 Thread Lucas Stach
SoC specific driver to be able to handle PLL reprogramming for exact OPP frequencies and additional power saving. Signed-off-by: Lucas Stach --- .../devicetree/bindings/cpufreq/cpufreq-imx5.txt | 43 +++ drivers/cpufreq/Kconfig.arm| 8 + drivers/cpufreq/Makefile