Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-26 Thread Tim Kryger
On Tue, Nov 26, 2013 at 1:45 AM, Thierry Reding wrote: > On Mon, Nov 25, 2013 at 05:38:44PM -0800, Tim Kryger wrote: > Okay, that's fine then. Do you have a pointer to that documentation? Unfortunately the documentation is not publicly available at the moment. >> The hardware is always enabled

Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-26 Thread Thierry Reding
On Mon, Nov 25, 2013 at 05:38:44PM -0800, Tim Kryger wrote: > On Mon, Nov 25, 2013 at 3:08 AM, Thierry Reding > wrote: > > On Mon, Nov 18, 2013 at 10:54:58AM -0800, Tim Kryger wrote: > > [...] > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig [...] > >> +#define PWM_CONTROL_INITIAL

Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-25 Thread Tim Kryger
On Mon, Nov 25, 2013 at 3:08 AM, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 10:54:58AM -0800, Tim Kryger wrote: > [...] >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > [...] >> +config PWM_BCM_KONA >> + tristate "Kona PWM support" >> + depends on ARCH_BCM_MOBILE >> + d

Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-25 Thread Thierry Reding
On Mon, Nov 18, 2013 at 10:54:58AM -0800, Tim Kryger wrote: [...] > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig [...] > +config PWM_BCM_KONA > + tristate "Kona PWM support" > + depends on ARCH_BCM_MOBILE > + default y Why do you want this to be the default? Shouldn't this be

[PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-18 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-bcm-kona.c | 226 +++