Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Thor Thayer
On Tue, 2014-04-08 at 18:22 +0200, Borislav Petkov wrote: > On Tue, Apr 08, 2014 at 05:10:54PM +0100, Mark Rutland wrote: > > Typically the bindings would go with the driver via the appropriate > > subsystem maintainer. That way we don't get bindings without drivers > > or vice-versa if there's a p

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Borislav Petkov
On Tue, Apr 08, 2014 at 05:10:54PM +0100, Mark Rutland wrote: > Typically the bindings would go with the driver via the appropriate > subsystem maintainer. That way we don't get bindings without drivers > or vice-versa if there's a problem part-way, and we don't end up with > every other driver goi

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Mark Rutland
On Tue, Apr 08, 2014 at 05:03:51PM +0100, Borislav Petkov wrote: > On Tue, Apr 08, 2014 at 04:40:17PM +0100, Mark Rutland wrote: > > The patches should be in the same series, but for review purposes it's > > nicer if the bindings are separate patches from the code within that > > series. > > > > I

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Borislav Petkov
On Tue, Apr 08, 2014 at 04:40:17PM +0100, Mark Rutland wrote: > The patches should be in the same series, but for review purposes it's > nicer if the bindings are separate patches from the code within that > series. > > I usually look at the drivers implementing bindings and prefer to be > Cc'd on

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Mark Rutland
On Tue, Apr 08, 2014 at 04:24:06PM +0100, Borislav Petkov wrote: > On Tue, Apr 08, 2014 at 08:57:39AM -0500, Thor Thayer wrote: > > Yes, Altera has a group specifically supporting Linux drivers on the > > Altera SoCs. > > Then please add MAINTAINERS file entry for this EDAC driver so that > people

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Borislav Petkov
On Tue, Apr 08, 2014 at 08:57:39AM -0500, Thor Thayer wrote: > Yes, Altera has a group specifically supporting Linux drivers on the > Altera SoCs. Then please add MAINTAINERS file entry for this EDAC driver so that people can send issues/reports to that group. > I was told that the device tree ad

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Thor Thayer
On Tue, 2014-04-08 at 14:45 +0200, Steffen Trumtrar wrote: > On Tue, Apr 08, 2014 at 11:45:25AM +0100, Mark Rutland wrote: > > On Mon, Apr 07, 2014 at 10:54:09PM +0100, ttha...@altera.com wrote: > > > From: Thor Thayer > > > > > > Added EDAC support for reporting ECC errors of CycloneV > > > and

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Thor Thayer
On Tue, 2014-04-08 at 12:08 +0200, Borislav Petkov wrote: > On Mon, Apr 07, 2014 at 04:54:09PM -0500, ttha...@altera.com wrote: > > From: Thor Thayer > > > > Added EDAC support for reporting ECC errors of CycloneV > > and ArriaV SDRAM controller. > > - The SDRAM Controller registers are used by t

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Steffen Trumtrar
On Tue, Apr 08, 2014 at 11:45:25AM +0100, Mark Rutland wrote: > On Mon, Apr 07, 2014 at 10:54:09PM +0100, ttha...@altera.com wrote: > > From: Thor Thayer > > > > Added EDAC support for reporting ECC errors of CycloneV > > and ArriaV SDRAM controller. > > - The SDRAM Controller registers are used

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Mark Rutland
On Mon, Apr 07, 2014 at 10:54:09PM +0100, ttha...@altera.com wrote: > From: Thor Thayer > > Added EDAC support for reporting ECC errors of CycloneV > and ArriaV SDRAM controller. > - The SDRAM Controller registers are used by the FPGA bridge so > these are accessed through the syscon interface.

Re: [PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-08 Thread Borislav Petkov
On Mon, Apr 07, 2014 at 04:54:09PM -0500, ttha...@altera.com wrote: > From: Thor Thayer > > Added EDAC support for reporting ECC errors of CycloneV > and ArriaV SDRAM controller. > - The SDRAM Controller registers are used by the FPGA bridge so > these are accessed through the syscon interface.

[PATCH 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV

2014-04-07 Thread tthayer
From: Thor Thayer Added EDAC support for reporting ECC errors of CycloneV and ArriaV SDRAM controller. - The SDRAM Controller registers are used by the FPGA bridge so these are accessed through the syscon interface. - The configuration of the SDRAM memory size for the EDAC framework is discov