Re: [PATCH 3/7] ARM: meson6: clocksource: add Meson6 timer support

2014-08-19 Thread Carlo Caione
On lun, ago 18, 2014 at 05:27:26 +0100, Mark Rutland wrote: On Sun, Aug 17, 2014 at 11:49:50AM +0100, Carlo Caione wrote: +enum { + A = 0, + B, + C, + D, +}; That's a very terse set of enum names. I would recomment something a little longer. Any reason for missing E?

Re: [PATCH 3/7] ARM: meson6: clocksource: add Meson6 timer support

2014-08-18 Thread Matthias Brugger
On 17/08/14 12:49, Carlo Caione wrote: Meson6 SoCs are equipped with 5 32-bit timers, called TIMER_A, TIMER_B, TIMER_C, TIMER_D and TIMER_E. The driver is providing clocksource support for the 32-bit counter using TIMER_E. Clockevents are also supported using TIMER_A. Signed-off-by: Carlo

Re: [PATCH 3/7] ARM: meson6: clocksource: add Meson6 timer support

2014-08-18 Thread Carlo Caione
On Mon, Aug 18, 2014 at 01:59:38PM +0200, Matthias Brugger wrote: On 17/08/14 12:49, Carlo Caione wrote: +enum { +A = 0, +B, +C, +D, +}; You are just using timer A, so this enum is unnecessary. Please use a define instead. Also it would be better, if the define would be

Re: [PATCH 3/7] ARM: meson6: clocksource: add Meson6 timer support

2014-08-18 Thread Mark Rutland
On Sun, Aug 17, 2014 at 11:49:50AM +0100, Carlo Caione wrote: Meson6 SoCs are equipped with 5 32-bit timers, called TIMER_A, TIMER_B, TIMER_C, TIMER_D and TIMER_E. The driver is providing clocksource support for the 32-bit counter using TIMER_E. Clockevents are also supported using TIMER_A.

[PATCH 3/7] ARM: meson6: clocksource: add Meson6 timer support

2014-08-17 Thread Carlo Caione
Meson6 SoCs are equipped with 5 32-bit timers, called TIMER_A, TIMER_B, TIMER_C, TIMER_D and TIMER_E. The driver is providing clocksource support for the 32-bit counter using TIMER_E. Clockevents are also supported using TIMER_A. Signed-off-by: Carlo Caione ca...@caione.org ---