Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

2015-10-08 Thread Javier Martinez Canillas
Hello Fei Wang, On Wed, Sep 30, 2015 at 1:05 PM, Fei Wang wrote: > Add Hi655x regulator driver. > > Signed-off-by: Fei Wang > --- [snip] > > +config REGULATOR_HI655X > +tristate "Hisilicon HI655X PMIC regulators support" The Kconfig symbol is tree state which means it can be built as

Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

2015-10-08 Thread wangfei
On 2015/10/1 1:58, Mark Brown wrote: > On Wed, Sep 30, 2015 at 07:05:07PM +0800, Fei Wang wrote: > >> +config REGULATOR_HI655X >> +tristate "Hisilicon HI655X PMIC regulators support" >> +depends on ARCH_HISI >> +depends on MFD_HI655X_PMIC && OF > > You've got some tab/space co

Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

2015-09-30 Thread Mark Brown
On Wed, Sep 30, 2015 at 07:05:07PM +0800, Fei Wang wrote: > +config REGULATOR_HI655X > +tristate "Hisilicon HI655X PMIC regulators support" > +depends on ARCH_HISI > + depends on MFD_HI655X_PMIC && OF You've got some tab/space confusion above. Also, can't we have an || COMPIL

[PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator

2015-09-30 Thread Fei Wang
Add Hi655x regulator driver. Signed-off-by: Fei Wang --- drivers/regulator/Kconfig |8 + drivers/regulator/Makefile |1 + drivers/regulator/hi655x-regulator.c | 517 include/linux/regulator/hi655x-regulator.h | 69 +++