Re: [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-25 Thread Mark Brown
On Wed, Nov 19, 2014 at 10:52:44AM -0800, Kenneth Westfield wrote: + if (channels == 8) { + if (bit_width == 24 + ((samp_freq != 176400) + (samp_freq != 192000))) + return 2; + return 1; Coding style

Re: [alsa-devel] [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-21 Thread Kenneth Westfield
On Wed, November 19, 2014 1:17 pm, Pierre-Louis Bossart wrote: On 11/19/14, 12:52 PM, Kenneth Westfield wrote: From: Kenneth Westfield kwest...@codeaurora.org Add the CPU DAI driver for the QCOM LPASS SOC. Change-Id: I64ac4407dd32bb9a3066d4b7427292002eaf5d14 Signed-off-by: Kenneth

Re: [alsa-devel] [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-20 Thread Lars-Peter Clausen
On 11/19/2014 07:52 PM, Kenneth Westfield wrote: [...] +static struct clk *lpaif_mi2s_bit_clk; +static struct clk *lpaif_mi2s_osr_clk; +static struct mi2s_hw_params mi2s_params; Again, no global state please. [...] +static int lpass_cpu_mi2s_prepare(struct snd_pcm_substream *substream, +

Re: [alsa-devel] [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-19 Thread Pierre-Louis Bossart
On 11/19/14, 12:52 PM, Kenneth Westfield wrote: From: Kenneth Westfield kwest...@codeaurora.org Add the CPU DAI driver for the QCOM LPASS SOC. Change-Id: I64ac4407dd32bb9a3066d4b7427292002eaf5d14 Signed-off-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Banajit Goswami

Re: [PATCH 4/9] ASoC: ipq806x: Add LPASS CPU DAI driver

2014-11-19 Thread Courtney Cavin
On Wed, Nov 19, 2014 at 07:52:44PM +0100, Kenneth Westfield wrote: From: Kenneth Westfield kwest...@codeaurora.org Add the CPU DAI driver for the QCOM LPASS SOC. Change-Id: I64ac4407dd32bb9a3066d4b7427292002eaf5d14 Signed-off-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: