Re: [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE

2015-11-25 Thread Simon Arlott
On 25/11/15 14:10, Guenter Roeck wrote: > On 11/25/2015 05:02 AM, Simon Arlott wrote: >> On Wed, November 25, 2015 02:44, Guenter Roeck wrote: >>> The "running" flag should no longer be needed. watchdog_active() >>> should provide that information. >> >> I'm going to need to keep that because I nee

Re: [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE

2015-11-25 Thread Guenter Roeck
On 11/25/2015 05:02 AM, Simon Arlott wrote: On Wed, November 25, 2015 02:44, Guenter Roeck wrote: The "running" flag should no longer be needed. watchdog_active() should provide that information. I'm going to need to keep that because I need to know if it's running in the interrupt handler, an

Re: [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE

2015-11-25 Thread Simon Arlott
On Wed, November 25, 2015 02:44, Guenter Roeck wrote: > The "running" flag should no longer be needed. watchdog_active() > should provide that information. I'm going to need to keep that because I need to know if it's running in the interrupt handler, and wdd->lock is a mutex. >> @@ -306,17 +202,

Re: [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE

2015-11-24 Thread Guenter Roeck
Hi Simon, On 11/22/2015 06:06 AM, Simon Arlott wrote: Convert bcm63xx_wdt to use WATCHDOG_CORE. The default and maximum time constants that are only used once have been moved to the initialisation of the struct watchdog_device. Comments inline. Thanks, Guenter Signed-off-by: Simon Arlott

[PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE

2015-11-22 Thread Simon Arlott
Convert bcm63xx_wdt to use WATCHDOG_CORE. The default and maximum time constants that are only used once have been moved to the initialisation of the struct watchdog_device. Signed-off-by: Simon Arlott --- drivers/watchdog/Kconfig | 1 + drivers/watchdog/bcm63xx_wdt.c | 249