Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-07 Thread Grant Likely
On Fri, 6 Jun 2014 13:36:53 +0100, Lee Jones lee.jo...@linaro.org wrote: On Fri, 06 Jun 2014, Mark Brown wrote: On Thu, Jun 05, 2014 at 04:55:09PM +0100, Lee Jones wrote: On Thu, 05 Jun 2014, Grant Likely wrote: I still think the way to do it is to emulate the missing i2c_device_id

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-07 Thread Mark Brown
On Sat, Jun 07, 2014 at 12:42:53AM +0100, Grant Likely wrote: On Fri, 6 Jun 2014 13:36:53 +0100, Lee Jones lee.jo...@linaro.org wrote: On Fri, 06 Jun 2014, Mark Brown wrote: I've also been mulling over the idea of removing the second probe() parameter, as suggested by Wolfram.

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-06 Thread Mark Brown
On Thu, Jun 05, 2014 at 04:55:09PM +0100, Lee Jones wrote: On Thu, 05 Jun 2014, Grant Likely wrote: I still think the way to do it is to emulate the missing i2c_device_id when calling the drivers .probe() hook by having a temporary copy on the stack and filling it with data from the OF or

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-06 Thread Lee Jones
On Fri, 06 Jun 2014, Mark Brown wrote: On Thu, Jun 05, 2014 at 04:55:09PM +0100, Lee Jones wrote: On Thu, 05 Jun 2014, Grant Likely wrote: I still think the way to do it is to emulate the missing i2c_device_id when calling the drivers .probe() hook by having a temporary copy on the

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Mika Westerberg
On Wed, Jun 04, 2014 at 02:28:20PM +0100, Lee Jones wrote: On Wed, 04 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote: On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote: Currently this is a helper function for the I2C subsystem to

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Lee Jones
On Thu, 05 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:28:20PM +0100, Lee Jones wrote: On Wed, 04 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote: On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote: Currently

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and devices which use DT and/or ACPI, but do not supply any nodes (see: [1] Method 4). However, it has

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, 5 Jun 2014 09:20:08 +0100, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:28:20PM +0100, Lee Jones wrote: On Wed, 04 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote:

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Lee Jones
On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and devices which use DT and/or ACPI, but do not supply any

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, Jun 5, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Lee Jones
On Thu, 05 Jun 2014, Grant Likely wrote: On Thu, Jun 5, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, Jun 5, 2014 at 4:55 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Thu, Jun 5, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org

[PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-04 Thread Lee Jones
Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and devices which use DT and/or ACPI, but do not supply any nodes (see: [1] Method 4). However, it has been made more generic as it can be used to only make one call for drivers which

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-04 Thread Rafael J. Wysocki
On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and devices which use DT and/or ACPI, but do not supply any nodes (see: [1] Method 4). However, it has been made more

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-04 Thread Lee Jones
On Wed, 04 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote: On Wednesday, June 04, 2014 01:09:56 PM Lee Jones wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and